Commit Graph
1394 Commits
Author SHA1 Message Date
bchanot 5e6d74428f test(tests): a sideways scroll attempt proves no overflow; margin comment
scrollWidth against clientWidth hid an overflow up to the scrollbar
gutter's width; the probe now tries to scroll sideways. The drawing
place's margin comment names the pinned column's exception.
2026-11-19 20:24:36 +01:00
bchanot 36ed9f980b fix(editor): the drawing stays clear of the strip while the page scrolls
The drawing column (chips, tools, canvas, add row, message line) is
pinned under the strip from 1 024 px wide and 644 px high; the canvas
box is capped in width by the window height (4:3 kept, unchanged at the
three sizes); pinned controls carry no strip margin. The rev 4 test
workarounds go; the row-click scroll was Playwright's bring-into-view.
2026-11-19 20:19:26 +01:00
bchanot da04c79d13 docs(docs): U2 plan rev 5, owner decisions 2026-11-19 19:44:57 +01:00
bchanot e2f9302dfe docs(docs): U2 contract addendum 2, owner decisions D1 to D5 2026-11-19 19:44:30 +01:00
bchanot 0d362605b3 chore(memory): journal, U2 rev 4 ready for the owner trial 2026-11-19 19:04:35 +01:00
bchanot 9e03f1443a docs(docs): U2 plan file list, demo zone name, two owner choices, TODO 2026-11-19 19:04:25 +01:00
bchanot 56a76a70f8 docs(docs): U2 gate figures on the final code da8642dd 2026-11-19 18:45:11 +01:00
bchanot da8642dd44 docs(docs): focus margin under the top bar, « Redessiner » wording in the trial 2026-11-19 18:24:16 +01:00
bchanot 238650719e fix(editor): no focus in the editor header lands under the top bar 2026-11-19 18:24:07 +01:00
bchanot 1ab3b6afba docs(docs): U2 gate figures on the final code f9656a0d 2026-11-19 17:48:53 +01:00
bchanot f9656a0d9b fix(editor): a focus left in a hidden panel counts as lost after a guarded press 2026-11-19 17:24:32 +01:00
bchanot 7cb1aee7a1 docs(docs): U2 status as built, trial measures and gate failures stated as proven 2026-11-19 17:17:16 +01:00
bchanot fa00e57652 fix(editor): a guarded press that hides the handle keeps the focus off body 2026-11-19 17:16:56 +01:00
bchanot 8df52fd1be docs(docs): rev 4 gate figures on the final head 2026-11-19 16:45:32 +01:00
bchanot f5a6eafc7f fix(editor): zone handles remount per annotation so a row tap lands the focus 2026-11-19 16:21:14 +01:00
bchanot 6ad378b08b docs(docs): trial step 17 covers the overview rows 2026-11-19 16:16:30 +01:00
bchanot 8b190b4e0d fix(editor): an overview row tap keeps the focus off body 2026-11-19 16:16:30 +01:00
bchanot 0aa0f6bc62 docs(docs): rev 4 gate figures and the amended held-reason criterion 2026-11-19 15:44:25 +01:00
bchanot 448a17eff7 docs(docs): trial step 19 tool and the tapped tool's focus, pinned 2026-11-19 15:18:06 +01:00
bchanot b0344a4af6 fix(editor): no strip scroll margin on a dialog's controls 2026-11-19 15:18:05 +01:00
bchanot 303e153777 fix(editor): any pointer press clears the keyboard scroll of a vertex
The key flag only heard presses on the handle group: a press on the
interior after a keyed series let the re-chosen vertex scroll the page
under the pointer. Any pointerdown in the document now clears it.
2026-11-19 15:18:04 +01:00
bchanot 462a22e74f docs(docs): rev 4 fix round: trial steps, held reasons, cited tests 2026-11-19 15:05:26 +01:00
bchanot 7a9ccf149c chore(editor): rev 4 leftovers: closeTrace returns nothing, doc reflow 2026-11-19 15:04:27 +01:00
bchanot f3c4f7baa9 test(tests): a resumed shape has no interior drag and no handle past 40 2026-11-19 15:03:07 +01:00
bchanot 77251fa636 fix(editor): a held press on another tab leaves the hidden line empty
The kept-alive annotations tab showed the reason in its hidden message
line, so it came back on the return. A press made while the place is
hidden is now only described by the button.
2026-11-19 15:03:06 +01:00
bchanot 531bbef619 fix(editor): a tool or view chip tap keeps the focus off body
Safari focuses no tapped button: a tool or a view chip pressed after a
keyboard series commits through the guard with the focus on the handle,
then the change unmounts the handle. The focus now lands on the pressed
button, without a scroll, only when it fell to body (M-4).
2026-11-19 15:00:39 +01:00
bchanot 966ad4fe45 fix(editor): no focus in the drawing place lands under the strip
The scroll margin now covers every native focusable of the place (tools,
view chips, add buttons, the aside's controls), the strip's own commands
excepted, as a real Tab walk found them hidden (I-3). A vertex chosen
from the keyboard takes the focus with a scroll (M-1).
2026-11-19 14:58:19 +01:00
bchanot 59e189c375 fix(editor): « Défaire » cancels pending work; reasons only when they help
A press on « Défaire » over a pending series or mode keeps the focus and
skips the field commit, so its handle's blur no longer commits before
the cancel (R-13): the redo stack survives. A held button gives its
reason only when that cause alone holds it; redo during a creation gets
its own text, and the pending text says to cancel with « Défaire ».
2026-11-19 14:52:51 +01:00
bchanot de418b29a9 test(tests): press the drawing where the sticky strip leaves it visible
The strip made sticky in f2809f20 covers the drawing's top band and the
aside's top while the page is scrolled (rev 4 point 1 ruling, accepted
cost). Three presses and one axe scan ran at that scroll after a row
click: back to the top first, and assert the press hits the drawing.
2026-11-19 14:43:19 +01:00
bchanot 05a8525455 docs(docs): rev 4 owner trial, UX tests and rendering notes 2026-11-19 14:13:59 +01:00
bchanot 682bbd4a18 chore(editor): rev 4 review nits 2026-11-19 14:12:30 +01:00
bchanot 8f036b2a8a fix(editor): a press on a held redo keeps the pending work untouched 2026-11-19 14:02:11 +01:00
bchanot 00e995a6cb feat(editor): say why redo is unavailable during pending work 2026-11-19 12:38:26 +01:00
bchanot e341f03390 fix(editor): one focus marker on every handle, proven on an SVG vertex 2026-11-19 12:32:27 +01:00
bchanot 399a5adae6 fix(editor): focus margin on the strip's targets, not a page padding 2026-11-19 12:24:34 +01:00
bchanot f2809f20ca fix(editor): the strip stays below the top bar on scroll 2026-11-19 12:15:52 +01:00
bchanot 62b400e876 fix(editor): « − » press follows Delete, discriminating focus tests 2026-11-19 12:00:48 +01:00
bchanot 03e85a7c67 fix(editor): focus follows the action after a touch commit 2026-11-19 11:26:37 +01:00
bchanot df46390bdb fix(editor): vertex keys act on the focused handle after an undo 2026-11-19 11:20:19 +01:00
bchanot 6df66f9bb9 feat(editor): Backspace and « + » on a vertex handle 2026-11-19 11:16:55 +01:00
bchanot c01c6f3145 fix(editor): resumed shape names and minor review fixes
- French fallback names: « cette nouvelle zone », « ce nouvel accès »
  (controller ruling: « Sommets de ce nouvel accès »); doc updated.
- useZoneHandle back to 5 locals.
- dropPending clears the strip hint as a kept stored change does.
- Tests: the chosen vertex cleared by finishCreation itself (document
  unchanged) and by a view change through the guard; both fail
  without their clearing.

Changed assertions, editor-creation-dialog.test.tsx:
- « Sommets de la nouvelle zone », « Sommet 1 de la nouvelle zone »
  -> « … de cette nouvelle zone » (ruling)
- « Sommets de le nouvel accès » -> « Sommets de ce nouvel accès »
- chosen null after « Créer » (cleared by the document change, not
  discriminating) -> « the chosen vertex ends with a finished
  creation, the document unchanged »
2026-11-19 09:49:27 +01:00
bchanot a5896710e5 feat(editor): resumed trace edits the closed shape with its handles
« Reprendre le tracé » keeps the pending shape closed; the zone handles
(vertex, « + », « − », vertex keys) edit it through the same press path
and useZoneEdit, the target generalised to points + drop. A drop on
PENDING_ID patches creation.pending only: document, history and unsaved
count untouched, message without « Défaire ». Strip: « Tracé repris,
saisie gardée » with « Revenir aux propriétés » and « Abandonner ».
Handle names fall back to « la nouvelle zone » / « le nouvel accès ».

Removed (resumed branch of popVertex, backToProperties -> closeTrace,
CreationCommands tracedCount and its « Retirer le dernier sommet »).

Removed assertions, editor-creation-dialog.test.tsx, « keeps the
vertices and the form; a new vertex, then the dialog again »:
- strip « Tracé repris, saisie gardée » -> kept in « keeps the shape
  closed and the form, shows its handles; two strip commands »
- « Retirer le dernier sommet » enabled -> absent; commands are exactly
  « Revenir aux propriétés », « Abandonner » (same test)
- a click on the drawing adds a 4th vertex -> « a click off the handles
  adds and selects nothing; a double « + » inserts once »
- dialog again with Nom (FR) « Tibia » -> « « Revenir aux propriétés »
  shows the edited shape; « Créer » inserts it »
- « Zone tracée, 4 sommets » -> « Zone tracée, 5 sommets » after « + »
  (same test)
2026-11-19 09:42:58 +01:00
bchanot 816d0f4f9a docs(docs): U2 rev 4, owner corrections before the trial 2026-11-19 00:45:08 +01:00
bchanot 1f2485ecb8 chore(memory): journal U2 T7-T10 and owner trial stop 2026-11-18 15:27:40 +01:00
bchanot 04d083ff85 docs(docs): U2 gate note gives the batch count for catalogue-integrity 2026-11-18 15:19:56 +01:00
bchanot 08458b6971 docs(docs): U2 gate notes name the serial skip and one-worker run 2026-11-18 15:00:14 +01:00
bchanot 4e2bdb5ebb docs(docs): U2 final gate results and measures on 15b23f8
UX_TESTS: gates at 15b23f8 (check:all passed; shell suite 311 passed, 14 failed, red; test 105 passed; test-db FAIL 014/021 as before U2), measures rerun, keyboard map row (Backspace only while tracing). Plan Tasks 8 and 10 and OWNER_TRIAL Mesures carry the new figures.
2026-11-18 14:54:24 +01:00
bchanot 15b23f8420 docs(docs): U2 redo hold as built and owner trial choices
UX_TESTS: redo is held while a move, a redraw or keyed steps are pending (ae80511), the message line also pauses under keyboard focus. OWNER_TRIAL 4.17: greyed redo, Mac keys (M-7), focus hold, focus back to the page after a touch or Safari commit, the new handle names.
2026-11-18 14:14:33 +01:00
bchanot 9522eb72aa test(tests): probe mode entry and exit for shifts at three widths
Criterion 5: « Déplacer le point », « Déplacer la zone », « Valider la
position », and « Redessiner » entered then cancelled, each under
expectNoShift at 1 024, 1 180 and 1 280 px (seeded point and zone, the
existing multi-width pattern). The editor-touch « Déplacer la zone » entry
joins the probe; its button is centred first, since below xl the sticky top
bar can cover the strip and Playwright would scroll inside the probe.

No assertion removed. No product shift found.
2026-11-18 14:13:53 +01:00
bchanot b6aa2819ea fix(editor): name vertex handles after their zone, in a named group
Criterion 18: « Sommet {n} de {nom} », « Ajouter un sommet après le sommet
{n} de {nom} », « Retirer le sommet {n} de {nom} » (EN « Vertex {n} of
{name} » …), {nom} the zone's display name in the current locale; the
handle group is a role="group" named « Sommets de {nom} ».

Tests: no assertion removed; every unit and e2e locator that read the old
names now reads the same handle with the zone name appended (fixtures: N,
Vertèbres thoraciques, Zone dessinée, Zone clavier). New unit tests in
editor-zone-edit cover the FR names, the group and the EN locale.
2026-11-18 14:09:24 +01:00