docs(docs): U2 rev 4, owner corrections before the trial
This commit is contained in:
1 parent
1f2485ecb8
commit
816d0f4f9a
3 files changed
+259
-2
No files matched your search
@@ -718,7 +718,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- [x] Task 7 shell spec admin-sheets-list + three locators (b4a5254, reviewed). Spec alone 4 passed. Sweep 27 files without editor-equine: 277 passed, 6 failed, 163 skipped, 0 flaky; failures all `admin.spec.ts` on the rights screen (BLK-015): « admin screens » :714 ×4 « Target crashed », A0 :220 ×2 lookup timeout at :144 (other symptom, about 7 600 grants; not A/B proven against pre-R3). A1, « access per right », editor-journey green. Guard: 0 pre-existing row changed; 12 R3 sheets soft-deleted
|
||||
- [x] Task 8 docs, closing gates, owner trial on db:trial: [x] documents as built (a86020d: U1_CORRECTIONS §R3, SQL checkpoint §6-§7 with F2-F4 corrections and F7 limits, V1-2 §12.3 M9, SUPABASE §5.1, BROWSER_TESTS, Rust Part II class C rows, design README deviations, CLAUDE.md, CHANGELOG) · [x] owner trial text §4.15 in French (b9e5d32) · [x] closing gates design review (28 CONFORME, 29 A and 29 B ÉCARTS, findings 1-4 fixed in the wave), code review (0 C, 0 I, 9 Minor: 1-7 fixed, 9 done at Task 8, 8 left), security PASS (4 non-blocking: spec SQL, date refine, RegExp escape fixed; db-sandbox.sh:485 false positive left) · [x] verifier on the contract 2026-11-16 at bcdacbb: ECARTS(1), 17/18 MET, criterion 4 NOT-MET on its CHECK line only (one-line literal split and strengthened by 374e300; layout-insensitive equivalent prints DATE_SOURCE_OK, recorded in the contract a8ab668; the owner closes it) · [x] `pnpm check:all` 2026-11-16 at bcdacbb: exit 0, « all checks passed » in 7 min 52 s (core-wasm 66, supabase 182, app 1743 in 137 files, e2e:ui 253 passed, app image, worker test and runtime image); e2e:shell NOT RUN by check:all (the sweep and the fix-wave run are the lines above) · [x] owner trial on db:trial passed and R3 validated 2026-11-16, no merge. Deviations for the owner: no magnifier (F14, validated); no info icon in the board 28 no-result block (ruling, to confirm)
|
||||
- [x] Final fix wave 2026-11-16 (`374e300` client refuses an unreadable date, test first; `1758276` list hooks split, rows memoised, className constants, phone clear button; `8bb2486` home cards as board 29 B, 44 px name links, row rhythm; `ea5512a` spec: `literal()` + uuid shape, UTC, one `<time>` per item, escaped pattern, Escape; docs commit after). Units core-wasm 66, supabase 182, app 1743; build ok. One run of admin-sheets-list + admin + editor-journey: 15 passed, 6 failed, 9 skipped, all six `admin.spec.ts` BLK-015 class (admin screens ×3 Target crashed + ×1 timeout during axe at :747; A0 fr :144, A0 en :158 « Granting… »), not A/B proven; guard 0 changed 0 missing 20 new; 6 R3 sheets deleted. Owner decisions open: U1_CORRECTIONS §R3 list (info icon, « Nouvelle fiche » at 375, breadcrumb, filter + search no result, double announcement)
|
||||
- [ ] Follow-up (security gate, outside R3's diff): guardrails scanner 2 FAIL at `scripts/db-trial-check.sh:1340`, pre-existing, not analysed
|
||||
- [ ] Follow-up (security gate, outside R3's diff): guardrails scanner 2 FAIL at `scripts/db-trial-check.sh:1340`, pre-existing, not analysed. Owner 2026-11-19: made-up passwords in scripts keep the ratified requirement, no real secret in clear in logs, process arguments, test or CI/CD artefacts before production; the audit checks the line against it
|
||||
- [ ] Follow-up: WebKit parsing of six fraction digits in `new Date(iso)` not verified (Chromium only until V1-5)
|
||||
- [ ] Follow-up: the R3 spec adds 2 accounts and 2 `sheet_editor` grants per run, feeding BLK-015's accumulation (RR-13)
|
||||
- shortcut: `apps/app/src/admin/sheetList.ts` search and sort run in the browser on the whole loaded list. Limit: the whole list loaded in one unbounded read, then filtered and sorted in the browser at each keystroke. Upgrade path: they move to the server with the admin list paging, RR-13 (widened per D4)
|
||||
@@ -746,6 +746,9 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- [x] V1-2.6 UX U2 design: boards 02-06, 13 redrawn + extras from 31 (owner brief 2026-11-17 « R4 est terminé … préparer U2 », orientation 2026-11-14 BDR-117; contract `.claude/tasks/contracts/2026-11-17-u2-design-boards.md`; docs only, no code, no DEV, no merge). [x] audit as built · [x] boards + REVUE + ARBITRAGES in `docs/design/v1-2-6-u2/` (bc19481, fixes 8bdb23a and pass 3) · [x] fresh design review (5 must-fix, 19 should, 19 observations; fixed) · [x] fresh conformity check (ECARTS(4), then re-check ECARTS(1) on 8bdb23a: two labels, fixed) · [x] owner validation 2026-11-17: nine boards + A1-A15 as recommended, adjustments A13 hint, A14 no shift, board 33 messages (ARBITRAGES « Validation du propriétaire »)
|
||||
- [x] V1-2.6 UX U2 technical plan (owner brief 2026-11-17 « conception graphique U2 validée … plan technique »): plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md` · [x] audit · [x] plan rev 1 · [x] three fresh plan-challengers (rev 1: correctness FATAL(9), robustness FATAL(9), simplicity CONCERNS(5); rev 2 integrates them) · [x] owner approval 2026-11-17 (rev 2 + D1, D2 with zoom hint R-18, R-12 corrected) → rev 3, BDR-123
|
||||
- [ ] V1-2.6 UX U2 implementation (contract `.claude/tasks/contracts/2026-11-17-v1-2-6-u2-implementation.md`, plan rev 3, subagent-driven): [ ] T1 core min radius · [ ] T2 press machine · [ ] T3 strip + message, no shift · [ ] T4 points, move mode, guard · [ ] T5 zones, redraw, R-18 · [ ] T6 properties dialog · [ ] T7 creation · [ ] T8 touch, loupe · [ ] T9 docs · [ ] T10 gates, verifier, security · [ ] STOP owner trial on `pnpm db:trial` before closure
|
||||
- [ ] Owner corrections before the trial (owner brief 2026-11-19 « Le bilan technique de U2 est encourageant », plan rev 4 Tasks 11-16, contract addendum criteria 25-31): [ ] T11 « Reprendre le tracé » with board 04 C handles · [ ] T12 Backspace and « + » on a vertex (Mac), group name pinned · [ ] T13 focus after a touch commit · [ ] T14 strip below the sticky top bar · [ ] T15 why « Refaire » is unavailable · [ ] T16 docs, gates, verifier, security, STOP for the db:trial run
|
||||
- [ ] Follow-up (owner approved 2026-11-19): the rights screen pages its grants (about 10 380 rows in the sandbox render at once; admin.spec axe Target crashed, lookup timeout; same on pre-U2 56c75b1). Production risk at those volumes.
|
||||
- [ ] Follow-up (owner approved 2026-11-19): the catalogue loads published versions progressively (`useCardDetails` loads 426 at once in the sandbox; catalogue-integrity times out; same on pre-U2 56c75b1).
|
||||
- [ ] `shortcut:` the « − » bubble for a mouse is 28 × 22 px, read off board 05 (R-9 gives only the touch size), `apps/app/src/editor/annotations/handleSize.ts`. Upgrade: the owner's value at the trial (U2 Task 5).
|
||||
- [ ] No `scroll-padding-top` under the sticky top bar (pre-existing, WCAG 2.4.11): a keyboard focus on the header's « Défaire », « Refaire » or « Enregistrer » while scrolled can stay hidden under it; axe target-size flags them once a list click scrolled the page (U2 Task 5 review M-3).
|
||||
- [x] At the page's end, a side panel that shortens (the issue list leaving it) clamps the scroll and moves the canvas by its height (11 px in `editor-geometry.spec.ts`, which starts from the top for that reason). Gone with Task 6: the column keeps the overview, the issue is in the strip and the dialog. `editor-geometry.spec.ts` now runs the accepted repair (the issue leaving) from the page's end under `expectNoShift`, buttons pressed in place, scroll position unchanged (U2 Task 5 fix round 1, closed by Task 6 fix round 1).
|
||||
|
||||
@@ -221,7 +221,7 @@ Je souhaite pouvoir essayer le résultat sur db:trial avant la clôture définit
|
||||
### Accessibility and touch
|
||||
|
||||
18. **Accessibility.**
|
||||
- Handles are focusable outside any `aria-hidden` subtree, with names such as « Sommet 3 de Thoraciques ».
|
||||
- Handles are focusable outside any `aria-hidden` subtree, with names such as « Sommet 3 de Vertèbres thoraciques » (the annotation's full name).
|
||||
- Every drag has a non-drag path (WCAG 2.5.7): move mode arrows, a track click, « + » and « − » clicks,
|
||||
« Redessiner ».
|
||||
- axe passes on the selection, tracing, move, creation and dialog states.
|
||||
@@ -267,3 +267,83 @@ packages/core-wasm/types/**, packages/core-wasm/tests/**, apps/app/src/{editor/*
|
||||
components/ui/Dialog.tsx,catalogue/useFraming.ts,app/routes/app/admin/AdminSheetDraftRoute.tsx,
|
||||
components/shell/SignOutButton.tsx,styles/index.css,i18n/fr.ts,i18n/en.ts}, apps/app/tests/**, apps/app/e2e/**,
|
||||
docs/**, CLAUDE.md, CHANGELOG.md, .claude/tasks/**, .claude/memory/*
|
||||
|
||||
## ADDENDUM 2026-11-19: owner corrections before the trial
|
||||
|
||||
### REQUEST (verbatim — IMMUTABLE)
|
||||
|
||||
Le bilan technique de U2 est encourageant.
|
||||
|
||||
Je valide globalement les choix visibles et les comportements annoncés, sous réserve de mon essai manuel sur db:trial.
|
||||
|
||||
Avant cet essai définitif, je souhaite corriger quelques points.
|
||||
|
||||
1. Sur tablette, la barre supérieure fixe ne doit jamais recouvrir le bandeau des outils de l'éditeur pendant le défilement.
|
||||
|
||||
C'est un véritable défaut d'ergonomie à corriger. Le dessin et les autres éléments ne doivent pas se décaler de manière inattendue.
|
||||
|
||||
2. Après une interaction tactile qui valide des réglages en attente, le focus doit revenir à un endroit cohérent avec l'action, et non simplement sur la page.
|
||||
|
||||
3. Lorsque l'on choisit « Reprendre le tracé », je préférerais retrouver les poignées prévues sur la planche 04 C, afin de pouvoir corriger directement la forme.
|
||||
|
||||
4. Sur Mac, Retour arrière doit pouvoir supprimer le sommet sélectionné, dans le respect des règles de validation du polygone.
|
||||
|
||||
Pour la fonction Inser, prévois une alternative accessible au clavier sur Mac. Je te laisse choisir la solution la plus naturelle, sans multiplier inutilement les raccourcis.
|
||||
|
||||
5. Utilise le nom complet de l'annotation pour le groupe de poignées, par exemple « Sommets de Vertèbres thoraciques ».
|
||||
|
||||
6. Si « Refaire » est indisponible pendant une opération, une explication accessible serait appréciable.
|
||||
|
||||
Les autres comportements sont acceptés :
|
||||
- Échap demande confirmation avant d'abandonner une création.
|
||||
- « Annuler le tracé » est une action explicite d'abandon.
|
||||
- Double-clic sur « + » = un seul sommet.
|
||||
- Un message conserve sa visibilité pendant qu'il a le focus.
|
||||
|
||||
Je valide également l'ajout au suivi produit des problèmes de pagination des droits et de chargement progressif du catalogue.
|
||||
|
||||
Pour les mots de passe fictifs présents dans les scripts, conserve l'exigence déjà ratifiée : aucun véritable secret en clair dans les journaux, arguments de processus ou artefacts de test et CI/CD avant la production.
|
||||
|
||||
Je te laisse autonome pour organiser les corrections, les tests et les relectures avec ton processus habituel.
|
||||
|
||||
Une fois ces points traités, je souhaite procéder à l'essai manuel U2 sur db:trial, notamment sur la véritable fiche équine et sur tablette.
|
||||
|
||||
Je validerai la clôture de U2 après cet essai.
|
||||
|
||||
### Rulings carried (plan rev 4, « Owner corrections before the trial »)
|
||||
|
||||
The accepted behaviours (Escape asks, « Annuler le tracé » discards, a double click on « + » inserts once, the
|
||||
focus hold) close criteria 2 and 6's open rulings. The plan's rev 4 rulings bind criteria 25 to 30.
|
||||
|
||||
### ACCEPTANCE CRITERIA (addendum)
|
||||
|
||||
25. **Strip under the top bar (point 1).** At 1 024 × 768, 1 180 × 820 and 1 280 × 800, at every scroll position of
|
||||
the editor's annotations tab, the strip's top is at or below the top bar's bottom and the strip is fully
|
||||
visible; the canvas and aside boxes do not shift; a focused or scrolled-to target is never under the bar or the
|
||||
strip; below 1 024 px nothing changes.
|
||||
26. **Focus after a touch commit (point 2).** A pending keyboard series or slider change commits without `blur()`;
|
||||
after a tap that commits it (Safari-like: the tapped control takes no focus), the focus is on the pressed
|
||||
handle, the handle that held the series, the canvas box, or the command's own keyboard target, per the path
|
||||
(plan Task 13), never `body`. Real iPad Safari is a trial item, not a verified one.
|
||||
27. **Resumed trace with handles (point 3, board 04 C).** « Reprendre le tracé » shows the closed pending shape with
|
||||
its vertex, « + » and « − » handles; drags, « + », « − » and the vertex keys change only the pending shape
|
||||
(document text, history and unsaved count unchanged); the three-vertex floor holds with its message; the strip
|
||||
shows « Revenir aux propriétés » and « Abandonner » only; « Créer » writes the edited shape in one insert;
|
||||
handle names use the form's name with a fallback while it is empty; the polyline reopening and its assertions
|
||||
are gone, each mapped.
|
||||
28. **Mac keys (point 4).** On a focused vertex handle, Backspace removes the chosen vertex exactly as Delete
|
||||
(three-vertex floor, move-mode inertness, pending steps committed first) and « + » inserts after it exactly as
|
||||
Insert, also when that segment's « + » is hidden; neither zooms the canvas nor reaches the tracing's Backspace;
|
||||
`aria-keyshortcuts` lists them.
|
||||
29. **Group name (point 5).** On the real equine sheet copy the group reads « Sommets de Vertèbres thoraciques »
|
||||
(e2e assertion), its vertices « Sommet {n} de Vertèbres thoraciques ».
|
||||
30. **Why redo is held (point 6).** A held « Refaire » (pending work) and a held « Défaire » or « Refaire » (creation)
|
||||
carry an `aria-describedby` reason; a press on a held button shows that reason in the message line without any
|
||||
shift; other disabled causes unchanged; axe passes on the held state.
|
||||
31. **Follow-ups and gates (rev 4).** TODO carries the rights paging, the catalogue progressive loading and the
|
||||
passwords requirement; §4.17 is rewritten for points 1 to 6 with the accepted behaviours moved out of the
|
||||
choices to judge; criteria 22 and 23 are met again on the final head (check:all, the shell suite without
|
||||
editor-equine, both measures, a fresh verifier, a fresh security auditor).
|
||||
|
||||
### FILE SCOPE (addendum)
|
||||
apps/app/src/components/shell/ShellChrome.tsx (the top bar's height variable only), apps/app/src/components/editor/HistoryButtons.tsx.
|
||||
@@ -1450,3 +1450,177 @@ Behaviour:
|
||||
never move the drawing, the read-only sheet keeps its properties readable, touch, loupe and gestures as planned.
|
||||
A13, A14 and the board 33 adjustment validated as integrated.
|
||||
- The owner tries the result on `pnpm db:trial` before U2 closes (Task 10).
|
||||
|
||||
## Owner corrections before the trial (2026-11-19, rev 4)
|
||||
|
||||
The owner read the Task 10 checkpoint and asked for six corrections before the db:trial run (verbatim in the
|
||||
contract's addendum). Accepted as built, no change: Escape asks before dropping a creation; « Annuler le tracé » is an
|
||||
explicit discard; a double click on « + » inserts one vertex; a message stays visible while it holds the focus. The
|
||||
paging of the rights screen and the progressive loading of the catalogue go to the TODO. The ratified requirement on
|
||||
made-up passwords in scripts stays: no real secret in clear in logs, process arguments, test or CI/CD artefacts before
|
||||
production.
|
||||
|
||||
Findings that shape the tasks (controller, read-only, at 1f2485e):
|
||||
|
||||
- Point 5 is already the code's behaviour: the group is « Sommets de {nom} » with `annotationName()`, the annotation's
|
||||
full name. The real equine zone is « Vertèbres thoraciques » (`measure-drag.ts:122` already expects « Sommet 1 de
|
||||
Vertèbres thoraciques »); « Thoraciques » is the vertebral region's name, used only by a unit fixture and by
|
||||
criterion 18's example. Task 12 pins it with an e2e assertion; the contract example is corrected.
|
||||
- Point 1: the shell's top bar is `sticky top-0 z-30 h-14` (`ShellChrome.tsx:89`, plus the safe-area inset) on the
|
||||
document's scroll; the edit strip is not sticky, so it scrolls under the bar (verifier-fix-report §3: bar bottom
|
||||
56 px at 1 024, 1 180 and 1 280 px).
|
||||
- Point 2: `commitFocusedSeries` (`drawingGuard.ts:7-13`) commits by `blur()`, so a touch press or a Safari tap sends
|
||||
the focus to `body`. Its callers: `usePressGesture.ts:298`, `usePointEdit.ts:115`, `redraw.ts:18`,
|
||||
`deselect.ts:57`, `drawingGuard.ts:34`.
|
||||
- Point 3: `useZoneEdit`, `ZoneHandles` and the press machine take a stored `Annotation` (`currentPoints(id)`,
|
||||
`onDrop` commit, `chosen` stamped with the document text). `resumeTrace` reopens the polyline (`closed: false`).
|
||||
- Point 4: the canvas box maps `+`, `=`, `-`, `0` to the zoom (`useFraming.ts:243-252`) when it has the focus itself;
|
||||
the tracing maps Backspace to « Retirer le dernier sommet » (`usePlacement.ts:116`).
|
||||
- Point 6: `HistoryButtons` uses `aria-disabled` (focusable) and a `title`; neither tells a touch or keyboard user why
|
||||
the button is held.
|
||||
|
||||
Rulings (rev 4):
|
||||
|
||||
- Ruling: point 3 generalises the existing zone editing to a target « points + drop »; a pending creation's drop
|
||||
patches `creation.pending` and never touches the document or the history. No second handle path — two paths
|
||||
would drift — cost if wrong: a later split.
|
||||
- Ruling: undo stays inactive during a creation (A12, criterion 12); a change of the pending shape has no undo
|
||||
entry, so its message line carries no « Défaire ». Arrow keys move a pending vertex at once (no keyboard series,
|
||||
nothing held) — cost if wrong: one message variant.
|
||||
- Ruling: the core's verdict on a zone stays at « Créer » (board 04: « Une zone trop étroite est refusée … »); the
|
||||
handles enforce only the three-vertex floor, as on a stored zone — cost if wrong: a refusal arrives at « Créer »
|
||||
instead of at the drop.
|
||||
- Ruling: no interior drag of a pending zone (board 04 C draws vertices and « + » only); the 40-vertex cap applies
|
||||
as on a stored zone. Both are listed for the trial.
|
||||
- Ruling: point 4's Insert alternative is the « + » key (`event.key === '+'`, so AZERTY, QWERTY and the keypad
|
||||
alike) on a focused vertex handle: it matches the drawn « + », needs no visible « + » (hidden on short segments),
|
||||
and adds one key, not a chord. Backspace joins Delete through the same path. On the canvas box itself « + » still
|
||||
zooms — cost if wrong: one key in a map.
|
||||
- Ruling: point 1 makes the strip sticky under the top bar on the editable layout (≥ 1 024 px), the bar's height in
|
||||
one CSS variable shared by both; below 1 024 px nothing changes (boards 14, 16). `ShellChrome.tsx` joins the FILE
|
||||
SCOPE for that variable — cost if wrong: a strip that hides a band of the drawing while scrolled.
|
||||
- Ruling: point 6 also covers « Défaire » during a creation (same mechanism, same question from the user); two
|
||||
reasons only: a creation, or work pending. Extension of the owner's ask, reported after.
|
||||
|
||||
### Task 11: « Reprendre le tracé » edits the closed shape with its handles (board 04 C)
|
||||
|
||||
**Files:** `editor/annotations/{creationWork,workStore,useZoneEdit,zoneEdit,usePlacement,usePressGesture}.ts`,
|
||||
`components/editor/annotations/{ZoneHandles,HandleLayer,AnnotationCanvas,EditableAnnotations,CreationCommands,
|
||||
SceneStrip,stripLead}.tsx|ts` as needed, `i18n/{fr,en}.ts`, unit and e2e tests (new e2e in a creation spec, never
|
||||
`editor-equine.spec.ts`).
|
||||
|
||||
**Behaviour (board 04 C):**
|
||||
|
||||
- « Reprendre le tracé » hides the dialog; the closed pending polygon stays drawn with its category fill, and the
|
||||
zone handles show on it: vertices, « + » on segments long enough (R-9, the zoom hint as on a stored zone), « − »
|
||||
on the chosen vertex. Same for a keyboard-added zone and for a link drawn as a polygon.
|
||||
- A vertex drag (mouse, touch with the loupe), « + », « − », the vertex keys (arrows, Enter, Insert, Delete, and
|
||||
Task 12's keys once added) change `creation.pending` only: the document, the history, « Défaire » and the unsaved
|
||||
count are untouched. « − » at three vertices says `message.vertex_min`. The message line says what changed without
|
||||
« Défaire ».
|
||||
- The strip reads « Nouvelle zone » (« Nouvel accès ») · « Tracé repris, saisie gardée », with « Revenir aux
|
||||
propriétés » and « Abandonner » only. « Retirer le dernier sommet » is gone from the resumed state (it stays in a
|
||||
fresh tracing).
|
||||
- A click or tap on the drawing off the handles adds no vertex and selects nothing. Escape asks « Abandonner la
|
||||
création ? » as today. « Revenir aux propriétés » reopens the dialog with the form intact and the edited shape; the
|
||||
focus goes where it goes today.
|
||||
- Handle names: « Sommet {n} de {nom} » in « Sommets de {nom} », with the form's name in the current locale; while
|
||||
that name is empty, « la nouvelle zone » / « le nouvel accès » (en: « the new zone » / « the new link »).
|
||||
- The chosen vertex of a pending shape never outlives the creation (finish, drop, view change) and never leaks onto
|
||||
a stored annotation.
|
||||
- A point keeps « Replacer le point » as today.
|
||||
|
||||
**Deletions:** the `resumed` branch of `popVertex` and of `backToProperties` → `closeTrace`, the resumed
|
||||
`tracedCount` path of `CreationCommands`, and every assertion of the polyline reopening; each removed assertion is
|
||||
mapped in the commit body.
|
||||
|
||||
- [ ] **Step 1: failing tests.** Unit: resume keeps `closed` true and shows the handles; a drag, « + », « − », Insert,
|
||||
Delete and arrows patch `creation.pending` and leave the document text and the history unchanged; « − » at three
|
||||
vertices is refused with the message; « Créer » writes the edited shape in one insert; the chosen vertex clears on
|
||||
finish and drop; the fallback names. E2E (1 280 px mouse and a touch run at 1 180 px): close a 5-vertex trace,
|
||||
type a name, « Reprendre le tracé », drag a vertex, add one by « + », remove one by « − », « Revenir aux
|
||||
propriétés », « Créer », then one undo removes the whole new zone; axe on the resumed state; `expectNoShift` at
|
||||
resume and back.
|
||||
- [ ] **Step 2:** FAIL. **Step 3:** implement. **Step 4:** typecheck, lint, unit suite, the touched shell specs.
|
||||
- [ ] **Step 5:** commit `feat(editor): resumed trace edits the closed shape with its handles`.
|
||||
|
||||
### Task 12: Vertex keys without Insert and Delete (Mac), the group name pinned
|
||||
|
||||
**Files:** `editor/annotations/useZoneEdit.ts`, `components/editor/annotations/ZoneHandles.tsx`
|
||||
(`aria-keyshortcuts`), `i18n/{fr,en}.ts` if a key hint names the keys, unit and e2e tests.
|
||||
|
||||
- On a focused vertex handle (stored zone, and a pending one from Task 11): Backspace removes the chosen vertex
|
||||
exactly as Delete (three-vertex floor and its message, move-mode inertness, pending arrow steps committed first);
|
||||
« + » (`event.key === '+'`) inserts after the chosen vertex exactly as Insert, also when that segment's « + » is
|
||||
hidden. Both `preventDefault`; neither reaches the canvas zoom nor the tracing's Backspace; no platform sniffing.
|
||||
- The vertex handles' `aria-keyshortcuts` list the added keys.
|
||||
- E2E on the sandbox copy: the handle group's accessible name is « Sommets de Vertèbres thoraciques » and a vertex
|
||||
reads « Sommet 3 de Vertèbres thoraciques »; Backspace and « + » on a vertex, each undone.
|
||||
- The unit fixture « Thoraciques » may stay (a unit name), but criterion 18's example is corrected in the contract.
|
||||
- [ ] Steps: failing tests, FAIL, implement, gates, commit `feat(editor): Backspace and « + » on a vertex handle`.
|
||||
|
||||
### Task 13: The focus after a touch commit of pending settings
|
||||
|
||||
**Files:** `editor/annotations/{drawingGuard,usePressGesture,usePointEdit,redraw,deselect,focusTarget}.ts` and the
|
||||
mode commands that call them, unit tests (the existing Safari block simulates a tap that does not focus).
|
||||
|
||||
- The pending keyboard series or slider change commits explicitly (the focused handle's or slider's own commit), not
|
||||
by `blur()`; the focus never lands on `body` because of the commit.
|
||||
- Then the focus goes where the same action sends it from the keyboard, with `preventScroll`:
|
||||
- a press on a handle: that handle (the pressed vertex or point handle);
|
||||
- a press elsewhere on the drawing that keeps the selection: the handle that held the series, if it still exists;
|
||||
else the canvas box;
|
||||
- « Déplacer … », « Redessiner », « Désélectionner » and the other selection commands: the focus their keyboard
|
||||
activation gives today (the mode's own target, or the command);
|
||||
- a handle removed by the action itself (a removed vertex, a redraw): the next vertex, else the strip's command.
|
||||
- Unit tests per path with a tap that does not focus (Safari block); one e2e touch run. Real iPad Safari stays a
|
||||
trial item, never reported as verified.
|
||||
- [ ] Steps: failing tests, FAIL, implement, gates, commit `fix(editor): focus follows the action after a touch commit`.
|
||||
|
||||
### Task 14: The strip stays below the top bar while the page scrolls
|
||||
|
||||
**Files:** `components/shell/ShellChrome.tsx` (the bar's height as one CSS variable), `styles/index.css`,
|
||||
`components/editor/annotations/SceneStrip.tsx` (or the strip's wrapper), e2e tests.
|
||||
|
||||
- On the editable layout (≥ 1 024 px), the strip is sticky right under the top bar: at every scroll position its top
|
||||
is at or below the bar's bottom, and nothing of the strip is under the bar. Opaque background; above the drawing,
|
||||
below the bar, the dialogs, the loupe and the menus.
|
||||
- No ancestor `overflow` breaks the stickiness; the boxes of the canvas, the aside and the strip keep their place in
|
||||
the flow (no layout shift); a programmatic focus or `scrollIntoView` never leaves a target under the bar or the
|
||||
strip (`scroll-margin` or `scroll-padding`).
|
||||
- Below 1 024 px nothing changes.
|
||||
- E2E at 1 024 × 768, 1 180 × 820 and 1 280 × 800: scroll by steps to the bottom; at each step the strip's top ≥ the
|
||||
bar's bottom and the strip is fully visible; `expectNoShift` on the canvas and the aside; a tap on a strip command
|
||||
after a scroll hits it (no re-scroll by the hit check).
|
||||
- [ ] Steps: failing tests, FAIL, implement, gates, commit `fix(editor): the strip stays below the top bar on scroll`.
|
||||
|
||||
### Task 15: Why « Refaire » (and « Défaire » during a creation) is unavailable
|
||||
|
||||
**Files:** `components/editor/HistoryButtons.tsx`, the annotations message line (a store signal or the existing
|
||||
message API), `i18n/{fr,en}.ts`, unit and e2e tests.
|
||||
|
||||
- While held, the button keeps `aria-disabled` and gets `aria-describedby` to a short reason, read on focus:
|
||||
- pending work (a started mode, a keyboard series, a slider change): « Refaire attend la fin de la modification en
|
||||
cours : validez-la ou annulez-la. » (en: « Redo waits for the change in progress: confirm or cancel it. »);
|
||||
- a creation: « Indisponible pendant une création : créez l'annotation ou abandonnez-la. » (en: « Unavailable
|
||||
during a creation: create the annotation or discard it. »).
|
||||
- A press (click, tap, Enter, Space) on a held button shows the same reason in the message line under the drawing,
|
||||
without moving anything (A14), announced once; nothing else happens.
|
||||
- The other disabled causes (nothing to redo, read-only) keep today's behaviour.
|
||||
- The stale comment at `HistoryButtons.tsx:83` is fixed.
|
||||
- [ ] Steps: failing tests, FAIL, implement, gates (axe on the held state), commit
|
||||
`feat(editor): say why redo is unavailable during pending work`.
|
||||
|
||||
### Task 16: Documents, TODO, gates and the owner checkpoint (rev 4)
|
||||
|
||||
- `docs/development/V1-2-6_OWNER_TRIAL.md` §4.17: steps for Tasks 11 to 15 (mouse and tablet), the four accepted
|
||||
behaviours moved out of « Choix visibles à juger », the new visible choices (the reason texts, the « + » key, the
|
||||
sticky strip, the fallback handle names, no interior drag of a pending zone).
|
||||
- `docs/development/V1-2-6_UX_TESTS.md` §U2, `docs/design/README.md:240` (« Reprendre le tracé » now draws the
|
||||
handles as board 04 C), `docs/ANNOTATION-RENDERING.md` if the pending shape's handles change the overlay.
|
||||
- `.claude/tasks/TODO.md`: the two follow-ups the owner approved (paging of the rights screen, progressive loading
|
||||
of the catalogue) and the passwords requirement kept with the guardrails item.
|
||||
- Gates on the final head: `pnpm check:all` exit 0; the shell suite without `editor-equine.spec.ts`; both opt-in
|
||||
measures again; a fresh verifier on the contract with its addendum; a fresh security auditor on the U2 diff.
|
||||
- [ ] STOP for the owner's trial on `db:trial`, the real equine sheet and the tablet. U2 closes only on the owner's
|
||||
validation.
|
||||
Reference in new issue
Block a user