docs(docs): rev 4 gate figures on the final head
This commit is contained in:
1 parent
f5a6eafc7f
commit
8df52fd1be
1 file changed
+3
-3
@@ -50,12 +50,12 @@ Implemented (contract `.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md`)
|
||||
|
||||
## U2 · Points and polygons
|
||||
|
||||
Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4; boards `docs/design/v1-2-6-u2/`, A1 to A15 and the three adjustments). Rule numbers (R-n) are the plan's. Gates (plan Task 16) on the final head, 2026-11-19 (code at 448a17ef, this page's figures added after): `pnpm check:all` exit 0; the shell suite without `editor-equine.spec.ts` 326 passed, 18 failed, 5 not run, the failures being the admin, catalogue-integrity, catalogue and admin-sheets-list tests that fail the same way before U2 (sandbox data), plus one `editor-signout.spec.ts` « Page crashed » that passes alone and four times repeated; both opt-in measures rerun (figures in the Performance row). The owner trial is pending. The suites run on the sandbox only (`pnpm db:sandbox`).
|
||||
Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4; boards `docs/design/v1-2-6-u2/`, A1 to A15 and the three adjustments). Rule numbers (R-n) are the plan's. Gates (plan Task 16) on the final head, 2026-11-19 (code at f5a6eafc, this page's figures added after): `pnpm check:all` exit 0 (app 2 137, core-wasm 67, supabase 182 tests, e2e:ui 253); the shell suite without `editor-equine.spec.ts` 325 passed, 19 failed, 5 not run, the failures being the admin, catalogue-integrity, catalogue and admin-sheets-list tests that fail the same way before U2 (sandbox data), plus one `editor-shell-layout.spec.ts` « Page crashed » that passes alone three times repeated (39 passed); `pnpm db:sandbox test` 105 passed, 10 skipped, and `test-db` Files=21 Tests=1958 FAIL on `014_animals_relations` (2) and `021_sheet_verification_jobs` (23), identical to before U2, which changes no SQL (run at 0aa0f6bc); `up fresh` is the owner's call; both opt-in measures rerun (figures in the Performance row). The owner trial is pending. The suites run on the sandbox only (`pnpm db:sandbox`).
|
||||
|
||||
| Kind | Tests |
|
||||
|---|---|
|
||||
| Unit (tables) | the press machine (`annotations.press.test.ts`): slop per kind (4, 6 and 10 CSS px), click and drag decisions, handle priority (vertex over « − » over « + », nearest first), double click within 400 ms and 8 px opens the dialog and never inserts, a second pointer cancels; slider stops, most-used radius, snap within 8 CSS px, range (`pointSize`); midpoint insert after the segment start, « − » refused at 3 vertices (`message.vertex_min`), vertex move, no-op move, the 40-vertex cap, « + » hidden under two hit radii (`polygonEdit`); Escape action (`escape`); `missingFields` names only the missing fields in form order; keyboard map (arrows by 0.5 % of the frame's longer side, Shift ×10, Insert and Delete on a vertex, Backspace while tracing, Enter, Escape, roving focus); arrows pan only when the box itself is focused (`useFraming`, catalogue defaults unchanged); two pointers translate without scaling (`twoPointerPan`) |
|
||||
| Unit (state) | every preview, keyboard series and chosen vertex carries the `documentText` it was computed on, and a stale stamp is refused (`annotations.workStore.test.ts`); a preview is cancelled and restored, never committed, on undo, document replacement, tab change and a second pointer; redo is held (the header « Refaire » `aria-disabled`, Ctrl+Shift+Z inert) while a move mode, a redraw or uncommitted arrow or slider steps are pending, so the pending work is kept, never dropped (`editor-zone-edit.test.tsx` « final review I-1 »); a held « Refaire » or « Défaire » (a creation holds both) carries its reason as the accessible description only when its cause alone holds it (something to redo or to undo), a press shows the reason in the message line and does nothing else (a mouse press no longer commits a pending series), a mouse or touch press on « Défaire » over pending work only cancels it and keeps the redo stack, Ctrl+Z during a hold is silent, and a press while another tab is shown leaves the hidden line empty and keeps the description (`holdOf`, `HistoryButtons.tsx`, `editor-history-buttons.test.tsx`); « + » and Backspace on a focused vertex handle insert and remove like Insert and Delete, and after an undo the keys act on the focused handle (`useZoneEdit.ts`); a Safari tap (no focus move) on a tool or a view chip after a keyboard series commits it and lands the focus on the pressed button, never on `body` (`editor-zone-edit.test.tsx`); a resumed trace gets the polygon handles on its pending shape, named « cette nouvelle zone » or « ce nouvel accès » while the form has no name, with no interior drag and no handle above 40 vertices (`editor-creation-dialog.test.tsx`); an undo with a move mode, a slider or a series pending only cancels the preview (R-13); during a creation undo is inactive and « Défaire » is hidden (A12); the message line: « Point déplacé · Défaire » calls the same `undo()` as the header, any commit, undo or redo closes it, a refusal is `role="alert"` without « Défaire », 6 s, a mouse hover or the keyboard focus inside the line pauses it (WCAG 2.2.1) and a touch does not; the hint after a futile finger drag only when the line is free and never after a two-finger gesture worked (R-1); the slider commits once on release (history depth after a keyboard walk); the strip keeps a fixed height and truncates a long name before the status; dialogs mounted outside `EditOnly`: the width flip and the mode flip keep the draft, disable the save and commit nothing (R-14); a creation, a started move mode or a started redraw asks before a tab, a section, a view chip, a tool, Back, Escape, sign-out or leaving the editor, and a document change made elsewhere announces the dropped work (R-12, R-13); `Dialog` `anchor`, a click on the veil does nothing (R-6); undo history cap 8 MiB, about 47 equine steps (R-15) |
|
||||
| Unit (state) | every preview, keyboard series and chosen vertex carries the `documentText` it was computed on, and a stale stamp is refused (`annotations.workStore.test.ts`); a preview is cancelled and restored, never committed, on undo, document replacement, tab change and a second pointer; redo is held (the header « Refaire » `aria-disabled`, Ctrl+Shift+Z inert) while a move mode, a redraw or uncommitted arrow or slider steps are pending, so the pending work is kept, never dropped (`editor-zone-edit.test.tsx` « final review I-1 »); a held « Refaire » or « Défaire » (a creation holds both) carries its reason as the accessible description only when its cause alone holds it (something to redo or to undo), a press shows the reason in the message line and does nothing else (a mouse press no longer commits a pending series), a mouse or touch press on « Défaire » over pending work only cancels it and keeps the redo stack, Ctrl+Z during a hold is silent, and a press while another tab is shown leaves the hidden line empty and keeps the description (`holdOf`, `HistoryButtons.tsx`, `editor-history-buttons.test.tsx`); « + » and Backspace on a focused vertex handle insert and remove like Insert and Delete, and after an undo the keys act on the focused handle (`useZoneEdit.ts`); a Safari tap (no focus move) on a tool, a view chip or an overview row (annotation or view) after a keyboard series commits it and lands the focus on the pressed control, never on `body`; the zone handles remount per annotation, so a row tap from a focused vertex of another zone lands on the row (`editor-zone-edit.test.tsx`); a resumed trace gets the polygon handles on its pending shape, named « cette nouvelle zone » or « ce nouvel accès » while the form has no name, with no interior drag and no handle above 40 vertices (`editor-creation-dialog.test.tsx`); an undo with a move mode, a slider or a series pending only cancels the preview (R-13); during a creation undo is inactive and « Défaire » is hidden (A12); the message line: « Point déplacé · Défaire » calls the same `undo()` as the header, any commit, undo or redo closes it, a refusal is `role="alert"` without « Défaire », 6 s, a mouse hover or the keyboard focus inside the line pauses it (WCAG 2.2.1) and a touch does not; the hint after a futile finger drag only when the line is free and never after a two-finger gesture worked (R-1); the slider commits once on release (history depth after a keyboard walk); the strip keeps a fixed height and truncates a long name before the status; dialogs mounted outside `EditOnly`: the width flip and the mode flip keep the draft, disable the save and commit nothing (R-14); a creation, a started move mode or a started redraw asks before a tab, a section, a view chip, a tool, Back, Escape, sign-out or leaving the editor, and a document change made elsewhere announces the dropped work (R-12, R-13); `Dialog` `anchor`, a click on the veil does nothing (R-6); undo history cap 8 MiB, about 47 equine steps (R-15) |
|
||||
| Core | the per-view minimum visible radius (`PreviewState.min_point_radius`) equals the `marker_too_small` threshold on the equine views and on edge frames (`sheet_preview.rs`, `editor-min-point-radius.test.ts`) |
|
||||
| E2E mouse | drag a vertex, « + », « − », zone drag on a selected zone, redraw accepted, redraw refused by `interior_too_small` keeps and restores the old shape, undo and redo of each (`editor-zones.spec.ts`); a point: handle drag, size by a click on the track, the move mode (`editor-annotations.spec.ts`); the properties dialog opens over the right column and never over the drawing, a click on the veil does nothing, a double click on the selected zone opens it and inserts no vertex, a typed form then Back asks, a width crossing below 1 024 px keeps the draft (`editor-properties.spec.ts`); « Défaire » in the message line undoes the same entry as the header button, which carries the accessible name « Défaire la dernière modification » (T15; EN « Undo the last change »); during a held arrow series a mouse press on « Défaire » cancels it and « Refaire » restores the earlier move (`editor-annotations.spec.ts`); a Tab and Shift+Tab walk over the drawing place's native controls, and a keyboard Delete whose next vertex starts under the strip, land below the strip at 1 024, 1 180 and 1 280 px (`editor-geometry.spec.ts`) |
|
||||
| E2E touch (`hasTouch`, 1 024, 1 180, 1 280 px; CDP `Input.dispatchTouchEvent`) | one finger drags a vertex and the point under the loupe; every handle hit circle is at least 44 px; one finger off the handles moves nothing and shows the hint once, with no hint over a page scroll; two fingers zoom and pan; finger 1 on a vertex handle then finger 2: the drag is cancelled, the shape restored, nothing committed, the pinch zooms (Review Focus 1); the move mode by a finger; a tap on the selected shape opens the dialog and it stays open (Review Focus 5), with a chosen vertex it unchooses; the trace closes from a finger within 22 px; page scroll over the canvas with a selection and outside it (`editor-touch.spec.ts`, `editor-properties.spec.ts`, `editor-deselect.spec.ts`) |
|
||||
@@ -63,7 +63,7 @@ Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4; boards `
|
||||
| Keyboard | create a zone, add and remove a vertex, move the zone, validate, without a pointer; « + » inserts and Backspace removes on a focused vertex, Backspace after an undo acts on the same focused handle; Ctrl+Z on a focused handle after arrow moves only cancels the preview and a later Enter commits nothing stale; after undoing « + », « − » never removes the wrong vertex; « Désélectionner » commits a pending series |
|
||||
| Paths (T16) | a path annotation gets no handle, no « + » or « − », no zone move in either mode, no keyboard move; its `d` is byte-identical after every gesture on its neighbours, a save and a reload; « Remplacer par un polygone » stays the only change: explicit, validated by the core, the path kept while tracing, on Escape and on a refusal; one undo entry restoring the exact `d`, redo restoring the polygon (owner, BDR-101) |
|
||||
| Accessibility | axe on selection, tracing, move states and the dialog in read and edit modes; handle names (« Point {nom} », « Sommet {n} de {nom} », « Ajouter un sommet après le sommet {n} de {nom} », « Retirer le sommet {n} de {nom} », the handle group « Sommets de {nom} »); live-region message after a move; WCAG 2.5.7: the move mode with four arrow buttons is the single-pointer path without dragging (A11) |
|
||||
| Performance | commit latency under the 500 ms budget for drag, insert and remove, a measure run by hand at the gates (`e2e/support/measure-commit.ts`, `editor-measure-commit.spec.ts`, `MEASURE_COMMIT=1`) on a run-seeded equine-sized draft, never on the historical copy nor through `editor-equine.spec.ts`. Measured 2026-11-18 on a production build under `vite preview`, Chromium mouse at 1 280 px, CPU ×4, from the release to the painted frame showing the new geometry with the undo entry; on the final code (448a17ef, 2026-11-19): median / max drag 179 / 206 ms, « + » 183 / 187.8 ms, « − » 178.6 / 179 ms (three runs each; 15b23f8 and earlier figures in plan Task 10); the drag smoothness is a measure, not an assertion (`e2e/support/measure-drag.ts`, `editor-measure-drag.spec.ts`, run by hand). Measured 2026-11-18 on a production build under `vite preview`, Chromium touch at 1 180 px, CPU ×4: frame work p95 3.9 to 4.5 ms with the loupe (technique A, final code 15b23f8; 4.2 to 4.7 ms before), 4.0 to 4.4 ms outline only (B), 3.6 to 4.2 ms without a loupe; technique A kept. Rerun on 448a17ef (2026-11-19, same setup): touch with the loupe, handler to frame median 3.6 ms, p95 5.1 ms (event to frame median 27 ms, p95 33.6 ms); mouse, handler to frame p95 3.9 ms. The figures are in plan Task 8; the owner's tablet trial is the real check |
|
||||
| Performance | commit latency under the 500 ms budget for drag, insert and remove, a measure run by hand at the gates (`e2e/support/measure-commit.ts`, `editor-measure-commit.spec.ts`, `MEASURE_COMMIT=1`) on a run-seeded equine-sized draft, never on the historical copy nor through `editor-equine.spec.ts`. Measured 2026-11-18 on a production build under `vite preview`, Chromium mouse at 1 280 px, CPU ×4, from the release to the painted frame showing the new geometry with the undo entry; on the final code (f5a6eafc, 2026-11-19): median / max drag 178.7 / 210.3 ms, « + » 185.4 / 186.7 ms, « − » 178.4 / 185.1 ms (three runs each; 15b23f8 and earlier figures in plan Task 10); the drag smoothness is a measure, not an assertion (`e2e/support/measure-drag.ts`, `editor-measure-drag.spec.ts`, run by hand). Measured 2026-11-18 on a production build under `vite preview`, Chromium touch at 1 180 px, CPU ×4: frame work p95 3.9 to 4.5 ms with the loupe (technique A, final code 15b23f8; 4.2 to 4.7 ms before), 4.0 to 4.4 ms outline only (B), 3.6 to 4.2 ms without a loupe; technique A kept. Rerun on f5a6eafc (2026-11-19, same setup): touch with the loupe, handler to frame median 3.6 ms, p95 5.3 ms (event to frame median 27.2 ms, p95 33.7 ms); mouse, handler to frame p95 4.0 ms. The figures are in plan Task 8; the owner's tablet trial is the real check |
|
||||
|
||||
## U3 · Category panel and own colour
|
||||
|
||||
|
||||
Reference in new issue
Block a user