Commit Graph
407 Commits
Author SHA1 Message Date
bchanot c66cd96ded chore(memory): journal — U2 trial: criterion 32 symptoms, Refaire hold anomaly evidence 2026-11-20 16:55:25 +01:00
bchanot fef5f126b3 chore(memory): journal — ship-feature U2 trial adjustments, plan + contract 2026-11-20 16:39:08 +01:00
bchanot c16840d736 docs(docs): U2 criterion 32 outcome and overlay text reflow 2026-11-20 16:01:40 +01:00
bchanot d3f6314219 feat(editor): lighter coarse handle marks, hit areas unchanged 2026-11-20 14:37:47 +01:00
bchanot 4e99305833 docs(docs): U2 trial amendments before the handle change 2026-11-20 14:35:53 +01:00
bchanot 70d4addc56 docs(docs): U2 preparatory closure, skipped tests, contrast anomaly, Prettier on two tests 2026-11-20 11:38:08 +01:00
bchanot da04c79d13 docs(docs): U2 plan rev 5, owner decisions 2026-11-19 19:44:57 +01:00
bchanot e2f9302dfe docs(docs): U2 contract addendum 2, owner decisions D1 to D5 2026-11-19 19:44:30 +01:00
bchanot 9e03f1443a docs(docs): U2 plan file list, demo zone name, two owner choices, TODO 2026-11-19 19:04:25 +01:00
bchanot da8642dd44 docs(docs): focus margin under the top bar, « Redessiner » wording in the trial 2026-11-19 18:24:16 +01:00
bchanot 0aa0f6bc62 docs(docs): rev 4 gate figures and the amended held-reason criterion 2026-11-19 15:44:25 +01:00
bchanot 816d0f4f9a docs(docs): U2 rev 4, owner corrections before the trial 2026-11-19 00:45:08 +01:00
bchanot 4e2bdb5ebb docs(docs): U2 final gate results and measures on 15b23f8
UX_TESTS: gates at 15b23f8 (check:all passed; shell suite 311 passed, 14 failed, red; test 105 passed; test-db FAIL 014/021 as before U2), measures rerun, keyboard map row (Backspace only while tracing). Plan Tasks 8 and 10 and OWNER_TRIAL Mesures carry the new figures.
2026-11-18 14:54:24 +01:00
bchanot fab641c278 docs(docs): U2 contract records the scope oracle evidence 2026-11-18 14:04:31 +01:00
bchanot c6b8c7e48a docs(docs): U2 owner trial section and gate figures
OWNER_TRIAL §4.17: db:trial preparation, mouse and tablet steps, visible choices to judge, invented strings, known limits, measures. Plan Task 10 Step 3 and UX_TESTS performance row: commit latency figures. CLAUDE.md cites the two hand-run measure specs.
2026-11-18 12:20:49 +01:00
bchanot 0ca1f20452 docs(docs): U2 plan records the loupe drag measure 2026-11-18 11:18:03 +01:00
bchanot 4d2c64f57f feat(editor): creation on the drawing then the creation dialog
U2 Task 7 (A2, A4, A5, A7, A12, A15; R-3, R-4, R-12, R-13, R-14).
The work store's `creation` owns the new shape, its form, its view and
F: a click with the point tool, a closed tracing or a keyboard
« Ajouter … » opens « Nouveau point / zone / accès », a modal without
a history layer over the right column, mounted beside EditOnly so a
read-only flip keeps it (« Créer », « Replacer », « Reprendre » off).
A new zone or link is a creation from its first vertex. The ghost
takes the form's category colour; the point tool previews under a
mouse; the canvas carries data-creating (other markers dimmed,
unselectable). « Replacer le point » / « Reprendre le tracé » hide the
dialog and keep the form; the strip offers « Revenir aux propriétés »,
« Retirer le dernier sommet », « Abandonner ». « Créer »: one insert,
tool back to « Sélectionner », the new element selected, « Point
créé · Défaire », focus on its row. ✕, Échap, « Abandonner » and Back
always ask « Abandonner la création ? » (DiscardConfirm inside the
dialog; DrawingGuardDialog elsewhere); answerDrawing drops the
creation. Undo, its shortcuts and the line's « Défaire » are inactive
during a creation. missingFields replaces formProblem (MissingSummary
shared with the edit form); the C26 notice has no numbers.
CreationPanel, formProblem, withGeometry and the keys required.fields,
required.names and create_cancel are gone; GeometryGroup is imported
by RepairDialog only.

Removed or rewritten assertions:
- tab « holds a point at the frame centre »: « Centre x » = 50 ->
  the ghost circle cx = 50; plus tool back to Sélectionner, « Point
  créé », one undo step.
- tab « refuses a creation without laterality »: the general line
  « Choisissez la catégorie et la latéralité » -> only « Choisissez
  une latéralité. » and « À compléter : Latéralité. », focus on it.
- tab « applies the geometry group to a pending zone »: removed (A8,
  no coordinate field) -> « places a triangle at the centre: the ghost
  shows it, Créer inserts it »; vertex edits after Créer are the e2e
  keyboard test.
- tab C26 « proposes C »: « x = 15, y = 15 » in the notice -> the R-4
  text, the notice inside the dialog; cancel test « Centre x » = 0 ->
  ghost cx = 0.
- tab « offers the correction when the core refuses a pending point »
  (typed cx 98): removed, no typed coordinate is possible; the verdict
  path stays covered by the C26 click tests and correctionFor units.
- tab H5 « a typed radius shows the core issue »: removed (A8); the
  size refusal is the slider's (Task 4 tests).
- tab H6 « a second click moves the pending point »: -> « Replacer le
  point », then the click moves the ghost, the form kept.
- tab H7 « Centre x/y » = 30/50 -> ghost cx/cy.
- tab tracing Enter: « x du sommet 3 » -> ghost points; « drops the
  tracing on Escape » -> Escape asks first (board 32 row 3), Continuer
  keeps, Abandonner drops; new « Annuler le tracé acts at once ».
- keep-alive « a pending creation is kept and focused » and « a
  tracing … is kept and focused »: the tab now asks first (R-12) ->
  « Continuer » keeps the tracing / the form, « Abandonner » goes.
- sections « its panel takes the focus » -> its dialog's
  [data-creation-focus] takes it.
- no-loss « pending creation with its name » (hidden with the body) ->
  the dialog stays across the crossing, read-only, Créer off (R-14).
- point-edit A5 « Rayon » = 7 / 9 -> ghost r = 7 / 9.
- e2e editor-annotations keyboard test « numeric position » (cx field
  250) -> UX_TESTS Keyboard: zone added, vertex added and removed,
  moved by the move mode, validated, saved. The « Fermer le tracé »
  step runs under expectNoShift again (shortcut removed).
- e2e editor-geometry C26: the proposed x, y read from the notice
  text -> from the overlay's correction circle; the R-4 text checked
  in the dialog.
- e2e editor-deselect « Escape cancels the tracing only » -> Escape
  asks, « Abandonner » cancels it, the selection kept.
- e2e editor-shell-crossing « keeps its tool and its pending
  creation » (field hidden) -> the dialog stays read-only, Créer off,
  then editable on widening.
2026-11-17 23:32:42 +01:00
bchanot 9a0fe3784c fix(editor): veil ignores clicks, names merged apart, honest tests
U2 Task 6 fix round 1 (review minors 1 to 9).

- R-6: `Dialog` takes `veilCloses`; the annotation dialog passes false,
  so its veil ignores clicks centred too. Other dialogs unchanged.
- Save merges each name on its own (an EN refreshed meanwhile survives
  an FR-only edit); the merged annotation is typed per kind, no cast.
- Tests: the category change and the region row really run (a second
  category and a region in the fixture); EN kept under an FR edit;
  focus to the drawing when a filter hides the row; a centred veil
  ignores a click; act() around the store write; ui.Dialog restores
  innerHeight and visualViewport after each test.
- e2e: `pickAnnotation` no longer scrolls; `scrollToTop` is explicit
  where a low row leaves the drawing out of view (editor-zones x3,
  editor-geometry). editor-geometry runs the accepted repair from the
  page's end, buttons pressed in place, scroll unchanged. The touch
  and double-click tests wait on the clicks themselves; the stray
  click on the veil can fail.
- CreationPanel's `required.fields` recorded as a shortcut for Task 7;
  TODO lines updated. focusTarget comment wrapped.
2026-11-17 22:47:02 +01:00
bchanot cd794f3c39 feat(editor): properties dialog over the column, transactional save
U2 Task 6 (A1, A2, A3, A9, A10, R-3, R-5, R-6, R-14, R-16).

- Dialog: `anchor` places the panel at the column's left and width,
  from its top, under a 22 % ink veil that ignores clicks; the visual
  viewport below 320 px; centred without an anchor box.
- Navigation: `annotation` layer (LAYERS, EditorView, history entry,
  leave guards, left-draft flag); Back closes, Forward reopens.
- AnnotationDialog: read body, « Modifier » form (CreationFields with
  « Couleur », missingFields, R-3 messages), one `update` on the
  current annotation by id, « Marquer comme relu », « Modifier la
  forme », « Supprimer »; read-only flip keeps the draft.
- The column always shows the overview, selected row marked; Enter on
  it, a second click or a double click, the strip's « Propriétés »
  open the dialog. « Aller à » focuses the row (R-5).
- Read-only twin: strip and read-only dialog at 1 024 px and wider,
  inline read body below. PropertiesPanel and AnnotationFields gone.
- Strip lead 256 px and a fixed status slot, so the commands fit at
  1 024 px and a status change moves nothing.
- e2e: `aside-content` exemption removed; scroll-to-top workarounds
  of editor-geometry, editor-zones and editor-journey removed.

Removed assertions mapped:
  editor-annotations-tab.test.tsx:
  - selectFromList waited for `annotation-properties` -> waits for the strip's « Propriétés » (selection without dialog, A1)
  - refused place: issues block `annotation-geometry-issues` in the panel -> the strip notice alert (present, then gone)
  - keyboard creation / C26 confirmation: `annotation-properties` after create -> strip « Propriétés » (new element selected)
  - Désélectionner from the panel -> « Désélectionner » in the strip (all 7 tests); « panel closes » -> strip has no « Propriétés »
  - undo after deselect (typed name) -> handle key series then deselect then undo
  - commits a valid typed value once without blur (name field) -> a pending handle key series committed once by the strip deselect
  - a refused typed value: the panel closes (two tests: strip deselect, tap deselect) -> removed: no field outside the dialog; the dialog's draft writes nothing before « Enregistrer » (new dialog tests)
  - not offered while a replace tracing runs: panel's Désélectionner absent -> strip offers neither « Désélectionner » nor « Propriétés » during the tracing
  - tap: isDeselected read `annotation-properties` -> strip « Propriétés » absent; link select -> strip title data-selection
  - tap: undo after tap deselect (typed name) -> handle series; typed value committed on blur -> handle series committed on blur
  - strip geometry issues: list read in the panel -> list read in the properties dialog's issues block
  - a new commit replaces the message (typed name) -> « Marquer comme relu » in the dialog
  editor-escape.test.tsx:
  - `panel()` = `annotation-properties` -> the strip's « Propriétés » or the phone twin's inline read body
  - Escape from a panel button (« Marquer comme relu ») -> from the selected row in the side column: focus on the row
  - after A then B from the panel (via « Toutes les annotations ») -> select A, select B, Escape from a button of the side column: focus on B's row
  - a text field (panel « Nom (FR) ») -> the overview « Filtrer par nom »
  - redraw via the panel's « Remplacer par un polygone » -> the strip's command
  - modal / delete dialog opened by the panel's « Supprimer » -> « Supprimer » of the properties dialog
  - read-only width: hidden `annotation-properties` -> hidden strip « Propriétés » of the kept edit body
  editor-history-buttons.test.tsx (typed text and the press, 8 tests): the annotation's committed « Nom (FR) » field of the panel -> the sheet's committed « Nom (FR) » on Général (same TextField commit-on-blur path; annotation fields are now a dialog draft)
  editor-focus-request.test.tsx: « Aller à » focuses `data-properties-heading` inside `annotation-properties` -> focuses the annotation's row, marked aria-current, no dialog (R-5)
  editor-sections.test.tsx: « Aller à » with nothing in progress focused the properties heading -> focuses the row (R-5); creation kept: no `annotation-properties` -> no strip « Propriétés »
  editor-overview.test.tsx (edit and read-only): row opens `annotation-properties`, « Toutes les annotations » returns -> row selects, stays marked aria-current, no dialog; strip « Désélectionner » returns focus to the row; filter kept across select and « Désélectionner »
  editor-citations-guards.test.tsx: LAYERS_TOP_DOWN gains 'annotation' at the bottom
  editor-keep-alive.test.tsx: `annotation-properties` visible after the round trip -> the strip's « Propriétés » visible (selection kept)
  editor-no-loss.test.tsx: ids `ro-annotation-name-fr` and `annotation-name-fr` (both panels' fields) -> the twin's inline read body (no ids), then the dialog edit form's `annotation-edit-fr`, kept through a flip to 800 px, no duplicate id; « Aller à » visible `annotation-properties` -> visible `annotation-read` (inline twin), none at 1 280
  editor-point-edit.test.tsx / editor-zone-edit.test.tsx: `select()` waited for `annotation-properties` and returned it -> waits for the strip's « Propriétés » and returns the strip (its « Désélectionner » and « Remplacer par un polygone » moved there)
  - move mode Escape: `annotation-properties` still there -> the strip's « Propriétés » back after the mode
  - « Toutes les annotations » asks first during a started move -> Enter on the selected row asks first (no dialog), and the strip offers neither « Propriétés » nor « Désélectionner » during the mode
  - Escape from the handle / slider: `annotation-properties` gone -> the strip's « Propriétés » gone
  - I-3 touch tap: `annotation-properties` gone -> the strip's « Propriétés » gone
  e2e (sandbox):
  - support/layout.ts: `aside-content` exemption removed (ShiftExemption type, the loose compare); every `swaps`/`SWAPS` argument removed (editor-annotations, editor-zones, editor-geometry)
  - support/editor.ts pickAnnotation: clicked « Toutes les annotations » first when the panel showed -> the overview is always shown: clicks the row, then scrolls back to the top (the page no longer shortens)
  - editor-annotations: `annotation-properties` visible after a creation -> strip with « Propriétés »; review toggle and « Supprimer » of the panel -> the properties dialog's; a jitter click on the selected point now opens the dialog (A1), closed by Escape before the drag; handle names exact (the marked row shares the prefix); trace close moved out of expectNoShift (creation panel until Task 7, shortcut + TODO)
  - editor-deselect: `annotation-properties` -> the strip with « Propriétés » or the twin's inline read body; Escape in a field: panel « Nom (FR) » -> overview filter; delete dialog from the panel -> from the properties dialog (Escape closes it, then the dialog); « a typed value is applied by the click that deselects » (name field, refused blank) -> a pending point-handle key series applied by the deselecting click and by « Désélectionner » (refused value: no field outside the dialog); « the selected one stays » -> a second click, double click and jitter open the dialog, Escape closes it, selection kept
  - editor-geometry: `annotation-geometry-issues` in the panel -> read in the properties dialog, then the strip notice; after the refusal the error count unchanged; scroll-to-top workaround removed
  - editor-zones: panel « Désélectionner » -> strip; scroll-to-top after pickAnnotation removed (helper does it)
  - editor-structures: panel « Supprimer » -> properties dialog « Supprimer », confirmation over it
  - editor-journey: `#annotation-name-fr` committed field + `#annotation-laterality` -> the dialog's edit form, one « Enregistrer »; scroll-to-top removed
  - editor-shell / editor-shell-journeys: « Aller à » focus on `data-properties-heading` -> the annotation's row (aria-current), no dialog (R-5)
  - editor-shell-layout: focus kind `annotation-properties` -> removed (the overview is the side)
2026-11-17 22:01:57 +01:00
bchanot e596e0765e fix(editor): no lost series, tap click absorbed, focus kept on handles
Task 5 review fix round 1.
- I-1: Insert and Delete on a vertex commit pending arrow steps first,
  then act on the stored polygon (read from the store, not the render).
- I-2: deselect commits a handle's pending series before the handle
  unmounts (commitFocusedSeries, no reliance on blur at removal).
- I-3: a touch or pen tap absorbs the click the browser synthesises at
  its place, once, within 400 ms and 8 px; mouse and later clicks pass.
  Scroll anchoring is off while the editor shows: the deselect's panel
  swap scrolled the drawing under the finger. editor-deselect step c is
  back at the page's end, and asserts the drawing does not move.
- I-4, M-2: the double-click and undo tests press what is there now;
  a hand-set stale chosen vertex removes nothing.
- I-5: editor-zones undos, the vertex choice and the refused-trace
  clicks run under expectNoShift; new e2e for I-2.
- M-1: Delete on the last vertex and Enter on « − » keep the focus on a
  vertex (the next one is chosen).
- M-4: the strip notice comment names R-18. M-5: the tracing carries a
  `refused` flag; only a refused close titles « Fermeture refusée ».
- M-7: TODO lines (bubble size shortcut, scroll-padding-top, scroll
  clamp at the page's end).

Rewritten assertions: zone-edit « − » double click and undo-then-« − »
pressed the detached bubble -> press the live bubble or the box at the
same place. editor-deselect step c: scroll-to-top removed, drawing y
asserted unchanged. editor-geometry: scroll-to-top kept with the clamp
named (reported, TODO). editor-zones and editor-journey: comment says
the scroll-to-top undoes Playwright's own auto-scroll.
2026-11-17 21:04:23 +01:00
bchanot 56c75b12ef docs(docs): U2 plan rev 3 with owner answers, implementation contract, BDR-123 2026-11-17 16:24:26 +01:00
bchanot 8c5a8871e5 docs(docs): U2 plan rev 2 final pass, D2 added 2026-11-17 16:16:07 +01:00
bchanot 31d0c415ec docs(docs): U2 technical plan rev 2 after three challenges, D1 open 2026-11-17 16:10:55 +01:00
bchanot 6de5e56e33 docs(docs): U2 technical plan rev 1 2026-11-17 15:46:08 +01:00
bchanot 29073a956b docs(docs): U2 boards and A1-A15 validated by owner, three adjustments, BDR-122 2026-11-17 15:34:46 +01:00
bchanot 272a7b54e4 docs(docs): U2 boards re-check fixes, A15, notes aligned, owner gate 2026-11-17 13:26:33 +01:00
bchanot bc19481b93 docs(docs): V1-2.6 U2 boards 02-06, 13, 31-33, review and arbitrations 2026-11-17 12:54:12 +01:00
bchanot c42c65509b docs(docs): R4 closed by owner validation 2026-11-17, BDR-121 2026-11-17 12:29:09 +01:00
bchanot b6408f177f docs(docs): R4 verifier passes recorded, owner trial pending 2026-11-17 01:33:26 +01:00
bchanot fbf5a0e096 docs(docs): R4 check:all and verifier-gap tests recorded 2026-11-17 01:25:43 +01:00
bchanot 2c9d837e7b docs(docs): R4 contract evidence lines, criterion 9 oracle, scope rulings 2026-11-17 01:18:32 +01:00
bchanot 04b723cc54 chore(docs): R4 final fix wave recorded, check:all pending 2026-11-17 01:07:11 +01:00
bchanot 4a7919c763 chore(docs): R4 Tasks 1 to 3 done, census recorded, gates pending 2026-11-17 00:31:53 +01:00
bchanot 7575c67c47 docs(docs): R4 plan rev 3 validated, contract 2026-11-17 00:05:15 +01:00
bchanot b895ecf136 docs(docs): R4 card integrity plan rev 2, owner decisions pending 2026-11-16 23:47:51 +01:00
bchanot dc67c4aaca docs(docs): R3 closed by owner validation 2026-11-16, BDR-120 2026-11-16 23:34:34 +01:00
bchanot 5774d52144 docs(docs): R3 phone filters review rounds and check:all recorded 2026-11-16 20:55:10 +01:00
bchanot ca701787ce docs(docs): owner message verbatim, happy-dom, trial step 10 wording 2026-11-16 20:39:01 +01:00
bchanot c25a994c0e docs(docs): R3 phone filters, trial step 4.15, verifier gap closed 2026-11-16 20:33:15 +01:00
bchanot 5014a45053 chore(docs): R3 verifier and check:all results recorded 2026-11-16 18:21:17 +01:00
bchanot a8ab6689e8 chore(docs): R3 contract verification result recorded 2026-11-16 18:19:54 +01:00
bchanot bcdacbbb9a docs(app): R3 gate results, fix wave run, deploy order, trial steps
- CHANGELOG: the six shell failures split into the four Target crashed
  of BLK-015 and the two A0 lookup timeouts (counted as BLK-015, not A/B
  proven); pgTAP 014 / 021 not proven by a run without M9; the intro
  names the R3 entry's branch
- owner trial 4.15: steps strictly in order (step 5 shows what two
  sheets prove, the move back to the top is step 9's last action), how
  to open the working copy, the trimmed text, no Claude sentence, the
  re-save sentence removed
- deploy order (database first, then the application) and its
  fail-closed consequence in the SQL checkpoint and SUPABASE.md
- design review, code review and security gate results, the fix wave
  run, the owner decisions left open; verifier, check:all and the owner
  trial still pending
- TODO: fix wave line, three follow-ups
2026-11-16 18:11:12 +01:00
bchanot 72ec758278 chore(docs): R3 Task 8 documents done, gates pending, shortcuts harvested 2026-11-16 17:48:07 +01:00
bchanot 73ed37546f chore(docs): R3 contract from the owner's three messages 2026-11-16 17:40:08 +01:00
bchanot 1adb19b479 chore(docs): R3 Task 7 done, sweep results recorded 2026-11-16 17:38:52 +01:00
bchanot 2326e1cb15 chore(docs): R3 Task 6 done 2026-11-16 17:18:20 +01:00
bchanot 856667d070 chore(docs): R3 Task 5 done 2026-11-16 17:05:37 +01:00
bchanot a950e403c2 chore(docs): R3 Task 4 done 2026-11-16 16:46:22 +01:00
bchanot d5852f5f8e chore(docs): R3 Task 3 done 2026-11-16 15:48:50 +01:00
bchanot f5e92dc5a9 chore(docs): R3 Task 2 done, db:trial migrated to M9, pgTAP 014/021 kept open 2026-11-16 15:44:42 +01:00