chore(docs): R4 Tasks 1 to 3 done, census recorded, gates pending

This commit is contained in:
bchanot committed 2026-11-17 00:31:53 +01:00
1 parent e1cdd9d25c
commit 4a7919c763
1 file changed
+12 -3
+12 -3
View File
@@ -733,11 +733,20 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
- [x] (was) Anomaly B (owner 2026-11-12, decision C): `admin.spec.ts` « admin screens: axe and no sideways scroll » (4 failures: 2 locales × 2 viewports) depends on the historical sheet's free working-copy slot, taken on the sandbox by `sheets-admin.sandbox.ts:181-195` (copy `8c315a12-…`, never archived). Fix in its own commit with proof the 4 failures are gone; isolated reproducible fixture, no existing data deleted; stop and present options if impossible without a destructive op or a scope change
- [x] R3 sheet list: search + name sort first; date, date sort and « most recent » home card only after the dedicated SQL checkpoint `docs/development/V1-2-6_R3_SQL_CHECKPOINT.md` (A7 ratified 2026-11-09; never a creation date shown as modification date). Two-step split superseded 2026-11-16 by owner D2: one lot after M9, tracked in the R3 block above
- [ ] R4 catalogue card integrity warning (independent fix, = anomaly C): `useCardDetails.ts` drops a failed `loadVersion` silently; UI only, check never bypassed
- [ ] R4 plan rev 2 (owner brief 2026-11-16 « R3 est terminé … passer à R4 »): `.claude/tasks/plans/2026-11-16-r4-card-integrity-2337.md`, audit F1-F12, three challenges on rev 1 (correctness FATAL(4), robustness FATAL(4), simplicity FATAL(3)) folded in. STOP: owner decisions D1 caps class, D2 thumbnail failure, D3 trial place (sandbox recommended, trial stack has no published version), D4 e2e cleanup of published fixtures (archive own rows by SQL recommended). No implementation before them; DEV unchanged, no merge
- [x] R4 plan rev 2 (owner brief 2026-11-16 « R3 est terminé … passer à R4 »): `.claude/tasks/plans/2026-11-16-r4-card-integrity-2337.md`, audit F1-F12, three challenges on rev 1 (correctness FATAL(4), robustness FATAL(4), simplicity FATAL(3)) folded in. STOP: owner decisions D1 caps class, D2 thumbnail failure, D3 trial place (sandbox recommended, trial stack has no published version), D4 e2e cleanup of published fixtures (archive own rows by SQL recommended). No implementation before them; DEV unchanged, no merge
- [x] R4 plan rev 3 VALIDATED 2026-11-17 (owner « Je valide le plan R4 … »: D1 alternative, own caps line without retry; D2, D3, D4 as recommended; R-2 to R-7 accepted; P1 trial tells sandbox anomalies apart, P2 spec cleans only its own rows). Contract `.claude/tasks/contracts/2026-11-17-r4-card-integrity-0004.md` (7575c67). Branch feature/v1-2-anatomical-sheets, no merge, DEV unchanged, no write on db:trial
- [x] Task 1 card failure line (board 30): f061111 Notice warning tone, `icon`, `live` + `wifi-off`; 6ad8d83 `cardFailure`, `useCardDetails` `{ state, retry }`, `CardFailure`, A10 key; `Card` `aria-busy` (outside file list, accepted). App 1771 tests in 138 files; typecheck, lint, build exit 0. Review approved (0 C, 0 I)
- [x] Task 2 browser proof dadd8e5: `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky (twice); `catalogue.spec.ts` alone 8 passed. Guard: 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants); 8 R4 sheets archived, 4 grants revoked by id, read back. Review approved (0 C, 0 I)
- [x] Task 3 documents as built: U1_CORRECTIONS §R4 « As built 2026-11-17 » and §5 row C closed, OWNER_TRIAL §4.16 (db:sandbox trial), review Part II class C row (R-8), CHANGELOG, BROWSER_TESTS, design README deviation. Read-only sandbox census: 164 catalogue entries, 160 ok and main view composed, 4 `fingerprint_mismatch` = the four « Cheval sandbox » (anomaly A, stored `'a'.repeat(64)`), no other kind. No `shortcut:` in the R4 diff (`git diff b895ecf..HEAD`)
- [ ] Closing gates (controller): design review vs board 30, final code review, security review, fresh verifier on the contract, `pnpm check:all` (not yet run)
- [ ] Owner trial §4.16 on `pnpm db:sandbox trial`
- [ ] Known deviation from board 30 (pending design review): desktop network card stacks « Réessayer » above « Consulter »; board draws them side by side
- [ ] Follow-up (final wave, parked minors): retry guard via ref or functional update (double bump in one tick); three lines over 100 columns (`failure.ts` doc, `Notice` signature); rendered tests for engine stopped, two cards failing on the core, no `createObjectURL` after unmount; spec checks own row name and tag before archive
- [ ] Follow-up: seed owner row in `private.catalog_write_budgets` grows 2 per project per run (8 of 300 per hour after R4 runs, outside the data guard); `catalogue.spec.ts` still leaves its published sheets listed, warm-up its sheet and `sheet_editor` grant per invocation (BLK-015, RR-13)
- [ ] owner arbitrations A1-A15 (`V1-2-6_U1_CORRECTIONS.md` §6, `TRIAL_STACK.md` §6)
- [ ] Test anomaly A (owner 2026-11-09, separate from U1/U2): fictitious fingerprints `'a'.repeat(64)` from worker stand-ins (`packages/supabase/tests/sandbox/sheet-fixtures.ts:115` openRound, `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`); 7 published/deprecated sandbox versions fail `check_published`. Fix: real fingerprint through the core (as e2e `fingerprintOf`, `apps/app/e2e/support/catalogue.ts:88`); never weaken the publish gate or the reader check. Needs its own go.
- [ ] Test anomaly A (owner 2026-11-09, separate from U1/U2): fictitious fingerprints `'a'.repeat(64)` from worker stand-ins (`packages/supabase/tests/sandbox/sheet-fixtures.ts:115` openRound, `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`); 7 published/deprecated sandbox versions fail `check_published`. Fix: real fingerprint through the core (as e2e `fingerprintOf`, `apps/app/e2e/support/catalogue.ts:88`); never weaken the publish gate or the reader check. Needs its own go. Census 2026-11-17 (R4 Task 3, read-only): 4 of 164 catalogue entries fail, the four current « Cheval sandbox » versions (2 at v1, 2 at v2), all `fingerprint_mismatch`; R4 cards show them with the integrity line.
- [ ] Test anomaly B (owner 2026-11-09, separate from U1/U2): `packages/supabase/tests/sandbox/sheets-admin.sandbox.ts:181-195` creates the historical working copy and never archives it; slot taken → `admin.spec.ts:717` fails x4. Fix test independence and cleanup; the existing copy `8c315a12-20d4-4432-9db3-7cb88b27a5b4` stays untouched until the owner authorises. Linked: RR-13, the admin.spec confirmation line above.
- [ ] Test anomaly C (owner 2026-11-09, separate from U1/U2): integrity failure invisible in catalogue cards; implemented as lot R4; failure shown, never hidden or bypassed.
- [ ] Test anomaly C (owner 2026-11-09, separate from U1/U2): integrity failure invisible in catalogue cards; implemented as lot R4; failure shown, never hidden or bypassed. Built 2026-11-17 (R4 Task 1-3, `V1-2-6_U1_CORRECTIONS.md` §5 row C closed by R4); checked off with R4's owner validation.
- [ ] Dedicated persistent manual trial stack (owner 2026-11-09, D8; brief « Après R0 — Implémentation technique », contract .claude/tasks/contracts/2026-11-09-db-trial-stack-1809.md): [x] lot A suites' guard · [x] lot A2 trial dev server target (R13) · [x] lot B1 foundation · [x] lot B2 backups, restore, migrate, rotation · [x] lot B3 accounts, grants, drawings, app · [x] lot C docs · [x] reviews (verifier ECARTS owner-gated only, security PASS, code review + 2 re-reviews fixed: d3bdbbe, f2cbf68) · [x] first create 2026-11-11 at 255dd67 (owner go) · [x] post-create checks: interrupted at check 3 (TR_PW in the db container log), owner decided 2026-11-11 (rotation + fix, sub-item below) · [x] accounts 2026-11-11 (owner brief « Checkpoint sécurité et autorisation des comptes »): owner@trial.local owner+admin, praticien@trial.local admin+sheet_editor, 1 verified TOTP each (BDR-112), roles/rights/audit/aal2 refusals/secrets/persistence checked · [x] equine drawing 2026-11-11 (owner brief « Autorisation de l'import équin »): `pnpm db:trial assets`, 1/1 uploaded and confirmed, object re-downloaded through the gateway byte-identical, second read-only pass nothing to do, draft = document.json, seed = HEAD · [x] owner U1 manual test 2026-11-12 (brief « Retour du test manuel U1 »): equine working copy, four tabs, annotation select and edit, saves kept after reload, undo/redo, historical sheet unchanged; one defect → R1 D6b · [ ] owner Droits screen at aal2 not reported
- app exposure (owner 2026-11-11, BDR-111): `pnpm db:trial app` listens on 192.168.1.100:5194 only (not 0.0.0.0; Host allowlist answers 403 to other names; 127.0.0.1:5194 closed). The accounts brief authorised 127.0.0.1:5194; the owner moved it to the LAN address the same day. No wider LAN exposure (other port, 0.0.0.0, firewall change) without a distinct decision.
- shortcut: `pnpm db:trial app` takes no lock (scripts/db-trial.sh, comment above cmd_app): stop, backup, migrate, destroy, restore or rotate-* started in another terminal in the second before Vite listens on 5194 goes ahead. Upgrade: a dedicated app lock, shared by app and exclusive for those commands.