docs(app): R3 gate results, fix wave run, deploy order, trial steps
- CHANGELOG: the six shell failures split into the four Target crashed of BLK-015 and the two A0 lookup timeouts (counted as BLK-015, not A/B proven); pgTAP 014 / 021 not proven by a run without M9; the intro names the R3 entry's branch - owner trial 4.15: steps strictly in order (step 5 shows what two sheets prove, the move back to the top is step 9's last action), how to open the working copy, the trimmed text, no Claude sentence, the re-save sentence removed - deploy order (database first, then the application) and its fail-closed consequence in the SQL checkpoint and SUPABASE.md - design review, code review and security gate results, the fix wave run, the owner decisions left open; verifier, check:all and the owner trial still pending - TODO: fix wave line, three follow-ups
This commit is contained in:
1 parent
ea5512af02
commit
bcdacbbb9a
8 files changed
+125
-34
No files matched your search
@@ -716,7 +716,11 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- [x] Task 5 list page (board 28, 29 A) (423125c, reviewed; app 1736, build ok)
|
||||
- [x] Task 6 home card (board 29 B) (de2424f, reviewed; app 1743, build ok)
|
||||
- [x] Task 7 shell spec admin-sheets-list + three locators (b4a5254, reviewed). Spec alone 4 passed. Sweep 27 files without editor-equine: 277 passed, 6 failed, 163 skipped, 0 flaky; failures all `admin.spec.ts` on the rights screen (BLK-015): « admin screens » :714 ×4 « Target crashed », A0 :220 ×2 lookup timeout at :144 (other symptom, about 7 600 grants; not A/B proven against pre-R3). A1, « access per right », editor-journey green. Guard: 0 pre-existing row changed; 12 R3 sheets soft-deleted
|
||||
- [ ] Task 8 docs, closing gates, owner trial on db:trial: [x] documents as built (a86020d: U1_CORRECTIONS §R3, SQL checkpoint §6-§7 with F2-F4 corrections and F7 limits, V1-2 §12.3 M9, SUPABASE §5.1, BROWSER_TESTS, Rust Part II class C rows, design README deviations, CLAUDE.md, CHANGELOG) · [x] owner trial text §4.15 in French (b9e5d32) · [ ] closing gates (verifier, security, design review, code review), pending 2026-11-16 · [ ] `pnpm check:all`, pending · [ ] STOP owner trial on db:trial, no merge. Deviations for the owner: no magnifier (F14, validated); no info icon in the board 28 no-result block (ruling, to confirm)
|
||||
- [ ] Task 8 docs, closing gates, owner trial on db:trial: [x] documents as built (a86020d: U1_CORRECTIONS §R3, SQL checkpoint §6-§7 with F2-F4 corrections and F7 limits, V1-2 §12.3 M9, SUPABASE §5.1, BROWSER_TESTS, Rust Part II class C rows, design README deviations, CLAUDE.md, CHANGELOG) · [x] owner trial text §4.15 in French (b9e5d32) · [x] closing gates design review (28 CONFORME, 29 A and 29 B ÉCARTS, findings 1-4 fixed in the wave), code review (0 C, 0 I, 9 Minor: 1-7 fixed, 9 done at Task 8, 8 left), security PASS (4 non-blocking: spec SQL, date refine, RegExp escape fixed; db-sandbox.sh:485 false positive left) · [ ] verifier on the contract, pending 2026-11-16 · [ ] `pnpm check:all`, pending · [ ] STOP owner trial on db:trial, no merge. Deviations for the owner: no magnifier (F14, validated); no info icon in the board 28 no-result block (ruling, to confirm)
|
||||
- [x] Final fix wave 2026-11-16 (`374e300` client refuses an unreadable date, test first; `1758276` list hooks split, rows memoised, className constants, phone clear button; `8bb2486` home cards as board 29 B, 44 px name links, row rhythm; `ea5512a` spec: `literal()` + uuid shape, UTC, one `<time>` per item, escaped pattern, Escape; docs commit after). Units core-wasm 66, supabase 182, app 1743; build ok. One run of admin-sheets-list + admin + editor-journey: 15 passed, 6 failed, 9 skipped, all six `admin.spec.ts` BLK-015 class (admin screens ×3 Target crashed + ×1 timeout during axe at :747; A0 fr :144, A0 en :158 « Granting… »), not A/B proven; guard 0 changed 0 missing 20 new; 6 R3 sheets deleted. Owner decisions open: U1_CORRECTIONS §R3 list (info icon, « Nouvelle fiche » at 375, breadcrumb, filter + search no result, double announcement)
|
||||
- [ ] Follow-up (security gate, outside R3's diff): guardrails scanner 2 FAIL at `scripts/db-trial-check.sh:1340`, pre-existing, not analysed
|
||||
- [ ] Follow-up: WebKit parsing of six fraction digits in `new Date(iso)` not verified (Chromium only until V1-5)
|
||||
- [ ] Follow-up: the R3 spec adds 2 accounts and 2 `sheet_editor` grants per run, feeding BLK-015's accumulation (RR-13)
|
||||
- shortcut: `apps/app/src/admin/sheetList.ts` search and sort run in the browser on the whole loaded list. Limit: the whole list loaded in one unbounded read, then filtered and sorted in the browser at each keystroke. Upgrade path: they move to the server with the admin list paging, RR-13 (widened per D4)
|
||||
- shortcut: the search field in `AdminSheetsRoute.tsx` repeats `ReferenceToolbar`'s search markup (R2, closed). Limit: two copies of one field. Upgrade path: fold both onto one shared search component when the editor is next opened
|
||||
- [ ] Follow-up, NOT R3 (owner D5 2026-11-16): keep the admin sheet list's search, sort and filters when coming back from a sheet; joins the app-wide « search not kept on back » follow-up (BDR-079); BDR-116 rejected address parameters for view state; later navigation improvement, own go
|
||||
|
||||
+4
-2
@@ -8,7 +8,9 @@ Versions follow [Semantic Versioning](https://semver.org/).
|
||||
|
||||
Nothing in this section is released or deployed: faunosteo.com runs 0.1.0.
|
||||
Everything below is on `develop` only, accumulated since 0.1.0: the SaaS
|
||||
Steps 0 to 8 and the Rust migration R0 to R5 included. `release/0.2.0` (Steps
|
||||
Steps 0 to 8 and the Rust migration R0 to R5 included. One exception: the
|
||||
first entry (V1-2.6 R3) lives on `feature/v1-2-anatomical-sheets`, not merged
|
||||
into `develop`. `release/0.2.0` (Steps
|
||||
3 to 6) was cut on 2026-10-11 and never finished; its `[0.2.0]` section lives
|
||||
on that branch and reaches this file only if the release is finished (TODO
|
||||
RR-9).
|
||||
@@ -18,7 +20,7 @@ RR-9).
|
||||
- The official sheet list (`/app/admin/sheets`) gets a search on the sheet name in French or English (accents and case ignored, instant, with « Effacer la recherche » and Escape), a « Trier par » with « Dernière modification » (default) or « Nom », a count line « {n} fiches » / « {n} fiches sur {total} », and « Modifiée le 9 nov. 2026, 12:06 » on each row, in Paris time. The four filters are unchanged and combine with the search; a search without result names the searched text with a clear button. The Administration home card lists the five most recently modified sheets under « Dernières modifications », with « Voir les {n} fiches ».
|
||||
- Migration M9 `20261116100000_sheet_admin_last_modified.sql`: the admin sheet summary answers `last_modified_at`, the newest of the sheet's and its versions' `updated_at`, so a draft save dates its sheet. Read change only; the typed client refuses an answer without a valid `last_modified_at` (`unavailable`). Applied to the sandbox and the trial stack, not to DEV.
|
||||
- `pnpm db:sandbox migrate`: the branch's pending migrations on the running sandbox, forward only, no reset.
|
||||
- Known open results, not green: pgTAP on the accumulated sandbox (`014_animals_relations` 2 of 258 failed, `021_sheet_verification_jobs` 23 failed with « Bad plan. You planned 90 tests but ran 42 »), and the shell sweep (277 passed, 6 failed, 163 skipped; the six in `admin.spec.ts` on the rights screen, BLK-015). Details: `docs/development/V1-2-6_U1_CORRECTIONS.md` §R3.
|
||||
- Known open results, not green: pgTAP on the accumulated sandbox (`014_animals_relations` 2 of 258 failed, `021_sheet_verification_jobs` 23 failed with « Bad plan. You planned 90 tests but ran 42 »), read as dependent on the accumulated sandbox state, not proven by a run without M9; and the shell sweep (277 passed, 6 failed, 163 skipped, all six in `admin.spec.ts`). Four are the « admin screens » test with the known `Target crashed` of BLK-015. Two are A0, a lookup timeout on the rights screen, counted as BLK-015 with another symptom and not proven by an A/B run against the pre-R3 commit. Details: `docs/development/V1-2-6_U1_CORRECTIONS.md` §R3.
|
||||
|
||||
### Fixed (2026-10-27, V1-1 DEV acceptance, RESP-01)
|
||||
|
||||
|
||||
+11
-2
@@ -197,5 +197,14 @@ board 28 literally, the card's « Dernières modifications » with at most five
|
||||
no new icon); the block follows the editor's validated no-result block. A ruling made during the build, to be
|
||||
confirmed by the owner.
|
||||
Below two sheets the card's link reads « Toutes les fiches officielles » instead of « Voir les {n} fiches » (owner
|
||||
decision D6, 2026-11-16). The design review of the two screens against boards 28 and 29 at 1 280 and 375 px is pending
|
||||
at the time of writing (2026-11-16).
|
||||
decision D6, 2026-11-16). Design review of the two screens against boards 28 and 29 at 1 280 and 375 px (fresh,
|
||||
2026-11-16): board 28 CONFORME (the two deviations above only); board 29 A ÉCARTS (2 small); board 29 B ÉCARTS.
|
||||
Findings 1 to 4 fixed in the final fix wave: the home's « Espèces » and « Accès et habilitations » stacked in the right
|
||||
column at their own height beside the sheets card (`8bb2486`), the card's sheet name links 44 px tall at 375 px
|
||||
(`8bb2486`), « Effacer la recherche » of the no-result block 44 px tall at 375 px (`1758276`), the card item on the
|
||||
list row's rhythm (`8bb2486`). Left to the owner (`docs/development/V1-2-6_U1_CORRECTIONS.md` §R3): finding 5, at
|
||||
375 px « Nouvelle fiche » beside the title where board 29 A draws it under (header older than R3); the top-bar
|
||||
breadcrumb « Administration › Fiches officielles » the boards draw (shell level, older than R3); the info icon above.
|
||||
Finding 6 (an opening guillemet can end a line, « version / 1 » orphan in the detail line) is not in the wave. Not
|
||||
checked by the review: the card's badges and working copy action, the owner's layout (deduced from the code), the
|
||||
English wording, the 0 or 1 sheet link, distinct dates, hover, screen reader output.
|
||||
@@ -116,20 +116,32 @@ the others. A sweep adds two accounts and two catalogue grants to the sandbox (B
|
||||
sheet listed. `allSheetsLink(scope, dict)` (`e2e/support/admin.ts`) finds the sheets card's link by
|
||||
`admin.home.all_sheets` or by `admin.home.see_all` with any number; the three earlier locators of that link (A1 and
|
||||
« access per right » in `admin.spec.ts`, `createSheetFromAdmin` in `editor-journey.spec.ts`) use it, their assertions
|
||||
unchanged. Known gaps, left for the final fix wave: the hour and minute are compared with a Paris clock, but the shell
|
||||
config sets no `timezoneId`, so a regression to local time would pass on a host already in Europe/Paris; the home's
|
||||
ordering loop would pass with no `<time>` at all (its count is not compared with the items'); the date pattern is
|
||||
built from dictionary text without escaping.
|
||||
unchanged. Closed by the final fix wave (`ea5512a`): the spec runs with `timezoneId: 'UTC'`, so a regression to
|
||||
local time fails on any host; the home's ordering loop first asserts one `<time>` per item; the date pattern escapes
|
||||
the dictionary text (`escaped`, exported by `e2e/support/admin.ts`); the long-search check types the text again and
|
||||
presses Escape (field empty and focused, count back); every value of the three fixture statements goes through
|
||||
`literal()` (`e2e/support/records.ts`), the ids refused unless they have the uuid shape.
|
||||
|
||||
Results on 2026-11-16 (code at `b4a5254`): the spec alone, 4 passed, 0 failed. The sweep of 27 spec files without
|
||||
`editor-equine.spec.ts`, 446 tests: 277 passed, 6 failed, 163 skipped, 0 flaky. The six failures, named: « admin
|
||||
screens » (`admin.spec.ts:714`) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed` during axe on
|
||||
the rights screen; A0 « the rights screen with grants » (`admin.spec.ts:220`) ×2, fr and en at desktop, the grant
|
||||
screens » (`admin.spec.ts:714`) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed` during axe at
|
||||
`admin.spec.ts:747`, inside that test's loop over the admin pages (the page is not recorded in this run; BLK-015's
|
||||
description below names the rights screen as the proven cause in earlier runs); A0 « the rights screen with grants » (`admin.spec.ts:220`) ×2, fr and en at desktop, the grant
|
||||
lookup stuck on « Recherche… » until the « E-mail confirmé » check timed out at `:144`, about 7 600 grant rows
|
||||
rendered. All six are counted as BLK-015, the A0 pair with another symptom than « Target crashed »; NOT proven by an
|
||||
A/B run against the commit before R3. Green as required: A1 and « access per right » in both languages,
|
||||
`editor-journey`, the new spec. The data guard found 0 pre-existing sheet or version row changed or missing.
|
||||
|
||||
Final fix wave run (2026-11-16, code at `ea5512a`), one run of `admin-sheets-list.spec.ts`, `admin.spec.ts` and
|
||||
`editor-journey.spec.ts`: 15 passed, 6 failed, 9 skipped. The new spec 4 passed; A1 and « access per right » in both
|
||||
languages and `editor-journey` passed. The six failures, all `admin.spec.ts`: « admin screens » (`:714`) fr desktop,
|
||||
en desktop and fr 375 px, `frame.evaluate: Target crashed` during axe at `:747`; « admin screens » en 375 px,
|
||||
`page.evaluate: Test timeout of 180000ms exceeded` during axe at `:747`, the failure screenshot on the rights screen;
|
||||
A0 (`:220`) fr, the « E-mail confirmé » check at `:144`; A0 en, the « Right granted. » check at `:158`, the submit
|
||||
button stuck on « Granting… ». Counted as BLK-015 (the timeout and the `:158` step being further symptoms), not proven
|
||||
by an A/B run against the commit before R3. Data guard: 0 changed, 0 missing, 20 new lines (10 sheets and their 10
|
||||
versions); the 6 sheets of the R3 spec read back `deleted`.
|
||||
|
||||
Layout additions in `e2e/shell/editor-shell-layout.spec.ts`: five tabs everywhere the four were checked (no
|
||||
sideways scroll from 1 024 to 1 280 px, axe from the top, read-only at 320, 375 and 768 px); the open panel at most
|
||||
34 rem and never wider than the viewport, the document size unchanged before, during and after; the canvas width
|
||||
|
||||
@@ -752,6 +752,14 @@ checked. Two anomalies:
|
||||
`pnpm db:reset && pnpm db:test` on the real stack.
|
||||
5. `pnpm db:types` and commit `packages/supabase/src/database.types.ts`.
|
||||
6. Never edit an applied migration. Corrections are new migrations.
|
||||
7. Deploy order: the database first, then the application, whenever the typed
|
||||
client starts requiring what a migration adds. M9
|
||||
(`20261116100000_sheet_admin_last_modified.sql`, V1-2.6 R3) is such a case:
|
||||
an application at the R3 head against a database without M9 answers
|
||||
« indisponible » on the admin sheet screens and on the editor's admin reads
|
||||
(fail closed, by the client's check of `last_modified_at`); an older
|
||||
application against a migrated database is unaffected (it ignores the key).
|
||||
Details: `V1-2-6_R3_SQL_CHECKPOINT.md` §8.
|
||||
|
||||
Rules enforced by the schema-types test for every future `public` table:
|
||||
RLS enabled, no `using (true)` / `with check (true)` policy for `anon` or
|
||||
|
||||
@@ -511,7 +511,7 @@ le navigateur est fermé brutalement, comme tout formulaire non enregistré (lim
|
||||
À faire sur la pile d'essai (`db:trial`), dans l'application d'essai `http://<host>:5194`, avec le compte praticien
|
||||
d'essai (rôle `admin` et habilitation `sheet_editor`), double authentification faite. Libellés :
|
||||
`docs/design/v1-2-6-r0/REVUE.md:82-84`. Les étapes 1 à 9 se font à 1 280 px, l'étape 10 sur un téléphone ou dans une
|
||||
fenêtre de 375 px. Rien dans ce parcours n'est lancé par Claude. Chaque étape donne l'action, puis l'attendu.
|
||||
fenêtre de 375 px. Chaque étape donne l'action, puis l'attendu.
|
||||
|
||||
La pile d'essai contient aujourd'hui deux fiches officielles : la fiche historique `faunosteo-cheval` (badge
|
||||
« Fiche historique ») et sa copie de travail (badge « Copie de travail »). Les étapes 1 à 8 se font avec ces deux
|
||||
@@ -528,8 +528,7 @@ ensuite sur la pile d'essai : c'est à vous de décider si vous les créez.
|
||||
anglais. Attendu : la liste suit chaque frappe, sans bouton à valider ; le nom français et le nom anglais trouvent
|
||||
tous deux la fiche, accents et majuscules ignorés. Le décompte devient « 1 fiche sur 2 » si une seule fiche
|
||||
correspond, et reste « 2 fiches » si les deux correspondent. À sa création, la copie de travail reprend le nom de
|
||||
la fiche historique : si leurs noms sont encore identiques, la recherche les garde toutes les deux, et le
|
||||
décompte « n fiches sur N » se voit à l'étape 9.
|
||||
la fiche historique : si leurs noms sont encore identiques, la recherche les garde toutes les deux.
|
||||
3. Effacer. Action : avec du texte dans le champ, cliquez ✕ (« Effacer la recherche »). Retapez un texte et appuyez
|
||||
sur Échap. Appuyez encore une fois sur Échap, le champ vide. Attendu : ✕ n'apparaît que lorsque le champ contient
|
||||
du texte. ✕ et Échap vident le champ, rendent « 2 fiches » et laissent le focus dans le champ. Échap sur un champ
|
||||
@@ -538,19 +537,18 @@ ensuite sur la pile d'essai : c'est à vous de décider si vous les créez.
|
||||
« Nom » range les fiches dans l'ordre alphabétique du nom affiché, en français dans l'interface française. Deux
|
||||
noms identiques gardent le même ordre d'un affichage à l'autre. « Dernière modification » met en haut la fiche
|
||||
modifiée le plus récemment. Trier ne modifie aucune fiche : les dates ne bougent pas.
|
||||
5. Un brouillon enregistré remonte. Action : ouvrez la copie de travail, « Ouvrir le brouillon », faites une petite
|
||||
modification (par exemple dans « Général ») et « Enregistrer ». Revenez à la liste, triée par « Dernière
|
||||
modification ». Attendu : la copie de travail est en haut, et sa date « Modifiée le … » est l'heure de votre
|
||||
enregistrement, en heure de Paris. Si la copie était déjà en haut à l'étape 1, seule sa date change. Pour voir la
|
||||
remontée, faites d'abord l'étape 9 : les fiches créées passent devant, puis l'enregistrement remet la copie en
|
||||
haut. Une valeur remise à l'identique ensuite est un nouvel enregistrement, qui date de nouveau la copie.
|
||||
5. Un brouillon enregistré date sa fiche. Action : dans la liste, cliquez la rangée de la copie de travail. Sur la
|
||||
page de la fiche, cliquez « Ouvrir le brouillon ». Faites une petite modification (par exemple dans l'onglet
|
||||
« Général ») et cliquez « Enregistrer ». Revenez à la liste, triée par « Dernière modification ». Attendu : la
|
||||
copie de travail est en première position. Sa date « Modifiée le … » est l'heure de votre enregistrement, en
|
||||
heure de Paris.
|
||||
6. Recherche sans résultat. Action : sans filtre, tapez un texte qu'aucun nom ne contient, par exemple « zzz ».
|
||||
Puis collez un long texte sans espace : le champ s'arrête à 100 caractères. Cliquez enfin « Effacer la
|
||||
recherche » sous la phrase. Attendu : la ligne « 0 fiche sur 2 », puis un bloc « Aucune fiche ne contient « zzz »
|
||||
dans son nom. » avec le bouton « Effacer la recherche ». Le texte s'affiche tel que vous l'avez tapé. Un texte
|
||||
long passe à la ligne, sans défilement horizontal. Le bouton vide le champ, rend « 2 fiches » et le focus au
|
||||
champ. La planche 28 dessine une icône d'information dans ce bloc ; elle n'y est pas (écart à confirmer, voir
|
||||
`docs/design/README.md`).
|
||||
dans son nom. » avec le bouton « Effacer la recherche ». Le texte s'affiche sans ses espaces de début et de
|
||||
fin. Un texte long passe à la ligne, sans défilement horizontal. Le bouton vide le champ, rend « 2 fiches » et
|
||||
le focus au champ. La planche 28 dessine une icône d'information dans ce bloc ; elle n'y est pas (écart à
|
||||
confirmer, voir `docs/design/README.md`).
|
||||
7. Recherche et filtre. Action : tapez une partie d'un nom présent, puis choisissez « État de la fiche » :
|
||||
« Archivée ». Remettez « Tous », puis choisissez « Statut de version » : « Brouillon ». Attendu : les filtres
|
||||
s'ajoutent à la recherche. Si aucune fiche trouvée n'est archivée, « Archivée » affiche « Aucune fiche ne
|
||||
@@ -572,7 +570,11 @@ ensuite sur la pile d'essai : c'est à vous de décider si vous les créez.
|
||||
modifiée pendant cet essai), elle sort des cinq : son action « Créer une copie de travail » n'est plus sur la
|
||||
carte et reste sur la page de la fiche historique, que vous ouvrez depuis la liste. C'est le comportement validé
|
||||
(planche 29, arbitrage A9). Le libellé « Toutes les fiches officielles », prévu pour zéro ou une fiche, ne se voit
|
||||
pas sur cette pile, qui en compte au moins deux.
|
||||
pas sur cette pile, qui en compte au moins deux. Dernière action : dans la liste triée par « Dernière
|
||||
modification », les quatre fiches créées sont au-dessus de la copie de travail. Ouvrez de nouveau son brouillon
|
||||
(sa rangée, puis « Ouvrir le brouillon »), faites une autre petite modification et cliquez « Enregistrer ».
|
||||
Revenez à la liste. Attendu : la copie de travail repasse en première position, devant les quatre fiches
|
||||
créées.
|
||||
10. Téléphone (375 px). Action : sur un téléphone, ou dans une fenêtre de 375 px, reprenez les étapes 1 à 4, 6 et
|
||||
8. Attendu : le champ de recherche, « Trier par » puis les quatre filtres sont empilés sur toute la largeur, et
|
||||
chaque contrôle fait au moins 44 px de haut. La date passe sur sa propre ligne, sous la ligne de détail. Aucun
|
||||
|
||||
@@ -145,3 +145,12 @@ the application today.
|
||||
| iv | a future data migration that rewrites drafts | re-dates every such sheet to the deploy time |
|
||||
| v | the autumn clock change in Paris | two saves an hour apart can read the same « 02:30 » and still sort in their true order, which looks inconsistent |
|
||||
|
||||
|
||||
## 8. Deploy order and its consequence
|
||||
|
||||
Database first (M9), then the application. The typed client requires `last_modified_at` in the admin sheet summary
|
||||
and in the admin sheet read built on it (`packages/supabase/src/sheets.ts`). An application at this head against a
|
||||
database without M9 therefore answers « indisponible » on the admin sheet screens (the Administration card, the list,
|
||||
a sheet's page, the draft editor) and on the editor's admin reads around a save: it fails closed, by the client's
|
||||
check, and shows no wrong date. An older application against a migrated database is unaffected: its schema does not
|
||||
know the key and drops it. The order D3 already ran: sandbox, trial stack, then the application.
|
||||
@@ -640,10 +640,12 @@ deploy, DEV unchanged.
|
||||
reset), then the trial stack through `pnpm db:trial migrate` on the owner's go (cold backup
|
||||
`20261116T144154Z-pre-migrate` first), then the application code. Figures: `V1-2-6_R3_SQL_CHECKPOINT.md` §6.
|
||||
- Client (`packages/supabase/src/sheets.ts`): the summary requires `last_modified_at` as an ISO 8601 timestamp with
|
||||
offset; an answer without it, or with a value that is no timestamp, is the closed `unavailable` failure, never a
|
||||
list with a missing or invented date (P3).
|
||||
offset that a `Date` can read; an answer without it, with a value that is no timestamp, or with one the shape
|
||||
accepts but a `Date` cannot read (`+99:99`, final fix wave), is the closed `unavailable` failure, never a list with
|
||||
a missing or invented date (P3).
|
||||
- List page `/app/admin/sheets` (`AdminSheetsRoute.tsx`, boards 28 and 29 A): search on the name in French or English
|
||||
(`matchesSheetName`, shared with the catalogue: accents and case ignored, surrounding spaces trimmed), instant, 100
|
||||
(`sheetNameMatcher`, the catalogue's rule folded once per search, beside its `matchesSheetName`: accents and case
|
||||
ignored, surrounding spaces trimmed), instant, 100
|
||||
characters at most, no magnifier; « Effacer la recherche » shown only while the field holds text; Escape empties a
|
||||
non-empty field and does nothing on an empty one; every way of clearing returns the focus to the field. « Trier
|
||||
par »: « Dernière modification » (default, newest first) or « Nom » (the collation of the interface language: French
|
||||
@@ -685,16 +687,59 @@ Results recorded task by task up to the last code commit `b4a5254` (exact; nothi
|
||||
| `pnpm build` | passed at `423125c` and `de2424f` (the two screen commits) |
|
||||
| `pnpm test:run` | core-wasm 66, supabase 181, app 1743 (at `de2424f` and `b4a5254`) |
|
||||
| `pnpm db:sandbox test sheets-admin` (the client against the migrated sandbox's answers) | 5 of 5 |
|
||||
| `pnpm db:sandbox test-db` (pgTAP on the real image, accumulated sandbox, after M9) | Files=21, Tests=1958, Result FAIL. `022_sheet_admin_reads` ok, `023` ok. `014_animals_relations`: 2 of 258 failed (tests 6 « exactly the nine species… » and 7 « every species row is active »). `021_sheet_verification_jobs`: 23 failed, « Bad plan. You planned 90 tests but ran 42 », an error `draft.frozen` at :205. Read as dependent on the accumulated sandbox state (the suites need a fresh stack); M9 touches neither file's functions. NOT proven: no run of these files without M9, and no fresh stack (`up fresh` needs an owner go) |
|
||||
| `pnpm db:sandbox test-db` (pgTAP on the real image, accumulated sandbox, after M9) | Files=21, Tests=1958, Result FAIL. `022_sheet_admin_reads` ok, `023` ok. `014_animals_relations`: 2 of 258 failed (tests 6 « exactly the nine species of the contract and other, equine unchanged » and 7 « every species row is active »). `021_sheet_verification_jobs`: 23 failed, « Bad plan. You planned 90 tests but ran 42 », an error `draft.frozen` at :205. Read as dependent on the accumulated sandbox state (the suites need a fresh stack); M9 touches neither file's functions. NOT proven: no run of these files without M9, and no fresh stack (`up fresh` needs an owner go) |
|
||||
| `pnpm db:sandbox types --check` | no drift |
|
||||
| `e2e/shell/admin-sheets-list.spec.ts` alone on the sandbox | 4 passed, 0 failed |
|
||||
| Shell sweep, 27 spec files without `editor-equine.spec.ts` | 446 tests: 277 passed, 6 failed, 163 skipped, 0 flaky. All six failures in `admin.spec.ts`, on the rights screen: « admin screens » (:714) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed`; A0 (:220) ×2, fr and en at desktop, the grant lookup stuck on « Recherche… » until the « E-mail confirmé » check timed out (:144), about 7 600 grant rows rendered. Counted as BLK-015, the A0 pair with another symptom than « Target crashed ». NOT proven: no A/B run against the commit before R3. Green as required: A1 and « access per right » (the rewritten locators, both languages), `editor-journey`, the new spec |
|
||||
| Shell sweep, 27 spec files without `editor-equine.spec.ts` | 446 tests: 277 passed, 6 failed, 163 skipped, 0 flaky. All six failures in `admin.spec.ts`: « admin screens » (:714) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed` during axe at `admin.spec.ts:747`, inside that test's loop over the admin pages (the page is not recorded in this run; BLK-015's own description in `BROWSER_TESTS.md` names the rights screen as the proven cause in earlier runs); A0 (:220) ×2, on the rights screen, fr and en at desktop, the grant lookup stuck on « Recherche… » until the « E-mail confirmé » check timed out (:144), about 7 600 grant rows rendered. Counted as BLK-015, the A0 pair with another symptom than « Target crashed ». NOT proven: no A/B run against the commit before R3. Green as required: A1 and « access per right » (the rewritten locators, both languages), `editor-journey`, the new spec |
|
||||
| Data guard (every pre-existing row of `anatomical_sheets` and `anatomical_sheet_versions`, per id) | 0 changed, 0 missing on every run; the 12 sheets the R3 spec created in its two runs read back `deleted` (D7) |
|
||||
|
||||
Closing gates (verifier on the contract, security review of the whole diff, fresh design review of the two screens
|
||||
at 1 280 and 375 px, fresh code review of the range) and `pnpm check:all`: pending at the time of writing
|
||||
(2026-11-16). Not checked by the build: a browser sign-in on the trial stack (the owner's accounts, the owner's
|
||||
trial, `V1-2-6_OWNER_TRIAL.md` §4.15).
|
||||
Closing gates on the range `98178de..73ed375` (2026-11-16):
|
||||
|
||||
- Design review (fresh, the two screens at 1 280 and 375 px on the sandbox, one Playwright run, 2 passed, data guard
|
||||
0 changed, 0 missing): board 28 CONFORME (the two recorded deviations only); board 29 A ÉCARTS (2 small); board 29 B
|
||||
ÉCARTS. Findings 1 to 4 are fixed in the final fix wave: 1, the home at 1 280 px stacked « Espèces » and « Accès et
|
||||
habilitations » in the right column at their own height (`8bb2486`); 2, the card's sheet name links 44 px tall at
|
||||
375 px (`8bb2486`); 3, « Effacer la recherche » of the no-result block 44 px tall at 375 px (`1758276`); 4, the
|
||||
card item on the list row's rhythm (`8bb2486`). Left to the owner: finding 5 (below), the breadcrumb and the info
|
||||
icon. Finding 6 (typography: an opening guillemet can end a line, « version / 1 » orphan in the detail line) is not
|
||||
in the wave. Not checked by the design review: the badges and the working copy action on the card, the owner's
|
||||
layout (deduced from the code), the English wording, the 0 or 1 sheet link, distinct dates, hover, screen reader
|
||||
output.
|
||||
- Final code review (fresh, opus): 0 Critical, 0 Important, 9 Minor, « Ready for the owner's trial: Yes ». Fixed in
|
||||
the wave: 1 (each keystroke recomputed the whole list: the term folded once, the dates read once before the sort,
|
||||
the rows memoised; no `useDeferredValue`), 2, 3 and 6 (`useListView` split, className constants, the
|
||||
`SheetSummary` alias and the `ResultsProps` order, `1758276`), 4, 5 and 7 (the spec's `timezoneId`, the ordering
|
||||
loop's count, the escaped pattern, Escape pressed in Chromium, `ea5512a`). Already done by the Task 8 documents: 9
|
||||
(the `shortcut:` harvest). Left: 8 (the card checked for the true date: a flake risk on a shared sandbox).
|
||||
- Security gate (fresh): PASS. semgrep `p/security-audit`, `p/secrets`, `p/owasp-top-ten`: 0 findings. Four
|
||||
non-blocking findings: [MEDIUM] SQL built by template interpolation in the new spec, fixed (`literal()` and a uuid
|
||||
shape check, `ea5512a`); [MEDIUM] guardrails API-PASSWORD-LITERAL at `scripts/db-sandbox.sh:485`, a pre-existing line
|
||||
and a false positive, left; [LOW] the date checked by its shape only (`+99:99` passed and a `Date` read NaN), fixed
|
||||
(`374e300`); [LOW] a RegExp built from unescaped dictionary text in the spec, fixed (`ea5512a`). Outside the diff:
|
||||
the guardrails scanner reports 2 FAIL at `scripts/db-trial-check.sh:1340`, a file R3 never touched, not analysed
|
||||
(TODO).
|
||||
- Final fix wave (2026-11-16, `374e300`, `1758276`, `8bb2486`, `ea5512a`): unit gates core-wasm 66, supabase 182,
|
||||
app 1743; `pnpm build` passed. One Playwright run of `admin-sheets-list.spec.ts`, `admin.spec.ts` and
|
||||
`editor-journey.spec.ts`: 15 passed, 6 failed, 9 skipped. The new spec 4 passed; A1 and « access per right » green
|
||||
in both languages; `editor-journey` green. The six failures, all `admin.spec.ts`, all on the accumulated sandbox:
|
||||
« admin screens » (:714) fr desktop, en desktop and fr 375 px, `frame.evaluate: Target crashed` during axe at
|
||||
`:747`; « admin screens » en 375 px, `page.evaluate: Test timeout of 180000ms exceeded` during axe at `:747`, the
|
||||
screenshot on the rights screen; A0 (:220) fr, the « E-mail confirmé » check at `:144` after the lookup; A0 en, the
|
||||
« Right granted. » check at `:158`, the button stuck on « Granting… ». Counted as BLK-015, not proven by an A/B run
|
||||
against the commit before R3: the wave changed no file of the rights screen. Data guard: 0 changed, 0 missing, 20
|
||||
new lines (10 sheets with their 10 versions); the 6 sheets the R3 spec created read back `deleted`.
|
||||
- Still pending at the time of writing (2026-11-16): the verifier on the contract and `pnpm check:all` (run by the
|
||||
controller after the fix wave), and the owner's trial on the trial stack (`V1-2-6_OWNER_TRIAL.md` §4.15). Not
|
||||
checked by the build: a browser sign-in on the trial stack (the owner's accounts).
|
||||
|
||||
Owner decisions left open (R3):
|
||||
|
||||
1. The info icon of the no-result block: board 28 draws one, the page shows none (no glyph in `Icon`).
|
||||
2. At 375 px « Nouvelle fiche » sits beside the title, where board 29 A draws it under (header older than R3).
|
||||
3. The top-bar breadcrumb « Administration › Fiches officielles » the boards draw (shell level, older than R3).
|
||||
4. With a filter and a search both active and no result, the page shows the filters sentence without « Effacer la
|
||||
recherche » (board 28's note, followed literally).
|
||||
5. In that same case, the double announcement: the count line and the `role="status"` sentence.
|
||||
|
||||
### R4 — Integrity warning in catalogue cards (D9 C, independent fix)
|
||||
|
||||
|
||||
Reference in new issue
Block a user