docs(docs): R3 closed by owner validation 2026-11-16, BDR-120
This commit is contained in:
1 parent
5774d52144
commit
dc67c4aaca
6 files changed
+50
-4
No files matched your search
@@ -982,3 +982,10 @@ Owner 2026-11-15: finding dialog keeps only « Références citées » + « X r
|
||||
Owner pre-closure brief 2026-11-15. Reference created from references dialog edit mode held in draft (created[]), written with citations by one commitBatch (inserts + update = one undo); abandon leaves library unchanged. Dry-run applyEdit validates at draft submit. Select only browses, « Citer » button cites; save with pending choice refused. Family labels via isFamilyKey (finding key path len 1), 18 _family keys. Shared Dialog close 44px.
|
||||
Alternatives: write-now + delete on abandon (two undo steps, rejected); fold existing-reference edits into draft (offered to owner, not done).
|
||||
- **Status (2026-11-15)**: shipped: validated by owner db:trial 2026-11-15, R2 closed; both offered choices ratified as built
|
||||
|
||||
## BDR-120 — R3 sheet list + admin home closed by owner, phone filters panel (2026-11-16)
|
||||
- **Status**: accepted
|
||||
**Decision:** R3 closed 2026-11-16 by owner after db:trial trial. Sheet list: search fr/en, sort by true last_modified_at (M9 `private.official_sheet_admin_summary`) or name, count line, Paris date, « indisponible » when date missing/unreadable (never fallback date). Home card: latest five + « Voir les {n} fiches ». Phone (<640 px): four filters in CSS-only collapsible panel (grid-rows 0fr→1fr, `visibility:hidden` closed, « Filtres (n) »), reset only inside panel (owner confirmed, no other button). Filter-only empty line not a live region: count line announces once.
|
||||
**Rationale:** owner trial passed; desktop layout unchanged; no JS viewport detection; closed panel height 0 asserted at 375 px.
|
||||
**Alternatives:** reset button outside panel (rejected by owner); `inert` on panel (would disable desktop grid); motion lib (CSS enough).
|
||||
**Open, separate:** BLK-015, RR-13 (admin lists paging, server search), pgTAP 014/021 on accumulated sandbox, D5 keep list state on back. No merge, no deploy, DEV unchanged.
|
||||
@@ -569,3 +569,6 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
|
||||
- 2026-11-15 R2 owner follow-up built (Tasks 10-13 + fixes, b41c24b..ebd1d6d): references dialog with own edit mode, one tab order, vertical Plus. Gates 0, sweep 264 passed, fails = admin.spec BLK-015 + Target crashed (rerun green), GUARD OK. Waiting owner db:trial check.
|
||||
- R2 Rev 6 built: Citer button, draft-owned creation (commitBatch), family labels, 44px dialog close. Sweep final7 273 pass, 6 fail admin.spec BLK-015. Await owner db:trial then R2 closure.
|
||||
- R2 CLOSED 2026-11-15: owner db:trial 4.13+4.14 pass, validated functional+graphic; saved-ref edit own Défaire + unsaved new ref lost on abrupt close ratified. Sweep 52d5613 273p/163s/6f admin.spec BLK-015 open (RR-13). No merge/deploy. Next R3, R4; U2 orientation kept.
|
||||
|
||||
## 2026-11-16
|
||||
- R3 CLOSED 2026-11-16: owner db:trial trial pass, phone filters panel validated, reset in panel only. check:all exit 0 at a50796b. BLK-015, RR-13, pgTAP 014/021 open separate. No merge/deploy. Next R4 catalogue card integrity warning (D9 C).
|
||||
@@ -707,7 +707,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- R2 BUILT 2026-11-13, awaiting owner validation: fc3fec7 R2.0, 4499bc7 R2.1, c21995b R2.2, 3baac4d R2.3, 8db6f42 R2.4, 4b7d254 R2.5, 2182307 R2.6 docs, 1bf2701 final-review fixes (all pushed). Verifier 18/20 (NOT-MET 9 admin.spec renderer crash from accumulated grants, 15 read-only flip keeps panel open), security PASS, final review ready-with-fixes → fixed, re-review ready. Owner decisions pending: read-only flip ratification, admin.spec closure before merge (fresh-run authorisation or separate fix: paginated grants / run-scoped cleanup), add-draft cancel control, V1-2_ANATOMICAL_SHEETS.md D1-D4 supersede note wording. editor-equine updated, never run. Parked: N1 silent draft loss on read-only flip of an unmatched tile, N2 pinned non-matching tile beside no-result, first-click loss below a refused field, landscape 667×375 panel 13 px, M10 locals over 5 in R2 hooks (/refactor)
|
||||
- [x] R2 corrections (owner brief 2026-11-13, plan rev 5/5b): C0 admin.spec diagnosis (A/B 65a8fd3 vs 52aac41 identical, dose-response proves grant accumulation, BLK-015 open, pagination = RR-13), C1 read-only flip never drops a refused draft silently (3303530, 1e19479), C2 « Annuler l'ajout » + Escape (d177992, c8109af), C3 « Ne correspond pas à la recherche » (b1fd896), C4 667×375 touch proof, test only (969a5f3..78fb2d0), C5 docs (b919cf8, c0da36d, 58228ab), final review I1 (94f8a8b, 346a8fd), verifier gap undo drop announced (cb1ad47, 538ce27). Sweep 221p/119s/5f (admin.spec only), guard OK, verifier CONFORME, security PASS. BDR-115, LRN-133..135. Awaiting owner db:trial trial; residuals: two drops one flip speak last, undo/redo overwriting a pending draft in a mounted view, rotation cramped exception (auto-scroll offered), prettier drift editor-shell-layout.spec.ts:297-302
|
||||
- [x] R2 CLOSED 2026-11-15 (owner brief « Clôture R2 »): owner db:trial checks §4.13 + §4.14 pass, R2 validated functionally and graphically; Rev 4-6 adjustments (b41c24b..54e09a7, BDR-118, BDR-119); choices ratified: saved-reference edit keeps own Défaire, unsaved new reference lost on abrupt close. Final sweep 52d5613: 273p/163s/6f (admin.spec BLK-015, stays open, RR-13), not green. No merge, no deploy. Next: R3, R4; U2 not started (orientation 2026-11-14 kept)
|
||||
- [ ] R3 sheet list + Administration home (owner brief 2026-11-16): plan VALIDATED rev 2b `.claude/tasks/plans/2026-11-16-r3-sheet-list-0017.md` (D1-D4, D6, D7 yes; D5 no; recorded choices accepted; precisions P1-P4). Sandbox work authorised in plan scope; `pnpm db:trial migrate` authorised by the owner 2026-11-16 after the operational checkpoint and applied (Task 2); Tasks 3-8 authorised in plan scope; DEV unchanged. BLK-015 + RR-13 separate, open. pgTAP on the sandbox is NOT green (014, 021 below): never reported as green.
|
||||
- [x] R3 sheet list + Administration home (owner brief 2026-11-16): CLOSED 2026-11-16, owner validation after the db:trial trial, phone filters included (reset stays in the panel only); BDR-120. Plan VALIDATED rev 2b `.claude/tasks/plans/2026-11-16-r3-sheet-list-0017.md` (D1-D4, D6, D7 yes; D5 no; recorded choices accepted; precisions P1-P4). Sandbox work authorised in plan scope; `pnpm db:trial migrate` authorised by the owner 2026-11-16 after the operational checkpoint and applied (Task 2); Tasks 3-8 authorised in plan scope; DEV unchanged. BLK-015 + RR-13 separate, open. pgTAP on the sandbox is NOT green (014, 021 below): never reported as green.
|
||||
- [x] Task 1 M9 migration + pgTAP 022 (74: drafts, working copy, sheet newer than versions; mutation-proved) + task review + security PASS; frozen (blob a33b1770) — e3495df, a76a54d, f3712b2
|
||||
- [x] Task 2 `db:sandbox migrate` (21c9a81, reviewed) + sandbox migrated 2026-11-16 (rows identical 6981/7130, rerun no-op); types match; recompute 6981 sheets mismatch 0 (11 working copies). db:trial migrated 2026-11-16 on the owner's go: app process checked then stopped, `pnpm db:trial migrate` 21 s, backup `20261116T144154Z-pre-migrate` (63M, checked before M9, checksums and archives re-verified), 18 applied; before / after digest of 58 tables, 155 functions (definition + privileges), 23 policies, 20 grants: 3 lines differ (migration registry +1, the summary function = sandbox digest 1a4a1157, privileges unchanged); accounts, roles, TOTP, sheets, versions, drawings identical; recompute 2 sheets mismatch 0; admin list, sheet page and editor read answer for the aal2 editor account (read-only); app restarted on 5194. Not checked: browser sign-in (owner trial); restore not exercised
|
||||
- [ ] pgTAP on the sandbox after M9, exact result kept open: `pnpm db:sandbox test-db` Files=21 Tests=1958 Result FAIL. 022 ok, 023 ok. `014_animals_relations` 2/258 failed (tests 6 « exactly the nine species… », 7 « every species row is active »). `021_sheet_verification_jobs` 23 failed, « Bad plan. You planned 90 tests but ran 42 », ERROR draft.frozen at :205. Read as accumulated-state dependent (line « suites need a fresh stack »), NOT proven by a run without M9; M9 touches neither file's functions. To settle on a fresh stack (`db:sandbox up fresh` needs an owner go: no sandbox reset in R3)
|
||||
@@ -716,7 +716,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- [x] Task 5 list page (board 28, 29 A) (423125c, reviewed; app 1736, build ok)
|
||||
- [x] Task 6 home card (board 29 B) (de2424f, reviewed; app 1743, build ok)
|
||||
- [x] Task 7 shell spec admin-sheets-list + three locators (b4a5254, reviewed). Spec alone 4 passed. Sweep 27 files without editor-equine: 277 passed, 6 failed, 163 skipped, 0 flaky; failures all `admin.spec.ts` on the rights screen (BLK-015): « admin screens » :714 ×4 « Target crashed », A0 :220 ×2 lookup timeout at :144 (other symptom, about 7 600 grants; not A/B proven against pre-R3). A1, « access per right », editor-journey green. Guard: 0 pre-existing row changed; 12 R3 sheets soft-deleted
|
||||
- [ ] Task 8 docs, closing gates, owner trial on db:trial: [x] documents as built (a86020d: U1_CORRECTIONS §R3, SQL checkpoint §6-§7 with F2-F4 corrections and F7 limits, V1-2 §12.3 M9, SUPABASE §5.1, BROWSER_TESTS, Rust Part II class C rows, design README deviations, CLAUDE.md, CHANGELOG) · [x] owner trial text §4.15 in French (b9e5d32) · [x] closing gates design review (28 CONFORME, 29 A and 29 B ÉCARTS, findings 1-4 fixed in the wave), code review (0 C, 0 I, 9 Minor: 1-7 fixed, 9 done at Task 8, 8 left), security PASS (4 non-blocking: spec SQL, date refine, RegExp escape fixed; db-sandbox.sh:485 false positive left) · [x] verifier on the contract 2026-11-16 at bcdacbb: ECARTS(1), 17/18 MET, criterion 4 NOT-MET on its CHECK line only (one-line literal split and strengthened by 374e300; layout-insensitive equivalent prints DATE_SOURCE_OK, recorded in the contract a8ab668; the owner closes it) · [x] `pnpm check:all` 2026-11-16 at bcdacbb: exit 0, « all checks passed » in 7 min 52 s (core-wasm 66, supabase 182, app 1743 in 137 files, e2e:ui 253 passed, app image, worker test and runtime image); e2e:shell NOT RUN by check:all (the sweep and the fix-wave run are the lines above) · [ ] STOP owner trial on db:trial, no merge. Deviations for the owner: no magnifier (F14, validated); no info icon in the board 28 no-result block (ruling, to confirm)
|
||||
- [x] Task 8 docs, closing gates, owner trial on db:trial: [x] documents as built (a86020d: U1_CORRECTIONS §R3, SQL checkpoint §6-§7 with F2-F4 corrections and F7 limits, V1-2 §12.3 M9, SUPABASE §5.1, BROWSER_TESTS, Rust Part II class C rows, design README deviations, CLAUDE.md, CHANGELOG) · [x] owner trial text §4.15 in French (b9e5d32) · [x] closing gates design review (28 CONFORME, 29 A and 29 B ÉCARTS, findings 1-4 fixed in the wave), code review (0 C, 0 I, 9 Minor: 1-7 fixed, 9 done at Task 8, 8 left), security PASS (4 non-blocking: spec SQL, date refine, RegExp escape fixed; db-sandbox.sh:485 false positive left) · [x] verifier on the contract 2026-11-16 at bcdacbb: ECARTS(1), 17/18 MET, criterion 4 NOT-MET on its CHECK line only (one-line literal split and strengthened by 374e300; layout-insensitive equivalent prints DATE_SOURCE_OK, recorded in the contract a8ab668; the owner closes it) · [x] `pnpm check:all` 2026-11-16 at bcdacbb: exit 0, « all checks passed » in 7 min 52 s (core-wasm 66, supabase 182, app 1743 in 137 files, e2e:ui 253 passed, app image, worker test and runtime image); e2e:shell NOT RUN by check:all (the sweep and the fix-wave run are the lines above) · [x] owner trial on db:trial passed and R3 validated 2026-11-16, no merge. Deviations for the owner: no magnifier (F14, validated); no info icon in the board 28 no-result block (ruling, to confirm)
|
||||
- [x] Final fix wave 2026-11-16 (`374e300` client refuses an unreadable date, test first; `1758276` list hooks split, rows memoised, className constants, phone clear button; `8bb2486` home cards as board 29 B, 44 px name links, row rhythm; `ea5512a` spec: `literal()` + uuid shape, UTC, one `<time>` per item, escaped pattern, Escape; docs commit after). Units core-wasm 66, supabase 182, app 1743; build ok. One run of admin-sheets-list + admin + editor-journey: 15 passed, 6 failed, 9 skipped, all six `admin.spec.ts` BLK-015 class (admin screens ×3 Target crashed + ×1 timeout during axe at :747; A0 fr :144, A0 en :158 « Granting… »), not A/B proven; guard 0 changed 0 missing 20 new; 6 R3 sheets deleted. Owner decisions open: U1_CORRECTIONS §R3 list (info icon, « Nouvelle fiche » at 375, breadcrumb, filter + search no result, double announcement)
|
||||
- [ ] Follow-up (security gate, outside R3's diff): guardrails scanner 2 FAIL at `scripts/db-trial-check.sh:1340`, pre-existing, not analysed
|
||||
- [ ] Follow-up: WebKit parsing of six fraction digits in `new Date(iso)` not verified (Chromium only until V1-5)
|
||||
@@ -731,7 +731,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- [ ] editor-equine risk (owner 2026-11-12 « Validation du correctif E2E et GO R2 » §3; separate fix, NOT part of R2): `editor-equine.spec.ts` beforeAll archives every active historical working copy (`update public.anatomical_sheets … private.is_historical_working_copy(id)`), afterAll restores them, and `confirmHistoricalDrawing` may upload / confirm the historical sheet's drawing; it already changed 8c315a12's `updated_at` (2026-11-12 13:40 UTC). NOT to be run on a persistent database holding data to preserve until fixed. Before any rerun: list its writes exactly, propose a reproducible non-destructive isolation of pre-existing resources, check interactions with admin.spec and parallel suites; keep 8c315a12 and its current metadata (no artificial date restore); no sandbox reset or deletion
|
||||
- [ ] e2e fixture accumulation (owner 2026-11-12 §3): sheets created by the suites persist on the sandbox (admin.spec A1 `fiche-e2e-<tag>` never archived, seedDraft / seedOfficialSheet sheets, editor copies); track them (count per run, owner per fixture) and propose run-scoped cleanup limited to ids each run created
|
||||
- [x] (was) Anomaly B (owner 2026-11-12, decision C): `admin.spec.ts` « admin screens: axe and no sideways scroll » (4 failures: 2 locales × 2 viewports) depends on the historical sheet's free working-copy slot, taken on the sandbox by `sheets-admin.sandbox.ts:181-195` (copy `8c315a12-…`, never archived). Fix in its own commit with proof the 4 failures are gone; isolated reproducible fixture, no existing data deleted; stop and present options if impossible without a destructive op or a scope change
|
||||
- [ ] R3 sheet list: search + name sort first; date, date sort and « most recent » home card only after the dedicated SQL checkpoint `docs/development/V1-2-6_R3_SQL_CHECKPOINT.md` (A7 ratified 2026-11-09; never a creation date shown as modification date). Two-step split superseded 2026-11-16 by owner D2: one lot after M9, tracked in the R3 block above
|
||||
- [x] R3 sheet list: search + name sort first; date, date sort and « most recent » home card only after the dedicated SQL checkpoint `docs/development/V1-2-6_R3_SQL_CHECKPOINT.md` (A7 ratified 2026-11-09; never a creation date shown as modification date). Two-step split superseded 2026-11-16 by owner D2: one lot after M9, tracked in the R3 block above
|
||||
- [ ] R4 catalogue card integrity warning (independent fix, = anomaly C): `useCardDetails.ts` drops a failed `loadVersion` silently; UI only, check never bypassed
|
||||
- [ ] owner arbitrations A1-A15 (`V1-2-6_U1_CORRECTIONS.md` §6, `TRIAL_STACK.md` §6)
|
||||
- [ ] Test anomaly A (owner 2026-11-09, separate from U1/U2): fictitious fingerprints `'a'.repeat(64)` from worker stand-ins (`packages/supabase/tests/sandbox/sheet-fixtures.ts:115` openRound, `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`); 7 published/deprecated sandbox versions fail `check_published`. Fix: real fingerprint through the core (as e2e `fingerprintOf`, `apps/app/e2e/support/catalogue.ts:88`); never weaken the publish gate or the reader check. Needs its own go.
|
||||
|
||||
@@ -201,6 +201,32 @@ Tu peux utiliser ton processus habituel de développement, de tests, de relectur
|
||||
|
||||
R3 est validé fonctionnellement par mes essais, sous réserve de cette dernière amélioration mobile.
|
||||
|
||||
### Owner validation 2026-11-16 (R3 closed)
|
||||
|
||||
Je confirme avoir testé le volet repliable des filtres sur téléphone.
|
||||
|
||||
Tout fonctionne correctement et l'ergonomie me convient.
|
||||
|
||||
Je valide officiellement R3, y compris sa dernière amélioration mobile.
|
||||
|
||||
Je confirme également que « Réinitialiser les filtres » doit rester uniquement à l'intérieur du volet. Aucun bouton supplémentaire n'est nécessaire.
|
||||
|
||||
Tu peux enregistrer cette validation propriétaire dans la documentation, le suivi et la mémoire, puis committer et pousser les éventuelles mises à jour.
|
||||
|
||||
R3 est terminé.
|
||||
|
||||
Nous pouvons maintenant passer à R4 : affichage des erreurs d'intégrité sur les cartes du catalogue.
|
||||
|
||||
Reprends les décisions déjà validées, notamment D9 C, les maquettes R0 et le plan V1-2.6.
|
||||
|
||||
Je te laisse autonome pour auditer l'existant, préparer le plan technique et organiser les relectures habituelles.
|
||||
|
||||
Présente-moi les éventuelles décisions qui nécessitent mon accord avant l'implémentation.
|
||||
|
||||
Conserve BLK-015 et RR-13 comme chantiers séparés.
|
||||
|
||||
Aucune fusion ni intervention sur DEV.
|
||||
|
||||
## CLARIFICATIONS
|
||||
- Graphic reference: boards 28 and 29 of `docs/design/v1-2-6-r0/` (R0, validated 2026-11-09). Board 30 belongs to R4.
|
||||
- Labels: `docs/design/v1-2-6-r0/REVUE.md:82-84`. Date format (A8): « 9 nov. 2026, 12:06 » / « 9 Nov 2026, 12:06 », Paris time.
|
||||
@@ -255,3 +281,6 @@ supabase/migrations/20261116100000_sheet_admin_last_modified.sql, supabase/tests
|
||||
## Verification closure 2026-11-16 (after the owner trial)
|
||||
- Criterion 4: the CHECK line is now the layout-insensitive equivalent recorded above. Run 2026-11-16 at `6d2ba0d`: DATE_SOURCE_OK. Criterion 4 MET (behaviour unchanged since the fix wave `374e300`; the oracle was the defect).
|
||||
- Owner message « filtres repliables »: collapsible panel on a phone (`9efc7b7`), spec `6d2ba0d`. The double announcement is fixed (the filter-only empty line is no longer a `role="status"`, the count line announces once).
|
||||
|
||||
## Owner validation 2026-11-16 (R3 closed)
|
||||
- The owner tested the phone filters panel on db:trial and validated R3 officially, its last phone improvement included. « Réinitialiser les filtres » stays inside the panel only; no other button. Final state `5774d52` plus this record: `pnpm check:all` exit 0 at `a50796b`; BLK-015, RR-13 and the pgTAP 014 / 021 results on the accumulated sandbox stay open in their own tracking. No merge, no deploy, DEV unchanged.
|
||||
@@ -596,6 +596,9 @@ ensuite sur la pile d'essai : c'est à vous de décider si vous les créez.
|
||||
Passez l'application en anglais si vous voulez relire les libellés (« Search a sheet by name », « Sort by »,
|
||||
« Modified on 9 Nov 2026, 12:06 », « See the 2 sheets »). En anglais, « Nom » range par le nom anglais.
|
||||
|
||||
Résultat du 16 novembre 2026 : essai fait par le propriétaire sur db:trial, panneau des filtres sur
|
||||
téléphone compris. R3 est validé. « Réinitialiser les filtres » reste uniquement dans le panneau.
|
||||
|
||||
## 5. Limites à connaître
|
||||
- Risque résiduel RR-12 : les opérations du catalogue lisent la mention `aal2` du jeton, pas la session vivante.
|
||||
Un jeton émis à `aal2` reste accepté après la suppression du facteur, jusqu'à son expiration (une heure).
|
||||
|
||||
@@ -762,7 +762,11 @@ day (`9efc7b7`, spec `6d2ba0d`), no new board:
|
||||
e2e:shell not run by check:all. Spec admin-sheets-list alone: 8 passed. BLK-015 and the `admin.spec.ts`
|
||||
failures stay in their own tracking, untouched.
|
||||
|
||||
Owner decisions left open (R3):
|
||||
Owner validation 2026-11-16: R3 validated officially after the owner's db:trial trial, the phone filters panel
|
||||
included; « Réinitialiser les filtres » stays inside the panel only. R3 is closed. The points below were raised
|
||||
before that validation; no change was requested on them, so they stay as built.
|
||||
|
||||
Points raised before the validation (R3, as built):
|
||||
|
||||
1. The info icon of the no-result block: board 28 draws one, the page shows none (no glyph in `Icon`).
|
||||
2. At 375 px « Nouvelle fiche » sits beside the title, where board 29 A draws it under (header older than R3).
|
||||
|
||||
Reference in new issue
Block a user