The kept-alive annotations tab showed the reason in its hidden message
line, so it came back on the return. A press made while the place is
hidden is now only described by the button.
Safari focuses no tapped button: a tool or a view chip pressed after a
keyboard series commits through the guard with the focus on the handle,
then the change unmounts the handle. The focus now lands on the pressed
button, without a scroll, only when it fell to body (M-4).
The scroll margin now covers every native focusable of the place (tools,
view chips, add buttons, the aside's controls), the strip's own commands
excepted, as a real Tab walk found them hidden (I-3). A vertex chosen
from the keyboard takes the focus with a scroll (M-1).
A press on « Défaire » over a pending series or mode keeps the focus and
skips the field commit, so its handle's blur no longer commits before
the cancel (R-13): the redo stack survives. A held button gives its
reason only when that cause alone holds it; redo during a creation gets
its own text, and the pending text says to cancel with « Défaire ».
The strip made sticky in f2809f20 covers the drawing's top band and the
aside's top while the page is scrolled (rev 4 point 1 ruling, accepted
cost). Three presses and one axe scan ran at that scroll after a row
click: back to the top first, and assert the press hits the drawing.
- French fallback names: « cette nouvelle zone », « ce nouvel accès »
(controller ruling: « Sommets de ce nouvel accès »); doc updated.
- useZoneHandle back to 5 locals.
- dropPending clears the strip hint as a kept stored change does.
- Tests: the chosen vertex cleared by finishCreation itself (document
unchanged) and by a view change through the guard; both fail
without their clearing.
Changed assertions, editor-creation-dialog.test.tsx:
- « Sommets de la nouvelle zone », « Sommet 1 de la nouvelle zone »
-> « … de cette nouvelle zone » (ruling)
- « Sommets de le nouvel accès » -> « Sommets de ce nouvel accès »
- chosen null after « Créer » (cleared by the document change, not
discriminating) -> « the chosen vertex ends with a finished
creation, the document unchanged »
« Reprendre le tracé » keeps the pending shape closed; the zone handles
(vertex, « + », « − », vertex keys) edit it through the same press path
and useZoneEdit, the target generalised to points + drop. A drop on
PENDING_ID patches creation.pending only: document, history and unsaved
count untouched, message without « Défaire ». Strip: « Tracé repris,
saisie gardée » with « Revenir aux propriétés » and « Abandonner ».
Handle names fall back to « la nouvelle zone » / « le nouvel accès ».
Removed (resumed branch of popVertex, backToProperties -> closeTrace,
CreationCommands tracedCount and its « Retirer le dernier sommet »).
Removed assertions, editor-creation-dialog.test.tsx, « keeps the
vertices and the form; a new vertex, then the dialog again »:
- strip « Tracé repris, saisie gardée » -> kept in « keeps the shape
closed and the form, shows its handles; two strip commands »
- « Retirer le dernier sommet » enabled -> absent; commands are exactly
« Revenir aux propriétés », « Abandonner » (same test)
- a click on the drawing adds a 4th vertex -> « a click off the handles
adds and selects nothing; a double « + » inserts once »
- dialog again with Nom (FR) « Tibia » -> « « Revenir aux propriétés »
shows the edited shape; « Créer » inserts it »
- « Zone tracée, 4 sommets » -> « Zone tracée, 5 sommets » after « + »
(same test)
UX_TESTS: gates at 15b23f8 (check:all passed; shell suite 311 passed, 14 failed, red; test 105 passed; test-db FAIL 014/021 as before U2), measures rerun, keyboard map row (Backspace only while tracing). Plan Tasks 8 and 10 and OWNER_TRIAL Mesures carry the new figures.
UX_TESTS: redo is held while a move, a redraw or keyed steps are pending (ae80511), the message line also pauses under keyboard focus. OWNER_TRIAL 4.17: greyed redo, Mac keys (M-7), focus hold, focus back to the page after a touch or Safari commit, the new handle names.
Criterion 5: « Déplacer le point », « Déplacer la zone », « Valider la
position », and « Redessiner » entered then cancelled, each under
expectNoShift at 1 024, 1 180 and 1 280 px (seeded point and zone, the
existing multi-width pattern). The editor-touch « Déplacer la zone » entry
joins the probe; its button is centred first, since below xl the sticky top
bar can cover the strip and Playwright would scroll inside the probe.
No assertion removed. No product shift found.
Criterion 18: « Sommet {n} de {nom} », « Ajouter un sommet après le sommet
{n} de {nom} », « Retirer le sommet {n} de {nom} » (EN « Vertex {n} of
{name} » …), {nom} the zone's display name in the current locale; the
handle group is a role="group" named « Sommets de {nom} ».
Tests: no assertion removed; every unit and e2e locator that read the old
names now reads the same handle with the zone name appended (fixtures: N,
Vertèbres thoraciques, Zone dessinée, Zone clavier). New unit tests in
editor-zone-edit cover the FR names, the group and the EN locale.
Fixes semgrep react-insecure-request (CWE-319): ready() now checks the preview port with a node:net TCP connect instead of fetch on http://127.0.0.1. Also ignore apps/app/e2e/test-results/ in .dockerignore so the measure build, which inlines the sandbox anon key, stays out of the Docker context.
Safari, and iPad Safari on a tap, focuses no clicked button: the
handle or the slider keeps the focus, no blur commits its series, and
« Déplacer … », « Redessiner » or « Remplacer par un polygone »
cleared it (preview: null) without a word. startMove and beginRedraw
now call commitFocusedSeries() first, the same path a drawing press
takes since 10a8767. « Propriétés » (guardDrawing) and
« Désélectionner » (useDeselect) already committed; a test pins both.
Tests: no assertion removed.
Final review M-5: the hit test now probes 1 px inside each edge of the
44 px (36 px from xl) box and reads the ::before height, so the check
proves the full height, not 42 px. Tests: no assertion removed.
Final review M-3, M-4, M-5, M-6 in the sandbox suites:
- editor-annotations (A14 at 1024, 1180, 1280 px): « Défaire » on the
line hit-tested 44 px tall below xl and 36 px from xl, its pill 36
px; pressed under expectNoShift, the drawing then has the focus.
- editor-geometry: the same refused move twice under expectNoShift is
a new alert pill.
- editor-zones: « Redessiner » takes the focus back after a close and
a cancel; with the strip scrolled out and the focus on body, the
close returns it with no scroll.
Tests: no assertion removed.
Final review M-4 and M-6: the line's « Défaire » focuses the drawing
through focusDrawing (preventScroll), and a mode's end focuses its
entry with preventScroll, so neither scrolls the page (A14).
M-8: the empty tap kept after the removed click was as inert; gone.
Tests removed: in « a mouse tap deselects at the pointer-up », the
second pointerDown/pointerUp on the empty drawing and its repeated
isDeselected assertion (the first tap's assertion covers it).
Final review I-1 audit. A touch press moves no focus before its
pointer-up, so a press on « + » or « − », or a drag, committed over an
arrow or slider series still pending on the focused handle and dropped
it. A fresh press now commits it first (commitFocusedSeries, its own
blur), as the mouse's focus move already did.
Tests: no assertion removed; header « Refaire » cases added for a
started redraw and a size change.
Final review M-3, M-4, M-5, M-8.
- M-3: the line and the strip render a refusal's role="alert" beside
their always-mounted role="status" region, never inside it; every
shown message carries a serial that keys its pill, so a repeated
identical refusal is a new pill and is announced again.
- M-4: after the line's « Défaire » the focus goes to the canvas box.
- M-5: « Défaire » gets a transparent ::before, 44 px tall below xl
(36 px from xl), within the row's reserved 44 px: the pill keeps
its 36 px. The A14 e2e checks the hit area at 1024, 1180, 1280 px.
- M-8: the « swallows the click on a marker » test fired a click the
canvas ignores since T2; the inert click is dropped, the title says
what the taps prove.
Tests rewritten: « the message sits on its own row »: role="status" on
the row → a role="status" region inside the row, empty at rest.
« a mouse tap deselects … swallows the click »: the final
fireEvent.click on the marker removed (inert), its isDeselected
assertion kept after the second tap.
Final review M-6. useMoveFocusReturn becomes useModeFocusReturn: the
mode that ended picks its entry, « Déplacer … » (data-move-entry) for
a move, « Redessiner » or « Remplacer par un polygone »
(data-redraw-entry) for a redraw, the drawing when neither is shown.
A redraw counts as running while its mode or its tracing lives, so a
link polygon (no « Déplacer ») never leaves the focus on body.
Tests: no assertion removed.
Final review M-2: maxHeight runs to the visual viewport's bottom, not
the layout viewport's, so « Enregistrer » stays reachable while a
keyboard leaves 320 px or more. New unit case beside the keyboard one.
Final review I-1. Redo (Ctrl+Shift+Z and the header « Refaire ») is
inactive while a started move or redraw, a keyboard series or a size
change is pending (holdsRedo): the work stays, the user commits or
cancels it first. In a move mode, Insert and Delete on a vertex and
Enter or Space on « + » and « − » do nothing, as the press machine.
Tests: no assertion removed. The history-guards move-mode helper and
reset run in act, since « Refaire » now re-renders on a started mode.
Opt-in spec (MEASURE_COMMIT=1, MEASURE_BUILD=preview for the production build): vertex drag, « + » and « − » on a run-seeded equine draft, three runs each, from the pointerup to the painted frame showing the new geometry with the undo entry. Never editor-equine nor the historical copy.
Minor 1: the loupe's copy of the drawing drops every id (the equine
drawing has 142); its url(#…) and href="#…" resolve to the originals.
Minor 2: useFraming's onPinch marks the two-finger flag at the pinch
move itself; the passive effect that read the live press phase and
the press hook's multi() are removed.
Opt-in with MEASURE_DRAG=1 MEASURE_BUILD=preview: the app built with
the shell config's sandbox environment into e2e/test-results, served
by vite preview on 127.0.0.1:5193 (--strictPort), the allowlist set
to that origin and the fake Supabase origin. Suites unchanged.
useFraming gains twoPointerPan (the editor's pinch also pans by the
midpoint and scales from the spread since the pinch began; the
catalogue passes nothing). A futile one-finger drag shows the R-1
hint unless two fingers already worked in this editor visit (work
store flag). A finger drag of a handle shows the loupe (technique A:
the drawing copied once, data-anno-id stripped, outline on top).
editor-touch.spec covers 1 024, 1 180 and 1 280 px with CDP touch.
measure-drag.ts is the hand-run smoothness measure (MEASURE_DRAG=1).
equineShape moved from editor-zones.spec to support/editor.ts, no
assertion changed.
Task 7 fix round 1 (review task-7-review.md).
- Important 1: « Taille » shows beside « Revenir aux propriétés » while
a point is replaced (still hidden under the modal dialog); it feeds
the hover preview and the re-placed point (R-10).
- Important 2: a creation whose view leaves the document is dropped
and said, « Création abandonnée : la fiche a changé. » (dropped:
'creation', read by useDroppedNotice).
- Minor 3: DrawingGuardDialog leaves a creation question to the
creation dialog only while that dialog is really on screen
(creationShown, set by the dialog).
- Minor 7: the dialog's long className strings split into constants.
- Minor 8: dead TOOL_OF removed; trace_start is a redraw's only.
Tests added (no assertion removed): slider while replacing (unit,
RED then GREEN; e2e under expectNoShift at three widths, last strip
command inside the strip); view removed during a creation (RED then
GREEN); question shown by the workspace when the dialog is not on
screen (RED then GREEN); « Abandonner » while read-only; R-13 with a
restored copy during a started move; leaving the route resets the
work (fails with the session reset removed). The unit Back test's
comment is corrected: it does pin the modal branch.