docs(docs): U2 tests, plan, rendering and Rust review aligned
This commit is contained in:
1 parent
0ca1f20452
commit
6e42d2ada1
12 files changed
+93
-53
No files matched your search
@@ -216,6 +216,7 @@ faunosteo/
|
||||
│ ├─ auth/{navigationHint,stepUp,useStepUp,useMfaFailureMessage}.ts ← V1-2.5: nav entries from own grants + roles (a hint, never a gate), verified factors for a step-up, in-action step-up on aal2_required, MFA failure phrasing
|
||||
│ ├─ admin/{filters,labels,permissions,sheetList,useAdminQuery,validation}.ts ← V1-2.5 admin screens: sheet list filters, status labels, sheet list search and sort (R3), capability checks for display, page-local query, form schemas
|
||||
│ ├─ editor/references/{filter,citations,citationEdits,panel,sort,view,referenceTypes,safeLink}.ts ← V1-2.6 R2 Références tab: display-only search, citer lists, `citationEdits` (the references dialog's draft as adds and removes over the current list), panel entries, the four sorts, shown set, type order, safe links (TypeScript by owner exception BDR-114 (A), `RUST_ARCHITECTURE_REVIEW.md` II.3)
|
||||
│ ├─ editor/annotations/{press,escape,missingFields,polygonEdit,pointSize,workStore,usePressGesture,useZoneEdit,usePointEdit,usePlacement,useGestureMessage,...}.ts ← V1-2.6 U2 direct manipulation: the press machine (one decider for every press on the drawing), the work store (creation, move or size preview, chosen vertex; each preview stamped with the document text it was computed on), vertex, zone and point editing, creation by placing and tracing, the message line; pure page-side arithmetic stays TypeScript (`RUST_ARCHITECTURE_REVIEW.md` II.3, U2 exception), every end state judged by the core through `sheet.edit`
|
||||
│ ├─ editor/history/{entry,useEditorHistory}.ts + editor/{findingLayer,useReferenceMoves}.ts ← R2 finish: the editor view in the browser history (entries carry the sheet id and a random session tag, navigation only; pure planning of push / replace / back, write budget; the reconcile hook), the finding layer and the reference moves
|
||||
│ ├─ catalogue/{catalogue,failure,framing,preview,useCardDetails,useCatalogue,useEmptyTap,useFraming,useSheetVersion,versionText}.ts ← V1-2.5 catalogue: reads, closed failure kinds, canvas zoom and pan, PreviewSheet load path (hash, fingerprint, caps checked by the core); useEmptyTap (R1, D6b): a press on the drawing outside any annotation, told from drags and multi-pointer gestures
|
||||
│ ├─ account/{validation,useProfileForm}.ts ← account section schemas + one-save form hook
|
||||
@@ -257,6 +258,7 @@ faunosteo/
|
||||
│ │ ├─ admin/{ActivateSpeciesDialog,GrantList,GrantPanel,ModifiedDate,RevokeGrantDialog,SheetBadges,SpeciesDialog,WorkingCopyAction}.tsx ← V1-2.5 rights, species and sheet pieces
|
||||
│ │ ├─ editor/references/{ReferenceTiles,ReferenceTile,ReferenceFacts,ReferenceToolbar,NoResult,CitersList,CitationsPanel,CitationsDialog,CitationsEditForm,CitationsDraftList,ReferenceDialog,ReferenceForm}.tsx + use{ReferenceView,ReferenceLibrary,TileState,CitationsPanel}.ts ← V1-2.6 R2 and finish: read-only tiles, toolbar with the finding filter chip, the references dialog stacked over a finding (view and edit modes), the reference dialog and its form, their view and tile state hooks
|
||||
│ │ ├─ editor/findings/{FindingDialog,FindingView,FindingEditForm,FindingCreateForm,FindingActions,FindingCitations,DiscardConfirm,ReadOnlyNotice,useDirtyGuard}.tsx ← R2 finish: the finding dialog (view and transactional edit modes, creation), discard confirmation, dirty guard; `findings/useItemMode.ts`: the dialogs' local view / edit mode, focus back to « Modifier » or on the draft's first control
|
||||
│ │ ├─ editor/annotations/{EditStrip,GestureMessage,SizeSlider,MoveModeBar,HandleLayer,ZoneHandles,Loupe,AnnotationDialog,AnnotationReadBody,AnnotationEditForm,CreationDialog,OverviewPanel,...}.tsx ← V1-2.6 U2: the fixed strip and message line (no layout shift), the handle layer (its own SVG, `ANNOTATION-RENDERING.md`), the touch loupe, the properties and creation dialogs (`Dialog` `anchor`, over the right column); `GeometryGroup.tsx` stays for `RepairDialog` until U5; the U1 side panels and tracing bar are gone
|
||||
│ │ ├─ editor/useMoreMenu.ts ← R2 finish: « Plus » overlay state, dismiss (Escape, outside press) and the CloseWatcher back request
|
||||
│ │ ├─ ui/afterModalsClosed.ts ← R2 finish: runs a callback once no `dialog[open]` remains (focus landings, queued announcements)
|
||||
│ │ ├─ editor/tabs/ReferencesTab.tsx ← V1-2.6 R2: the fifth editor tab (toolbar, tiles, add tile, reorder hint)
|
||||
@@ -273,7 +275,7 @@ faunosteo/
|
||||
├─ tests/
|
||||
│ ├─ setup.ts
|
||||
│ └─ unit/*.test.ts
|
||||
├─ e2e/ ← Playwright (V1-1.3): playwright.{ui,shell}.config.ts, support/{browser,sandbox,shell,records,admin,catalogue}.ts, ui/*.spec.ts, shell/*.spec.ts (V1-2.5: admin, catalogue; V1-2.6 R2: editor-references, editor-citations; R3: admin-sheets-list), harness/{dialog,working-copy}.{html,tsx} (dev server only, never built)
|
||||
├─ e2e/ ← Playwright (V1-1.3): playwright.{ui,shell}.config.ts, support/{browser,sandbox,shell,records,admin,catalogue}.ts, ui/*.spec.ts, shell/*.spec.ts (V1-2.5: admin, catalogue; V1-2.6 R2: editor-references, editor-citations; R3: admin-sheets-list; V1-2.6 U2: editor-zones, editor-properties, editor-touch, `support/layout.ts` (`expectNoShift`)), harness/{dialog,working-copy}.{html,tsx} (dev server only, never built)
|
||||
├─ docker/
|
||||
│ ├─ entrypoint.sh ← injects env.js at container start
|
||||
│ └─ nginx.conf ← SPA fallback + PORT envsubst
|
||||
|
||||
@@ -61,8 +61,11 @@ highlight drops every `data-*` attribute and a raster never shows a title.
|
||||
| `data-state` | `current` on every element of an annotation of the active observation |
|
||||
|
||||
Click handling walks up to the nearest `[data-anno-id]` and hands the
|
||||
annotation id to the core's click rule (`zone.click`, R2). Behaviour never
|
||||
depends on a label, an element id or a class. The canvas sets and removes
|
||||
annotation id to the core's click rule (`zone.click`, R2). In the editor the
|
||||
press machine (`press.ts`, U2) lists the elements under the pointer
|
||||
(`elementsFromPoint`), reads the nearest `[data-anno-id]` of each and decides
|
||||
one action for the whole press. Behaviour never depends on a label, an element
|
||||
id or a class. The canvas sets and removes
|
||||
`data-state` in place when the active observation changes (no rebuild), for
|
||||
the annotation ids of every zone of that observation, whatever their view;
|
||||
the custom tooltip reads the two name attributes (none on a trigger).
|
||||
@@ -171,7 +174,7 @@ from `(any-pointer: coarse)`:
|
||||
| Device | Vertex | « + » | « − » bubble | Hit radius |
|
||||
|---|---|---|---|---|
|
||||
| Coarse (finger) | 18 px | 24 px | 44 × 36 px | 22 px |
|
||||
| Fine (mouse, pen) | 12 px | 16 px | board 05 size | 10 px |
|
||||
| Fine (mouse, pen) | 12 px | 16 px | 28 × 22 px | 10 px |
|
||||
|
||||
The point handle covers the selected point's own circle (at least the hit
|
||||
radius), so the whole marker can be held. A chosen vertex is drawn bigger,
|
||||
|
||||
@@ -232,3 +232,12 @@ and 13 of `v1-2-6/` as the reference. Three minor adjustments apply at implement
|
||||
(`v1-2-6-u2/ARBITRAGES.md` « Validation du propriétaire »): a discreet contextual hint for the two-finger pan on
|
||||
tablet (A13); the message after a gesture never moves or resizes the drawing (A14); validation messages name only the
|
||||
fields actually missing (board 33).
|
||||
|
||||
2026-11-18: U2 BUILT from the validated `v1-2-6-u2/` boards (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, Tasks 1
|
||||
to 8; the owner tries it on `pnpm db:trial` before U2 closes). Where the code differs from a board, the owner's trial
|
||||
decides: the message line is its own fixed row under the add buttons at the drawing's full width (board 02 C draws it
|
||||
beside the buttons), and a refusal's text also shows in the strip's middle; « Reprendre le tracé » reopens the polyline
|
||||
without handles (board 04 C draws handles); the point-size slider is hidden while the creation dialog shows; the
|
||||
strip's left part has a fixed width, so a long name truncates; board 31 gaps: no category swatch, the
|
||||
discard buttons wrap at 352 px, the dialog header scrolls with its content. Boards 14 and 16 (phone, read-only) are
|
||||
unchanged.
|
||||
@@ -3973,7 +3973,11 @@ with a PI shown `rejected` by the preview as the verdict refuses it.
|
||||
### 12.6 Residual risks and points for V1-2.3
|
||||
|
||||
- The module's margin under its budget is about 30.8 KB by the test's measure since §12.8 (31.3 KB at §12.7) (3.3 KB before): the V1-2.5 and V1-2.6 pages must not grow the
|
||||
core's browser surface without measuring.
|
||||
core's browser surface without measuring. V1-2.6 U2 took it to 4 669 B (`PreviewState.min_point_radius`, the row above);
|
||||
U2 adds no Rust after that value, so U5 starts with that margin and measures before any new op. The U2 TypeScript
|
||||
modules (`press`, `escape`, `missingFields`, `polygonEdit`, `pointSize`) are listed as class C in
|
||||
`RUST_ARCHITECTURE_REVIEW.md` Part II. The core files themselves are unchanged since that value (the module on disk
|
||||
is 1 580 788 B).
|
||||
- cairo colours: closed at the checkpoint (§12.7), strict numeric `rgb()` / `rgba()` kept.
|
||||
- Editor exports: Inkscape 1.4.3 covered at the checkpoint (§12.7), Figma at the finalisation (§12.8); A6's final
|
||||
perimeter (owner, 2026-10-30, §12.10) is Figma, Inkscape, cairo and ImageMagick; Adobe Illustrator and Affinity are
|
||||
|
||||
@@ -309,6 +309,9 @@ concrete constraint.
|
||||
| `apps/app/src/admin/sheetList.ts` (`searchSheets`, `sortSheets`, `SHEET_SORTS`) and `matchesSheetName` in `apps/app/src/catalogue/useCatalogue.ts` | the admin official sheet list (R3): search on the name in French or English (`folded`, the catalogue's rule, now shared), sort by `last_modified_at` (newest first) or by name, ties by name then id | TS, `Intl.Collator` of the current language | portable, but the collation needs the browser's ICU data (a Rust equivalent would ship its own); filters and orders the loaded list for display, never writes; the date itself is computed by the server (M9) and checked at the client boundary | no | none; called in the render of the list page and the home card | none | `admin.sheetList.test.ts`, the catalogue suites | **C**: display-only search and ordering over server data, no business rule, no mutation; owner validation of the R3 plan, 2026-11-16 (as BDR-114 (A)); `shortcut:` until RR-13 pages the list on the server, where search and sort move | n/a |
|
||||
| `formatShortParisDateTime` in `apps/app/src/admin/labels.ts` | the « 9 nov. 2026, 12:06 » / « 9 Nov 2026, 12:06 » date of the admin list and home card (A8), Paris time | TS, `Intl.DateTimeFormat` (`fr-FR`, `en-GB`, `Europe/Paris`), one formatter per language | screen date formatting needs the browser's ICU and time zone data | no | none | none | `admin.labels.test.ts` (ratified strings, the Paris summer offset) | **C**: screen date formatting (as `lib/dates.ts`); owner validation of the R3 plan, 2026-11-16 | n/a |
|
||||
| `cardFailure` in `apps/app/src/catalogue/failure.ts`, `apps/app/src/components/catalogue/CardFailure.tsx` | how a catalogue card shows the closed failure kind of its version (R4, board 30): integrity class (A10 text, no retry), size limits (D1), other kinds with « Réessayer », tone and glyph | TS, React | portable (a set lookup), but it only maps kinds the core already decided to a line, a tone and a button; the check itself stays the core's `check_published` | no | none; called in the card's render | none | `routes.catalogue.test.tsx` (test 11 lists every member of `CatalogueFailure`), `components.Notice.test.tsx` | **C**: display formatting of closed kinds, no business rule, no mutation; owner validation of the R4 plan, 2026-11-17 (R-8) | n/a |
|
||||
| `apps/app/src/editor/annotations/{press,escape}.ts` | the press machine of the editor drawing (click or drag, which handle, which annotation, what a second pointer cancels, double click) and the Escape priority across the workspace (V1-2.6 U2) | TS | portable (pure functions), but pointer and keyboard event handling is DOM and UI; each result is a proposal that goes through `sheet.edit` and the core's verdict | no | none; called in event handlers | none | `annotations.press.test.ts`, `editor-escape.test.tsx` | **C**: pointer and keyboard event handling, DOM and UI (CLAUDE.md « kept as is »); owner validation of the U2 plan, 2026-11-17 (R-17) | n/a |
|
||||
| `apps/app/src/editor/annotations/missingFields.ts` | which required fields of the annotation form are missing, as i18n keys, in form order (V1-2.6 U2, board 33) | TS | portable, but it is a UI form rule over i18n keys; the document's own rules stay the core's | no | none | none | `annotations.missingFields.test.ts` | **C**: UI form rule over i18n keys (CLAUDE.md « kept as is »); owner validation of the U2 plan, 2026-11-17 (R-17) | n/a |
|
||||
| `apps/app/src/editor/annotations/{polygonEdit,pointSize}.ts` | preview arithmetic while a handle moves: midpoint, vertex removal, vertex move, handle cap, « + » visibility; point-size stops, most used radius, snap, slider range (V1-2.6 U2) | TS | portable, but it runs at interaction rate on every pointer move, and UX plan §1.3 and §2 G, ratified at U0, place it in the page; each result is committed through `sheet.edit`, and no core rule is copied: the minimum point radius comes from the core (`PreviewState.min_point_radius`) | no | none; called in event handlers | none | `annotations.polygonEdit.test.ts`, `annotations.pointSize.test.ts` | **C**: interaction-rate preview arithmetic, the core judges the end state; owner validation of the U2 plan, 2026-11-17 (R-17) | n/a |
|
||||
| `i18n/*` (281 keys ×2, `useT`, `pickLocaleLabel`) | UI strings | TS | UI data and hook; the engine's 25 archived labels move with the engine | no | | | parity test | **C** | n/a |
|
||||
| `config/env.ts`, `lib/supabase.ts`, providers, guards, routes, components, styles | runtime config, React | TS | glue | no | | | | **C** | n/a |
|
||||
| `vite/sheet-bundle.ts`, ESLint, Vite, vitest configs | build tooling | Node | Vite plugin API is JavaScript | no | | | | **C** | n/a |
|
||||
@@ -347,6 +350,12 @@ concrete constraint.
|
||||
Same exception for the catalogue card's failure line (R4, owner validation
|
||||
of the plan, 2026-11-17, R-8): it shows the kind the core answered, never
|
||||
decides or bypasses the check.
|
||||
Same exception for the annotation editor's page-side modules (V1-2.6 U2, owner
|
||||
validation of the plan, 2026-11-17, R-17): `press.ts`, `escape.ts`,
|
||||
`missingFields.ts`, `polygonEdit.ts` and `pointSize.ts` under
|
||||
`apps/app/src/editor/annotations/` handle pointer and keyboard events, a UI
|
||||
form rule and interaction-rate preview arithmetic. Every end state goes
|
||||
through `sheet.edit` and the core's verdict; no core rule is copied.
|
||||
|
||||
---
|
||||
|
||||
|
||||
@@ -82,9 +82,9 @@ The criteria below are the contract as written.
|
||||
unchanged); `HistoryButtons.tsx` keeps its structure. Shortcuts unchanged: Ctrl/⌘+Z undo, Ctrl/⌘+Maj+Z redo
|
||||
(`apps/app/src/editor/useUndoShortcuts.ts:19-23`). Every prose string that names the history « Annuler » is
|
||||
reworded; dialog « Annuler » buttons untouched.
|
||||
- « Désélectionner »: a secondary button beside « Supprimer » (`PropertiesPanel.tsx:257-284`), shown while an
|
||||
- « Désélectionner »: a secondary button beside « Supprimer » (`PropertiesPanel.tsx:257-284`, removed at U2: the strip's `SelectionCommands.tsx` holds it), shown while an
|
||||
annotation is selected, in read-only modes too (selection is interface state); it dispatches the existing
|
||||
« no selection » path that « Toutes les annotations » uses (`PropertiesPanel.tsx:93-108`).
|
||||
« no selection » path that « Toutes les annotations » uses (`PropertiesPanel.tsx:93-108`, removed at U2).
|
||||
- Escape: today a tracing consumes it when the canvas box has focus (`usePlacement.ts:82`), the references panel
|
||||
when not already handled (`ReferencesPanel.tsx:234`), dialogs natively (`ModalDialog.tsx:111`). One handler on the
|
||||
workspace, at the bubbling phase, deselects only when `event.defaultPrevented` is false, no dialog is open, no menu
|
||||
|
||||
@@ -317,8 +317,9 @@ défaite »). The text below is the historical record.
|
||||
« Abandonner » or « Abandonner les modifications » for a form.
|
||||
- Applied at U1 and later:
|
||||
- history command: the header button keeps the drawn icon and short label of the approved boards; its accessible
|
||||
name and tooltip are « Annuler la dernière modification » (EN « Undo the last change », proposed); the toast
|
||||
after a gesture undoes the same entry under the same name;
|
||||
name and tooltip are « Annuler la dernière modification » (EN « Undo the last change », proposed); the message
|
||||
line's « Défaire » after a gesture (U2, replacing the toast) undoes the same entry under the same name. The shipped
|
||||
FR name since R1 (D5) is « Défaire la dernière modification » (`editor.history.undo_title`);
|
||||
- leaving a staged form without applying it (board 02 pending point, board 07 states, board 08 rectangle, board 09
|
||||
regions): « Abandonner »;
|
||||
- returning the draft to its last saved revision (level-1 C11, today `editor.draft.discard` « Annuler les
|
||||
@@ -343,7 +344,7 @@ défaite »). The text below is the historical record.
|
||||
drawing's shapes and curve drawing are level 2 (contract §8.3).
|
||||
- Journeys that meet a path: display by the core layer; the attach repair returns a path unchanged and keeps the
|
||||
attach refused, document unchanged byte for byte (`repair.ts:55-69`, blocked ids `95-100`, C45, `editor-geometry.spec.ts:317`);
|
||||
« Remplacer par un polygone » (`PropertiesPanel.tsx:138`, contract §8.3).
|
||||
« Remplacer par un polygone » (`PropertiesPanel.tsx:138` before U2, now the strip (`SceneStrip.tsx`) and `redraw.ts`, contract §8.3).
|
||||
- Not inspected: the database contents of DEV and of the sandbox (docs-only brief, no query run). A path there can
|
||||
only come from a direct RPC save or a test fixture. Before the new model is activated on an environment (its U6
|
||||
write lock lifted there), and before U6 or U8 reaches any environment beyond the throwaway sandbox, a read-only
|
||||
|
||||
@@ -56,7 +56,7 @@ used for delete confirmations. BDR-031 already rejected an `annotation_finding_m
|
||||
### 1.3 What the editor and the core already offer
|
||||
|
||||
- Editor: one `selectedId` on the canvas (`app/editor/annotations/uiState.ts:14-67`), one marked annotation
|
||||
(`useCanvasBuild.ts:70-83`); « Zone de constats » select in the annotation properties (`AnnotationFields.tsx:162-187`)
|
||||
(`useCanvasBuild.ts:70-83`); « Zone de constats » select in the annotation properties (`AnnotationFields.tsx:162-187` at the time, since U2 `AnnotationEditForm.tsx`, `finding_zone_id`)
|
||||
and at creation (`CreationFields.tsx:141-161`); the Constats tab as an ARIA tree over `buildItems`
|
||||
(`app/editor/findings/tree.ts:161-196`), creation of zones, families and findings (`FindingCreateForm.tsx`); no search,
|
||||
no filter, no link between the two tabs; the Annotations tab cannot create a finding zone.
|
||||
@@ -96,7 +96,7 @@ No integration point has to be added to U1, and no amendment of the U1 plan is p
|
||||
are already in the plan:
|
||||
|
||||
- `navigate(target)` with `zone`, `finding` and `annotation` keys (`targetOfKey`, U1 plan §1) gives both directions of
|
||||
the jump; `PropertiesPanel` receives `navigate` from Lot B1 (its unmeasured-view link is retargeted there).
|
||||
the jump; the annotation dialog and the strip receive `navigate` from Lot B1 (the strip's unmeasured-view link is retargeted there; `PropertiesPanel` was removed at U2).
|
||||
- The Constats tab stays mounted (U1 plan §2), so search and drawing filters survive tab changes without any store.
|
||||
- `usePlaceVisible()` and the « one composed copy of a view » rule (U1 plan §2) cover the filter panel's drawing: it
|
||||
detaches while its place is hidden, and the Annotations drawing is hidden while Constats is shown.
|
||||
@@ -133,14 +133,14 @@ before U3, with its own contract, tests and checkpoint, on its own owner authori
|
||||
Not started.
|
||||
|
||||
- Why after U2: U2 rewrites the selection, pointer and keyboard model of the same canvas and the same
|
||||
`PropertiesPanel`; the Constats segment sits in that panel and the drawing filter reuses the pointer rules
|
||||
properties (`AnnotationDialog.tsx` since U2); the Constats segment sits in that dialog and the drawing filter reuses the pointer rules
|
||||
(§2 G of the UX plan: a second pointer cancels, arrows pan only on the canvas box).
|
||||
- Why before U3-U6: none of them changes the zone link or the findings tree; U3 and U6 touch `AnnotationFields`
|
||||
- Why before U3-U6: none of them changes the zone link or the findings tree; U3 and U6 touch `AnnotationEditForm`
|
||||
(colour, roles, region picker), not the zone field nor the Constats tab; U4 and U5 add views, which the view chips
|
||||
list by construction; U6's internal `cat-access` and the detail triggers never carry findings, so they never appear
|
||||
as filter choices.
|
||||
- Alternative: after U6 (less rework risk in `AnnotationFields`, later delivery).
|
||||
- Files: `app/components/editor/annotations/{PropertiesPanel,EditableAnnotations,ConstatsSegment (new),
|
||||
- Alternative: after U6 (less rework risk in `AnnotationEditForm`, later delivery).
|
||||
- Files: `app/components/editor/annotations/{AnnotationDialog,AnnotationReadBody,EditableAnnotations,ConstatsSegment (new),
|
||||
ZoneLink (new)}.tsx`, `app/components/editor/tabs/FindingsTab.tsx`, `app/components/editor/findings/{FindingTree,
|
||||
FindingDetail,FindingContent,FindingCreateForm,FindingsSearch (new),SchemaFilterPanel (new)}.tsx`,
|
||||
`app/editor/findings/{tree,filter (new)}.ts`, `app/editor/annotations/zoneIndex.ts` (new), the canvas marking state,
|
||||
@@ -252,7 +252,7 @@ differ, the ratification brief prevails. Owner sentences are quoted verbatim. Th
|
||||
|
||||
| Id | Question | Boards | Alternatives | Recommendation | Technical consequences | State |
|
||||
|---|---|---|---|---|---|---|
|
||||
| F1 | Sub-step | 17-22 | (a) dedicated U2b after U2, before U3; (b) after U6: less rework in `AnnotationFields`, later delivery; (c) inside U2: one larger sub-step mixing gestures and findings | (a) | Own contract, tests (section 6) and owner checkpoint; depends on U1 (navigation, kept-mounted Constats tab, `folded`) and U2 (selection, pointer and keyboard model of the canvas and of `PropertiesPanel`); no Rust op, wasm budget unchanged; U3 to U6 unaffected (section 4); listed in `V1-2-6_UX_PLAN.md` §3 | approved: « F1 : placement U2b approuvé. » and « Retenir une sous-étape U2b « Annotations et constats », après U2 et avant U3, avec son propre contrat, ses tests et son checkpoint. » Implementation not authorised |
|
||||
| F1 | Sub-step | 17-22 | (a) dedicated U2b after U2, before U3; (b) after U6: less rework in `AnnotationEditForm`, later delivery; (c) inside U2: one larger sub-step mixing gestures and findings | (a) | Own contract, tests (section 6) and owner checkpoint; depends on U1 (navigation, kept-mounted Constats tab, `folded`) and U2 (selection, pointer and keyboard model of the canvas and of the annotation dialog); no Rust op, wasm budget unchanged; U3 to U6 unaffected (section 4); listed in `V1-2-6_UX_PLAN.md` §3 | approved: « F1 : placement U2b approuvé. » and « Retenir une sous-étape U2b « Annotations et constats », après U2 et avant U3, avec son propre contrat, ses tests et son checkpoint. » Implementation not authorised |
|
||||
| F2 | What the counters count | 17, 20, 21, 22 | (a) every finding node at any depth, groups included (boards: grasset 29, « restriction » 108 of 730); (b) leaves only, the findings a practitioner can tick (grasset 25, 81 of 627); (c) families or zones | (b), decided 2026-11-06 (was (a) in commit 567da67) | One counting function over `buildItems` for the segment, the search count, the filter count and, under F18 (a), the no-result count; a finding counts when it is a leaf (no children, the picker's test, `app/components/observation/FindingsTreePicker.tsx:35`); identity is the zone id and the node path, never the label, so a zone shown by several annotations counts once and two findings with the same label count twice (F8); the boards show (a) and stay as they are until U2b | approved: « F2 — Compter uniquement les feuilles sélectionnables de l'arbre des constats, sans les groupes intermédiaires. Les doublons dus à plusieurs annotations d'une même zone doivent être éliminés. » (second brief, completing « F2 : les compteurs portent sur les constats réels à toute profondeur, sans compter les conteneurs de familles et sans doublonner les constats associés à une même zone par plusieurs annotations. ») |
|
||||
| F3 | Search scope | 20 | Per field, language and word rule: section 7.2 | changed 2026-11-06: names of zones, families and findings at every level, French and English; a name match on a zone, family or group keeps everything under it; every typed word must match, in any order; descriptions, references, ids, annotation names, kind labels, status and flags not searched (7.2). Was: finding names in French and English, a zone name match showing all its findings, descriptions and references not searched | A page filter over `buildItems` and `folded` (no core op; same boundary as `filterCatalog`, BDR-043, BDR-095), memoised on the parsed document and the query; `folded` gains œ → oe, æ → ae and ’ → ' (7.2) at U2b, shared with the catalogue search (U1 Lot C only exports it); a row matched only in the other language shows its interface-language name and, beside it, the matched name | approved: « F3 — Recherche en français et en anglais, sur les noms des zones, familles, groupes et feuilles. Recherche insensible aux accents et à la casse. Tous les mots doivent correspondre, dans n'importe quel ordre, y compris lorsqu'ils apparaissent à différents niveaux de l'arbre. » (first brief: « F3 : recherche instantanée, insensible aux accents et à la casse. »). Details decided (ratification brief): « F3 : recherche normalisée entre catalogue et constats, avec équivalence œ/oe, æ/ae et apostrophes droites/typographiques. Une correspondance trouvée uniquement dans l'autre langue doit afficher aussi le libellé correspondant. » (interrupted brief: « F3 : harmoniser la recherche avec le catalogue. Équivalence œ/oe, æ/ae, apostrophes droites/typographiques, accents et casse. Si une correspondance n'existe que dans l'autre langue, afficher également le libellé correspondant. ») |
|
||||
| F4 | Drawing filter semantics | 21, 22 | Model A (facets, board 21) or model B (picks only): section 7.3 | changed 2026-11-06: model A with the rules of 7.3, decided (was: views give all their zones until a pick, text AND drawing, applied at each click) | Filter state = chosen views and picked annotation ids, held by the kept-mounted Constats tab; zone set derived at each render from the current document; text AND drawing; picked zones by union, each once; no core op | approved: « F4 — Valider le modèle A. Sans annotation cochée, les vues sélectionnées filtrent les zones représentées. Dès qu'une annotation est cochée, les zones explicitement sélectionnées déterminent le filtre anatomique. Combiner ce filtre avec la recherche textuelle par intersection. » (first brief: « F4 : filtres texte et anatomiques combinés par intersection ; plusieurs zones anatomiques sélectionnées produisent une union sans doublon. »). Rules of 7.3 that name F10, F16, F17 or F20 follow those decisions once taken |
|
||||
|
||||
@@ -64,7 +64,7 @@ Paths below are relative to the repository root. `core/` stands for `crates/core
|
||||
| Explicit save, unsaved state, conflict dialog with M8 | `editorSave.ts:43-149`, `DraftHeader.tsx:27-153`, `ConflictDialog.tsx:105-231` | REUSE |
|
||||
| Local recovery (sessionStorage, key user + version, revision in the record) | `recovery.ts:10-155`, `recoveryFlow.ts:56-187` | REUSE |
|
||||
| Pan, pinch, wheel, keyboard zoom | `app/catalogue/useFraming.ts:85-168` | REUSE, keys ADAPT |
|
||||
| Point and polygon move after 4 CSS px, one update on pointer-up | `useMoveGesture.ts:78-116`, `gesture.ts:5-33` | ADAPT (pointerId) |
|
||||
| Point and polygon move after 4 CSS px, one update on pointer-up | before U2: `useMoveGesture.ts:78-116`, `gesture.ts:5-33`; since U2: the press machine `press.ts` and `usePressGesture.ts` | ADAPT (pointerId) |
|
||||
| Point, zone and link creation by clicks | `creation.ts:93-178`, `usePlacement.ts:13-85` | ADAPT |
|
||||
| Geometry accept after commit | `app/editor/issues.ts:123-175` | REUSE |
|
||||
| Upload, cleaning, attach, repair | `drawingUpload.ts:86-192`, `repair.ts:60-309` | REUSE, attach ADAPT (remap) |
|
||||
@@ -156,7 +156,7 @@ Node `gzipSync(bytes, { level: 9 })` on the `pkg` build, re-measured on 2026-11-
|
||||
| Adding a role to `os`, `articulations`, `zone-colonne` suffices | `os` (Os / Bones) and `articulations` (Articulations / Joints) already carry the fixed names; only `zone-colonne` (Segments vertébraux / Vertebral segments) differs. Three equine annotations carry an own colour that overrides any category setting |
|
||||
| Not covered | A detail view without an access is a `view.unreachable` **error** (`core/domain/sheet/validate.rs:199-220`): it blocks the fingerprint, the snapshot and publication. Under choice 6 an access not created automatically must be placed before submission |
|
||||
| Recovery keyed by version and revision (contract C13) | Key = user + version; the revision is a field of the record (`recovery.ts:47-49`). Code and contract text differ |
|
||||
| `useMoveGesture` has a weak pointerId check | It has none (`useMoveGesture.ts:87`): a second finger feeds the drag while the pinch zooms |
|
||||
| `useMoveGesture` has a weak pointerId check | It had none (`useMoveGesture.ts:87`, removed at U2): a second finger fed the drag while the pinch zoomed. The press machine cancels the press on a second pointer |
|
||||
|
||||
### 1.8 SQL, RLS and worker
|
||||
|
||||
@@ -375,10 +375,10 @@ so it can start without a new study:
|
||||
panning (the browser reads `touch-action` at touchstart, `useCanvasGestures.ts:73-83`).
|
||||
- Redraw: the old shape stays drawn and committed until the new trace closes and is accepted; Escape or a refusal
|
||||
keeps the old one. One undo entry.
|
||||
- Undo and redo: one entry per accepted commit, whatever the tab; header buttons, shortcuts and the toast call the
|
||||
same `undo()`. The toast is dismissed by any commit, undo or redo, stays until then or until closed, is reachable
|
||||
by keyboard, and its message is in a live region. Sliders (point size, opacity) and arrow moves commit on release,
|
||||
Enter or blur only (BDR-050), so a keyboard walk never floods the 8 MiB history (about 20 entries of the equine
|
||||
- Undo and redo: one entry per accepted commit, whatever the tab; header buttons, shortcuts and the message line's
|
||||
« Défaire » call the same `undo()`. The message (under the drawing, not a toast) closes after 6 s or on any commit,
|
||||
undo or redo, is reachable by keyboard, and sits in a live region. Sliders (point size, opacity) and arrow moves commit on release,
|
||||
Enter or blur only (BDR-050), so a keyboard walk never floods the 8 MiB history (about 47 entries of the equine
|
||||
document).
|
||||
- Keyboard: roving focus inside a shape (Tab enters the shape, arrows between handles when the handle list is
|
||||
focused, then move the chosen handle in « move » state), Shift ×10, Insert or the visible « + » button, Delete or
|
||||
@@ -462,7 +462,7 @@ Status: implemented on `feature/v1-2-anatomical-sheets` (lots A to H; Lot I, gat
|
||||
Annotations; References as a side panel from the header or a finding; Undo and Redo in the header on every tab;
|
||||
sidebar hidden in the editor below 1 280 px with the menu one tap away; « Aller à » retargeted.
|
||||
- Files: `app/editor/tabs.ts`, `EditorTabs.tsx`, `EditorTabBody.tsx`, `DraftHeader.tsx`, `components/editor/tabs/*`,
|
||||
`app/editor/verification.ts:64-131`, `PropertiesPanel.tsx:169`, `components/shell/AppLayout.tsx:72-123`,
|
||||
`app/editor/verification.ts:64-131`, `PropertiesPanel.tsx:169` (removed at U2), `components/shell/AppLayout.tsx:72-123`,
|
||||
`ToolColumn.tsx`, i18n.
|
||||
- Dependencies: U0, T11 (ratified: level-1 trial stopped, level 1 not declared validated, residuals tracked), T15
|
||||
(ratified: header undo named « Annuler la dernière modification », C11 relabelled « Abandonner les
|
||||
@@ -478,16 +478,25 @@ Status: implemented on `feature/v1-2-anatomical-sheets` (lots A to H; Lot I, gat
|
||||
|
||||
### U2 · Direct manipulation of points and polygons
|
||||
|
||||
- Objective: boards 02 to 06 and 13 for points and polygons (curve handles excluded, curves lot): point move and size
|
||||
slider snapping to the radii of the view with the red minimum mark; vertex drag; « + » per segment; « − » on the
|
||||
chosen vertex; zone drag directly with the mouse once selected, explicit « Déplacer la zone » mode by touch; redraw
|
||||
keeping the old shape until accepted; 44 px touch handles; pointer rules and keyboard of §2 G; the toast;
|
||||
coordinate fields leave the normal journey.
|
||||
- Files: `AnnotationOverlay.tsx` (interactive handle layer), `EditableAnnotations.tsx`, `GeometryGroup.tsx`,
|
||||
`PropertiesPanel.tsx`, `TracingBar.tsx`, `ToolColumn.tsx`, `KeyboardAdd.tsx`, `useMoveGesture.ts`, `gesture.ts`,
|
||||
`geometryEdit.ts`, `usePlacement.ts`, `useCanvasGestures.ts`, `app/catalogue/useFraming.ts`, a toast in
|
||||
`components/ui`; core: `anatomy/frame.rs` and `domain/sheet/preview.rs` (per-view minimum visible radius in
|
||||
`PreviewState`), types and wrapper.
|
||||
- Status: implemented on `feature/v1-2-anatomical-sheets` (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, Tasks 1
|
||||
to 9; gates and owner checkpoint, Task 10, pending). The boards are `docs/design/v1-2-6-u2/` (A1 to A15 and the three
|
||||
adjustments, validated 2026-11-17).
|
||||
- Objective: boards 02 to 06, 13 and 31 to 33 of `v1-2-6-u2/` for points and polygons (curve handles excluded, curves
|
||||
lot): point move and size slider snapping to the radii of the view with the red minimum mark; vertex drag; « + » per
|
||||
segment; « − » on the chosen vertex; zone drag directly with the mouse once selected, explicit « Déplacer la zone »
|
||||
mode with four arrow buttons (A11); redraw keeping the old shape until accepted; creation by placing and tracing;
|
||||
44 px touch handles and a loupe; two-finger pan with its hint (A13); pointer rules and keyboard of §2 G; a message
|
||||
line under the drawing with « Défaire », 6 s, in place of the toast (A14); the properties and creation dialogs over
|
||||
the right column (A1, A2); nothing lost without a question (A12); coordinate fields leave the normal journey (A8).
|
||||
- Files: new `editor/annotations/{press,polygonEdit,pointSize,escape,missingFields,workStore}.ts`,
|
||||
`components/editor/annotations/{EditStrip,GestureMessage,SizeSlider,MoveModeBar,HandleLayer,Loupe,AnnotationDialog,
|
||||
AnnotationReadBody,AnnotationEditForm,CreationDialog}.tsx`, `e2e/support/layout.ts`; changed
|
||||
`AnnotationOverlay.tsx`, `EditableAnnotations.tsx`, `usePlacement.ts`, `useCanvasGestures.ts`, `gesture.ts`,
|
||||
`geometryEdit.ts`, `app/catalogue/useFraming.ts` (`twoPointerPan`, opt-in), `components/ui/Dialog.tsx` (`anchor`),
|
||||
navigation, history and leave guards; removed `TracingBar.tsx`, `CreationPanel.tsx`, `PropertiesPanel.tsx`,
|
||||
`AnnotationFields.tsx` and `useMoveGesture.ts` (`GeometryGroup.tsx` stays for `RepairDialog`); core:
|
||||
`anatomy/frame.rs` and `domain/sheet/preview.rs` (per-view minimum visible radius in `PreviewState`), types and
|
||||
wrapper. The full list is the plan's « File Structure ».
|
||||
- Dependencies: U1.
|
||||
- Rust ops: one read-only value (minimum visible radius per view, from the `marker_too_small` threshold,
|
||||
`frame.rs:67`, `220`), so the page draws the mark without a TypeScript size rule (BDR-043, C32).
|
||||
@@ -504,9 +513,9 @@ Status: implemented on `feature/v1-2-anatomical-sheets` (lots A to H; Lot I, gat
|
||||
Source: owner brief of 2026-11-14, applying to annotations the principle R2 uses for findings and references.
|
||||
Properties and forms live in modal dialogs; geometry stays a direct manipulation on the drawing. The gestures
|
||||
validated for U2 stay binding: vertex drag, « + » on a segment, « − » on a vertex, zone move, redraw, a point's
|
||||
properties. Status: orientation for the U2 design and plan. U2 is not started; its contract, boards and code wait for
|
||||
the U2 planning and its owner gate. Where the objective above says `PropertiesPanel.tsx` or a side panel, this
|
||||
orientation replaces it with a dialog.
|
||||
properties. Status: orientation for the U2 design and plan. U2 has since been planned and built (Status above).
|
||||
The first objective written for U2 named `PropertiesPanel.tsx` and a side panel; this orientation replaced them
|
||||
with a dialog, and U2 built it that way.
|
||||
|
||||
What goes where:
|
||||
|
||||
@@ -562,8 +571,8 @@ choices waiting for the owner, including deviations from rules 1 and 6 above (fi
|
||||
|
||||
Owner validation 2026-11-17: the redrawn boards and arbitrations A1 to A15 are validated as recommended (A1 to A3
|
||||
deviations included), with three adjustments for the implementation (two-finger pan hint, A13; no layout shift from
|
||||
the message line, A14; validation messages naming only missing fields, board 33). U2 planning starts; U2 code waits
|
||||
for the owner's approval of the U2 plan.
|
||||
the message line, A14; validation messages naming only missing fields, board 33). The U2 plan (rev 3) was validated the same day and
|
||||
its code is written; the owner tries it before U2 closes.
|
||||
|
||||
Risks to settle in the U2 plan: the slop threshold for touch versus mouse; a dialog opened by a tap at a canvas edge
|
||||
on a tablet; focus return after « Modifier la forme »; the ghost's contrast under the backdrop; the handle cap (T18)
|
||||
@@ -593,7 +602,7 @@ with a dialog open.
|
||||
the candidate document on the preview handle, the store commits one batch on Apply, Cancel restores), delete when
|
||||
unused, « Réaffecter à… » when a delete is refused (one batch of annotation updates, one undo entry); own colour of
|
||||
an annotation shown only when set, with « Revenir à la couleur de la catégorie »; new annotations inherit.
|
||||
- Files: `components/editor/general/CategoriesSection.tsx` (moved), `AnnotationFields.tsx:96-104`,
|
||||
- Files: `components/editor/general/CategoriesSection.tsx` (moved), `AnnotationEditForm.tsx` (it replaced `AnnotationFields.tsx` at U2),
|
||||
`AnnotationList.tsx:53-73`, `editorEdit.ts` (preview without commit), i18n.
|
||||
- Dependencies: U1.
|
||||
- Rust ops: none.
|
||||
@@ -715,7 +724,7 @@ with a dialog open.
|
||||
letting a path enter a document. Kept here so it can start without a new study.
|
||||
- Objective: board 05 curve handles (§2 D), curved zone move, remap of paths, the C45 refusal replaced by real
|
||||
correction (with the path point-correction proposal `.claude/tasks/plans/2026-11-04-v1-2-6-path-repair-core-proposal.md`).
|
||||
- Files: core `anatomy/path.rs`, `ops.rs`, types, wrappers; app `AnnotationOverlay.tsx`, `useMoveGesture.ts`,
|
||||
- Files: core `anatomy/path.rs`, `ops.rs`, types, wrappers; app `AnnotationOverlay.tsx`, `usePressGesture.ts`, `useZoneEdit.ts`,
|
||||
`repair.ts:60-100`; SQL round-withdrawal migration (the path reader feeds the frame and interior verdict rules,
|
||||
`frame.rs:25`, `interior.rs:23`); `RUST.md`.
|
||||
- Dependencies: U2, U5; T1 (a lever is certain); its own owner authorisation.
|
||||
@@ -769,7 +778,7 @@ robustness CONCERNS(9), simplicity CONCERNS(6); no BLOCKER. Integrated:
|
||||
- Remap: the seed head drawing has the crop's exact `viewBox`, so the remap is an explicit choice, never automatic;
|
||||
returned as a command batch through `commitBatch`; descendant crops and paths refused with closed codes.
|
||||
- Pointer and keyboard: second pointer cancels the drag; pending previews cancelled before undo, redo, replacement
|
||||
or tab change; toast dismissed on any commit; sliders commit on release; `touch-action` on handle targets; roving
|
||||
or tab change; the message line closes on any commit; sliders commit on release; `touch-action` on handle targets; roving
|
||||
focus, Backspace, live region; touch tests at 1 024, 1 180 and 1 280 px; handle cap.
|
||||
- Sandbox safety: forbidden DEV-reaching SQL commands listed; image checked against `HEAD`; shared sandbox and
|
||||
owner-trial stack rules; owner demos on a provisioned demo sheet.
|
||||
|
||||
@@ -29,7 +29,7 @@ in the plan (§3, each sub-step's « Dependencies »); deploy order, write lock
|
||||
| R-19 | Sliders flood the history | M | M | commit on release or blur (T19); history depth test | U2, U6 |
|
||||
| R-20 | `touch-action` read at touchstart: a late change breaks one-finger handle drags | M | M | `touch-action: none` on handle hit targets and in move mode, box keeps pan | U2 |
|
||||
| R-21 | Oversized shapes render thousands of handles | L | M | handle cap (T18) | U2 |
|
||||
| R-22 | Keyboard gaps: no Insert or Delete on compact keyboards, Tab through every vertex, toast timing | M | M | Backspace and visible buttons, roving focus, persistent toast, live region | U2 |
|
||||
| R-22 | Keyboard gaps: no Insert or Delete on compact keyboards, Tab through every vertex, message timing | M | M | Backspace and visible buttons, roving focus, a message line (6 s, « Défaire », `role=alert` for a refusal), live region | U2 |
|
||||
| R-23 | Header undo after typing reverts the typing, not the previous action | M | L | flush the field first, pinned by a test | U1 |
|
||||
| R-24 | Large test rewrite hides lost coverage | M | M | each removed assertion mapped to its replacement; verifier checks the mapping | U1, U2 |
|
||||
| R-25 | Touch only tested in Chromium; WebKit and real tablets differ (LRN-108) | M | M | owner trial on a real tablet at U2 and U8 | owner |
|
||||
|
||||
@@ -50,17 +50,20 @@ Implemented (contract `.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md`)
|
||||
|
||||
## U2 · Points and polygons
|
||||
|
||||
Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 3; boards `docs/design/v1-2-6-u2/`, A1 to A15 and the three adjustments). Rule numbers (R-n) are the plan's. The owner trial and the gates (plan Task 10) are pending. The suites run on the sandbox only (`pnpm db:sandbox`).
|
||||
|
||||
| Kind | Tests |
|
||||
|---|---|
|
||||
| Unit (tables) | slider stops = distinct radii of the view; snapping; red mark from the core value; midpoint insert after the segment start; « − » disabled at 3 vertices with its reason (board 12 B); zone translation; nearest-handle priority; keyboard map (arrows, Shift ×10, Insert or Backspace or Delete, Enter, Escape, roving focus); arrows pan only when the box is focused; handle cap fallback |
|
||||
| Unit (state) | pending preview cancelled and restored on undo, redo, document replacement, tab change, second pointer; toast dismissed on any commit, undo or redo; slider commits once on release (history depth after a keyboard walk) |
|
||||
| Core | the per-view minimum visible radius equals the `marker_too_small` threshold on the equine views and on edge frames |
|
||||
| E2E mouse | drag a vertex, « + », « − », zone drag on a selected zone, redraw accepted, redraw refused by `interior_too_small` restores the old shape, undo and redo of each, toast « Annuler » undoes the same entry as the header; header button and toast action carry the accessible name « Annuler la dernière modification » (T15) |
|
||||
| E2E touch (`hasTouch`, 1 024, 1 180, 1 280 px) | one-finger handle drag; explicit « Déplacer la zone » mode; finger 1 on a vertex handle then finger 2 elsewhere: the pinch zooms, the drag is cancelled, no commit (CDP `Input.dispatchTouchEvent` with two points); page scroll over the canvas with a selection and outside it |
|
||||
| Keyboard | create a zone, add and remove a vertex, move the zone, validate, without a pointer; Ctrl+Z on a focused handle after arrow moves restores the pre-move shape |
|
||||
| Unit (tables) | the press machine (`annotations.press.test.ts`): slop per kind (4, 6 and 10 CSS px), click and drag decisions, handle priority (vertex over « − » over « + », nearest first), double click within 400 ms and 8 px opens the dialog and never inserts, a second pointer cancels; slider stops, most-used radius, snap within 8 CSS px, range (`pointSize`); midpoint insert after the segment start, « − » refused at 3 vertices (`message.vertex_min`), vertex move, no-op move, the 40-vertex cap, « + » hidden under two hit radii (`polygonEdit`); Escape action (`escape`); `missingFields` names only the missing fields in form order; keyboard map (arrows by 0.5 % of the frame's longer side, Shift ×10, Insert, Backspace or Delete, Enter, Escape, roving focus); arrows pan only when the box itself is focused (`useFraming`, catalogue defaults unchanged); two pointers translate without scaling (`twoPointerPan`) |
|
||||
| Unit (state) | every preview, keyboard series and chosen vertex carries the `documentText` it was computed on, and a stale stamp is refused (`annotations.workStore.test.ts`); a preview is cancelled and restored, never committed, on undo, redo, document replacement, tab change and a second pointer; an undo with a move mode, a slider or a series pending only cancels the preview (R-13); during a creation undo is inactive and « Défaire » is hidden (A12); the message line: « Point déplacé · Défaire » calls the same `undo()` as the header, any commit, undo or redo closes it, a refusal is `role="alert"` without « Défaire », 6 s, a mouse hover pauses it and a touch does not; the hint after a futile finger drag only when the line is free and never after a two-finger gesture worked (R-1); the slider commits once on release (history depth after a keyboard walk); the strip keeps a fixed height and truncates a long name before the status; dialogs mounted outside `EditOnly`: the width flip and the mode flip keep the draft, disable the save and commit nothing (R-14); a creation, a started move mode or a started redraw asks before a tab, a section, a view chip, a tool, Back, Escape, sign-out or leaving the editor, and a document change made elsewhere announces the dropped work (R-12, R-13); `Dialog` `anchor`, a click on the veil does nothing (R-6); undo history cap 8 MiB, about 47 equine steps (R-15) |
|
||||
| Core | the per-view minimum visible radius (`PreviewState.min_point_radius`) equals the `marker_too_small` threshold on the equine views and on edge frames (`sheet_preview.rs`, `editor-min-point-radius.test.ts`) |
|
||||
| E2E mouse | drag a vertex, « + », « − », zone drag on a selected zone, redraw accepted, redraw refused by `interior_too_small` keeps and restores the old shape, undo and redo of each (`editor-zones.spec.ts`); a point: handle drag, size by a click on the track, the move mode (`editor-annotations.spec.ts`); the properties dialog opens over the right column and never over the drawing, a click on the veil does nothing, a double click on the selected zone opens it and inserts no vertex, a typed form then Back asks, a width crossing below 1 024 px keeps the draft (`editor-properties.spec.ts`); « Défaire » in the message line undoes the same entry as the header button, which carries the accessible name « Défaire la dernière modification » (T15; EN « Undo the last change ») |
|
||||
| E2E touch (`hasTouch`, 1 024, 1 180, 1 280 px; CDP `Input.dispatchTouchEvent`) | one finger drags a vertex and the point under the loupe; every handle hit circle is at least 44 px; one finger off the handles moves nothing and shows the hint once, with no hint over a page scroll; two fingers zoom and pan; finger 1 on a vertex handle then finger 2: the drag is cancelled, the shape restored, nothing committed, the pinch zooms (Review Focus 1); the move mode by a finger; a tap on the selected shape opens the dialog and it stays open (Review Focus 5), with a chosen vertex it unchooses; the trace closes from a finger within 22 px; page scroll over the canvas with a selection and outside it (`editor-touch.spec.ts`, `editor-properties.spec.ts`, `editor-deselect.spec.ts`) |
|
||||
| Layout (A14) | `expectNoShift` (`e2e/support/layout.ts`) at 1 024, 1 180 and 1 280 px: no box of the canvas, the strip, the aside or the header moves, `scrollHeight` and the scrollbar gutter are unchanged, and the layout-shift sum is zero around selection, strip content, a message showing and expiring, the hint, a dialog opening and closing, mode entry and exit, and the first commit's save line; `scrollbar-gutter: stable` on the editor page only (`editor-annotations.spec.ts`) |
|
||||
| Keyboard | create a zone, add and remove a vertex, move the zone, validate, without a pointer; Ctrl+Z on a focused handle after arrow moves only cancels the preview and a later Enter commits nothing stale; after undoing « + », « − » never removes the wrong vertex; « Désélectionner » commits a pending series |
|
||||
| Paths (T16) | a path annotation gets no handle, no « + » or « − », no zone move in either mode, no keyboard move; its `d` is byte-identical after every gesture on its neighbours, a save and a reload; « Remplacer par un polygone » stays the only change: explicit, validated by the core, the path kept while tracing, on Escape and on a refusal; one undo entry restoring the exact `d`, redo restoring the polygon (owner, BDR-101) |
|
||||
| Accessibility | axe on selection, tracing and move states; handle names (« sommet 3 de Thoraciques »); live-region message after a move |
|
||||
| Performance | commit latency under the 500 ms budget (`editor-equine.spec.ts:25-34`) for drag, insert, remove |
|
||||
| Accessibility | axe on selection, tracing, move states and the dialog in read and edit modes; handle names (« Point {nom} », « Sommet {n} », « Ajouter un sommet après le sommet {n} », « Retirer le sommet {n} »); live-region message after a move; WCAG 2.5.7: the move mode with four arrow buttons is the single-pointer path without dragging (A11) |
|
||||
| Performance | commit latency under the 500 ms budget (`editor-equine.spec.ts`) for drag, insert and remove, measured at the gates (plan Task 10) on a run-seeded equine-sized draft, never on the historical copy; the drag smoothness is a measure, not an assertion (`e2e/support/measure-drag.ts`, `editor-measure-drag.spec.ts`, run by hand). Measured 2026-11-18 on a production build under `vite preview`, Chromium touch at 1 180 px, CPU ×4: frame work p95 4.2 to 4.7 ms with the loupe (technique A), 4.0 to 4.4 ms outline only (B), 3.6 to 4.2 ms without a loupe; technique A kept. The figures are in plan Task 8; the owner's tablet trial is the real check |
|
||||
|
||||
## U3 · Category panel and own colour
|
||||
|
||||
|
||||
@@ -2888,8 +2888,8 @@ configured from it (board 09), never in two places.
|
||||
« Refaire ». The paragraph below is the historical record.
|
||||
|
||||
**Wording (T15).** « Annuler la dernière modification » names the history
|
||||
command (header button, tooltip and accessible name, the toast after a
|
||||
gesture); « Abandonner » or « Abandonner les modifications » names leaving a
|
||||
command (header button, tooltip and accessible name, the message line's
|
||||
« Défaire » after a gesture, U2); « Abandonner » or « Abandonner les modifications » names leaving a
|
||||
form or discarding unsaved changes (level-1 C11).
|
||||
|
||||
**Open.** T1 (only if a measure exceeds the 600 000 B wasm budget), T6
|
||||
|
||||
Reference in new issue
Block a user