Commit Graph
435 Commits
Author SHA1 Message Date
bchanot 9386288ffd docs(docs): U2 held reason goes to the bubble on every tab 2026-11-19 23:55:20 +01:00
bchanot 481335f99a docs(docs): U2 final gate figures on 3d6aacad, review minors 2026-11-19 23:38:15 +01:00
bchanot 3d6aacad99 docs(docs): rev 5 owner decisions, trial steps and test notes 2026-11-19 21:15:41 +01:00
bchanot a9252375e1 fix(editor): bubble clears the strip's commands, announces through a steady region 2026-11-19 21:04:21 +01:00
bchanot 49f0144729 feat(editor): the held reason shows in a bubble by its button 2026-11-19 20:50:56 +01:00
bchanot 031826dced fix(editor): state the pinned column's window bounds; tidy its tests
The canvas is unchanged for browser windows of the three sizes, smaller
in shorter ones; below 644 px of window height nothing is pinned (CSS
comment, rendering doc, owner trial step 18). A page-top focus on the add
row reveals it below the strip; the geometry helper is split, long test
titles wrapped.
2026-11-19 20:40:02 +01:00
bchanot 36ed9f980b fix(editor): the drawing stays clear of the strip while the page scrolls
The drawing column (chips, tools, canvas, add row, message line) is
pinned under the strip from 1 024 px wide and 644 px high; the canvas
box is capped in width by the window height (4:3 kept, unchanged at the
three sizes); pinned controls carry no strip margin. The rev 4 test
workarounds go; the row-click scroll was Playwright's bring-into-view.
2026-11-19 20:19:26 +01:00
bchanot 9e03f1443a docs(docs): U2 plan file list, demo zone name, two owner choices, TODO 2026-11-19 19:04:25 +01:00
bchanot 56a76a70f8 docs(docs): U2 gate figures on the final code da8642dd 2026-11-19 18:45:11 +01:00
bchanot da8642dd44 docs(docs): focus margin under the top bar, « Redessiner » wording in the trial 2026-11-19 18:24:16 +01:00
bchanot 1ab3b6afba docs(docs): U2 gate figures on the final code f9656a0d 2026-11-19 17:48:53 +01:00
bchanot f9656a0d9b fix(editor): a focus left in a hidden panel counts as lost after a guarded press 2026-11-19 17:24:32 +01:00
bchanot 7cb1aee7a1 docs(docs): U2 status as built, trial measures and gate failures stated as proven 2026-11-19 17:17:16 +01:00
bchanot 8df52fd1be docs(docs): rev 4 gate figures on the final head 2026-11-19 16:45:32 +01:00
bchanot f5a6eafc7f fix(editor): zone handles remount per annotation so a row tap lands the focus 2026-11-19 16:21:14 +01:00
bchanot 6ad378b08b docs(docs): trial step 17 covers the overview rows 2026-11-19 16:16:30 +01:00
bchanot 0aa0f6bc62 docs(docs): rev 4 gate figures and the amended held-reason criterion 2026-11-19 15:44:25 +01:00
bchanot 448a17eff7 docs(docs): trial step 19 tool and the tapped tool's focus, pinned 2026-11-19 15:18:06 +01:00
bchanot b0344a4af6 fix(editor): no strip scroll margin on a dialog's controls 2026-11-19 15:18:05 +01:00
bchanot 462a22e74f docs(docs): rev 4 fix round: trial steps, held reasons, cited tests 2026-11-19 15:05:26 +01:00
bchanot 7a9ccf149c chore(editor): rev 4 leftovers: closeTrace returns nothing, doc reflow 2026-11-19 15:04:27 +01:00
bchanot 966ad4fe45 fix(editor): no focus in the drawing place lands under the strip
The scroll margin now covers every native focusable of the place (tools,
view chips, add buttons, the aside's controls), the strip's own commands
excepted, as a real Tab walk found them hidden (I-3). A vertex chosen
from the keyboard takes the focus with a scroll (M-1).
2026-11-19 14:58:19 +01:00
bchanot 05a8525455 docs(docs): rev 4 owner trial, UX tests and rendering notes 2026-11-19 14:13:59 +01:00
bchanot e341f03390 fix(editor): one focus marker on every handle, proven on an SVG vertex 2026-11-19 12:32:27 +01:00
bchanot 399a5adae6 fix(editor): focus margin on the strip's targets, not a page padding 2026-11-19 12:24:34 +01:00
bchanot f2809f20ca fix(editor): the strip stays below the top bar on scroll 2026-11-19 12:15:52 +01:00
bchanot c01c6f3145 fix(editor): resumed shape names and minor review fixes
- French fallback names: « cette nouvelle zone », « ce nouvel accès »
  (controller ruling: « Sommets de ce nouvel accès »); doc updated.
- useZoneHandle back to 5 locals.
- dropPending clears the strip hint as a kept stored change does.
- Tests: the chosen vertex cleared by finishCreation itself (document
  unchanged) and by a view change through the guard; both fail
  without their clearing.

Changed assertions, editor-creation-dialog.test.tsx:
- « Sommets de la nouvelle zone », « Sommet 1 de la nouvelle zone »
  -> « … de cette nouvelle zone » (ruling)
- « Sommets de le nouvel accès » -> « Sommets de ce nouvel accès »
- chosen null after « Créer » (cleared by the document change, not
  discriminating) -> « the chosen vertex ends with a finished
  creation, the document unchanged »
2026-11-19 09:49:27 +01:00
bchanot a5896710e5 feat(editor): resumed trace edits the closed shape with its handles
« Reprendre le tracé » keeps the pending shape closed; the zone handles
(vertex, « + », « − », vertex keys) edit it through the same press path
and useZoneEdit, the target generalised to points + drop. A drop on
PENDING_ID patches creation.pending only: document, history and unsaved
count untouched, message without « Défaire ». Strip: « Tracé repris,
saisie gardée » with « Revenir aux propriétés » and « Abandonner ».
Handle names fall back to « la nouvelle zone » / « le nouvel accès ».

Removed (resumed branch of popVertex, backToProperties -> closeTrace,
CreationCommands tracedCount and its « Retirer le dernier sommet »).

Removed assertions, editor-creation-dialog.test.tsx, « keeps the
vertices and the form; a new vertex, then the dialog again »:
- strip « Tracé repris, saisie gardée » -> kept in « keeps the shape
  closed and the form, shows its handles; two strip commands »
- « Retirer le dernier sommet » enabled -> absent; commands are exactly
  « Revenir aux propriétés », « Abandonner » (same test)
- a click on the drawing adds a 4th vertex -> « a click off the handles
  adds and selects nothing; a double « + » inserts once »
- dialog again with Nom (FR) « Tibia » -> « « Revenir aux propriétés »
  shows the edited shape; « Créer » inserts it »
- « Zone tracée, 4 sommets » -> « Zone tracée, 5 sommets » after « + »
  (same test)
2026-11-19 09:42:58 +01:00
bchanot 04d083ff85 docs(docs): U2 gate note gives the batch count for catalogue-integrity 2026-11-18 15:19:56 +01:00
bchanot 08458b6971 docs(docs): U2 gate notes name the serial skip and one-worker run 2026-11-18 15:00:14 +01:00
bchanot 4e2bdb5ebb docs(docs): U2 final gate results and measures on 15b23f8
UX_TESTS: gates at 15b23f8 (check:all passed; shell suite 311 passed, 14 failed, red; test 105 passed; test-db FAIL 014/021 as before U2), measures rerun, keyboard map row (Backspace only while tracing). Plan Tasks 8 and 10 and OWNER_TRIAL Mesures carry the new figures.
2026-11-18 14:54:24 +01:00
bchanot 15b23f8420 docs(docs): U2 redo hold as built and owner trial choices
UX_TESTS: redo is held while a move, a redraw or keyed steps are pending (ae80511), the message line also pauses under keyboard focus. OWNER_TRIAL 4.17: greyed redo, Mac keys (M-7), focus hold, focus back to the page after a touch or Safari commit, the new handle names.
2026-11-18 14:14:33 +01:00
bchanot b6aa2819ea fix(editor): name vertex handles after their zone, in a named group
Criterion 18: « Sommet {n} de {nom} », « Ajouter un sommet après le sommet
{n} de {nom} », « Retirer le sommet {n} de {nom} » (EN « Vertex {n} of
{name} » …), {nom} the zone's display name in the current locale; the
handle group is a role="group" named « Sommets de {nom} ».

Tests: no assertion removed; every unit and e2e locator that read the old
names now reads the same handle with the zone name appended (fixtures: N,
Vertèbres thoraciques, Zone dessinée, Zone clavier). New unit tests in
editor-zone-edit cover the FR names, the group and the EN locale.
2026-11-18 14:09:24 +01:00
bchanot 9e1ec4479d fix(editor): name a moved link « Link moved » in English
Final review M-1: the kind is « Link » everywhere else (« Link redrawn »,
« Link created »). The owner trial's string list follows.
2026-11-18 13:00:10 +01:00
bchanot c6b8c7e48a docs(docs): U2 owner trial section and gate figures
OWNER_TRIAL §4.17: db:trial preparation, mouse and tablet steps, visible choices to judge, invented strings, known limits, measures. Plan Task 10 Step 3 and UX_TESTS performance row: commit latency figures. CLAUDE.md cites the two hand-run measure specs.
2026-11-18 12:20:49 +01:00
bchanot e603de39e8 docs(docs): history undo name follows D5 in U2 tests and plan 2026-11-18 11:25:42 +01:00
bchanot 6e42d2ada1 docs(docs): U2 tests, plan, rendering and Rust review aligned 2026-11-18 11:23:22 +01:00
bchanot 3a7715486b docs(docs): what changes per move under the loupe 2026-11-18 00:33:02 +01:00
bchanot d39603ab6a docs(docs): the touch loupe in the editor overlay contract 2026-11-18 00:18:14 +01:00
bchanot 87528303a1 docs(docs): editor overlay creation ghost, point preview, dimming
The creation moves onto the drawing (U2 Task 7): the point tool's
hover preview, the ghost in the form's category colour on a white
halo, and data-creating dimming the other markers (A2, A4, A12).
2026-11-17 22:55:14 +01:00
bchanot 316d8c475c docs(docs): the « − » bubble is a rounded rectangle, no stem 2026-11-17 20:59:19 +01:00
bchanot ba8e766fe8 docs(docs): editor overlay zone handles, cap, redraw old outline 2026-11-17 19:33:14 +01:00
bchanot 463e0a2621 fix(editor): guard keeps pending series, mode end said, R-9 hook
- guardDrawing commits a keyboard or size series the focus still holds
  (its blur) and ends only the mode: a pending series is never dropped.
- A started move ended by a selection change is said (R-13).
- handleSize: no module-level state; useHandleSizes reads the device
  once per handle layer. The layer reads ResizeObserver contentRect.
- Dead kind check removed in SelectionPointCommands; long lines wrapped
  (code, doc).
- e2e: the zoom check waits for the transform to change; the move-mode
  arrow clicks are under expectNoShift.
2026-11-17 19:25:04 +01:00
bchanot 44de465c6d fix(editor): no silent move loss, no empty commit, focus kept
- « Toutes les annotations » in the properties panel asks the drawing
  guard before it drops a started move (R-12); tests also cover a tool
  and « Ajouter un point ».
- A keyboard series back on its place, or a slider pinned at its stop,
  commits nothing.
- Escape that deselects from the handle or the slider moves the focus to
  the row (or the drawing) instead of losing it.
- A link circle keeps its handle, named « Accès {nom} », with no slider
  and no move mode (no label for it in REVUE).
- The move-mode drop notice waits until the body is shown (R-14).
- No layout shift: the strip's lead has a fixed width, the commands and
  the message pill get a new box per set or message.
- Doc: hit shapes use pointer-events auto; the fine « − » bubble is
  board 05's size.
- Tests: R-14 flip, A5 through the Point tool click, the repair e2e
  wrapped in expectNoShift.
2026-11-17 19:08:08 +01:00
bchanot 9d03e0675c docs(docs): editor overlay handle layer, handle sizes and gesture marks
Step 1 of U2 Task 4: the handle layer as its own focusable svg, R-9 sizes,
the chosen vertex, the old place, the refused place and the move-mode target.
2026-11-17 18:17:49 +01:00
bchanot 5ca2b7e3ad feat(domain): per-view minimum point radius in preview state
PreviewState.min_point_radius maps a view id to the smallest point
hitbox radius that passes TooSmall on the smallest preview, so the
sheet editor can mark it on a size slider. Twin constants named in
layer.rs; frame.rs shares one first-view drawing lookup.
2026-11-17 16:33:40 +01:00
bchanot 29073a956b docs(docs): U2 boards and A1-A15 validated by owner, three adjustments, BDR-122 2026-11-17 15:34:46 +01:00
bchanot 272a7b54e4 docs(docs): U2 boards re-check fixes, A15, notes aligned, owner gate 2026-11-17 13:26:33 +01:00
bchanot 8bdb23ab0f docs(docs): U2 boards review fixes, arbitrations A11-A14, controls recorded 2026-11-17 13:13:02 +01:00
bchanot bc19481b93 docs(docs): V1-2.6 U2 boards 02-06, 13, 31-33, review and arbitrations 2026-11-17 12:54:12 +01:00