Commit Graph
298 Commits
Author SHA1 Message Date
bchanot 826e5fbcaa fix(i18n): restore dictionary layout, keep only the Task 5 keys
The formatter run of 6211046 rewrote the layout of fr.ts and en.ts
(quotes, line breaks): an unrelated diff. Both files are back to their
previous layout; the 19 keys Task 5 adds are kept as written.
2026-11-17 20:25:43 +01:00
bchanot 6211046537 feat(editor): vertex handles, insert and remove, zone move, redraw
U2 Task 5. A selected polygon gets its vertex, « + » and « − » handles
(R-9, hidden « + » under two hit radii, R-18 zoom hint in the strip),
the handle cap at 40 (R-7), vertex drag and keys, the move mode on the
zone or the chosen vertex, « Redessiner » as a redraw mode kept in step
with its tracing (R-12 guard, R-13 drop), close radius in CSS px
(R-11). The numeric group leaves the properties panel (D1).

Removed or rewritten assertions (numeric group -> replacement):
- tab « shows its exact stored numbers » (Centre x field) -> the overlay
  selection circle's cx attribute, same exact value.
- tab « a numeric edit » x3 -> « an edit on the drawing »: Enter on the
  handle without a step commits nothing, a step + Enter commits once;
  a refused handle drag keeps the stored shape then a drag inside the
  frame repairs it (issues gone); Escape drops a pending series.
- tab C26 « Centre x 15 » -> overlay cx 15.
- tab C32 unmeasured « Centre x as text » -> no handle, no field.
- tab « adds and removes a vertex as part of the whole group » -> « + »
  then « − » on the drawing; « never offers to remove below three » ->
  « − » aria-disabled at 3.
- tab H8 « refused Remplacer drops the tracing » -> keeps it open with
  « Fermeture refusée » (board 33 A); « refused vertex add/remove stay
  non appliqué » -> a refused vertex drag restores the shape exactly.
- tab Désélectionner and D6b (typed Centre x committed, refused, undone)
  x6 and strip « a new commit replaces the message » -> the same with
  the Nom (FR) field (a blank name is the refused value).
- focus-request « Centre x 20 » -> overlay cx 20.
- escape « strip commands keep their Escape » -> a redraw: Escape on the
  strip or the box cancels it (R-12 row 4); kept for a new zone tracing.
- keep-alive « Remplacer tracing kept across Aller à » -> ended by a tab
  when empty, asked once a vertex is placed (R-12).
- e2e annotations: numeric cx edit + undo/redo -> handle keys + undo/
  redo; jitter/drag and Task 4 point reads -> overlay attributes (the
  stored place during the mode -> overlay-old-place); keyboard-only cy
  and vertex x typed -> handle and vertex keys.
- e2e deselect: Centre x typed/refused/committed -> Nom (FR).
- e2e geometry, shell-crossing: Centre x/cy reads -> overlay attributes.
- e2e journey: cx +3 and vertex x +4 typed -> 3 and 4 arrow steps + Enter;
  a far typed value + revert -> a far handle drag refused.
- e2e equine latency: typed cx rounds -> handle arrow + Enter rounds.
2026-11-17 20:24:49 +01:00
bchanot 463e0a2621 fix(editor): guard keeps pending series, mode end said, R-9 hook
- guardDrawing commits a keyboard or size series the focus still holds
  (its blur) and ends only the mode: a pending series is never dropped.
- A started move ended by a selection change is said (R-13).
- handleSize: no module-level state; useHandleSizes reads the device
  once per handle layer. The layer reads ResizeObserver contentRect.
- Dead kind check removed in SelectionPointCommands; long lines wrapped
  (code, doc).
- e2e: the zoom check waits for the transform to change; the move-mode
  arrow clicks are under expectNoShift.
2026-11-17 19:25:04 +01:00
bchanot e01d8519ea fix(editor): sign-out and shell links ask the drawing guard first
With a started move, sign-out and an in-app link now ask « Abandonner
le déplacement ? » (R-12) through the page's own question, registered by
the draft route in leaveGuardStore (`ask`; the shell imports no editor
module). The generic leave and sign-out dialogs cover only sheet-level
unsaved work; with both pending the drawing asks first, then the sheet
question, as useLeaveConfirm orders them. A move with nothing started
arms nothing (it ends); a started one still guards a reload.

Tests: sign-out and link with a started move (alone and with sheet
changes), the history jump with only a move and after dirty layers, a
section entry and « Tout afficher ».
2026-11-17 19:25:04 +01:00
bchanot 44de465c6d fix(editor): no silent move loss, no empty commit, focus kept
- « Toutes les annotations » in the properties panel asks the drawing
  guard before it drops a started move (R-12); tests also cover a tool
  and « Ajouter un point ».
- A keyboard series back on its place, or a slider pinned at its stop,
  commits nothing.
- Escape that deselects from the handle or the slider moves the focus to
  the row (or the drawing) instead of losing it.
- A link circle keeps its handle, named « Accès {nom} », with no slider
  and no move mode (no label for it in REVUE).
- The move-mode drop notice waits until the body is shown (R-14).
- No layout shift: the strip's lead has a fixed width, the commands and
  the message pill get a new box per set or message.
- Doc: hit shapes use pointer-events auto; the fine « − » bubble is
  board 05's size.
- Tests: R-14 flip, A5 through the Point tool click, the repair e2e
  wrapped in expectNoShift.
2026-11-17 19:08:08 +01:00
bchanot 91e94952f0 feat(editor): point handle, size slider with core minimum, move mode
HandleLayer: its own svg over the overlay, not aria-hidden; the selected
point (or link circle) gets a focusable « Point {nom} » handle whose hit
circle (data-handle) the press machine reads, sized in CSS px under zoom
(R-9, read once from any-pointer: coarse). The Task 2 stand-in (the
selected marker as its own handle) is removed.

Keys on the handle: arrows step 0.5 % of the frame (Shift x10) as a
stamped series, Enter or blur commit once, Escape drops it (R-11, R-13).
SizeSlider in the strip for a selected point and for the Point tool (A5):
the view's sizes as ticks, the core minimum as a red mark, snap 8 px,
arrows 1 %, Page Up/Down next size, one commit on release, Enter or blur;
a refusal restores the size and draws the refused place in red dashes.
« Déplacer le point » opens the move mode (board 06 B): drag anywhere or
four arrows move a preview only, clicks select nothing, « Valider la
position » commits once, « Annuler » and Escape restore; the focus comes
back to the button. Escape follows board 32 (escapeAction). The overlay
reads the preview from the work store and draws the old place in grey
dashes. Ctrl+Z now also works from a slider (not a text field).

Rewritten assertions:
- editor-annotations-tab « a finger drags the selected point »:
  drag(marker('anno-a')) -> drag(pointHandle()), same expected geometry.
- editor-geometry.spec « a point inherited out of its frame is repaired
  through the geometry group » (cx/cy typed 200) -> « ... repaired with
  the move mode »: a partial move refused and restored (cx 110, issue
  kept), then a move inside kept (issue gone, fewer errors).
2026-11-17 18:50:29 +01:00
bchanot 2882821661 feat(editor): drawing guard before navigations drop a started move (R-12)
The move mode lives in the work store with its document stamp. guardDrawing
ends an unstarted mode at once and asks « Abandonner le déplacement ? »
(DrawingGuardDialog, at workspace level) once work is started, before a
tab, a section, « Aller à », Back and a history jump out of the editor;
the leave guard and sign-out count started work. An undo from the header,
Ctrl+Z or the message only cancels a pending mode or preview (R-13), and a
document change drops a stale mode, keeping a started one to be said.
ConfirmDialog takes an optional body. Strings for Task 4 added.
2026-11-17 18:26:49 +01:00
bchanot 8cd1bda6c2 feat(editor): new points take the view's most used size (A5, R-10)
proposePoint, correctedCircle and centreCircle take the wanted radius,
fitted to the frame; pendingForClick, keyboardPending and the C26 test
(correctionFor) use it. The size comes from newPointSize: the strip's
choice, else the most used radius of the view, else defaultRadius.
pointSize.ts (stops, snap, range) and escape.ts (board 32 order) land
with their tests; the repair dialog keeps defaultRadius (D1).

Rewritten assertions: editor-frame.test.ts calls now pass
defaultRadius(frame) explicitly, same expected values.
2026-11-17 18:20:58 +01:00
bchanot 7a45f1d885 fix(editor): message line lifecycle, own row, sound no-shift check
Task 3 review, fix round 1.
- The gesture message closes for good on any document or history
  change (store subscription): undo then redo no longer revives it.
- Hover and focus hold only the message they were taken on: after
  « Défaire » the next message expires.
- An accepted drop clears the strip's refusal hint again.
- Controller ruling: the message has its own fixed row under the add
  buttons, column width; a refused gesture's full text also shows in
  the strip notice (red, aria-hidden copy of the row's alert).
- expectNoShift: native requestAnimationFrame kept before page.clock
  (keepNativeFrames), every part box asserted non-null, message row
  measured; the e2e checks the message is not truncated.
No assertion removed; the refused-drop unit test gains the strip copy.
2026-11-17 18:10:24 +01:00
bchanot 1deb037fac feat(editor): fixed edit strip and message line without layout shift
U2 Task 3 (A6, A14, R-2). A fixed-height strip over the drawing and the
right column replaces the tool line, the sr-only selection tag of the
edit body and TracingBar: lead (name + status, type + detail), notice
(refusal, first geometry issue + n, unmeasured view with its link, no
category, no child view), commands (Fermer le trace, Retirer le dernier
sommet, Annuler le trace). A fixed-height line under the drawing holds
the add buttons and the gesture message: a kept drop says « Point
deplace » with « Defaire » (same store undo as the header), a refused
drop says « Deplacement refuse : ... » as a red alert. 6 s, held by
mouse hover and focus inside, closed by any commit, undo or redo.
trace_pop and Backspace remove the last vertex. The busy « Aller a »
target is the strip's tracing commands. scrollbar-gutter stable, scoped
to the editor. e2e helper expectNoShift (boxes, scroll height, gutter,
client width, layout-shift sum). DraftHeader untouched: no shift seen.

Rewritten assertions (old -> new):
- tab unit « Sélection : point » on annotation-selection-tag -> strip
  detail « Point »
- tab unit tag sr-only, not live -> strip lead outside any live region
- tab unit « 1 sommet posé. » -> « 1 sommet posé » (board 04 wording)
- tab unit D6b tag present / « zone » -> strip detail « Point » /
  « Zone · 3 sommets »
- keep-alive, sections, escape units: tracing-bar -> tracing-commands
- e2e selectionTag helper -> strip title with data-selection; the
  twin's tag is twinSelectionTag (deselect 375 px describe)
- e2e deselect « tag position absolute » (edit) -> strip height 64 px,
  drawing top unchanged; twin Escape test keeps tag 0, properties 0,
  overview visible
- e2e deselect and journey tracing-bar / annotation-selection-tag ->
  tracing-commands / selectionTag
- e2e historyButton scoped to history-buttons (the message's
  « Défaire » has the same accessible name)
2026-11-17 17:45:41 +01:00
bchanot b2d78f9621 fix(editor): one press is either a pan or a click
useFraming takes an optional panning gate read on each one-pointer move;
the editor passes the press machine's drag-with-pan phase, so a zoomed
pen within its 6 px slop or a mouse wiggle no longer pans and clicks.
Catalogue: no options, behaviour unchanged.

Test added: « a press is either a pan or a click, never both (R-8) »
(pen 5 px clicks without pan, pen 8 px pans without click, mouse wiggle
clicks without pan). No assertion removed.
2026-11-17 17:10:45 +01:00
bchanot 35e4a4c75a refactor(editor): keep the press and block-drag helpers within 5 locals
Split onClick (place / select click), onPointerDown (targetAt) and
useBlockDrag (dragActions) to respect the 5-locals limit. No behaviour
change; no test changed.
2026-11-17 17:01:39 +01:00
bchanot 08d266c89f refactor(editor): one press machine for clicks, drags and taps on the drawing
press.ts (pure: slop per pointer kind, nearest handle, press target, click
and drag actions, double click, stepPress) is now the editor canvas's only
decider; useCanvasGestures no longer uses clickHandler, useEmptyTap,
swallowClick nor useMoveGesture (deleted), and the box has no onClick.
canPan = dragAction(press target).type === 'pan' at pointer-down; framing
keys only when the box itself is the target. workStore.ts holds the U2
work with stale stamps: dropStale on every documentText change, reset on
a new session (editorStore subscription). The catalogue keeps useFraming
defaults and useEmptyTap, unchanged.

Named change (A13): a finger drag on a selected zone's (or circle link's)
interior moves nothing; the selected point is its own handle and still
moves by any pointer. Second observable change: touch and pen taps are
decided at the pointer-up from the press target, no longer from the
following click (no browser touch adjustment toward a marker).

tests/setup.ts: happy-dom has no elementsFromPoint; a shim answers the
pointerdown target and its ancestors.

Rewritten tests (editor-annotations-tab.test.tsx, D6b):
- "a touch tap deselects in its own click, not at the pointer-up" ->
  "a touch tap deselects at the pointer-up" (deselected after pointerup)
- "a touch tap whose click lands on a marker (adjustment) selects that
  marker" -> "a touch tap is decided by its press: a click adjusted toward
  a marker selects nothing" (deselected, announced, marker b not current)
- "a pen tap deselects in its own click, like a touch tap" -> "a pen tap
  deselects at the pointer-up, like a mouse tap"
- "a pen tap whose click lands on a marker selects that marker" -> "a pen
  tap is decided by its press: a click landing on a marker selects
  nothing"
Added: "a finger drags the selected point (its handle), never a selected
zone (A13)".
Drive-only changes, assertions unchanged: canvas fireEvent.click(x, y)
-> pressAt (pointerdown + pointerup) in the tab suite (C26, tracing,
paths, H3, H6, H8, filter reselect), editor-keep-alive and
editor-sections; drag moves carry buttons: 1 (C34, polygon block move,
H8 lostpointercapture and read-only, editor-no-loss drag in flight),
since a move without a button is a hover.
2026-11-17 16:56:35 +01:00
bchanot 5ca2b7e3ad feat(domain): per-view minimum point radius in preview state
PreviewState.min_point_radius maps a view id to the smallest point
hitbox radius that passes TooSmall on the smallest preview, so the
sheet editor can mark it on a size slider. Twin constants named in
layer.rs; frame.rs shares one first-view drawing lookup.
2026-11-17 16:33:40 +01:00
bchanot 83f2d8bede test(app): card glyph per failure and focus rule after retry 2026-11-17 01:18:20 +01:00
bchanot 3bea19f16b test(app): e2e cleanup checks the seeded name before archiving
D4 identity check: the integrity spec reads each own sheet's name by its
captured id and archives it only when it is exactly the seeded name.
seedGrant checks the account id as a captured id, now shared from
records.ts.
2026-11-17 01:04:27 +01:00
bchanot 1e5058577f fix(app): failure row fits Réessayer and Consulter side by side
Board 30: in a three-column card at 1280 px the two buttons wrapped by a
few pixels. The failure row narrows their padding only there; the wrap
stays as the fallback. The network e2e now checks both on one row.
2026-11-17 01:04:03 +01:00
bchanot 2930f4919f style(app): wrap R4 lines over 100 columns 2026-11-17 00:59:34 +01:00
bchanot b378cf066f fix(app): card retry keeps focus and voice when no retry is left
A retry ending on a failure with no retry (network to integrity, engine
stopped for good) keeps the polite region and moves focus to Consulter.
Busy look on Réessayer, error tone once the engine stopped, one attempt
for two calls in one tick; tests for the stopped engine, two core cards
and no blob URL after unmount.
2026-11-17 00:59:30 +01:00
bchanot dadd8e5d29 test(app): catalogue card integrity and retry on the sandbox 2026-11-17 00:24:14 +01:00
bchanot 6ad8d8347c feat(app): catalogue cards say an integrity or load failure (board 30) 2026-11-17 00:14:14 +01:00
bchanot f061111e25 feat(ui): notice warning tone, glyph and non-live option 2026-11-17 00:08:45 +01:00
bchanot a50796b89f fix(app): closed filters panel has no height; e2e asserts it at 375 px 2026-11-16 20:47:34 +01:00
bchanot 7a129dc763 fix(app): filters toggle layout, constant spacing, one active-count helper 2026-11-16 20:39:01 +01:00
bchanot d3b8292aaf chore(app): mark the phone filters panel shortcut at its site 2026-11-16 20:33:14 +01:00
bchanot 6d2ba0dbf2 test(app): phone filters panel on the sandbox sheet list spec 2026-11-16 20:31:36 +01:00
bchanot 9efc7b7647 feat(app): collapsible sheet filters on phone, one empty announcement 2026-11-16 20:30:27 +01:00
bchanot ea5512af02 test(app): sheet list spec binds its SQL values, pins UTC, checks Escape
- the three fixture statements pass every value through literal(); the
  sheet, draft and actor ids are refused unless they have the uuid shape
- test.use({ timezoneId: 'UTC' }): a row still in Paris time proves the
  page sets the zone itself, whatever the host's
- the home ordering loop first asserts one <time> per item
- ratifiedDate escapes the dictionary text (escaped, now exported by
  support/admin.ts)
- the long-search check types the text again and presses Escape: field
  empty and focused, count back (Chromium's native type=search included)

R-24: no assertion removed or rewritten. Added: 'one date per home item'
(toHaveLength) before the unchanged ordering loop; the Escape block after
the unchanged button block. ratifiedDate builds the same pattern for the
current dictionaries (no RegExp character in them).

Run: admin-sheets-list 4 passed (fr, en x desktop, 375).
2026-11-16 18:10:13 +01:00
bchanot 8bb2486a34 fix(app): Administration home cards laid out as board 29 B
- the grid aligns its cards at the start; Espèces and Accès et
  habilitations stack in one right-hand column at their own height
- when the sheets card is refused, that column spans the grid and lays
  its cards side by side, so no half of the page stays empty
- the card's sheet name links are 44 px tall on the phone, unchanged
  from sm up
- the card item keeps the list row's rhythm (space-y-1), a larger gap
  only above the working copy action

No test changed.
2026-11-16 17:59:47 +01:00
bchanot 1758276087 refactor(app): sheet list hooks split, rows memoised, phone clear button
- useSearch holds the query, its field and clearSearch; useListView keeps
  the filters and the sort (8 bindings down to 5)
- the search term is folded once per search (sheetNameMatcher beside
  matchesSheetName, whose signature and behaviour stay), each date read
  once before the sort, the shown rows memoised on list, filters, search,
  sort and language
- long className strings hoisted into module constants, no class changed
- the no-result block's clear button takes the page's 44 px phone height
- labels.ts: the SheetSummary alias removed; ResultsProps declared first

No test changed: the existing unit suites are the oracle.
2026-11-16 17:57:18 +01:00
bchanot b4a5254068 test(app): shell proof of the sheet list search, sort and dates
admin-sheets-list.spec.ts (sandbox, fr and en, desktop and 375 px): three
draft sheets of this run, the oldest saved last; search, count line against
the list answer of the same load, order by last modification then by name,
the Paris date format, a search cut at 100 characters and its clearing, axe
and no sideways scroll on the searched list, the empty state and
/app/admin; the home's latest changes. Teardown soft-deletes only the ids
this run created (D7).

allSheetsLink (e2e/support/admin.ts): the sheets card link named
admin.home.all_sheets or admin.home.see_all with any number.

R-24, locators rewritten (assertions unchanged):
- admin.spec.ts A1: areaCard(...).getByRole('link', { name:
  dict['admin.home.all_sheets'] }) -> allSheetsLink(areaCard(...), dict)
- admin.spec.ts access per right: sheets.getByRole('link', { name:
  dict['admin.home.all_sheets'] }) -> allSheetsLink(sheets, dict)
- editor-journey.spec.ts createSheetFromAdmin: section locator
  .getByRole('link', { name: dict['admin.home.all_sheets'] }) ->
  allSheetsLink(section locator, dict)
2026-11-16 17:34:43 +01:00
bchanot de2424f519 feat(app): Administration home lists the latest modified sheets
Board 29 B: five latest sheets with badges, detail line and date; footer
link shows the total from two sheets. R-24: no existing assertion removed
or rewritten; seven cases added.
2026-11-16 17:17:27 +01:00
bchanot 423125c18f feat(app): search, sort, count and date on the official sheet list
Boards 28 and 29 A: name search with clear button and Escape, « Trier
par » (last modification by default, or name), a polite count line,
« Modifiée le … » on each row in a <time>, and the search no-result
block. The detail line moves to labels.ts as sheetDetails.

R-24: no existing assertion removed or rewritten; six tests added.
2026-11-16 17:03:08 +01:00
bchanot f3b58abe70 feat(app): search, sort and date format of the admin sheet list 2026-11-16 16:45:23 +01:00
bchanot d9a5846d0d feat(supabase): admin sheet summary carries last_modified_at
Schema requires last_modified_at as an ISO 8601 timestamp with offset. Fixtures in routes.admin.test.tsx and editorRoute.tsx gain the key.
2026-11-16 15:47:54 +01:00
bchanot 52d5613fe5 test(editor): keyboard-only cite and save restores in one undo 2026-11-15 20:50:49 +01:00
bchanot 3e94f732c7 fix(editor): citation notices, literal citation text, local limits 2026-11-15 20:50:48 +01:00
bchanot ee7912768c fix(editor): draft notice after the reference dialog, locale list 2026-11-15 20:08:55 +01:00
bchanot 1d119c3684 fix(editor): stale cite choice reset, pending line under the add row 2026-11-15 20:00:28 +01:00
bchanot 70eb2fcbb4 feat(editor): a reference made in the citations draft saves with it 2026-11-15 19:55:41 +01:00
bchanot 8c3fcca0b9 feat(editor): « Citer » button and family labels in references 2026-11-15 19:40:47 +01:00
bchanot 240c2ba0e7 feat(editor): dialog close button is a 44 px touch box 2026-11-15 19:40:46 +01:00
bchanot 5059641c04 fix(editor): edit mode focuses the draft, tile edit call 2026-11-15 17:43:43 +01:00
bchanot 6c0f913104 fix(editor): forget the citing form on Back, refuse sparse paths 2026-11-15 17:42:26 +01:00
bchanot 7a5684aace fix(editor): an explicit discard of the citations draft says nothing 2026-11-15 17:04:28 +01:00
bchanot 11c2b0c5ee fix(editor): Task 12 review minors, delete hint and cite label 2026-11-15 16:58:50 +01:00
bchanot 2579d4c7ae test(editor): e2e on the references dialog's edit mode 2026-11-15 16:46:05 +01:00
bchanot 3dc5820e3a feat(editor): edit mode of the references dialog
« Modifier » turns the references dialog into a draft of adds and removes,
saved as one update on the current citations. A new layer, citations,
guards it between the finding and the reference dialogs: close, Back,
POP refusal and the leave cascade ask it. « Modifier la référence » and
« Nouvelle référence » stack the reference dialog over it; a creation it
started joins its draft.
2026-11-15 16:39:43 +01:00
bchanot d9dbcf1609 fix(editor): dialog trigger for references, Task 11 review minors 2026-11-15 16:25:32 +01:00
bchanot da755f9768 fix(editor): Plus rows hover tint, axe on an active row, line limits 2026-11-15 16:21:01 +01:00