Commit Graph
1048 Commits
Author SHA1 Message Date
bchanot 62fb8dc7b8 fix(app): Lot F review polish (tests, drawer default)
Measure kept as a canvas-width annotation, no console.log; positive
two-frame wait replaces the fixed sleep; 64rem listener asserted
absent in the editor; drawer default read from DEFAULT_SHELL; long
test lines wrapped.
2026-11-08 19:29:36 +01:00
bchanot 580ff28214 feat(app): editor sidebar hidden below 1 280 px, menu one tap away
AC9: on the draft editor path AppLayout uses the xl class set (sidebar
from 1 280 px, menu button and brand below); other pages keep lg.
AppLayout split: Sidebar and TopBar in ShellChrome.tsx. MobileDrawer
takes closesFrom ('64rem' | '80rem') and also closes at setup when
its query already matches.

Rewritten assertions (R-24):
- shell.AppLayout "opens the mobile drawer" and shell.navigation
  "carries the same entries into the mobile drawer": stub a narrow
  matchMedia, the drawer now closes at setup at the happy-dom width.
New: unit tests (class sets, 64rem/80rem close, setup close, leave
guard on a drawer link) and editor-shell.spec F journeys (sidebar at
1024/1180/1279/1280, one-tap menu, drawer open at 1180, guard).
2026-11-08 19:25:49 +01:00
bchanot 89da8d3f55 fix(editor): keyboard refused-commit rule, missing history tests
Keyboard activation after a refused blur commit skips the undo and refocuses the field. Adds restore, Général-from-Annotations and DeleteDialog tests; SaveLine helpers.
2026-11-08 18:09:10 +01:00
bchanot 99b669bf8f feat(editor): header history, save line and Abandonner les modifications
Header Annuler/Retablir on every tab (aria-disabled, commit on pointerdown,
refused blur commit skips the undo). Save line: unsaved count selector
(savedDistance), saveLineState forms, server save time via readSaveTime
(lastSave in the store, never the browser clock). Discard relabelled and
names the stored copy. Tool column pair removed, glyphs in EditorGlyph.

Rewritten or removed assertions (R-24):
- editor-route.test: Revision 3 / unsaved text / Annuler les modifications
  -> save-line testid, Abandonner label, copy sentence in the dialog
- editor-route-conflict, editor-route-recovery: Revision n and copy_cap/
  copy_quota text queries -> save-line testid
- editor-no-loss: discard button label
- editor-annotations-tab: tool column undo/redo test -> no pair left
  (behaviour moved to editor-history-buttons.test)
- e2e journey/annotations/recovery/structures/support saveDraft/lan:
  undo/redo and revision/unsaved text -> historyButton, saveLine helpers;
  structures toHaveCount(0) on old text -> exact Revision n line
- editor-shell clickability: header Annuler/Retablir added
2026-11-08 17:55:49 +01:00
bchanot ab51ea764d feat(editor): references side panel with filter, search and counts
Non-modal panel in a relative container after the tab row (scrim over the
tab panels, which are inert while it is open). Chip "Citées par" opened
from a finding's Citations block, "Tout afficher (N)", accent- and
case-insensitive search on citation, DOI and URL, "citée n fois" per card
(citationCounts, memoised TS read; the core stays the authority for
refused deletions). Up/down only without filter or search. "Aller à" a
reference clears a hiding search then focuses the card.

Rewritten assertions (R-24): editor-shell "the references panel keeps its
form text and no id repeats" closes the panel before reaching the inert
tab panels. Added: Chromium clickability at 1 024 and 1 280 px (top and
scrolled), editor-structures count and search, unit
editor-references-panel, editor-citations, navigation clear_cited_by.
2026-11-08 17:33:26 +01:00
bchanot cf9c300c80 test(editor): view row switches the canvas view 2026-11-08 17:18:02 +01:00
bchanot 7cca88592f test(editor): scoped overview card queries, group names 2026-11-07 03:03:39 +01:00
bchanot 6131225288 feat(editor): board 01 annotation card, side column from 1 024 px
Annotations of the view move from under the drawing to the overview card
(grouped by category, name filter, all rows); side column from lg.
Properties panel gains « Toutes les annotations ».

E2E mapping (R-24): after a creation the card is hidden (the new annotation is
selected), so list(...).getByText(name) became selectionTag toContainText
(annotations, geometry, journey); row clicks go through pickAnnotation
(annotations, geometry, journey, structures); geometry's list count 0 while a
creation is pending became selectionTag count 0.
2026-11-06 21:40:25 +01:00
bchanot 51fd3db608 feat(editor): no silent loss on a 1 024 px crossing
Drawing actions stay mounted and hidden while read-only: an upload in
flight, a cleaning candidate, a repair offer and a parent choice come
back on widening. Decision dialogs open only while editing, in a shown
place, references panel closed; otherwise the decision is held per
object, shown as a pending line, reopened by « Reprendre » (absent in
read-only). Picker, file input and parent button are disabled while one
is pending. Repair geometries move into RepairDialog, keyed on the offer.

R-24: no existing assertion rewritten; editor-no-loss-decisions.test.tsx
added (12 cases).
2026-11-06 21:23:46 +01:00
bchanot c57af6441f feat(editor): keep edit-only forms across a width change
Edit-only parts (creation forms, submission note, crop group, annotation
edit body) mount at the first editable render and stay mounted, hidden
and detached from canvases, while read-only. Guards: the viewport hook
commits the focused field before the tier crosses 1 024 px, the route
releases focus left in a hidden part and treats a store out of step as
read-only, delete and discard confirmations close when the editor turns
read-only, a drag is dropped while the edit body is hidden. Read-only
twins take an id prefix.

R-24: no existing assertion rewritten; editor-no-loss.test.tsx and two
editor-shell Chromium cases added.
2026-11-06 21:22:10 +01:00
bchanot 9d89daed19 test(editor): pending creation announcement on « Aller à » 2026-11-06 20:59:11 +01:00
bchanot 79a09f8b25 test(editor): keep-alive paths, neutral place visibility
Place visibility context moves to lib/placeVisibility.ts so the catalogue
no longer imports from components/editor. Adds tests: selection survival,
unmeasured hint round trip, keyboard tab move and « Aller à » with a field
focused, replace-tracing kept, announcements. Parse-sharing test uses
object identity. Early exits are two statements; shortcut comment on the
parse cache.

R-24:
- editor-equine.spec.ts:118, editor-geometry.spec.ts:376,
  editor-recovery.spec.ts:39, editor-signout.spec.ts:26: page.getByLabel
  ('Nom (FR)') -> place(page, 'general').getByLabel(...)
- editor-shell.spec.ts: toHaveCount(0) on the visible query -> count 1
  on the raw selector and toBeHidden()
- editor-keep-alive.test.tsx: JSON.parse stack-trace count -> same
  object reference across places
2026-11-06 20:57:08 +01:00
bchanot 6689827a8d feat(editor): kept-mounted tabs, sections and references panel
Each visited tab, Annotations section and the references panel stay
mounted in a KeptPlace (hidden, nested visibility). Composed canvases
detach while hidden. One JSON.parse per document text. Focus requests
reach only their owning place.

Rewritten assertions (R-24):
- editor-route.test.tsx:127: annotations testid toBeNull -> not.toBeVisible
- editor-sections.test.tsx: place('annotations.drawing') toBeNull -> not.toBeVisible
- editor-journey.spec.ts:311: page-wide getByLabel('Nom (FR)') -> scoped to place 'general'
- editor-tabs-lists.test.tsx: ReferencesPanel `open` prop dropped (the wrapper hides it)
- editor-annotations-tab, editor-focus-request, editor-sections tests: props gain `visited`
No assertion removed.
2026-11-06 20:50:40 +01:00
bchanot ca184da4d9 refactor(editor): split B1 navigation hooks, category count on the overview card 2026-11-06 20:31:26 +01:00
bchanot bc2dba7c14 feat(editor): four tabs, Annotations sections, references from the header
U1 Lot B1. Four tabs (Général, Annotations, Constats, Vérification); views,
categories and regions become full-width Annotations sections opened from the
overview panel; references move to a header-toggled panel (minimal, Lot D
completes it); « Aller à » goes through EditorTarget and the navigation hook.
EditorWorkspace owns the navigation; DraftHeader split in HeaderActions and
SaveLine; EditorTabs split in TabList and MoreTabs.

R-24, assertions removed or rewritten (file: old -> new):
unit
- editor-route.test: seven tab names -> four; « Plus » at 800 px with
  Références clicked -> no « Plus »; below 640 px five others -> Général,
  Constats, and Constats opens the findings tab; + references panel cases
- editor-route-recovery.test: tab Références + editor-tab-references label ->
  header button + editor-references-panel labelled by its heading
- editor-mode.test: small tier `more` of five -> [general, findings]
- editor-focus-request.test: {key,serial} -> {target,serial}; ReferencesTab and
  VertebraeTab -> ReferencesPanel and RegionsSection; issueTarget tab/key ->
  target place/section/key (vertebrae tab -> annotations/regions); consumed
  context (serial) -> (serial, outcome); annotation case adds heading focus
- editor-verification.test: onGoTo('annotations', key) -> navigate(targetOfKey
  (key), opener); props onSelectTab/onGoTo -> navigate
- editor-annotations-tab.test: props onSelectTab -> navigate + section props;
  no_category text « (onglet Général) » -> « (Annotations, section
  Catégories) »
- editor-tabs-general.test: categories cases render GeneralTab ->
  CategoriesSection(doc); + Général holds no categories editor
- editor-tabs-lists.test: tab imports -> panel and section; read-only
  references « no button » -> only « Fermer les références »
- editor-tabs-views, editor-drawing-upload, editor-repair.test: ViewsTab ->
  ViewsSection import, assertions kept; editor-findings.test: navigate prop
e2e
- support/editor selectTab: exact name -> pattern (error badge in the name);
  + place, openSection, showDrawing, backToDrawing, openReferences, TABS
- support/warm-up: seven tabs -> four + sections + references panel
- editor-access: seven-tab axe loops -> four tabs + three sections + panel
  (edit and read-only); narrow widths add panel overflow and axe
- editor-drawings: tab Vues -> openSection views; tab Annotations ->
  showDrawing
- editor-structures: tab Général (categories) -> openSection categories, axe
  label « general tab » -> « categories section »; tab Références ->
  openReferences/closeReferences; tab Vertèbres -> openSection regions; tab
  Annotations -> showDrawing
- editor-geometry: three tab Vues -> openSection views
- editor-equine: tab Général (categories add) -> openSection categories; five
  tabs loop -> two tabs + sections + panel; tab Annotations -> showDrawing
- editor-journey: tab Vues, tab Général (category), tab Annotations ->
  openSection views/categories, showDrawing; frozen axe scrolls to the header
- lan/trial-lan (not run): tab Vues -> Annotations tab + views entry

Verified: typecheck, lint, vitest 107 files / 1125 tests, whole shell suite on
the sandbox 151 passed, 49 skipped, 0 failed.
2026-11-06 20:25:35 +01:00
bchanot 95b1b7e461 feat(editor): navigation model for the four-tab shell 2026-11-06 18:25:21 +01:00
bchanot 9ec232ac22 chore(docs): U1 contract, counter-check CONFORME, MINOR answers 2026-11-06 18:22:36 +01:00
bchanot 2c8b606be3 chore(docs): U1 contract, fourth pass fixes
« Reprendre » absent in read-only; withheld state per decision; picker
disabled while a decision is pending; parent pending line; panel open
withholds; route resync after a submission.
2026-11-06 18:11:50 +01:00
bchanot c834fe933a chore(docs): U1 contract, owner choice « Reprendre » for withheld dialogs 2026-11-06 18:02:06 +01:00
bchanot 4692b27959 chore(docs): U1 contract, third pass MINOR fixes
Route read-only until the store's canEdit matches the mode; repair
dialog offer and open split; upload notices outside the hidden part.
One MAJOR left for the owner.
2026-11-06 17:58:32 +01:00
bchanot 049d5146b4 chore(docs): U1 contract, re-check REMAINING(1) fixes
Dialogs of kept parts open only in edit mode in a visible place; ids
rule for both annotation bodies; kept parts mount at first edit render;
repair geometries lifted; N2, N4, N6, N7 stated.
2026-11-06 17:47:55 +01:00
bchanot 10fb2d84d4 chore(docs): U1 contract, counter-check REMAINING(4) fixes
Whole shell suite at B1, E, F; unmounted-forms clarification prevails
over the plan lines, B2 and H lists; distinct ids for read-only twins;
drawing actions kept hidden with dialogs closed; 9 MINOR answered.
2026-11-06 17:34:04 +01:00
bchanot ed6fb0d313 chore(docs): U1 contract amended, owner precautions resolved
AC3, AC4, AC5, AC7, AC17 and changes 2.6-2.9 applied as approved
(BDR-105); per-operation sandbox go; precautions 2.8 (no silent loss
on a 1 024 px crossing or recovery decision) and AC7 (save time rights)
resolved from the code facts, AC21 and AC22 added. Plan unchanged.
2026-11-06 17:15:59 +01:00
bchanot 1ed5c96e1b docs(docs): U2b F5, F9-F21 ratified with F3, F8, F11-F14, F22 precisions
Owner brief « Ratification finale U1 et autorisation conditionnelle
d'implémentation » (BDR-105): study §6 tests, §7 table, 7.2, 7.3,
UX plan U2b entry, REVUE and decisions pointer. No implementation.
2026-11-06 17:12:30 +01:00
bchanot 7defed1c55 chore(memory): BDR-104, U1 plan challenge reports, checkpoint contract 2026-11-06 15:53:43 +01:00
bchanot 13dee0908b docs(docs): U2b decisions F2-F22 recorded, U1 authorisation checkpoint
Owner arbitrations: F2 leaves, F3 fields, F4 model A, F8, F22 in the study
with their tests. U1 checkpoint page: 18 choices, exact AC amendments,
audits traced, sandbox reset scope, criteria per lot; no implicit deletion.
2026-11-06 15:53:43 +01:00
bchanot a43145a03f chore(memory): BDR-103, LRN-119, U2b decisions contract and TODO 2026-11-06 14:56:50 +01:00
bchanot 604f502b44 docs(docs): U2b principle, decisions F1-F22, F2/F3/F4 detail, U2b sub-step
Owner principle validation recorded: U2b after U2; full decision table with
alternatives, consequences and state; F2 groups, F3 field list and F4 view
semantics computed from the equine draft; boards shown with their decisions.
2026-11-06 14:56:49 +01:00
bchanot 567da677d7 docs(docs): complement after verifier CONFORME, trigger name per the core
Detail trigger shows its view's name as the core does; F7 cites the
current Catégorie labels; review record and TODO updated.
2026-11-06 13:28:48 +01:00
bchanot 00aaccfc79 docs(docs): complement boards compute the last names, decisions F17-F21
Verifier round 2: view chip and grasset names computed from the draft;
partial clears, out-of-filter count, zone picker order, dashed sibling
and result presentation listed as owner decisions.
2026-11-06 13:22:54 +01:00
bchanot 212126c6ce docs(docs): V1-2.6 annotations-findings complement, boards 17-22, study
Owner brief: bidirectional navigation between annotations and findings.
Relations audit (one finding_zone_id link, no new association), six
boards from the equine draft data, placement U2b, risks, tests, owner
decisions F1-F16. Design only; U1 plan untouched.
2026-11-06 13:15:15 +01:00
bchanot 2e46c14697 chore(docs): V1-2.6 UX U1 contract and challenged plan
Owner approach A and four choices recorded as gated clarifications.
Plan lots A to I after three blind challengers and one confirmation
pass; no application code, no DEV.
2026-11-06 12:37:04 +01:00
bchanot 846994b4ab chore(memory): BDR-102, T17 answered 2026-11-06 11:12:18 +01:00
bchanot 439cabd09e docs(docs): V1-2.6 T17 ratified, vertebral regions fallback entry 2026-11-06 11:12:17 +01:00
bchanot 452a346f17 chore(memory): BDR-101, TODO and journal for V1-2.6 U0 2026-11-06 11:06:12 +01:00
bchanot d9e3e34aff docs(docs): V1-2.6 UX U0, contract amendments, O22 checks, level-1 notes 2026-11-06 11:06:10 +01:00
bchanot a505b24bfd chore(memory): BDR-100, LRN-118, TODO and journal for the V1-2.6 ratification 2026-11-05 19:06:48 +01:00
bchanot bd444d6906 docs(docs): V1-2.6 UX owner ratification recorded, independent checks 2026-11-05 19:06:48 +01:00
bchanot e10f167a6d chore(memory): journal, V1-2.6 UX technical preparation 2026-11-05 17:33:00 +01:00
bchanot 871c8a6b45 chore(memory): TODO, V1-2.6 UX technical preparation and separate tracks 2026-11-05 17:32:53 +01:00
bchanot 14fb527552 docs(docs): V1-2.6 UX redesign technical plan, compatibility, tests, risks, decisions 2026-11-05 17:32:52 +01:00
bchanot f58cf2308f chore(memory): journal, V1-2.6 maquettes final corrections 2026-11-05 16:15:29 +01:00
bchanot d11cb5a44b docs(docs): V1-2.6 maquettes, delta conformance result 2026-11-05 16:14:42 +01:00
bchanot b5058b3417 docs(docs): V1-2.6 maquettes, header undo visible on Constats, review fixes 2026-11-05 16:09:52 +01:00
bchanot 7bc3d6544e docs(docs): V1-2.6 maquettes final corrections after the external review 2026-11-05 16:02:35 +01:00
bchanot 7722433a1c chore(memory): journal, V1-2.6 maquettes review archive 2026-11-05 15:36:44 +01:00
bchanot d21ffcc5dc docs(docs): V1-2.6 maquettes arbitrations, technical study, conformance result 2026-11-05 15:35:39 +01:00
bchanot 9f420d329d chore(docs): V1-2.6 maquettes contract in the verifier's format 2026-11-05 15:29:39 +01:00
bchanot 46ea996a61 docs(docs): V1-2.6 graphic editor maquettes and core feasibility audit 2026-11-05 15:16:28 +01:00
bchanot 37c9fdf6eb chore(memory): V1-2.6 ready for the owner trial on the LAN 2026-11-04 23:58:24 +01:00