chore(docs): U1 contract, third pass MINOR fixes

Route read-only until the store's canEdit matches the mode; repair
dialog offer and open split; upload notices outside the hidden part.
One MAJOR left for the owner.
This commit is contained in:
bchanot committed 2026-11-06 17:58:32 +01:00
1 parent 049d5146b4
commit 4692b27959
1 file changed
+13
@@ -308,6 +308,19 @@ fixes, executor's (prevail over the answers above where they differ):
- N7: B2's files add `annotations/AnnotationFields.tsx` and `references/ReferencesPanel.tsx`.
- N8: the repair-dialog limit is removed: `geometries` moves from `RepairForm` into `RepairDialog`, keyed on the
offer, so typed repair geometries survive the crossing like the other kept values (`views/RepairDialog.tsx`, B2).
Q: Third pass (2026-11-06, fresh plan-challenger, REMAINING(1), 3 MINOR) / A: [gated 2026-11-06] MINOR fixes,
executor's:
- Pending offer after an edit-mode render: the route also treats `useEditorStore(s => s.canEdit) !==
storeCanEdit(mode)` as read-only, so no render is in edit mode before the recovery detection of `setCanEdit` runs
(`AdminSheetDraftRoute.tsx:115,132`, `recoveryFlow.ts:85-94`); test: rights → edit inside one mount with a stored
copy mounts no edit part before the offer.
- Repair dialog: `RepairDialog({ offer, open })`, `offer` never gated, state reset only when a different non-null
offer arrives; not kept across a crossing, stated: the apply refusal `result` and an unparseable draft held in
`GeometryGroup`'s own state.
- Upload outcomes: `UploadNotices` and the `views.error` notice render outside the hidden wrapper, so a working,
failed or pending state shows in read-only; N6 restricted to narrow mode (frozen, rights or inactive refuse the
attach, its failure shown by those notices).
The MAJOR of this pass (a withheld dialog reopening by itself when its place is shown again) waits for the owner.
## ACCEPTANCE CRITERIA
1. Four tabs from 1 024 px: Général, Annotations, Constats, Vérification, as an ARIA tablist (arrows, Home/End not