Commit Graph
357 Commits
Author SHA1 Message Date
bchanot b5dcb766b1 chore(editor): rev 5 review nits
Deterministic scroll-settle wait for the bubble e2e, useDismissal split,
precondition for the add-button focus test, CSS comment wrap.
2026-11-19 21:14:49 +01:00
bchanot a9252375e1 fix(editor): bubble clears the strip's commands, announces through a steady region 2026-11-19 21:04:21 +01:00
bchanot 49f0144729 feat(editor): the held reason shows in a bubble by its button 2026-11-19 20:50:56 +01:00
bchanot 031826dced fix(editor): state the pinned column's window bounds; tidy its tests
The canvas is unchanged for browser windows of the three sizes, smaller
in shorter ones; below 644 px of window height nothing is pinned (CSS
comment, rendering doc, owner trial step 18). A page-top focus on the add
row reveals it below the strip; the geometry helper is split, long test
titles wrapped.
2026-11-19 20:40:02 +01:00
bchanot 5e6d74428f test(tests): a sideways scroll attempt proves no overflow; margin comment
scrollWidth against clientWidth hid an overflow up to the scrollbar
gutter's width; the probe now tries to scroll sideways. The drawing
place's margin comment names the pinned column's exception.
2026-11-19 20:24:36 +01:00
bchanot 36ed9f980b fix(editor): the drawing stays clear of the strip while the page scrolls
The drawing column (chips, tools, canvas, add row, message line) is
pinned under the strip from 1 024 px wide and 644 px high; the canvas
box is capped in width by the window height (4:3 kept, unchanged at the
three sizes); pinned controls carry no strip margin. The rev 4 test
workarounds go; the row-click scroll was Playwright's bring-into-view.
2026-11-19 20:19:26 +01:00
bchanot 238650719e fix(editor): no focus in the editor header lands under the top bar 2026-11-19 18:24:07 +01:00
bchanot f9656a0d9b fix(editor): a focus left in a hidden panel counts as lost after a guarded press 2026-11-19 17:24:32 +01:00
bchanot fa00e57652 fix(editor): a guarded press that hides the handle keeps the focus off body 2026-11-19 17:16:56 +01:00
bchanot f5a6eafc7f fix(editor): zone handles remount per annotation so a row tap lands the focus 2026-11-19 16:21:14 +01:00
bchanot 8b190b4e0d fix(editor): an overview row tap keeps the focus off body 2026-11-19 16:16:30 +01:00
bchanot 448a17eff7 docs(docs): trial step 19 tool and the tapped tool's focus, pinned 2026-11-19 15:18:06 +01:00
bchanot b0344a4af6 fix(editor): no strip scroll margin on a dialog's controls 2026-11-19 15:18:05 +01:00
bchanot 303e153777 fix(editor): any pointer press clears the keyboard scroll of a vertex
The key flag only heard presses on the handle group: a press on the
interior after a keyed series let the re-chosen vertex scroll the page
under the pointer. Any pointerdown in the document now clears it.
2026-11-19 15:18:04 +01:00
bchanot 7a9ccf149c chore(editor): rev 4 leftovers: closeTrace returns nothing, doc reflow 2026-11-19 15:04:27 +01:00
bchanot f3c4f7baa9 test(tests): a resumed shape has no interior drag and no handle past 40 2026-11-19 15:03:07 +01:00
bchanot 77251fa636 fix(editor): a held press on another tab leaves the hidden line empty
The kept-alive annotations tab showed the reason in its hidden message
line, so it came back on the return. A press made while the place is
hidden is now only described by the button.
2026-11-19 15:03:06 +01:00
bchanot 531bbef619 fix(editor): a tool or view chip tap keeps the focus off body
Safari focuses no tapped button: a tool or a view chip pressed after a
keyboard series commits through the guard with the focus on the handle,
then the change unmounts the handle. The focus now lands on the pressed
button, without a scroll, only when it fell to body (M-4).
2026-11-19 15:00:39 +01:00
bchanot 966ad4fe45 fix(editor): no focus in the drawing place lands under the strip
The scroll margin now covers every native focusable of the place (tools,
view chips, add buttons, the aside's controls), the strip's own commands
excepted, as a real Tab walk found them hidden (I-3). A vertex chosen
from the keyboard takes the focus with a scroll (M-1).
2026-11-19 14:58:19 +01:00
bchanot 59e189c375 fix(editor): « Défaire » cancels pending work; reasons only when they help
A press on « Défaire » over a pending series or mode keeps the focus and
skips the field commit, so its handle's blur no longer commits before
the cancel (R-13): the redo stack survives. A held button gives its
reason only when that cause alone holds it; redo during a creation gets
its own text, and the pending text says to cancel with « Défaire ».
2026-11-19 14:52:51 +01:00
bchanot de418b29a9 test(tests): press the drawing where the sticky strip leaves it visible
The strip made sticky in f2809f20 covers the drawing's top band and the
aside's top while the page is scrolled (rev 4 point 1 ruling, accepted
cost). Three presses and one axe scan ran at that scroll after a row
click: back to the top first, and assert the press hits the drawing.
2026-11-19 14:43:19 +01:00
bchanot 682bbd4a18 chore(editor): rev 4 review nits 2026-11-19 14:12:30 +01:00
bchanot 8f036b2a8a fix(editor): a press on a held redo keeps the pending work untouched 2026-11-19 14:02:11 +01:00
bchanot 00e995a6cb feat(editor): say why redo is unavailable during pending work 2026-11-19 12:38:26 +01:00
bchanot e341f03390 fix(editor): one focus marker on every handle, proven on an SVG vertex 2026-11-19 12:32:27 +01:00
bchanot 399a5adae6 fix(editor): focus margin on the strip's targets, not a page padding 2026-11-19 12:24:34 +01:00
bchanot f2809f20ca fix(editor): the strip stays below the top bar on scroll 2026-11-19 12:15:52 +01:00
bchanot 62b400e876 fix(editor): « − » press follows Delete, discriminating focus tests 2026-11-19 12:00:48 +01:00
bchanot 03e85a7c67 fix(editor): focus follows the action after a touch commit 2026-11-19 11:26:37 +01:00
bchanot df46390bdb fix(editor): vertex keys act on the focused handle after an undo 2026-11-19 11:20:19 +01:00
bchanot 6df66f9bb9 feat(editor): Backspace and « + » on a vertex handle 2026-11-19 11:16:55 +01:00
bchanot c01c6f3145 fix(editor): resumed shape names and minor review fixes
- French fallback names: « cette nouvelle zone », « ce nouvel accès »
  (controller ruling: « Sommets de ce nouvel accès »); doc updated.
- useZoneHandle back to 5 locals.
- dropPending clears the strip hint as a kept stored change does.
- Tests: the chosen vertex cleared by finishCreation itself (document
  unchanged) and by a view change through the guard; both fail
  without their clearing.

Changed assertions, editor-creation-dialog.test.tsx:
- « Sommets de la nouvelle zone », « Sommet 1 de la nouvelle zone »
  -> « … de cette nouvelle zone » (ruling)
- « Sommets de le nouvel accès » -> « Sommets de ce nouvel accès »
- chosen null after « Créer » (cleared by the document change, not
  discriminating) -> « the chosen vertex ends with a finished
  creation, the document unchanged »
2026-11-19 09:49:27 +01:00
bchanot a5896710e5 feat(editor): resumed trace edits the closed shape with its handles
« Reprendre le tracé » keeps the pending shape closed; the zone handles
(vertex, « + », « − », vertex keys) edit it through the same press path
and useZoneEdit, the target generalised to points + drop. A drop on
PENDING_ID patches creation.pending only: document, history and unsaved
count untouched, message without « Défaire ». Strip: « Tracé repris,
saisie gardée » with « Revenir aux propriétés » and « Abandonner ».
Handle names fall back to « la nouvelle zone » / « le nouvel accès ».

Removed (resumed branch of popVertex, backToProperties -> closeTrace,
CreationCommands tracedCount and its « Retirer le dernier sommet »).

Removed assertions, editor-creation-dialog.test.tsx, « keeps the
vertices and the form; a new vertex, then the dialog again »:
- strip « Tracé repris, saisie gardée » -> kept in « keeps the shape
  closed and the form, shows its handles; two strip commands »
- « Retirer le dernier sommet » enabled -> absent; commands are exactly
  « Revenir aux propriétés », « Abandonner » (same test)
- a click on the drawing adds a 4th vertex -> « a click off the handles
  adds and selects nothing; a double « + » inserts once »
- dialog again with Nom (FR) « Tibia » -> « « Revenir aux propriétés »
  shows the edited shape; « Créer » inserts it »
- « Zone tracée, 4 sommets » -> « Zone tracée, 5 sommets » after « + »
  (same test)
2026-11-19 09:42:58 +01:00
bchanot 9522eb72aa test(tests): probe mode entry and exit for shifts at three widths
Criterion 5: « Déplacer le point », « Déplacer la zone », « Valider la
position », and « Redessiner » entered then cancelled, each under
expectNoShift at 1 024, 1 180 and 1 280 px (seeded point and zone, the
existing multi-width pattern). The editor-touch « Déplacer la zone » entry
joins the probe; its button is centred first, since below xl the sticky top
bar can cover the strip and Playwright would scroll inside the probe.

No assertion removed. No product shift found.
2026-11-18 14:13:53 +01:00
bchanot b6aa2819ea fix(editor): name vertex handles after their zone, in a named group
Criterion 18: « Sommet {n} de {nom} », « Ajouter un sommet après le sommet
{n} de {nom} », « Retirer le sommet {n} de {nom} » (EN « Vertex {n} of
{name} » …), {nom} the zone's display name in the current locale; the
handle group is a role="group" named « Sommets de {nom} ».

Tests: no assertion removed; every unit and e2e locator that read the old
names now reads the same handle with the zone name appended (fixtures: N,
Vertèbres thoraciques, Zone dessinée, Zone clavier). New unit tests in
editor-zone-edit cover the FR names, the group and the EN locale.
2026-11-18 14:09:24 +01:00
bchanot 059764ec60 test(tests): probe the measure preview port without HTTP
Fixes semgrep react-insecure-request (CWE-319): ready() now checks the preview port with a node:net TCP connect instead of fetch on http://127.0.0.1. Also ignore apps/app/e2e/test-results/ in .dockerignore so the measure build, which inlines the sandbox anon key, stays out of the Docker context.
2026-11-18 13:46:55 +01:00
bchanot a75c2999de fix(editor): commit a keyed series before a move or a redraw starts
Safari, and iPad Safari on a tap, focuses no clicked button: the
handle or the slider keeps the focus, no blur commits its series, and
« Déplacer … », « Redessiner » or « Remplacer par un polygone »
cleared it (preview: null) without a word. startMove and beginRedraw
now call commitFocusedSeries() first, the same path a drawing press
takes since 10a8767. « Propriétés » (guardDrawing) and
« Désélectionner » (useDeselect) already committed; a test pins both.

Tests: no assertion removed.
2026-11-18 13:31:34 +01:00
bchanot a5af9bdd4f test(tests): measure the line's « Défaire » hit box whole
Final review M-5: the hit test now probes 1 px inside each edge of the
44 px (36 px from xl) box and reads the ::before height, so the check
proves the full height, not 42 px. Tests: no assertion removed.
2026-11-18 13:28:17 +01:00
bchanot f2bf442ecd test(tests): prove the line and redraw fixes without a shift
Final review M-3, M-4, M-5, M-6 in the sandbox suites:
- editor-annotations (A14 at 1024, 1180, 1280 px): « Défaire » on the
  line hit-tested 44 px tall below xl and 36 px from xl, its pill 36
  px; pressed under expectNoShift, the drawing then has the focus.
- editor-geometry: the same refused move twice under expectNoShift is
  a new alert pill.
- editor-zones: « Redessiner » takes the focus back after a close and
  a cancel; with the strip scrolled out and the focus on body, the
  close returns it with no scroll.

Tests: no assertion removed.
2026-11-18 13:21:32 +01:00
bchanot a6685a04e0 fix(editor): return the focus without a scroll; drop an inert tap
Final review M-4 and M-6: the line's « Défaire » focuses the drawing
through focusDrawing (preventScroll), and a mode's end focuses its
entry with preventScroll, so neither scrolls the page (A14).
M-8: the empty tap kept after the removed click was as inert; gone.

Tests removed: in « a mouse tap deselects at the pointer-up », the
second pointerDown/pointerUp on the empty drawing and its repeated
isDeselected assertion (the first tap's assertion covers it).
2026-11-18 13:12:56 +01:00
bchanot 10a8767527 fix(editor): commit a keyed series as a press starts on the drawing
Final review I-1 audit. A touch press moves no focus before its
pointer-up, so a press on « + » or « − », or a drag, committed over an
arrow or slider series still pending on the focused handle and dropped
it. A fresh press now commits it first (commitFocusedSeries, its own
blur), as the mouse's focus move already did.

Tests: no assertion removed; header « Refaire » cases added for a
started redraw and a size change.
2026-11-18 13:12:55 +01:00
bchanot 13e2503e6a fix(editor): gesture line alerts, focus after « Défaire », hit area
Final review M-3, M-4, M-5, M-8.
- M-3: the line and the strip render a refusal's role="alert" beside
  their always-mounted role="status" region, never inside it; every
  shown message carries a serial that keys its pill, so a repeated
  identical refusal is a new pill and is announced again.
- M-4: after the line's « Défaire » the focus goes to the canvas box.
- M-5: « Défaire » gets a transparent ::before, 44 px tall below xl
  (36 px from xl), within the row's reserved 44 px: the pill keeps
  its 36 px. The A14 e2e checks the hit area at 1024, 1180, 1280 px.
- M-8: the « swallows the click on a marker » test fired a click the
  canvas ignores since T2; the inert click is dropped, the title says
  what the taps prove.

Tests rewritten: « the message sits on its own row »: role="status" on
the row → a role="status" region inside the row, empty at rest.
« a mouse tap deselects … swallows the click »: the final
fireEvent.click on the marker removed (inert), its isDeselected
assertion kept after the second tap.
2026-11-18 13:00:22 +01:00
bchanot e299c3d4f6 fix(editor): give the focus back to « Redessiner » after a redraw
Final review M-6. useMoveFocusReturn becomes useModeFocusReturn: the
mode that ended picks its entry, « Déplacer … » (data-move-entry) for
a move, « Redessiner » or « Remplacer par un polygone »
(data-redraw-entry) for a redraw, the drawing when neither is shown.
A redraw counts as running while its mode or its tracing lives, so a
link polygon (no « Déplacer ») never leaves the focus on body.

Tests: no assertion removed.
2026-11-18 13:00:12 +01:00
bchanot 323a342586 fix(ui): end an anchored dialog above the tablet keyboard
Final review M-2: maxHeight runs to the visual viewport's bottom, not
the layout viewport's, so « Enregistrer » stays reachable while a
keyboard leaves 320 px or more. New unit case beside the keyboard one.
2026-11-18 13:00:11 +01:00
bchanot 9e1ec4479d fix(editor): name a moved link « Link moved » in English
Final review M-1: the kind is « Link » everywhere else (« Link redrawn »,
« Link created »). The owner trial's string list follows.
2026-11-18 13:00:10 +01:00
bchanot ae80511964 fix(editor): redo and move-mode handle keys keep pending work
Final review I-1. Redo (Ctrl+Shift+Z and the header « Refaire ») is
inactive while a started move or redraw, a keyboard series or a size
change is pending (holdsRedo): the work stays, the user commits or
cancels it first. In a move mode, Insert and Delete on a vertex and
Enter or Space on « + » and « − » do nothing, as the press machine.

Tests: no assertion removed. The history-guards move-mode helper and
reset run in act, since « Refaire » now re-renders on a started mode.
2026-11-18 13:00:03 +01:00
bchanot e6f47280ad test(tests): measure commit latency on a seeded draft
Opt-in spec (MEASURE_COMMIT=1, MEASURE_BUILD=preview for the production build): vertex drag, « + » and « − » on a run-seeded equine draft, three runs each, from the pointerup to the painted frame showing the new geometry with the undo entry. Never editor-equine nor the historical copy.
2026-11-18 12:20:45 +01:00
bchanot dd3f245bca fix(editor): loupe copy without ids, two fingers counted in the pinch
Minor 1: the loupe's copy of the drawing drops every id (the equine
drawing has 142); its url(#…) and href="#…" resolve to the originals.
Minor 2: useFraming's onPinch marks the two-finger flag at the pinch
move itself; the passive effect that read the live press phase and
the press hook's multi() are removed.
2026-11-18 11:17:42 +01:00
bchanot 181f81789a test(tests): measure the drag on a production build (vite preview)
Opt-in with MEASURE_DRAG=1 MEASURE_BUILD=preview: the app built with
the shell config's sandbox environment into e2e/test-results, served
by vite preview on 127.0.0.1:5193 (--strictPort), the allowlist set
to that origin and the fake Supabase origin. Suites unchanged.
2026-11-18 11:09:06 +01:00
bchanot bc8d645554 test(tests): loupe drag without shift, a pinch at the fit unselected 2026-11-18 10:59:40 +01:00