diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index 31854f4e..1cc853b4 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -982,3 +982,10 @@ Owner 2026-11-15: finding dialog keeps only « Références citées » + « X r Owner pre-closure brief 2026-11-15. Reference created from references dialog edit mode held in draft (created[]), written with citations by one commitBatch (inserts + update = one undo); abandon leaves library unchanged. Dry-run applyEdit validates at draft submit. Select only browses, « Citer » button cites; save with pending choice refused. Family labels via isFamilyKey (finding key path len 1), 18 _family keys. Shared Dialog close 44px. Alternatives: write-now + delete on abandon (two undo steps, rejected); fold existing-reference edits into draft (offered to owner, not done). - **Status (2026-11-15)**: shipped: validated by owner db:trial 2026-11-15, R2 closed; both offered choices ratified as built + +## BDR-120 — R3 sheet list + admin home closed by owner, phone filters panel (2026-11-16) +- **Status**: accepted +**Decision:** R3 closed 2026-11-16 by owner after db:trial trial. Sheet list: search fr/en, sort by true last_modified_at (M9 `private.official_sheet_admin_summary`) or name, count line, Paris date, « indisponible » when date missing/unreadable (never fallback date). Home card: latest five + « Voir les {n} fiches ». Phone (<640 px): four filters in CSS-only collapsible panel (grid-rows 0fr→1fr, `visibility:hidden` closed, « Filtres (n) »), reset only inside panel (owner confirmed, no other button). Filter-only empty line not a live region: count line announces once. +**Rationale:** owner trial passed; desktop layout unchanged; no JS viewport detection; closed panel height 0 asserted at 375 px. +**Alternatives:** reset button outside panel (rejected by owner); `inert` on panel (would disable desktop grid); motion lib (CSS enough). +**Open, separate:** BLK-015, RR-13 (admin lists paging, server search), pgTAP 014/021 on accumulated sandbox, D5 keep list state on back. No merge, no deploy, DEV unchanged. diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index 20ed50ac..2b0f2496 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -569,3 +569,6 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp - 2026-11-15 R2 owner follow-up built (Tasks 10-13 + fixes, b41c24b..ebd1d6d): references dialog with own edit mode, one tab order, vertical Plus. Gates 0, sweep 264 passed, fails = admin.spec BLK-015 + Target crashed (rerun green), GUARD OK. Waiting owner db:trial check. - R2 Rev 6 built: Citer button, draft-owned creation (commitBatch), family labels, 44px dialog close. Sweep final7 273 pass, 6 fail admin.spec BLK-015. Await owner db:trial then R2 closure. - R2 CLOSED 2026-11-15: owner db:trial 4.13+4.14 pass, validated functional+graphic; saved-ref edit own Défaire + unsaved new ref lost on abrupt close ratified. Sweep 52d5613 273p/163s/6f admin.spec BLK-015 open (RR-13). No merge/deploy. Next R3, R4; U2 orientation kept. + +## 2026-11-16 +- R3 CLOSED 2026-11-16: owner db:trial trial pass, phone filters panel validated, reset in panel only. check:all exit 0 at a50796b. BLK-015, RR-13, pgTAP 014/021 open separate. No merge/deploy. Next R4 catalogue card integrity warning (D9 C). diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 1aee7796..1541902f 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -707,7 +707,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - R2 BUILT 2026-11-13, awaiting owner validation: fc3fec7 R2.0, 4499bc7 R2.1, c21995b R2.2, 3baac4d R2.3, 8db6f42 R2.4, 4b7d254 R2.5, 2182307 R2.6 docs, 1bf2701 final-review fixes (all pushed). Verifier 18/20 (NOT-MET 9 admin.spec renderer crash from accumulated grants, 15 read-only flip keeps panel open), security PASS, final review ready-with-fixes → fixed, re-review ready. Owner decisions pending: read-only flip ratification, admin.spec closure before merge (fresh-run authorisation or separate fix: paginated grants / run-scoped cleanup), add-draft cancel control, V1-2_ANATOMICAL_SHEETS.md D1-D4 supersede note wording. editor-equine updated, never run. Parked: N1 silent draft loss on read-only flip of an unmatched tile, N2 pinned non-matching tile beside no-result, first-click loss below a refused field, landscape 667×375 panel 13 px, M10 locals over 5 in R2 hooks (/refactor) - [x] R2 corrections (owner brief 2026-11-13, plan rev 5/5b): C0 admin.spec diagnosis (A/B 65a8fd3 vs 52aac41 identical, dose-response proves grant accumulation, BLK-015 open, pagination = RR-13), C1 read-only flip never drops a refused draft silently (3303530, 1e19479), C2 « Annuler l'ajout » + Escape (d177992, c8109af), C3 « Ne correspond pas à la recherche » (b1fd896), C4 667×375 touch proof, test only (969a5f3..78fb2d0), C5 docs (b919cf8, c0da36d, 58228ab), final review I1 (94f8a8b, 346a8fd), verifier gap undo drop announced (cb1ad47, 538ce27). Sweep 221p/119s/5f (admin.spec only), guard OK, verifier CONFORME, security PASS. BDR-115, LRN-133..135. Awaiting owner db:trial trial; residuals: two drops one flip speak last, undo/redo overwriting a pending draft in a mounted view, rotation cramped exception (auto-scroll offered), prettier drift editor-shell-layout.spec.ts:297-302 - [x] R2 CLOSED 2026-11-15 (owner brief « Clôture R2 »): owner db:trial checks §4.13 + §4.14 pass, R2 validated functionally and graphically; Rev 4-6 adjustments (b41c24b..54e09a7, BDR-118, BDR-119); choices ratified: saved-reference edit keeps own Défaire, unsaved new reference lost on abrupt close. Final sweep 52d5613: 273p/163s/6f (admin.spec BLK-015, stays open, RR-13), not green. No merge, no deploy. Next: R3, R4; U2 not started (orientation 2026-11-14 kept) - - [ ] R3 sheet list + Administration home (owner brief 2026-11-16): plan VALIDATED rev 2b `.claude/tasks/plans/2026-11-16-r3-sheet-list-0017.md` (D1-D4, D6, D7 yes; D5 no; recorded choices accepted; precisions P1-P4). Sandbox work authorised in plan scope; `pnpm db:trial migrate` authorised by the owner 2026-11-16 after the operational checkpoint and applied (Task 2); Tasks 3-8 authorised in plan scope; DEV unchanged. BLK-015 + RR-13 separate, open. pgTAP on the sandbox is NOT green (014, 021 below): never reported as green. + - [x] R3 sheet list + Administration home (owner brief 2026-11-16): CLOSED 2026-11-16, owner validation after the db:trial trial, phone filters included (reset stays in the panel only); BDR-120. Plan VALIDATED rev 2b `.claude/tasks/plans/2026-11-16-r3-sheet-list-0017.md` (D1-D4, D6, D7 yes; D5 no; recorded choices accepted; precisions P1-P4). Sandbox work authorised in plan scope; `pnpm db:trial migrate` authorised by the owner 2026-11-16 after the operational checkpoint and applied (Task 2); Tasks 3-8 authorised in plan scope; DEV unchanged. BLK-015 + RR-13 separate, open. pgTAP on the sandbox is NOT green (014, 021 below): never reported as green. - [x] Task 1 M9 migration + pgTAP 022 (74: drafts, working copy, sheet newer than versions; mutation-proved) + task review + security PASS; frozen (blob a33b1770) — e3495df, a76a54d, f3712b2 - [x] Task 2 `db:sandbox migrate` (21c9a81, reviewed) + sandbox migrated 2026-11-16 (rows identical 6981/7130, rerun no-op); types match; recompute 6981 sheets mismatch 0 (11 working copies). db:trial migrated 2026-11-16 on the owner's go: app process checked then stopped, `pnpm db:trial migrate` 21 s, backup `20261116T144154Z-pre-migrate` (63M, checked before M9, checksums and archives re-verified), 18 applied; before / after digest of 58 tables, 155 functions (definition + privileges), 23 policies, 20 grants: 3 lines differ (migration registry +1, the summary function = sandbox digest 1a4a1157, privileges unchanged); accounts, roles, TOTP, sheets, versions, drawings identical; recompute 2 sheets mismatch 0; admin list, sheet page and editor read answer for the aal2 editor account (read-only); app restarted on 5194. Not checked: browser sign-in (owner trial); restore not exercised - [ ] pgTAP on the sandbox after M9, exact result kept open: `pnpm db:sandbox test-db` Files=21 Tests=1958 Result FAIL. 022 ok, 023 ok. `014_animals_relations` 2/258 failed (tests 6 « exactly the nine species… », 7 « every species row is active »). `021_sheet_verification_jobs` 23 failed, « Bad plan. You planned 90 tests but ran 42 », ERROR draft.frozen at :205. Read as accumulated-state dependent (line « suites need a fresh stack »), NOT proven by a run without M9; M9 touches neither file's functions. To settle on a fresh stack (`db:sandbox up fresh` needs an owner go: no sandbox reset in R3) @@ -716,7 +716,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] Task 5 list page (board 28, 29 A) (423125c, reviewed; app 1736, build ok) - [x] Task 6 home card (board 29 B) (de2424f, reviewed; app 1743, build ok) - [x] Task 7 shell spec admin-sheets-list + three locators (b4a5254, reviewed). Spec alone 4 passed. Sweep 27 files without editor-equine: 277 passed, 6 failed, 163 skipped, 0 flaky; failures all `admin.spec.ts` on the rights screen (BLK-015): « admin screens » :714 ×4 « Target crashed », A0 :220 ×2 lookup timeout at :144 (other symptom, about 7 600 grants; not A/B proven against pre-R3). A1, « access per right », editor-journey green. Guard: 0 pre-existing row changed; 12 R3 sheets soft-deleted - - [ ] Task 8 docs, closing gates, owner trial on db:trial: [x] documents as built (a86020d: U1_CORRECTIONS §R3, SQL checkpoint §6-§7 with F2-F4 corrections and F7 limits, V1-2 §12.3 M9, SUPABASE §5.1, BROWSER_TESTS, Rust Part II class C rows, design README deviations, CLAUDE.md, CHANGELOG) · [x] owner trial text §4.15 in French (b9e5d32) · [x] closing gates design review (28 CONFORME, 29 A and 29 B ÉCARTS, findings 1-4 fixed in the wave), code review (0 C, 0 I, 9 Minor: 1-7 fixed, 9 done at Task 8, 8 left), security PASS (4 non-blocking: spec SQL, date refine, RegExp escape fixed; db-sandbox.sh:485 false positive left) · [x] verifier on the contract 2026-11-16 at bcdacbb: ECARTS(1), 17/18 MET, criterion 4 NOT-MET on its CHECK line only (one-line literal split and strengthened by 374e300; layout-insensitive equivalent prints DATE_SOURCE_OK, recorded in the contract a8ab668; the owner closes it) · [x] `pnpm check:all` 2026-11-16 at bcdacbb: exit 0, « all checks passed » in 7 min 52 s (core-wasm 66, supabase 182, app 1743 in 137 files, e2e:ui 253 passed, app image, worker test and runtime image); e2e:shell NOT RUN by check:all (the sweep and the fix-wave run are the lines above) · [ ] STOP owner trial on db:trial, no merge. Deviations for the owner: no magnifier (F14, validated); no info icon in the board 28 no-result block (ruling, to confirm) + - [x] Task 8 docs, closing gates, owner trial on db:trial: [x] documents as built (a86020d: U1_CORRECTIONS §R3, SQL checkpoint §6-§7 with F2-F4 corrections and F7 limits, V1-2 §12.3 M9, SUPABASE §5.1, BROWSER_TESTS, Rust Part II class C rows, design README deviations, CLAUDE.md, CHANGELOG) · [x] owner trial text §4.15 in French (b9e5d32) · [x] closing gates design review (28 CONFORME, 29 A and 29 B ÉCARTS, findings 1-4 fixed in the wave), code review (0 C, 0 I, 9 Minor: 1-7 fixed, 9 done at Task 8, 8 left), security PASS (4 non-blocking: spec SQL, date refine, RegExp escape fixed; db-sandbox.sh:485 false positive left) · [x] verifier on the contract 2026-11-16 at bcdacbb: ECARTS(1), 17/18 MET, criterion 4 NOT-MET on its CHECK line only (one-line literal split and strengthened by 374e300; layout-insensitive equivalent prints DATE_SOURCE_OK, recorded in the contract a8ab668; the owner closes it) · [x] `pnpm check:all` 2026-11-16 at bcdacbb: exit 0, « all checks passed » in 7 min 52 s (core-wasm 66, supabase 182, app 1743 in 137 files, e2e:ui 253 passed, app image, worker test and runtime image); e2e:shell NOT RUN by check:all (the sweep and the fix-wave run are the lines above) · [x] owner trial on db:trial passed and R3 validated 2026-11-16, no merge. Deviations for the owner: no magnifier (F14, validated); no info icon in the board 28 no-result block (ruling, to confirm) - [x] Final fix wave 2026-11-16 (`374e300` client refuses an unreadable date, test first; `1758276` list hooks split, rows memoised, className constants, phone clear button; `8bb2486` home cards as board 29 B, 44 px name links, row rhythm; `ea5512a` spec: `literal()` + uuid shape, UTC, one `