docs(docs): the two execution rulings accepted by the owner
This commit is contained in:
1 parent
b038bd5535
commit
8c4c980686
1 file changed
+1
-1
@@ -68,7 +68,7 @@ Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4 then rev
|
||||
| Criterion 32 on the final code (Task 7 Step 4b), 2026-11-20, superseded by the three rows below | with eight long-named detail views the chips take 3 to 5 rows and the stuck column overflows the window bottom. Measured overflow: 1 024 × 768, 5 rows, 64.3 px; 1 180 × 820, 3 rows, 53.3 px; 1 180 × 700, 3 rows, 76.0 px; 1 280 × 800, 5 rows, 24.3 px. The canvas size and the absence of sideways scroll hold; near the page end the column top also rises above the strip bottom. The test is committed as `test.fixme` in `editor-geometry.spec.ts` (« owner decision pending (criterion 32, chips on several rows) »). The pinned budget has counted ONE row of chips since Task 17 (pre-existing: at 1 280 px the add row did not change and still overflows 24.3 px). With one row (the equine sheet) the whole `editor-geometry.spec.ts` passes, short windows included. Decision pending: the budget for chips on several rows (options: raise the pinned budget per chip row (measured), let the chips scroll in one row, or accept the limit) |
|
||||
| Criterion 32 with one scrolling row (2026-11-21, board `v1-2-6-u2-chips/`, owner tablet check pending) | the chips sit in one horizontally scrolling row: the criterion 32 test in `editor-geometry.spec.ts` (`test.fixme` removed) passes at 1 024 × 768, 1 180 × 820, 1 180 × 700 and 1 280 × 800 with eight long-named views: one chip top, the row overflows inside itself (`scrollWidth > clientWidth`), the scroll walk green. The real DOM parts, read back at 1 180 × 820 and 1 280 × 800, are 162 px and 154 px, equal to the CSS budget (10.125rem and 9.625rem). Runs, all `--workers=2`, 0 failed (editor-geometry, editor-annotations and editor-touch ran on 190471d4, the other specs on 068ecd57; a dated full pass at HEAD follows): editor-geometry 59 passed, editor-annotations 23, editor-touch 15, editor-drawings 3, editor-shell-layout 13, editor-access 9, editor-shell-crossing 12; unit app 2 227 passed |
|
||||
| View row tests (2026-11-21) | unit `annotations.viewRow.test.ts` (reveal, hint state) and `editor-view-row.test.tsx`: a guarded view change refused with « Continuer » leaves the active view and `aria-pressed` unchanged and runs no activation reveal; the row is revealed again on the active chip when the hidden edit body is shown again; a language switch with long names recomputes the hints; a removed view whose chip had focus leaves a tab stop; a keyboard focus entering a chip from outside the row (`:focus-visible`) reveals it, a pointer focus never does. E2E (`editor-geometry.spec.ts`, `editor-shell-layout.spec.ts`): the view row at 1 024 × 768, on a phone (375), under the sticky strip, read-only (reviewer, 1 280 × 800), a pointer press on a peeking chip activates it at the first click without scrolling the row, a swipe starting on a chip activates nothing, language switch en to fr |
|
||||
| Residual risks (one scrolling row; the three residuals owner-accepted 2026-11-21, the two rulings below submitted to the owner) | a row scroll closes an open « Défaire / Refaire » hold bubble (closed by any scroll, owner rule kept 2026-11-20); the chevron hit areas are a swipe dead zone at the row ends; some focus behaviours are proven only in Chromium (Tab entry clear of the fades relies on `scroll-padding-inline` plus the `:focus-visible` reveal). Test scope (controller ruling during execution, submitted to the owner, not owner-accepted): the language-switch vertical check is measured below the draft header, which wraps per language; the read-only twin's shown-again placement is checked with the properties dialog open; touch fling and inertia, a drag starting under a chevron and pinch-zoom are left for the owner's tablet trial. Deviation from plan rev 3 (controller ruling during execution, submitted to the owner, not owner-accepted): `scroll-padding-inline` alone left a chip partly under the end fade on Tab entry, so a chip receiving keyboard focus from outside the row is revealed; a pointer focus never reveals, so the row never scrolls at a press |
|
||||
| Residual risks (one scrolling row; the three residuals owner-accepted 2026-11-21, the two rulings below submitted to the owner) | a row scroll closes an open « Défaire / Refaire » hold bubble (closed by any scroll, owner rule kept 2026-11-20); the chevron hit areas are a swipe dead zone at the row ends; some focus behaviours are proven only in Chromium (Tab entry clear of the fades relies on `scroll-padding-inline` plus the `:focus-visible` reveal). Test scope (controller ruling during execution, accepted by the owner 2026-11-21): the language-switch vertical check is measured below the draft header, which wraps per language; the read-only twin's shown-again placement is checked with the properties dialog open; touch fling and inertia, a drag starting under a chevron and pinch-zoom are left for the owner's tablet trial. Deviation from plan rev 3 (controller ruling during execution, accepted by the owner 2026-11-21): `scroll-padding-inline` alone left a chip partly under the end fade on Tab entry, so a chip receiving keyboard focus from outside the row is revealed; a pointer focus never reveals, so the row never scrolls at a press |
|
||||
| Residual risks (trial adjustments) | assistive technologies activating with `detail ≥ 1` arm the tool instead of placing at the centre (mitigated 2026-11-21 by « Placer au centre » in the add row (works whatever the activation)); a fast double tap on the tablet browser: counted as a double-click (stays armed) or as two taps (arms then disarms), not verified on the device; the canvas box can be scrolled by a focus (overflow-hidden), the bubble's screen bound then lags (pre-existing, pointer choices use `preventScroll`) |
|
||||
| Gates of the trial adjustments (head 1f9ed523, 2026-11-20) | `pnpm typecheck && pnpm lint && pnpm test:run` green (app 154 files, 2 185 tests); `pnpm e2e:ui` 253 passed; shell suite on the 33 baseline specs by full path, never `editor-equine.spec.ts`, `--workers=2`: 352 passed, 247 skipped, 13 failed (28.1 min), the 13 failures being exactly the 13 of the 3d6aacad baseline by test name, none new (environment failures do not block the manual trial, owner decision D5) |
|
||||
| « Placer au centre » (2026-11-21) | the fourth slot of the add row, reserved, shown while a creation tool is armed and nothing is in progress (frame built, a category, a detail view for a link); one placement function shared with Enter on the drawing and the add buttons' keyboard path; unit `editor-add-buttons.test.tsx` (« Placer au centre » describe: availability, activation by click / Enter / Space / detail 0, focus return, stale hint, guards proven by mutation including the unbuilt-drawing frame guard, exact fr/en strings), e2e `editor-annotations.spec.ts` (1 024 / 1 180 / 1 280 px: shown, four buttons on one line, no shift, opens the dialog; 1 280 px double-click keeps the dialog) |
|
||||
|
||||
Reference in new issue
Block a user