test(tests): criterion 32 wording, waiver, press settle; records corrected
This commit is contained in:
1 parent
dd0648e1b3
commit
b038bd5535
4 files changed
+20
-13
No files matched your search
@@ -468,8 +468,8 @@ apps/app/src/components/shell/AppLayout.tsx, apps/app/src/state/leaveGuardStore.
|
||||
|
||||
### Owner decisions 2026-11-20 (addendum 3)
|
||||
- Criterion 32: validated by the owner on the trial build; REOPENED by the owner (2026-11-20) until re-verified on the final code (the 44 px add buttons move the pinned thresholds): short windows and several rows of view chips (plan Task 7 Step 4b).
|
||||
- Criterion 32 re-verified on the final code (2026-11-20): one row of view chips (equine sheet) passes, whole editor-geometry spec including short windows; several rows (eight long-named views, 3 to 5 rows) FAIL: the stuck column overflows the window bottom by 64.3 px (1 024 × 768), 53.3 px (1 180 × 820), 76.0 px (1 180 × 700), 24.3 px (1 280 × 800); the test is committed as test.fixme. The pinned budget counts one row of chips since Task 17 (at 1 280 px neither the add row nor the budget changed). Criterion 32 stays OPEN, owner decision pending.
|
||||
- Criterion 32 (2026-11-21): the owner chose one horizontally scrolling chip row (board `v1-2-6-u2-chips/`). Implemented (commits 9148bb27 to 190471d4): the criterion 32 test passes at 1 024 × 768, 1 180 × 820, 1 180 × 700 and 1 280 × 800 (one chip top, the row overflows inside itself, scroll walk green); real DOM parts 162 / 154 px match the CSS budget. Residuals accepted by the owner: a row scroll closes an open « Défaire / Refaire » hold bubble; the chevron hit areas are a swipe dead zone at the row ends; some focus behaviours proven only in Chromium. Pending the owner's final check on the tablet (fling, drag under a chevron, pinch-zoom). Tests: `docs/development/V1-2-6_UX_TESTS.md`.
|
||||
- Criterion 32 re-verified on the final code (2026-11-20): one row of view chips (equine sheet) passes, whole editor-geometry spec including short windows; several rows (eight long-named views, 3 to 5 rows) FAIL: the stuck column overflows the window bottom by 64.3 px (1 024 × 768), 53.3 px (1 180 × 820), 76.0 px (1 180 × 700), 24.3 px (1 280 × 800); the test is committed as test.fixme. The pinned budget counts one row of chips since Task 17 (at 1 280 px neither the add row nor the budget changed). Criterion 32 stays OPEN, owner decision pending (superseded below).
|
||||
- Criterion 32 (2026-11-21): the owner chose one horizontally scrolling chip row (board `v1-2-6-u2-chips/`). Implemented (commits 9148bb27 to 190471d4): the criterion 32 test passes at 1 024 × 768, 1 180 × 820, 1 180 × 700 and 1 280 × 800 (one chip top, the row overflows inside itself, scroll walk green); real DOM parts 162 / 154 px match the CSS budget. Residuals accepted by the owner: a row scroll closes an open « Défaire / Refaire » hold bubble; the chevron hit areas are a swipe dead zone at the row ends; some focus behaviours proven only in Chromium. Controller rulings during execution, submitted to the owner (not owner-accepted): the keyboard-focus reveal deviation and the language-switch vertical measurement below the draft header. Pending the owner's final check on the tablet (fling, drag under a chevron, pinch-zoom). Tests: `docs/development/V1-2-6_UX_TESTS.md`.
|
||||
- Criterion 12 reworded: « The add buttons: a pointer press (click or tap) arms their tool, the
|
||||
shape is placed or traced on the drawing and the dialog opens itself; a keyboard press (Enter,
|
||||
Space) places the shape at the centre and opens the dialog; a second single pointer press on an
|
||||
|
||||
@@ -1266,9 +1266,10 @@ for (const { pinned, ...viewport } of SHORT_WINDOWS) {
|
||||
})
|
||||
}
|
||||
|
||||
// U2 criterion 32 on the final code (owner 2026-11-20): with enough detail views for the view
|
||||
// chips to wrap onto several rows, the pinned column still sits below the strip, fits the
|
||||
// window when stuck, keeps its canvas size and never scrolls sideways.
|
||||
// U2 criterion 32 on the final code (owner 2026-11-20, one scrolling row 2026-11-21): with
|
||||
// enough detail views to overflow the view chips, which stay in one scrolling row, the pinned
|
||||
// column still sits below the strip, fits the window when stuck, keeps its canvas size and
|
||||
// never scrolls sideways.
|
||||
const CHIP_WINDOWS = [
|
||||
{ width: 1024, height: 768 },
|
||||
{ width: 1180, height: 820 },
|
||||
@@ -1294,7 +1295,7 @@ function chipRowsShape(document: Record<string, unknown>) {
|
||||
}
|
||||
|
||||
for (const viewport of CHIP_WINDOWS) {
|
||||
test.describe(`the column with the view chips on several rows at ${viewport.width} x ${viewport.height} (U2 criterion 32)`, () => {
|
||||
test.describe(`the drawing column with eight long-named views (criterion 32, one scrolling row) at ${viewport.width} x ${viewport.height} (U2)`, () => {
|
||||
test.use({ locale: 'fr-FR', actionTimeout: 15_000, viewport })
|
||||
test.beforeEach(async ({ context }, info) => {
|
||||
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
||||
@@ -1736,7 +1737,13 @@ test.describe('the view row (criterion 32)', () => {
|
||||
const before = (await rowGeometry(page)).scrollLeft
|
||||
await page.mouse.move(at.x, at.y)
|
||||
await page.mouse.down()
|
||||
// Pressed, not yet released: the row has not moved under the pointer.
|
||||
// Pressed, not yet released: let two frames pass, the row has not moved under the pointer.
|
||||
await page.evaluate(
|
||||
() =>
|
||||
new Promise((resolve) =>
|
||||
requestAnimationFrame(() => requestAnimationFrame(() => resolve(null))),
|
||||
),
|
||||
)
|
||||
expect((await rowGeometry(page)).scrollLeft).toBeCloseTo(before, 0)
|
||||
await page.mouse.up()
|
||||
await expect(pressedChip(page)).toHaveAttribute(
|
||||
@@ -1955,7 +1962,7 @@ test.describe('the view row (criterion 32)', () => {
|
||||
test.describe('the view row on a phone (criterion 32)', () => {
|
||||
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
||||
test.beforeEach(async ({ context }, info) => {
|
||||
test.skip(!isPhone(info), 'the 375 px project only')
|
||||
test.skip(!isPhone(info), 'the 375 px project only') // floor-guard: allow C16 phone read-only row checked in the 375 px project only
|
||||
await routeToSandbox(context)
|
||||
})
|
||||
test.afterEach(async ({ context }) => {
|
||||
|
||||
@@ -809,8 +809,8 @@ Tablette en paysage (au moins 1 024 px de large ; en dessous, l'éditeur est en
|
||||
la bande pendant que la liste de droite défile, et cette liste continue de passer sous la bande. Sur la tablette,
|
||||
faites défiler la page des annotations jusqu'à la fin : aucune partie de la colonne ne passe sous la bande. Si une
|
||||
partie y passe, notez la hauteur de la fenêtre et la vue : une fenêtre de moins de 658 px de haut (650 px dès 1 280
|
||||
px de large) n'épingle rien, mais le dessin peut aussi passer sous la bande dans une fenêtre plus haute (une seule rangée de
|
||||
vues défilante, colonne limitée par la hauteur). Sur un vrai iPad, le dessin peut être plus petit et collé à
|
||||
px de large) n'épingle rien, mais dans une fenêtre plus haute la colonne garde sa hauteur quel que soit le nombre de vues (une seule
|
||||
rangée de vues défilante, colonne limitée par la hauteur) : rien ne passe sous la bande. Sur un vrai iPad, le dessin peut être plus petit et collé à
|
||||
gauche, avec une bande libre à sa droite : c'est attendu, pas un défaut, car les barres du navigateur réduisent la
|
||||
fenêtre. Notez aussi tout déplacement du dessin à l'écran quand vous sélectionnez une rangée, tout défilement sur le
|
||||
côté, et un Tab sur un contrôle du dessin qui ferait défiler la page.
|
||||
|
||||
@@ -65,10 +65,10 @@ Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4 then rev
|
||||
| Trial adjustments, add buttons (contract `.claude/tasks/contracts/2026-11-20-u2-trial-adjustments-1259.md`) | unit (`editor-add-buttons.test.tsx`): a pointer click on « Ajouter un point » or « Ajouter une zone » arms the tool, says where to click and opens no dialog; a click in the drawing places the point there and opens its dialog; abandoning it focuses the button; « Replacer le point » then a second click keeps the origin; a second click on the armed button disarms it, and a started zone asks first; a double-click leaves the tool armed; Enter and Space keep the centre path (C7); screen-reader path: the armed tool is announced, then Enter on the drawing places at the centre (point and zone), and with the Select tool Enter creates nothing; a redraw lends the zone tool and « Ajouter une zone » then arms a new zone; the three announcements exist in both languages. E2E mouse (`editor-annotations.spec.ts`, 1 024, 1 180, 1 280 px): a click arms « Ajouter un point », pressed like the tool, nothing moves. E2E touch (`editor-touch.spec.ts`, 1 180 px): a tap arms it, a tap in the drawing opens the dialog, the button is 44 px tall |
|
||||
| Open-side bubble (« − ») | unit (`annotations.removeBubble.test.ts`): sweep over the six equine polygons of the main view at zoom 1 to 6, clear of every shown « + » and of its own vertex, inside the frame; a control showing the former centre fails the criterion (thoracic, vertex 2); the part on screen when zoomed and panned, an off-screen vertex not forced, a vertex rung kept clear of another vertex on the open ray. E2E touch (`editor-touch.spec.ts`): on « Vertèbres thoraciques » zoomed, every chosen vertex keeps its bubble clear, on screen and light; a tap on « + » adds, « Défaire » restores |
|
||||
| Device-independent geometry (criterion 8) | `annotations.pointSize.test.ts` and the `insertMidpoint` tests of `annotations.polygonEdit.test.ts`; the handle sizes are read only by `HandleLayer` and `ZoneHandles` |
|
||||
| Criterion 32 on the final code (Task 7 Step 4b), 2026-11-20, superseded by the two rows below | with eight long-named detail views the chips take 3 to 5 rows and the stuck column overflows the window bottom. Measured overflow: 1 024 × 768, 5 rows, 64.3 px; 1 180 × 820, 3 rows, 53.3 px; 1 180 × 700, 3 rows, 76.0 px; 1 280 × 800, 5 rows, 24.3 px. The canvas size and the absence of sideways scroll hold; near the page end the column top also rises above the strip bottom. The test is committed as `test.fixme` in `editor-geometry.spec.ts` (« owner decision pending (criterion 32, chips on several rows) »). The pinned budget has counted ONE row of chips since Task 17 (pre-existing: at 1 280 px the add row did not change and still overflows 24.3 px). With one row (the equine sheet) the whole `editor-geometry.spec.ts` passes, short windows included. Decision pending: the budget for chips on several rows (options: raise the pinned budget per chip row (measured), let the chips scroll in one row, or accept the limit) |
|
||||
| Criterion 32 with one scrolling row (2026-11-21, board `v1-2-6-u2-chips/`) | the chips sit in one horizontally scrolling row: the criterion 32 test in `editor-geometry.spec.ts` (`test.fixme` removed) passes at 1 024 × 768, 1 180 × 820, 1 180 × 700 and 1 280 × 800 with eight long-named views: one chip top, the row overflows inside itself (`scrollWidth > clientWidth`), the scroll walk green. The real DOM parts, read back at 1 180 × 820 and 1 280 × 800, are 162 px and 154 px, equal to the CSS budget (10.125rem and 9.625rem). Runs, all `--workers=2`, 0 failed: editor-geometry 59 passed, editor-annotations 23, editor-touch 15, editor-drawings 3, editor-shell-layout 13, editor-access 9, editor-shell-crossing 12; unit app 2 227 passed |
|
||||
| Criterion 32 on the final code (Task 7 Step 4b), 2026-11-20, superseded by the three rows below | with eight long-named detail views the chips take 3 to 5 rows and the stuck column overflows the window bottom. Measured overflow: 1 024 × 768, 5 rows, 64.3 px; 1 180 × 820, 3 rows, 53.3 px; 1 180 × 700, 3 rows, 76.0 px; 1 280 × 800, 5 rows, 24.3 px. The canvas size and the absence of sideways scroll hold; near the page end the column top also rises above the strip bottom. The test is committed as `test.fixme` in `editor-geometry.spec.ts` (« owner decision pending (criterion 32, chips on several rows) »). The pinned budget has counted ONE row of chips since Task 17 (pre-existing: at 1 280 px the add row did not change and still overflows 24.3 px). With one row (the equine sheet) the whole `editor-geometry.spec.ts` passes, short windows included. Decision pending: the budget for chips on several rows (options: raise the pinned budget per chip row (measured), let the chips scroll in one row, or accept the limit) |
|
||||
| Criterion 32 with one scrolling row (2026-11-21, board `v1-2-6-u2-chips/`, owner tablet check pending) | the chips sit in one horizontally scrolling row: the criterion 32 test in `editor-geometry.spec.ts` (`test.fixme` removed) passes at 1 024 × 768, 1 180 × 820, 1 180 × 700 and 1 280 × 800 with eight long-named views: one chip top, the row overflows inside itself (`scrollWidth > clientWidth`), the scroll walk green. The real DOM parts, read back at 1 180 × 820 and 1 280 × 800, are 162 px and 154 px, equal to the CSS budget (10.125rem and 9.625rem). Runs, all `--workers=2`, 0 failed (editor-geometry, editor-annotations and editor-touch ran on 190471d4, the other specs on 068ecd57; a dated full pass at HEAD follows): editor-geometry 59 passed, editor-annotations 23, editor-touch 15, editor-drawings 3, editor-shell-layout 13, editor-access 9, editor-shell-crossing 12; unit app 2 227 passed |
|
||||
| View row tests (2026-11-21) | unit `annotations.viewRow.test.ts` (reveal, hint state) and `editor-view-row.test.tsx`: a guarded view change refused with « Continuer » leaves the active view and `aria-pressed` unchanged and runs no activation reveal; the row is revealed again on the active chip when the hidden edit body is shown again; a language switch with long names recomputes the hints; a removed view whose chip had focus leaves a tab stop; a keyboard focus entering a chip from outside the row (`:focus-visible`) reveals it, a pointer focus never does. E2E (`editor-geometry.spec.ts`, `editor-shell-layout.spec.ts`): the view row at 1 024 × 768, on a phone (375), under the sticky strip, read-only (reviewer, 1 280 × 800), a pointer press on a peeking chip activates it at the first click without scrolling the row, a swipe starting on a chip activates nothing, language switch en to fr |
|
||||
| Residual risks (one scrolling row, owner-accepted 2026-11-21) | a row scroll closes an open « Défaire / Refaire » hold bubble (closed by any scroll, owner rule kept 2026-11-20); the chevron hit areas are a swipe dead zone at the row ends; some focus behaviours are proven only in Chromium (Tab entry clear of the fades relies on `scroll-padding-inline` plus the `:focus-visible` reveal). Test scope: the language-switch vertical check is measured below the draft header, which wraps per language; the read-only twin's shown-again placement is checked with the properties dialog open; touch fling and inertia, a drag starting under a chevron and pinch-zoom are left for the owner's tablet trial. Deviation from plan rev 3 (controller ruling): `scroll-padding-inline` alone left a chip partly under the end fade on Tab entry, so a chip receiving keyboard focus from outside the row is revealed; a pointer focus never reveals, so the row never scrolls at a press |
|
||||
| Residual risks (one scrolling row; the three residuals owner-accepted 2026-11-21, the two rulings below submitted to the owner) | a row scroll closes an open « Défaire / Refaire » hold bubble (closed by any scroll, owner rule kept 2026-11-20); the chevron hit areas are a swipe dead zone at the row ends; some focus behaviours are proven only in Chromium (Tab entry clear of the fades relies on `scroll-padding-inline` plus the `:focus-visible` reveal). Test scope (controller ruling during execution, submitted to the owner, not owner-accepted): the language-switch vertical check is measured below the draft header, which wraps per language; the read-only twin's shown-again placement is checked with the properties dialog open; touch fling and inertia, a drag starting under a chevron and pinch-zoom are left for the owner's tablet trial. Deviation from plan rev 3 (controller ruling during execution, submitted to the owner, not owner-accepted): `scroll-padding-inline` alone left a chip partly under the end fade on Tab entry, so a chip receiving keyboard focus from outside the row is revealed; a pointer focus never reveals, so the row never scrolls at a press |
|
||||
| Residual risks (trial adjustments) | assistive technologies activating with `detail ≥ 1` arm the tool instead of placing at the centre (mitigated 2026-11-21 by « Placer au centre » in the add row (works whatever the activation)); a fast double tap on the tablet browser: counted as a double-click (stays armed) or as two taps (arms then disarms), not verified on the device; the canvas box can be scrolled by a focus (overflow-hidden), the bubble's screen bound then lags (pre-existing, pointer choices use `preventScroll`) |
|
||||
| Gates of the trial adjustments (head 1f9ed523, 2026-11-20) | `pnpm typecheck && pnpm lint && pnpm test:run` green (app 154 files, 2 185 tests); `pnpm e2e:ui` 253 passed; shell suite on the 33 baseline specs by full path, never `editor-equine.spec.ts`, `--workers=2`: 352 passed, 247 skipped, 13 failed (28.1 min), the 13 failures being exactly the 13 of the 3d6aacad baseline by test name, none new (environment failures do not block the manual trial, owner decision D5) |
|
||||
| « Placer au centre » (2026-11-21) | the fourth slot of the add row, reserved, shown while a creation tool is armed and nothing is in progress (frame built, a category, a detail view for a link); one placement function shared with Enter on the drawing and the add buttons' keyboard path; unit `editor-add-buttons.test.tsx` (« Placer au centre » describe: availability, activation by click / Enter / Space / detail 0, focus return, stale hint, guards proven by mutation including the unbuilt-drawing frame guard, exact fr/en strings), e2e `editor-annotations.spec.ts` (1 024 / 1 180 / 1 280 px: shown, four buttons on one line, no shift, opens the dialog; 1 280 px double-click keeps the dialog) |
|
||||
|
||||
Reference in new issue
Block a user