forked from bchanot/claude
chore(memory): 4d GATE 1 closed, exact-field test follow-up
This commit is contained in:
1 parent
c5f69c8381
commit
f1332d85e3
2 files changed
+3
-1
No files matched your search
@@ -118,7 +118,7 @@ Shared rules for every phase:
|
||||
- **4c read side (built 2026-11-05 on feature/memory-recall, merged 2026-11-06 ddb04f4).** Two channels only: intent recall at `prompt.submit` for classifier labels design/analysis or the first coding prompt after idle (BM25 top-30 over title + lesson + body → haiku keeps ≤3, bounded 3 s, fail open) and tool-error 4-gram match (PostToolUse; a classic hook is acceptable if the mod ledger is not needed). Session digest (open BLK via the status parser, actionable TODO, last journal line) in `hooks/session-start.sh` on `source: startup|compact|clear` (native matchers; the mod's `session.compact` only skips); a SubagentStart twin if sub-agents need it. Injection = ID + title + lesson line; superseded never injected; budget ~1.5k chars per turn; once per context. Deferred: Read path triggers, Bash command triggers, "critical → deny once", Tier 1, cross-repo scope=global index, `memory_search` tool.
|
||||
- 4c follow-up from the 4b live proof (2026-11-04): `memory_pending` lists milestones of the current session only, so a `/capitalize` run right after `/clear` misses the previous session's `fix:`/finish milestones (they stay in the store). Option: list earlier-session milestones marked `(earlier session)`. Doctrine (capitalize before /clear) covers the normal path.
|
||||
- **4d feedback (4d.1-4d.3 built 2026-11-08 on feature/memory-feedback, BDR-140, merge on signal).** Mod logs `cands`+`ms`; bun reader `lib/memory-feedback/`; `/memory-feedback` skill; banner reminder; two gates (prompt 20 or 35 d, tool 10 or 35 d +1 extension). Plan r3 `docs/superpowers/plans/2026-11-06-memory-feedback.md` (purged at finish; git keeps it), contract `.claude/tasks/contracts/2026-11-06-memory-feedback-4d-1825.md`. 4d.4 (/prune-memory step D, BDR-100 promotion) stays conditional: built only when a gate reports a noisy entry or a promotion candidate.
|
||||
- [ ] 4d follow-ups (final review + task reviews 2026-11-08, non-blocking): transcript cache holds every parsed file per run (~1 GB at steady state: process per (root, session, agent) and drop); image prompts (array content) become `lost` (counted); no boundary tests for the threshold actions (3rd pick, late, tool, miss, noisy/promotion, idle tie-break), eviction note, torn count, toolItem; `replyAfter` hides `seen.add` in a filter; no `tsc` type check on lib/memory-feedback; labels.ts minors (fromLine checks column count only, readState accepts non-object JSON, .bak keeps one state, misleading error on an entry label with a cause).
|
||||
- [ ] 4d follow-ups (final review + task reviews 2026-11-08, non-blocking): transcript cache holds every parsed file per run (~1 GB at steady state: process per (root, session, agent) and drop); image prompts (array content) become `lost` (counted); no boundary tests for the threshold actions (3rd pick, late, tool, miss, noisy/promotion, idle tie-break), eviction note, torn count, toolItem; `replyAfter` hides `seen.add` in a filter; no `tsc` type check on lib/memory-feedback; kit test pinning the exact field set of a prompt log record (IR11 is toMatchObject since 4d.1, so a future text field would pass); labels.ts minors (fromLine checks column count only, readState accepts non-object JSON, .bak keeps one state, misleading error on an entry label with a cause).
|
||||
- [ ] shortcut: the injection log lives under `l:<root>` store keys (about 28 KiB each, 200 records and 64 KiB at most); `sweepLogs` counts them with the `p:` keys and evicts the oldest log key (by its newest record, never the current root's) once the total nears the engine's 4 MiB store cap; upgrade = one global log key or a smaller per-root cap (`mods/memory/hooks/register.ts`).
|
||||
- [x] residual: the pre-existing `memory.sh check` call in `hooks/session-start.sh` is not time-bounded (the digest's `memory.sh index blocker` call is); upgrade = wrap it in `timeout 2`. Done 2026-11-06 d93f06c (SD16).
|
||||
- [x] BLK-043 hotfix merged 2026-11-06 (`bd5e661` main, `7e47bea` develop, back-merged into feature/memory-recall `3564e3e`, worktree removed).
|
||||
|
||||
@@ -52,6 +52,7 @@ Q: spec deviations / A: reader in lib/memory-feedback/; miss causes no-overlap|o
|
||||
- skills/memory-feedback/SKILL.md, mods/model-router/routing.json
|
||||
- docs/superpowers/{specs,plans}/2026-11-06-memory-feedback* (transient, purged at finish)
|
||||
- public docs as patched by doc sync (STEP 8)
|
||||
- Orchestrator-only: .claude/tasks/**, .claude/memory/** [gated 2026-11-08]
|
||||
|
||||
## EXECUTION LOG (orchestrator)
|
||||
- Tasks 1-7 via SDD on feature/memory-feedback (21483dc..c00649f), each task review approved (rulings and deferred minors in the SDD ledger, workspace .superpowers/sdd/2026-11-06-memory-feedback/progress.md).
|
||||
@@ -61,3 +62,4 @@ Q: spec deviations / A: reader in lib/memory-feedback/; miss causes no-overlap|o
|
||||
- Task 8 step 2: live record in the store (repo zenquality, 2026-11-08T17:59:41Z): channel prompt, trigger fresh, outcome none, cands 11, ms 1408.
|
||||
- Task 8 step 3: live /memory-feedback run 2026-11-08 ~18:35Z: worksheet 1 record (joined, not lost), labelled `1 - test` (proof prompt), apply rc 0, FEEDBACK clock start 2026-11-08, both gates open, ~/.claude/memory-feedback 700 with 3 files 600, labels.tsv holds no prompt word and no path, reminder silent after the run.
|
||||
- Merge: user signal "tu peux merge" given before GATE 1; merged dcb593a (develop), GATE 1 run after the merge.
|
||||
- GATE 1 (verifier, post-merge): 9/9 criteria MET, floor clean; ECARTS(5) were scope only (flow bookkeeping files), closed by the user's micro-gate 2026-11-08 adding the orchestrator-only line to FILE SCOPE. Not re-dispatched: the scope line was the only gap.
|
||||
Reference in new issue
Block a user