forked from bchanot/claude
chore(todo): park GATE 2 LOW on unvalidated git-tree lock keys
This commit is contained in:
1 parent
14bee52964
commit
7e29279b24
1 file changed
+1
@@ -102,6 +102,7 @@ Open children of the shipped phases (History 2026-11-12), text verbatim.
|
||||
- [x] DONE 5bba6ce, merged 30f9825, /hotfix 2026-11-20: numeric id required, indented ABANDON counts (game ledger 2026-09-30-verify-qual-deparse MET → ABANDONED(1)), malformed → ERROR, 5 tests. Was: gates.sh:93 ABANDON regex `([0-9]+)?` reads `ABANDON: 1b …` / `1.1` as id 1: after a renumber (LRN-284) criterion 1 is masked ABANDONED (rc 3) instead of "unknown criterion" ERROR. Anchor the id `([0-9]+)([[:space:]]|$)` + test (robustness challenger, gates hotfix 2026-11-17)
|
||||
- [ ] parked (GATE 2 LOW, 5a98c2c): probe table names not checked with `IDENT.fullmatch` per table (a `/` walks a path on the approved Supabase host); `printable` lets Unicode bidi/format controls (U+202E, U+2066…) through to the tty
|
||||
- [ ] parked (GATE 2 LOW, feature/modern-web-guidance): lib/vendor-skills.sh `vendor_pinned_tree` symlink check runs after the `cp -R` (overlapping lock targets could write through an upstream symlink; check each listed path before copy or reject overlaps); `_vendor_tree_swap` restore-mv failure → stage cleanup deletes the parked old copy (keep stage, name its path); `python3 -` without `-I` in vendor-skills.sh:271, doctor-vendored.sh:239
|
||||
- [ ] parked (GATE 2 LOW, 14bee52): lib/doctor-vendored.sh `_dv_tree_expectations` prints the lock key unvalidated, a tab or newline in a key shifts the fields (`tree_names` membership in check_vendored_skills; an unchecked `dest` reaching `cat …/.vendored-commit` in check_vendored_trees); validate `key` against NAME in the python or `cut -s -f2`. Semgrep could not parse `_dv_valid_item_name` `case` lines 151-152 (read by hand)
|
||||
- [x] profile name charset check (done by phase 5: `NAME_RE='^[a-z0-9][a-z0-9-]*$'` lib/profile.sh:63 on every profile and session name; the old `read_profile()` is gone)
|
||||
- [ ] P22 `make new-skill` scaffold: agent stub lacks `effort:` pin, skill stub lacks entry level, body loads `.claude/agents/$(name).md` instead of `$HOME/.claude/agents/<name>.md` → /hotfix; also: no routing.json row reminder
|
||||
- [x] `lib/tests/design-tool-gate.test.sh` hermetic CLI_ABSENT case (done by the phase 5 rewrite: suite green 2026-11-02 with `~/.local/bin/21st` installed, `make test` all suites green on this machine)
|
||||
|
||||
Reference in new issue
Block a user