User dropped new Horse.svg / Horse_head.svg that follow a simpler
convention:
- Categories renamed to longer human strings:
articulation → articulations
charniere → charni-res-vert-brales
spine-zone → zone-colonne
cadran-crane → cadrans-du-cr-ne
head, os-overlay → dropped (head zone is now category="os" + data-anno-opens-detail)
os → unchanged
- No more hitbox / visible class split; multiple elements may still share
the same data-anno-id but they all carry the same role.
- Trigger-only zones (`data-anno-opens-detail="head"`) may omit
`data-anno-name-fr/en`.
Changes:
- `Bone` now exposes a single `els: Element[]` instead of `hitboxEls +
visibleEls`.
- `parseSvgBones` accepts annotations without fr/en labels (defaults to
empty string) but still rejects unknown or missing categories.
- The "interactive vs decorative" filter is gone — every parsed
annotation is interactive, since the new SVGs only annotate the
clickable zones.
- Vertebra-picker trigger: `bone.category === 'zone-colonne'`
(EditorRoute + ObservationCard).
- PDF colorisation in `observationPage.colorizedSvgString` writes the
accent fill to every `els[]` entry (no more hitbox dual-pass).
- Dead `src/components/observation/ObservationEditor.tsx` removed (its
body lives inside ObservationCard since the accordion refactor).
- Tests rewritten for the new vocabulary; synthetic fixture uses the new
categories, real-SVG test asserts 18 + 9 unique zones.
92/92 tests pass, lint clean, build clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
96 lines
3.4 KiB
TypeScript
96 lines
3.4 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import {
|
|
parseSvgBones,
|
|
getBoneIdFromEvent,
|
|
isValidCategory,
|
|
} from '@/anatomy/svgConvention'
|
|
import { SvgConventionError } from '@/anatomy/types'
|
|
|
|
function svgFromString(s: string): SVGSVGElement {
|
|
const doc = new DOMParser().parseFromString(s, 'image/svg+xml')
|
|
return doc.documentElement as unknown as SVGSVGElement
|
|
}
|
|
|
|
const FIXTURE = `
|
|
<svg xmlns="http://www.w3.org/2000/svg">
|
|
<circle data-anno-id="point-shoulder" data-anno-name-fr="Épaule" data-anno-name-en="Shoulder"
|
|
data-anno-category="articulations" />
|
|
<circle data-anno-id="point-shoulder" data-anno-name-fr="Épaule" data-anno-name-en="Shoulder"
|
|
data-anno-category="articulations" />
|
|
<polygon data-anno-id="zone-cervical" data-anno-name-fr="Vertèbres cervicales"
|
|
data-anno-name-en="Cervical Vertebrae" data-anno-category="zone-colonne" />
|
|
<polygon data-anno-id="zone-head" data-anno-category="os" data-anno-opens-detail="head" />
|
|
</svg>`
|
|
|
|
describe('parseSvgBones', () => {
|
|
it('groups multiple elements sharing the same data-anno-id', () => {
|
|
const map = parseSvgBones(svgFromString(FIXTURE))
|
|
const shoulder = map.get('point-shoulder')
|
|
expect(shoulder).toBeDefined()
|
|
expect(shoulder?.fr).toBe('Épaule')
|
|
expect(shoulder?.en).toBe('Shoulder')
|
|
expect(shoulder?.category).toBe('articulations')
|
|
expect(shoulder?.els.length).toBe(2)
|
|
})
|
|
|
|
it('captures opensDetail when present', () => {
|
|
const map = parseSvgBones(svgFromString(FIXTURE))
|
|
expect(map.get('zone-head')?.opensDetail).toBe('head')
|
|
})
|
|
|
|
it('records zone-colonne single-element annotations', () => {
|
|
const map = parseSvgBones(svgFromString(FIXTURE))
|
|
const bone = map.get('zone-cervical')
|
|
expect(bone?.category).toBe('zone-colonne')
|
|
expect(bone?.els.length).toBe(1)
|
|
})
|
|
|
|
it('allows annotations without data-anno-name-fr/en (trigger-only zones)', () => {
|
|
const map = parseSvgBones(svgFromString(FIXTURE))
|
|
const trigger = map.get('zone-head')
|
|
expect(trigger?.fr).toBe('')
|
|
expect(trigger?.en).toBe('')
|
|
})
|
|
})
|
|
|
|
describe('parseSvgBones validation', () => {
|
|
it('throws on missing data-anno-category', () => {
|
|
const bad = `<svg xmlns="http://www.w3.org/2000/svg">
|
|
<circle data-anno-id="x" />
|
|
</svg>`
|
|
expect(() => parseSvgBones(svgFromString(bad))).toThrow(SvgConventionError)
|
|
})
|
|
|
|
it('throws on unknown category', () => {
|
|
const bad = `<svg xmlns="http://www.w3.org/2000/svg">
|
|
<circle data-anno-id="x" data-anno-category="bogus" />
|
|
</svg>`
|
|
expect(() => parseSvgBones(svgFromString(bad))).toThrow(SvgConventionError)
|
|
})
|
|
})
|
|
|
|
describe('isValidCategory', () => {
|
|
it('accepts documented categories', () => {
|
|
expect(isValidCategory('articulations')).toBe(true)
|
|
expect(isValidCategory('zone-colonne')).toBe(true)
|
|
expect(isValidCategory('cadrans-du-cr-ne')).toBe(true)
|
|
expect(isValidCategory('charni-res-vert-brales')).toBe(true)
|
|
expect(isValidCategory('os')).toBe(true)
|
|
})
|
|
|
|
it('rejects unknown values', () => {
|
|
expect(isValidCategory('nope')).toBe(false)
|
|
expect(isValidCategory('articulation')).toBe(false) // old singular form
|
|
expect(isValidCategory('spine-zone')).toBe(false) // old name
|
|
})
|
|
})
|
|
|
|
describe('getBoneIdFromEvent', () => {
|
|
it('returns null when no anno in ancestry', () => {
|
|
const div = document.createElement('div')
|
|
const evt = new Event('click')
|
|
Object.defineProperty(evt, 'target', { value: div })
|
|
expect(getBoneIdFromEvent(evt)).toBeNull()
|
|
})
|
|
})
|