Files
faunosteo/supabase/tests/016_sheet_review_workflow.sql
T
bchanot 77e5fa4cf5 feat(supabase): V1-2.1 M4/M5 secure sheet access and review workflow
M4 20261028100000_sheet_access_hardening + M5 20261028110000_sheet_review_workflow
(applied together; no unprotected window). Implements contract §5-§14.

- Catalogue rights table + owner RPCs; has_mfa / has_aal2_session (live
  auth.sessions check); grant_active vs caller_has split; catalogue reader
  predicate; can_edit_sheet on the sheet_editor capability (F14).
- AR-1 B: aal2 required on every platform role change, target verified factor,
  race-free last-owner guard (F18/F19); service_role loses table privileges on
  the catalogue + profiles/profile_roles and EXECUTE on the role RPCs (F12/F17).
- Reviewed lifecycle: version provenance + review columns, content/freeze/
  author triggers, rounds/comments/acknowledgments, save/submit/withdraw/
  comment/acknowledge/decide, atomic publish_sheet_version(review_id) on the
  stored verdict, deprecate/archive/restore, species RPCs, equine working copy,
  uploads with the storage check (F7) + editor INSERT policy + 2 MiB bucket.
  F1-F3,F5,F6,F8,F9,F13,F15,F16 closed. Verdict is a fixture until M6 (V1-2.3).
- O22: SQL business mirror removed, declared status check kept; pgTAP 011 and
  the Rust generator's SQL parts deleted, ledger retargeted.
- Access layer sheets.ts (closed SheetFailure kinds); old client publish gate
  deleted; types regenerated; upload tool reads via get_sheet_asset_state.

Tested on the throwaway sandbox only; DEV untouched. pgTAP 850 (real stack) /
122 (PGlite) green; real-GoTrue AR-1 B + F18 race green; fresh install and
M3->M5 upgrade green; V1-1 regression green; rust:check, typecheck, lint,
build, types drift clean. BDR-084, LRN-095.
2026-10-28 15:52:49 +01:00

210 lines
16 KiB
PL/PgSQL

-- V1-2.1 M5: the official-sheet lifecycle, review workflow and publication.
-- Contract docs/development/V1-2_ANATOMICAL_SHEETS.md §6, §7, §9, §14, §15.
-- The verdict is written directly (as the table owner) to stand in for the
-- worker of M6, as the contract allows until V1-2.3. Real GoTrue MFA and the
-- concurrency cases run in tests/sandbox.
begin;
select plan(30);
-- Accounts: owner, editor+publisher, reviewer, and a reviewer who also edits
-- (so becomes a round author -> separation of duties).
insert into auth.users (id, email, email_confirmed_at) values
('e0000000-0000-0000-0000-000000000001', 'own@wf.local', now()),
('e0000000-0000-0000-0000-00000000000e', 'edpub@wf.local', now()),
('e0000000-0000-0000-0000-0000000000f1', 'rev1@wf.local', now()),
('e0000000-0000-0000-0000-0000000000f2', 'rev2@wf.local', now());
insert into auth.mfa_factors (id, user_id, factor_type, status, created_at, updated_at)
select gen_random_uuid(), id, 'totp', 'verified', now(), now() from auth.users
where email in ('own@wf.local','edpub@wf.local','rev1@wf.local','rev2@wf.local');
insert into auth.sessions (id, user_id, aal) values
('e1000000-0000-0000-0000-000000000001', 'e0000000-0000-0000-0000-000000000001', 'aal2'),
('e1000000-0000-0000-0000-00000000000e', 'e0000000-0000-0000-0000-00000000000e', 'aal2'),
('e1000000-0000-0000-0000-0000000000f1', 'e0000000-0000-0000-0000-0000000000f1', 'aal2'),
('e1000000-0000-0000-0000-0000000000f2', 'e0000000-0000-0000-0000-0000000000f2', 'aal2');
select set_config('request.jwt.claims', '', true);
select private.assign_platform_role(null, 'e0000000-0000-0000-0000-000000000001', 'owner');
select private.assign_platform_role(null, 'e0000000-0000-0000-0000-00000000000e', 'admin');
select private.assign_platform_role(null, 'e0000000-0000-0000-0000-0000000000f2', 'admin');
insert into public.anatomical_catalog_grants (user_id, grant_kind, reason, verification_note, granted_by) values
('e0000000-0000-0000-0000-00000000000e','sheet_editor','a','c','e0000000-0000-0000-0000-000000000001'),
('e0000000-0000-0000-0000-00000000000e','sheet_publisher','a','c','e0000000-0000-0000-0000-000000000001'),
('e0000000-0000-0000-0000-0000000000f1','sheet_reviewer','a','c','e0000000-0000-0000-0000-000000000001'),
('e0000000-0000-0000-0000-0000000000f2','sheet_editor','a','c','e0000000-0000-0000-0000-000000000001'),
('e0000000-0000-0000-0000-0000000000f2','sheet_reviewer','a','c','e0000000-0000-0000-0000-000000000001');
create table pg_temp.k(key text primary key, id uuid);
grant all on pg_temp.k to authenticated;
create function pg_temp.act(p uuid, s uuid) returns void language sql as $$
select set_config('request.jwt.claims', jsonb_build_object('sub',p,'role','authenticated','aal','aal2','session_id',s)::text, true);
$$;
grant execute on function pg_temp.act(uuid,uuid) to authenticated;
-- A small document; `st` is the review_status applied to its three elements.
create function pg_temp.doc(p_asset uuid, st text) returns jsonb language sql as $$
select jsonb_build_object('schema_version',2,'species_id','equine',
'name',jsonb_build_object('fr','Cheval WF','en','WF horse'),
'description',jsonb_build_object('fr','d','en','d'),
'scope_disclaimer',jsonb_build_object('fr','x','en','x'),
'attribution',jsonb_build_object('authors',jsonb_build_array('F'),'license',null,'notes',null),
'vertebral_config',jsonb_build_object('regions','[]'::jsonb),'references','[]'::jsonb,
'categories',jsonb_build_array(jsonb_build_object('id','c','name',jsonb_build_object('fr','C','en','C'),'color',null)),
'views',jsonb_build_array(jsonb_build_object('id','main','kind','main','name',jsonb_build_object('fr','V','en','V'),'svg_asset_id',p_asset,'view_box',null)),
'annotations',jsonb_build_array(jsonb_build_object('id','a1','kind','point','view_id','main','category_id','c',
'laterality','unpaired','geometry',null,'review_status',st,'name',jsonb_build_object('fr','P','en','P'),
'finding_zone_id','z1','vertebral_region_code',null)),
'finding_zones',jsonb_build_array(jsonb_build_object('id','z1','name',jsonb_build_object('fr','Z','en','Z'),
'categories',jsonb_build_array(jsonb_build_object('id','cat','kind','dysfunction','name',jsonb_build_object('fr','D','en','D'),
'review_status',st,'children',jsonb_build_array(jsonb_build_object('id','n1','name',jsonb_build_object('fr','N','en','N'),'review_status',st)))))));
$$;
grant execute on function pg_temp.doc(uuid,text) to authenticated;
-- Writes a passing verdict on a round and opens it (stands in for the worker).
create function pg_temp.open_round(p_review uuid, p_asset uuid, p_sha text) returns void language sql as $$
update public.anatomical_sheet_reviews set status='open', verified_at=now(), verified_with='test',
verdict = jsonb_build_object('fingerprint', repeat('a',64),
'drawings', jsonb_build_array(jsonb_build_object('asset_id', p_asset, 'sha256', p_sha)),
'groups', jsonb_build_array(
jsonb_build_object('key','general','digest',repeat('1',64),'coverable',true),
jsonb_build_object('key','view:main','digest',repeat('2',64),'coverable',true),
jsonb_build_object('key','zone:z1','digest',repeat('3',64),'coverable',true)))
where id = p_review;
$$;
set local role authenticated;
select pg_temp.act('e0000000-0000-0000-0000-00000000000e','e1000000-0000-0000-0000-00000000000e');
-- Create, register + confirm a drawing, save with elements still to_confirm.
insert into pg_temp.k select 'sheet', public.create_official_sheet('wf-sheet', pg_temp.doc(null,'to_confirm'));
insert into pg_temp.k select 'v1', id from public.anatomical_sheet_versions where sheet_id=(select id from pg_temp.k where key='sheet');
insert into pg_temp.k select 'asset', public.register_sheet_asset((select id from pg_temp.k where key='sheet'), repeat('7',64), 1000, 'd.svg');
reset role;
insert into storage.objects (bucket_id,name,metadata) values ('anatomical-sheet-assets', repeat('7',64)||'.svg', '{"size":1000}');
set local role authenticated; select pg_temp.act('e0000000-0000-0000-0000-00000000000e','e1000000-0000-0000-0000-00000000000e');
select public.confirm_sheet_asset_upload((select id from pg_temp.k where key='asset'));
-- A stale revision is a conflict.
select throws_ok($$ select public.save_sheet_draft((select id from pg_temp.k where key='v1'), 9, pg_temp.doc(null,'to_confirm'), 'x') $$,
'P0001', 'draft_conflict', 'save with a stale expected_revision is a conflict');
-- An unchanged document is refused.
select public.save_sheet_draft((select id from pg_temp.k where key='v1'), 0, pg_temp.doc((select id from pg_temp.k where key='asset'),'to_confirm'), 'wire');
select throws_ok($$ select public.save_sheet_draft((select id from pg_temp.k where key='v1'), 1, pg_temp.doc((select id from pg_temp.k where key='asset'),'to_confirm'), 'again') $$,
'P0001', 'draft.unchanged', 'an unchanged save is refused');
-- Submit -> verifying; content is frozen.
insert into pg_temp.k select 'r1', public.submit_sheet_review((select id from pg_temp.k where key='v1'), 1, 'review please');
select is((select status::text from public.anatomical_sheet_reviews where id=(select id from pg_temp.k where key='r1')), 'verifying', 'round is verifying');
select throws_ok($$ select public.save_sheet_draft((select id from pg_temp.k where key='v1'), 1, pg_temp.doc((select id from pg_temp.k where key='asset'),'reviewed'), 'x') $$,
'55000', 'draft.frozen', 'the draft is frozen while a round runs');
select throws_ok($$ select public.submit_sheet_review((select id from pg_temp.k where key='v1'), 1, 'x') $$,
'55000', 'round.open', 'a second non-terminal round is refused');
-- Open the round with a passing verdict (worker stand-in).
reset role;
select pg_temp.open_round((select id from pg_temp.k where key='r1'), (select id from pg_temp.k where key='asset'), repeat('7',64));
set local role authenticated;
-- Approval is refused while an element is to_confirm (D2: counts as not reviewed).
select pg_temp.act('e0000000-0000-0000-0000-0000000000f1','e1000000-0000-0000-0000-0000000000f1');
select throws_ok($$ select public.decide_sheet_review((select id from pg_temp.k where key='r1'), true, 'ok') $$,
'P0001', 'publish.inherited.present', 'approval refused while an element is to_confirm');
-- Reviewer requests changes; editor marks reviewed and resubmits.
select public.decide_sheet_review((select id from pg_temp.k where key='r1'), false, 'please mark reviewed');
select is((select status::text from public.anatomical_sheet_reviews where id=(select id from pg_temp.k where key='r1')), 'changes_requested', 'round is changes_requested');
select pg_temp.act('e0000000-0000-0000-0000-00000000000e','e1000000-0000-0000-0000-00000000000e');
select public.save_sheet_draft((select id from pg_temp.k where key='v1'), 1, pg_temp.doc((select id from pg_temp.k where key='asset'),'reviewed'), 'all reviewed');
insert into pg_temp.k select 'r2', public.submit_sheet_review((select id from pg_temp.k where key='v1'), 2, 'round 2');
reset role;
select pg_temp.open_round((select id from pg_temp.k where key='r2'), (select id from pg_temp.k where key='asset'), repeat('7',64));
set local role authenticated;
-- An author of the round cannot acknowledge nor approve (separation).
select pg_temp.act('e0000000-0000-0000-0000-0000000000f2','e1000000-0000-0000-0000-0000000000f2');
-- rev2 is a reviewer but NOT an author of this draft, so it may acknowledge.
-- Make rev2 an author by saving once would freeze; instead prove the rule with
-- the editor (edpub is an author and holds no reviewer grant): rights first.
select pg_temp.act('e0000000-0000-0000-0000-00000000000e','e1000000-0000-0000-0000-00000000000e');
select throws_ok($$ select public.acknowledge_sheet_review_group((select id from pg_temp.k where key='r2'),'general',repeat('1',64)) $$,
'42501', 'rights.capability', 'the editor (author, no reviewer grant) cannot acknowledge');
-- Reviewer acknowledges every group, with a digest check and an unread guard.
select pg_temp.act('e0000000-0000-0000-0000-0000000000f1','e1000000-0000-0000-0000-0000000000f1');
select throws_ok($$ select public.acknowledge_sheet_review_group((select id from pg_temp.k where key='r2'),'general',repeat('9',64)) $$,
'P0001', 'review.digest', 'a digest mismatch is refused');
select public.acknowledge_sheet_review_group((select id from pg_temp.k where key='r2'),'general',repeat('1',64));
select public.acknowledge_sheet_review_group((select id from pg_temp.k where key='r2'),'view:main',repeat('2',64));
-- approval refused while one group is still uncovered
select throws_ok($$ select public.decide_sheet_review((select id from pg_temp.k where key='r2'), true, 'ok') $$,
'P0001', 'review.groups.uncovered', 'approval refused while a group is uncovered');
select public.acknowledge_sheet_review_group((select id from pg_temp.k where key='r2'),'zone:z1',repeat('3',64));
select public.decide_sheet_review((select id from pg_temp.k where key='r2'), true, 'approved');
select is((select status::text from public.anatomical_sheet_reviews where id=(select id from pg_temp.k where key='r2')), 'approved', 'round approved');
-- A reviewer cannot publish; the publisher publishes.
select throws_ok($$ select public.publish_sheet_version((select id from pg_temp.k where key='r2')) $$,
'42501', 'rights.capability', 'a reviewer cannot publish');
select pg_temp.act('e0000000-0000-0000-0000-00000000000e','e1000000-0000-0000-0000-00000000000e');
select is(public.publish_sheet_version((select id from pg_temp.k where key='r2')), (select id from pg_temp.k where key='v1'), 'the publisher publishes the approved round');
select is((select status::text from public.anatomical_sheet_versions where id=(select id from pg_temp.k where key='v1')), 'published', 'version is published');
select is((select (public.get_sheet_version((select id from pg_temp.k where key='v1'))) ->> 'fingerprint'), repeat('a',64), 'the fingerprint comes from the verdict');
-- An asset row cannot be mutated (F16); the reader account is seeded here too.
reset role;
select throws_ok($$ update public.anatomical_sheet_assets set sha256 = repeat('0',64) where id=(select id from pg_temp.k where key='asset') $$,
'42501', null, 'an asset row sha256 is immutable (F16)');
insert into auth.users (id,email,email_confirmed_at) values ('e0000000-0000-0000-0000-0000000000cc','reader@wf.local',now());
insert into public.anatomical_catalog_grants (user_id,grant_kind,reason,granted_by)
values ('e0000000-0000-0000-0000-0000000000cc','catalog_reader','beta','e0000000-0000-0000-0000-000000000001');
-- A catalogue reader sees the published version and its drawing; not the grants.
set local role authenticated;
select pg_temp.act('e0000000-0000-0000-0000-0000000000cc', gen_random_uuid());
select is((select jsonb_array_length(public.list_official_catalog())), 1, 'the reader sees one catalogue sheet');
select is((select (public.get_sheet_version((select id from pg_temp.k where key='v1'))) ->> 'status'), 'published',
'the reader reads the published version by id');
-- Deprecate, then the version is still readable by id (D8).
select pg_temp.act('e0000000-0000-0000-0000-00000000000e','e1000000-0000-0000-0000-00000000000e');
select public.deprecate_sheet_version((select id from pg_temp.k where key='v1'), 'superseded');
select pg_temp.act('e0000000-0000-0000-0000-0000000000cc', gen_random_uuid());
select is((select (public.get_sheet_version((select id from pg_temp.k where key='v1'))) ->> 'status'), 'deprecated',
'a deprecated version stays readable by id (D8)');
select is((select jsonb_array_length(public.list_official_catalog())), 0, 'the sheet leaves the catalogue list once its last version is deprecated');
-- ============ Species rules (§7.2) ============
select pg_temp.act('e0000000-0000-0000-0000-00000000000e','e1000000-0000-0000-0000-00000000000e');
select is(public.create_species('tapir','Tapir','Tapir',60), 'tapir', 'an editor creates an inactive species');
select is(
(select (g ->> 'active')::boolean from jsonb_array_elements(public.list_catalog_species()) g where g ->> 'id' = 'tapir'),
false, 'the new species is inactive (seen through the admin list)');
select throws_ok($$ select public.create_species('other','x','x') $$, 'P0001', 'invalid_input', 'the id other is refused');
select throws_ok($$ select public.activate_species('tapir') $$, '42501', 'rights.owner', 'an editor cannot activate a species');
-- inactive species invisible in the animal path (species_select_active unchanged)
select is((select count(*) from public.species where id='tapir'), 0::bigint, 'an inactive species is invisible under species_select_active (animal forms)');
select pg_temp.act('e0000000-0000-0000-0000-000000000001','e1000000-0000-0000-0000-000000000001');
select is(public.activate_species('tapir'), 'tapir', 'the owner activates the species');
select is((select active from public.species where id='tapir'), true, 'the species is now active');
-- ============ Working copy restricted to the historical sheet (§14.3) ============
select pg_temp.act('e0000000-0000-0000-0000-00000000000e','e1000000-0000-0000-0000-00000000000e');
select throws_ok($$ select public.create_sheet_working_copy((select id from pg_temp.k where key='v1'), 'copie') $$,
'P0001', 'working_copy.source_invalid', 'a working copy of a non-historical version is refused');
-- ============ Base only from a round-published version (§6.2) ============
-- v1 was published through r2 (a V1-2 round), so a new draft takes it as base
-- (passed explicitly, since deprecating the only published version cleared the
-- sheet's current version).
insert into pg_temp.k select 'v2', public.create_sheet_draft(
(select id from pg_temp.k where key='sheet'), (select id from pg_temp.k where key='v1'), 'new edition');
reset role;
select is(
(select (source_version_id = (select id from pg_temp.k where key='v1')) from public.anatomical_sheet_versions where id=(select id from pg_temp.k where key='v2')),
true, 'a draft derived from a round-published version records it as its base');
-- The publish gate: a direct UPDATE of a real draft to published is refused for
-- the table owner (no approved round named).
select throws_ok($$ update public.anatomical_sheet_versions set status='published', published_at=now(), document_fingerprint=repeat('a',64)
where id=(select id from pg_temp.k where key='v2') $$,
'42501', 'publish.review.missing', 'no direct UPDATE publishes a draft, even for the table owner');
select * from finish();
rollback;