Checkpoint page §7: criteria and gates, exact shell suite at da95b84
(188 passed, 90 skipped, 4 failed in admin.spec.ts:717), the five
out-of-scope files and three one-for-one assertion rewrites accepted
by the owner with their justification, reservations kept in U1.
Owner trial: canvas widths, trial-lan not run, the admin failures.
311 lines
30 KiB
Markdown
311 lines
30 KiB
Markdown
# V1-2.6 UX U1: authorisation checkpoint
|
|
|
|
Status: U1 implemented; owner validation checkpoint open (section 7, 2026-11-09). Written FOR THE OWNER'S U1
|
|
AUTHORISATION, 2026-11-06 (brief « U1 / U2b — Derniers arbitrages avant
|
|
implémentation »). This page presents the plan `.claude/tasks/plans/2026-11-06-v1-2-6-ux-u1.md` as committed at
|
|
2e46c14, without changing it, and its contract `.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md`. Nothing
|
|
here authorises code, a sandbox reset or any data deletion. « Plan :n » is a line of the plan file at 2e46c14.
|
|
|
|
Already recorded: approach A with the owner's ten precisions and four answers (server save time, non-modal references
|
|
panel, citation button in the finding's detail, board 01 annotation card), contract CLARIFICATIONS [gated
|
|
2026-11-06]; the U1 design confirmed on 2026-11-06 (BDR-104). Left for the owner: sections 1, 2 and 4, and the
|
|
residual point of section 3.
|
|
|
|
## 1. The 18 visible choices (plan :589-626)
|
|
|
|
The « Choice » column quotes the plan. The recommendation is the plan's choice in every row.
|
|
|
|
| # | Choice (plan wording) | Alternatives | Consequences |
|
|
|---|---|---|---|
|
|
| 1 | Unsaved count = accepted changes between the shown and the saved document along the history; « Modifications non enregistrées » without a number when the saved text is no longer in the history (restored copy, trim, a change made after undoing past the save). | (b) never a number, always « Modifications non enregistrées »: simplest, loses the boards' figure; (c) a counter of commits since the save: false after undos and during saves (three challengers) | A `savedDistance` selector over the history, no store field (plan :289-293); Lot E table tests; the number is never false, sometimes absent |
|
|
| 2 | After `draft.unchanged`: « Enregistré · révision n », without a time. | (b) the server time of the earlier save, shown as if it were now; (c) the browser clock, excluded by the owner (server time only) | `readSaveTime` is not called on `draft.unchanged` (plan :305-311) |
|
|
| 3 | Annuler and Rétablir stay enabled during a save, as Ctrl+Z (amends AC4). | (b) disabled while saving, as AC4 says: the buttons and Ctrl+Z disagree | The store already accepts a step during a save and keeps it unsaved (`editorSave.ts:118`); AC4 amended (2.2); Lot E test « enabled while saving and in step with Ctrl+Z » |
|
|
| 4 | Typed text then « Annuler »: the typed text is the last change and is undone, even when the history was empty (AC5). | (b) the button undoes the last committed change and leaves the typed text; (c) the button disabled while a field holds uncommitted text | `commitFocusedField()` at pointerdown (plan :278-281); with choice 18 for a refused value; AC5 amended (2.3) |
|
|
| 5 | Below 640 px: Annotations and Vérification shown, Général and Constats under « Plus »; history icon-only. | (b) four tabs in a horizontal scroll; (c) Général and Annotations shown | Today's « Plus » rule minus the removed tabs (plan :172-175); tier test at 500 px; focus fallback to « Plus » |
|
|
| 6 | From 1 024 to 1 279 px today's top bar with the menu button stays; board 13's merged row is not built; the header's right group wraps under the title when needed. | (b) board 13's merged row (title, tabs and actions on one line) | Lot F; a visible difference from board 13; Lot H checks no horizontal scroll at 1 024, 1 180 and 1 279 px |
|
|
| 7 | Board 12 A's save-failure strip is not built; today's `SaveFailureNotice` stays. | (b) build the strip of board 12 A | The save mechanism and its messages unchanged in U1 (AC14); a visible difference from board 12 A |
|
|
| 8 | « Régions vertébrales » sits in the Catégories card; read-only entries read « Voir les vues » and « Voir les catégories ». | (b) a card of its own for the regions; (c) the edit labels in read-only too | T17 fallback entry beside the categories (BDR-102), no role logic; read-only label tests in `editor-sections.test.tsx` |
|
|
| 9 | The annotation card shows every row (no « Voir les n annotations » truncation); the filter matches the displayed name. | (b) board 01's truncation with « Voir les n annotations » | 19 rows on the equine main view, 9 on the head view; a long card on large sheets, with « Filtrer par nom » |
|
|
| 10 | Panel: search on citation, DOI and URL; ↑/↓ only on the unfiltered list; focus on its heading at opening. | (b) search on the citation only; (c) ↑/↓ on a filtered list, which reorders among a hidden subset | Lot D tests; `folded` shared |
|
|
| 11 | Undo that removes the view shown on the canvas: back to the main view, a pending creation or tracing on the removed view is dropped (it can no longer be created there). | (b) keep the pending creation, which would be written on the main view (robustness MAJOR 2); (c) refuse that undo | Full canvas reset, dispatched only when the shown view is gone (plan :214-219); Lot B1 tests |
|
|
| 12 | « Aller à » an annotation while a creation is pending or a tracing is open: it is kept and shown, focus on its panel or bar, an announcement; no jump until it is finished or abandoned. | (b) jump and drop it (confirmation MAJOR 2); (c) ask in a dialog | Plan :220-225; Lot B1 and B2 tests |
|
|
| 13 | Keyboard order: header → tab list → Annuler/Rétablir → panel when open → tab panel content in visual order (tools, canvas, side column); the TESTS wording « panel → canvas » would put the DOM order against the visual one. | (b) the TESTS wording | AC17 amended (2.5); Lot H keyboard walk |
|
|
| 14 | Focus after « Retour au dessin »: the section's entry button, else the canvas box. | (b) always the canvas box; (c) the Annotations tab | Never `body`; Lot B1 and B2 tests |
|
|
| 15 | Announcements: « {Onglet} » or « {Onglet} · {Section} », « Références »; save status announced on state changes only, not on each count change; the Vérification badge text is part of the tab's name. | (b) every count change announced; (c) no live region, which AC12 rules out | One polite region for moves, a separate status for the save (plan :127-130, :303-304) |
|
|
| 16 | Discard confirmation adds the copy sentence whenever a copy is stored. | (b) only when the last write succeeded (`copyWritten`), which can delete a copy without naming it (robustness MAJOR 4) | `copyExists` read when the dialog opens (plan :313-317); Lot E tests including a quota refusal |
|
|
| 17 | Vues card rows without the drawing thumbnail of board 01: a second composition of each view would repeat the core's ids in the page (section 2); name, kind and annotation count only. | (b) raster thumbnails, new code and a render cost; (c) ids scoped per instance in the core, a Rust change outside U1 | A visible difference from board 01 |
|
|
| 18 | A typed value the field refuses (e.g. a name left empty) is not followed by an undo: « Annuler » leaves the history alone and returns focus to the field with its message. | (b) undo the previous change anyway, possibly on another tab | Plan :282-283; Lot E test |
|
|
|
|
## 2. Contract amendments (plan :627-647)
|
|
|
|
The plan proposes five amendments of acceptance criteria (2.1 to 2.5) and three other contract changes (2.6 to 2.8).
|
|
The owner's rule on data deletion adds a clarification (2.9). Each is applied to the contract only on the owner's
|
|
approval; the « current » texts are the contract's, verbatim.
|
|
|
|
### 2.1 AC3
|
|
|
|
Current: « References open in a side panel after board 11, from a « Références » button in the header and from a
|
|
finding (its citation badge), filtered to that finding's citations with « Tout afficher », with search, the citation
|
|
count per reference, and the level-1 add / edit / delete; read-only (no edit control) in every read-only mode; a modal
|
|
panel uses `ModalDialog` (D13, BDR-076); closing returns focus to the opener. »
|
|
|
|
Proposed: « References open in a non-modal side panel after board 11, anchored below the tab row so that it never
|
|
covers the draft header or the tab row, from a « Références » button in the header and from the selected finding's
|
|
detail (a « n référence(s) » button in its Citations block), filtered to that finding's citations with « Tout afficher
|
|
(N) », with search on citation, DOI and URL, the citation count per reference, and the level-1 add / edit / delete; a
|
|
scrim covers the tab panels, which are `inert` while the panel is open; the header, the tab row, « Annuler »,
|
|
« Rétablir » and Ctrl+Z stay usable; Escape, ✕ or a click on the scrim closes it, and focus returns to the opener,
|
|
else to the header « Références » button; read-only (no edit control) in every read-only mode; the panel is not a
|
|
`ModalDialog`, and every dialog opened from it stays one (D13, BDR-076). »
|
|
|
|
### 2.2 AC4
|
|
|
|
Current: « Undo and redo sit at the right of the tab row on every tab (board `hist()`): icon and visible « Annuler » /
|
|
« Rétablir »; « Annuler » has the accessible name and tooltip « Annuler la dernière modification » (T15); redo's long
|
|
name is a label proposal; enabled exactly when the store can undo or redo AND the editor is in edit mode with no
|
|
recovery pending; disabled in every read-only mode (narrow, frozen, rights, inactive, historical, recovery pending,
|
|
saving); the same `undo()`/`redo()` store actions as today, history and its 8 MiB bound unchanged; Ctrl+Z and
|
|
Ctrl+Shift+Z unchanged; the undo and redo buttons of the tool column are removed (no pair on the drawing). »
|
|
|
|
Proposed: the same text with « disabled in every read-only mode (narrow, frozen, rights, inactive, historical,
|
|
recovery pending); enabled while a save is in flight, as Ctrl+Z (a step taken during a save stays unsaved) » in place
|
|
of « disabled in every read-only mode (narrow, frozen, rights, inactive, historical, recovery pending, saving) ».
|
|
|
|
### 2.3 AC5
|
|
|
|
Current: « Undo from any tab reverts the last accepted commit, whichever tab made it; a field holding typed text is
|
|
committed before the header undo, and that commit is what the undo reverts (behaviour pinned by a test). »
|
|
|
|
Proposed: « Undo from any tab reverts the last accepted commit, whichever tab made it; a field holding typed text is
|
|
committed before the header undo (blur forced at pointerdown; keyboard users reach the button with Tab, which blurs
|
|
the field), and that commit is what the undo reverts, also when the history was empty before it; when the field
|
|
refuses the value (its error shown), no undo happens and focus returns to the field (behaviours pinned by tests). »
|
|
|
|
### 2.4 AC7
|
|
|
|
Current: « The header save line follows the boards: « n modification(s) non enregistrée(s) » while unsaved (count
|
|
through the existing plural mechanism), « Enregistrement… » while saving, « Enregistré à hh:mm · révision n » after a
|
|
save in this page session; « Révision n » when nothing was saved yet in the session; the save mechanism itself
|
|
unchanged. »
|
|
|
|
Proposed: « The header save line follows the boards, first matching form: a recovery copy issue (cap or quota),
|
|
today's text; « Enregistrement… » while saving; while unsaved, « n modification(s) non enregistrée(s) » (plural
|
|
mechanism) when n, the number of accepted changes between the shown and the saved document along the history, is
|
|
a positive number, else « Modifications non enregistrées »; after a save confirmed by the server in this page session,
|
|
« Enregistré à hh:mm · révision n » when one read of the existing admin endpoint returns that revision's save time,
|
|
else « Enregistré · révision n » (also after `draft.unchanged`), never the browser clock; « Révision n » when nothing
|
|
was saved in the session; state changes announced, not each count change; the save mechanism itself unchanged. »
|
|
|
|
### 2.5 AC17
|
|
|
|
Current, last item: « … a keyboard test of the order header → tabs → panel → canvas. »
|
|
|
|
Proposed, last item: « … a keyboard test of the order header → tab list → « Annuler » / « Rétablir » → references
|
|
panel when open → tab panel content in visual order (tools, canvas, side column). »
|
|
|
|
### 2.6 FILE SCOPE (plan :634-639, quoted)
|
|
|
|
« add `apps/app/src/editor/{navigation,saveLine,useEditorNavigation,sheetDocument}.ts`,
|
|
`apps/app/src/editor/references/citations.ts`, `apps/app/src/editor/annotations/{overview,useCanvasBuild}.ts`
|
|
(overview new; the build hook detaches while hidden; the canvas reset uses the existing `view` action of
|
|
`uiState.ts`, unchanged), `apps/app/src/catalogue/useCatalogue.ts` (export `folded` only),
|
|
`apps/app/e2e/lan/trial-lan.spec.ts`; `editor/state/*` edits limited to `lastSave` and `readSaveTime`. »
|
|
|
|
### 2.7 Design criteria tagged [gated] (plan :640-645, quoted)
|
|
|
|
« no loss on a tab, section or panel change (Lots B2, D tests); « Retour au dessin » focus and context; history tests
|
|
on typed text, shortcuts and section transitions; save shown only after the server answer, time only from the
|
|
server; read-only below 1 024 px on every moved form and shortcut; counts from the current document without network;
|
|
no « Prévisualiser », no withdrawal, no removed function; T17 entry without role logic; discard confirmation naming
|
|
the stored copy; sections replaceable through one registry. »
|
|
|
|
### 2.8 Documented limit (plan :646-647, quoted)
|
|
|
|
« creation forms unmount on a width change across 1 024 px or a recovery decision, as in level 1. »
|
|
|
|
### 2.9 Clarification required by the owner's rule on data deletion
|
|
|
|
Proposed, added to the contract's CLARIFICATIONS at the authorisation: « Q: sandbox data deletion / A: [gated] the
|
|
plan approval authorises no deletion of data, sandbox included. Before each `pnpm db:sandbox down` or
|
|
`pnpm db:sandbox up fresh` (Lot B1, Lot I or any other), the executor stops, reports the read-only inventory of
|
|
section 4 and runs the reset only on the owner's explicit go for that reset. This clarification prevails over plan
|
|
:38-40 and :397. » The plan text stays as committed.
|
|
|
|
## 3. Independent audits of the plan
|
|
|
|
Three blind challengers on the first draft, then one confirmation challenger on the revised plan. Original reports,
|
|
verbatim: `.claude/audits/2026-11-06-v1-2-6-u1-plan-challenges.md`.
|
|
|
|
| Pass | Verdict | MAJOR | MINOR | BLOCKER |
|
|
|---|---|---|---|---|
|
|
| Correctness, first draft | CONCERNS | 6 | 7 | 0 |
|
|
| Robustness, first draft | CONCERNS | 5 | 10 | 0 |
|
|
| Simplicity, first draft | CONCERNS | 2 | 7 | 0 |
|
|
| Correctness, confirmation pass | CONCERNS | 3 | 5 | 0 |
|
|
|
|
Every MAJOR and where the plan answers it:
|
|
|
|
| Pass, # | Finding | Resolution in the plan |
|
|
|---|---|---|
|
|
| Correctness 1 | The planned `nextSaveDistance` counter shows a false count after commits made during a save | Counter dropped; `savedDistance` derived from the history (§6, plan :289-293); the challengers' sequences in the Lot E table |
|
|
| Correctness 2 | `<Activity>` re-runs effects on reveal: the findings tree re-focuses (`FindingTree.tsx:31-33`) | `<Activity>` replaced by kept-mounted `hidden` wrappers (§2, plan :142-145); `focusId` one-shot (plan :108-110); no focus in mount effects (plan :51-52); LRN-119 |
|
|
| Correctness 3 | Same cause: zoom and pan reset on each return (`useFraming.ts:69`) | Same change: with `hidden`, no effect runs on a switch; Lot B2 keep-alive tests on zoom |
|
|
| Correctness 4 | Lot B depends on Lot D; two level-1 editors unreachable in between | Lot B split into B1 and B2; the overview's Vues and Catégories entries moved to B1 (plan :376-398) |
|
|
| Correctness 5 | The LAN trial suite would break silently | `trial-lan.spec.ts` in B1, E and H (plan :394, :473, :526) |
|
|
| Correctness 6 | The history-button spec contradicted itself on typed text | AC5 followed, pointerdown blur, test rewritten (choice 4, amendment 2.3) |
|
|
| Robustness 1 | The references panel covers the header controls | Panel anchored below the tab row in a positioned container (plan :238-241); Lot D Chromium click checks at 1 024 and 1 280 px |
|
|
| Robustness 2 | A pending creation written on the main view after its view vanished | Full canvas reset, guarded dispatch (choice 11, plan :214-219) |
|
|
| Robustness 3 | The counter misses trims and edits during a save | Same as Correctness 1 |
|
|
| Robustness 4 | The discard confirmation can delete a copy without naming it | `copyExists` read at opening (choice 16) |
|
|
| Robustness 5 | Hidden copies matched by label and text locators | `data-place` scoping, no page-wide non-role query (plan :60-61), unique ids test in B2 |
|
|
| Simplicity 1 | The unsaved-count machinery duplicates the history | Same as Correctness 1: one selector, no store field |
|
|
| Simplicity 2 | Lot B is several lots in one | Split into B1 and B2 |
|
|
| Confirmation 1 | Kept-mounted places lose the commit that a tab switch made on unmount | `commitFocusedField()` before every move (plan :117-122), tests in B2 |
|
|
| Confirmation 2 | « Aller à » drops a tracing in progress | The keep rule covers `ui.tracing` (choice 12, plan :220-225) |
|
|
| Confirmation 3 | Lots run only the specs they touch and miss specs they break | Every `editor-*.spec.ts` at every lot from B1 (plan :55-59) |
|
|
|
|
The 29 MINOR findings are integrated as the plan's « Challenge record » lists them (plan :668-685). Residual point:
|
|
the fixes for the confirmation pass's three MAJOR were not re-checked by a fresh challenger (the plan applies
|
|
`challenge-plan.md`: no further pass, the owner decides). They are re-checked during execution by the lot tests named
|
|
above and by the final fresh verifier (Lot I). A targeted re-check before execution is possible on request.
|
|
|
|
## 4. Sandbox: exact scope of the planned resets
|
|
|
|
Where the plan resets the sandbox:
|
|
|
|
- Lot B1, before the first e2e run: `pnpm db:sandbox up fresh`, « wipes the trial data, authorised by this plan » (plan :397; plan :39: « Approving this plan authorises that wipe »).
|
|
- Lot I, in the gate order of AC18: « a new `pnpm db:sandbox up fresh` » (plan :537).
|
|
- Plan :59 says « The full suites run in Lot H and in the gate order of Lot I on a new fresh sandbox ». Read with
|
|
:537, only Lot I starts a new sandbox; Lot H runs on the one started in B1. The sentence can also be read as a reset
|
|
for Lot H, so the clarification of 2.9 covers any reset.
|
|
|
|
What a reset does. `up fresh` refuses to start while any `faunosteo_dbsandbox_*` container exists
|
|
(`scripts/db-sandbox.sh:242`), so each reset is `pnpm db:sandbox down` then `up fresh`; the plan does not name
|
|
`down`, which is the deletion:
|
|
|
|
- `down` (`scripts/db-sandbox.sh:262-267`) removes the containers `faunosteo_dbsandbox_worker_avatar`,
|
|
`_worker_verify`, `_trial_gateway`, `_gateway`, `_rest`, `_storage`, `_auth`, `_mail` and `_db`, the network
|
|
`faunosteo_dbsandbox_net`, and under `~/.cache/faunosteo-db-sandbox` the files `secrets.sh`, `db.env`, `auth.env`,
|
|
`storage.env`, `rest.env` and `service-header`. The stack has no Docker volume (`:4-6`): the data lives in the
|
|
containers.
|
|
- Lost: every sandbox account (seed accounts, accounts made with `trial-account`, fictitious e2e accounts), roles,
|
|
grants and MFA factors, sheets, drafts and versions, uploaded drawings and avatars, mails held by Mailpit, a running
|
|
trial gateway.
|
|
- `up fresh` (`:231-258`) then creates new containers with new secrets, applies every migration and the seed; the
|
|
seed accounts come back with a new session password.
|
|
- Not touched: DEV (the `supabase_*_faunosteo` containers), the folders `rehearsal` and `upgrade-base` under
|
|
`~/.cache/faunosteo-db-sandbox`, the repository, the Docker images, the browser's local recovery copies.
|
|
|
|
State on 2026-11-06 (read-only `docker ps -a` and directory listing): no `faunosteo_dbsandbox_*` container and no
|
|
`secrets.sh`; the sandbox is down and holds no trial data today. What exists when Lot B1 starts is what a reset would
|
|
delete.
|
|
|
|
Between resets, the e2e runs add their own data: fictitious accounts with random `@sandbox.local` addresses
|
|
(`apps/app/e2e/support/sandbox.ts:104-126`) and their records. A search of `apps/app/e2e` finds no delete statement;
|
|
some specs change shared state (the equine spec sets an active working copy aside first, level-1 plan Lot K). The
|
|
specs were not audited one by one for this page.
|
|
|
|
Procedure proposed under the owner's rule (2.9): before each reset, the executor stops and reports a read-only
|
|
inventory (sandbox containers, accounts outside the seed, sheets and drafts) and runs the reset only on the owner's
|
|
go. Alternatives: (b) the U1 authorisation names the two resets (B1, I) explicitly after the inventory; (c) no reset,
|
|
U1's suites on the sandbox as found, which drops AC18's fresh-sandbox gate and the order of LRN-113. Effect on the
|
|
lots: Lot A needs no sandbox; the e2e of B1 and of every later lot wait for the first go; the sandbox gates of Lot I (from `up fresh` on)
|
|
wait for the second.
|
|
|
|
## 5. Validation criteria per lot (plan :360-545)
|
|
|
|
Common to every lot (plan :362-363, :55-59): `pnpm typecheck`, `pnpm lint` and `pnpm test:run` green; from B1, every
|
|
`apps/app/e2e/shell/editor-*.spec.ts` green on the sandbox, a spec broken by the lot added to it, never skipped;
|
|
removed or rewritten assertions mapped in the commit message (R-24); commit and push. Plan :362 also names « the two
|
|
sentinels », which the plan never defines; the rule of :55-59 (every editor spec at every lot) covers them.
|
|
|
|
| Lot | Validated when |
|
|
|---|---|
|
|
| A · Navigation model (pure) | `editor-navigation.test.ts`: `targetOfKey` for the eight key kinds; `go_to` increments the serial and sets tab, section or panel; `select_tab` keeps section and panel without a focus request; `open_section`, `back_to_drawing`; `open_references` and `close_references` keep tab and section; `focus_consumed` clears only its serial; visited lists only grow. No sandbox |
|
|
| B1 · Four tabs, sections, minimal references panel, « Aller à » | Four tab names and tiers at 1 280, 800 and 500 px with « Plus »; focus requests reach their owner, never `body`; each issue « Aller à » its target; sections open with `h2` focused, « Retour au dessin » focuses the entry, region entry with no role code, read-only labels; an undo removing the shown view with a pending point or a tracing resets to the main view; « Aller à » keeps a pending creation or tracing; moved components' tests on new paths; no level-1 function unreachable; e2e specs that used removed tabs rewritten; `trial-lan.spec.ts` updated. First sandbox reset (section 4) |
|
|
| B2 · Kept-mounted places | Typed text in a form survives tab and section round trips; findings expansion and selection, canvas tool, selection and zoom survive; a field focused during a programmatic move is committed first (one undo entry, unsaved, leave guard armed); reference form text survives closing the panel; no duplicate `id` with every place visited, SVG ids included; requests reach only their owner; after an « Aller à » to a finding, arrowing back onto Constats keeps focus on the tab; one `JSON.parse` per document text; Chromium spec `editor-shell.spec.ts` on keep-alive and focus |
|
|
| C · Annotation card, side column from 1 024 px | `editor-overview.test.tsx`: card in edit and read-only, grouping in category order, filter ignoring case and accents, « Toutes les annotations » back to the card with focus on the row, view rows switch the canvas; grid from `lg`; overflow measured at 1 024 and 1 180 px before the CSS change |
|
|
| D · References panel complete | `citationCounts`; panel opened from the header and from a finding (chip, count, « Tout afficher (N) »), search on citation, DOI and URL, ↑/↓ hidden while filtered, Escape, ✕ and scrim close with focus back, tab panels `inert`, Ctrl+Z while open, undo removing the cited finding clears the filter, read-only without edit control, « Aller à » a reference hidden by a search; Chromium: Enregistrer, Annuler and Rétablir clickable with the panel open at 1 024 and 1 280 px, the panel never over the header or the tab row |
|
|
| E · Header history, save line, Abandonner | `savedDistance` and `saveLineState` tables; `readSaveTime` rules; `editor-history-buttons.test.tsx` (names T15, enabled and disabled states per mode, enabled while saving, cross-tab undo, typed text undone, refused commit skips the undo, Ctrl+Z inside a field, Ctrl+Z ignored under a dialog, no pair in the tool column); save status announces transitions only; discard confirmation with and without the copy sentence, quota case |
|
|
| F · Editor sidebar from 1 280 px | `xl` set on the editor path, `lg` elsewhere; drawer closing rules (80rem in the editor, at setup too); leave guard on drawer links; Chromium: sidebar hidden at 1 024, 1 180 and 1 279 px, shown at 1 280 px, menu in one tap |
|
|
| G · Label proposals and parity | `.claude/audits/2026-11-06-v1-2-6-u1-label-proposals.md` written; dead keys removed after grep; AC20 parity command |
|
|
| H · Browser journeys and full suites | Journeys of plan :516-525 (four tabs, cross-tab undo, typed text, Ctrl+Z, each « Aller à », save line sequence, no horizontal scroll at the listed widths, width change below 1 024 px, keyboard walk, axe without serious or critical violation); commit-to-paint with every place visited, above 500 ms STOP; whole shell suite; C13, C14, C16, C34, C41 green; `trial-lan.spec.ts` run or recorded as not run |
|
|
| I · Docs, gates, checkpoint | Owner trial doc and UX docs updated; gates in the AC18 order, each with command and result, the second sandbox reset (section 4) between `pnpm e2e:ui` and `pnpm db:sandbox test-db`; AC19 and AC20 checks; a fresh verifier on the enriched contract; a fresh security review on `846994b..HEAD`; checkpoint report; STOP, no U2 |
|
|
|
|
## 6. What the authorisation decides
|
|
|
|
- The 18 choices of section 1, confirmed or changed.
|
|
- The amendments 2.1 to 2.9.
|
|
- The sandbox procedure of section 4: a go per reset (proposed), or both resets named in the authorisation.
|
|
- Whether the confirmation pass's fixes get a targeted re-check before execution (section 3).
|
|
|
|
## 7. Execution record (owner checkpoint, 2026-11-09)
|
|
|
|
Owner decisions: brief « V1-2.6 UX — Décisions au checkpoint U1 », 2026-11-09 (BDR-106). U1 implementation is done;
|
|
the owner's validation checkpoint stays open until the manual trial (`V1-2-6_OWNER_TRIAL.md` §4.9 and « Limites
|
|
connues de U1 »). U2 is not started.
|
|
|
|
### 7.1 Criteria and gates
|
|
|
|
- Pre-code counter-check: CONFORME at 9ec232a (three confirmation-pass fixes, precautions 2.8 and AC7).
|
|
- Lots A to I, 26 commits 9ec232a..da95b84, each reviewed per lot; ledger in the SDD workspace.
|
|
- Fresh verifier on 9ec232a..942d52a: the 22 acceptance criteria MET, AC18 gates included. Its two gaps are the
|
|
files and assertions of 7.2, accepted by the owner.
|
|
- Security gate on 846994b..81fba46: PASS, 0 blocking, 3 LOW (static mockup `innerHTML`; hidden edit-only inputs
|
|
stay live, refused by the store's `blockKind`; partial semgrep parse on tests). Not re-run on the final fixes
|
|
(0467885, da95b84: interface and tests only, no new data or access path).
|
|
- Final whole-branch review: ready with fixes; the fixes landed in 0467885 and da95b84, and the scoped re-review
|
|
found every finding addressed and no new Critical or Important issue.
|
|
- Tests at da95b84: typecheck and lint green; `test:run` app 1 280, supabase 159, core-wasm 66; `e2e:ui` 227.
|
|
- Whole shell suite at da95b84: 188 passed, 90 skipped, 4 failed. It is not green on the last commit. The four
|
|
failures are `admin.spec.ts:717` (fr and en, desktop and 375 px): « Créer une copie de travail » is disabled
|
|
because the historical sheet's single working-copy slot (`WorkingCopyAction.tsx:88`) was taken by an earlier run
|
|
on the same sandbox. Probable sandbox-state dependency, to confirm by a non-destructive reproduction or an
|
|
isolated test; no sandbox reset was made to obtain a green result.
|
|
- Earlier evidence, not of the last commit: at 81fba46 on the sandbox recreated under the owner's go of
|
|
2026-11-08, `e2e-shell` 192 passed, 0 failed; `test-db` 1 992; `db:sandbox test` 105; `check:all` passed;
|
|
`r5:import-equine --check` 0 differences.
|
|
- Not run: `e2e/lan/trial-lan.spec.ts` (needs the LAN trial stack); its revision reading is unit-tested on the real
|
|
save-line strings (`tests/unit/e2e-save-line-text.test.ts`).
|
|
|
|
### 7.2 Accepted by the owner, with their justification
|
|
|
|
Files outside the initial FILE SCOPE (executor rulings, contract CLARIFICATIONS « Files outside FILE SCOPE added
|
|
during execution »):
|
|
|
|
| File | Lot | Justification |
|
|
|---|---|---|
|
|
| `components/catalogue/CatalogueCanvas.tsx` | B2a | the catalogue canvas detaches its tree while hidden, like the editor canvases |
|
|
| `lib/placeVisibility.ts` | B2a | the visibility context in a neutral lib, so the catalogue does not import the editor |
|
|
| `editor/editingContext.ts` | B2b | `EditOnly` and `useEverEditable`, precaution 2.8 |
|
|
| `editor/references/filter.ts` | D | the panel filter split from `citations.ts` |
|
|
| `components/shell/ShellChrome.tsx` | F | `Sidebar` and `TopBar` split from `AppLayout.tsx` for the function limits |
|
|
|
|
Assertion lines rewritten one for one (floor guard ASSERT_DROP; `expect(` per file unchanged; mapping in the body of
|
|
99b669b, Lot E):
|
|
|
|
| Test | Assertion lines | `expect(` in the file | Rewrite |
|
|
|---|---|---|---|
|
|
| `e2e/shell/editor-journey.spec.ts:14` | 8 → 4 | 37 → 37 | undo/redo and revision text → `historyButton` and `saveLine` helpers |
|
|
| `e2e/shell/editor-recovery.spec.ts:7` | 4 → 2 | 41 → 41 | revision and unsaved text → `saveLine` helpers |
|
|
| `tests/unit/editor-route-recovery.test.tsx:93` | 8 → 5 | 45 → 45 | « Revision n » and copy_cap / copy_quota text queries → the save-line testid |
|
|
|
|
These acceptances do not widen the scope of later steps.
|
|
|
|
### 7.3 Reservations kept
|
|
|
|
Kept in U1, not moved to U2:
|
|
|
|
- N4: a field that switches in place to read-only loses a value the save refused.
|
|
- N6: an upload in flight at a narrow crossing still attaches.
|
|
- Repair window: the refusal `result` and an unparseable geometry draft are not kept across a crossing.
|
|
- Local recovery copy: held in the tab's `sessionStorage`, lost with the tab.
|
|
- References panel: the tab panels are `inert` while it is open (keyboard reaches them after closing).
|
|
- Widths (choice 2.6): canvas 538 px at 1 024 and 1 280 px, 694 at 1 180, 793 at 1 279.
|
|
- `trial-lan.spec.ts` not run; the four `admin.spec.ts:717` failures above.
|
|
- LOW: `usePress` (`HistoryButtons.tsx`) over the 25-line function limit.
|
|
|
|
Out of U1 and U2: the unbounded rights list (`list_catalog_grants`, `GrantList`) and its memory exhaustion under
|
|
the axe scan, tracked as TODO RR-13 « Pagination côté serveur de la liste des droits et prévention de l'épuisement
|
|
mémoire », not implemented.
|