Owner brief « Ratification finale U1 et autorisation conditionnelle d'implémentation » (BDR-105): study §6 tests, §7 table, 7.2, 7.3, UX plan U2b entry, REVUE and decisions pointer. No implementation.
393 lines
38 KiB
Markdown
393 lines
38 KiB
Markdown
# V1-2.6 UX redesign: technical decisions
|
|
|
|
Status: OWNER ANSWERS RECORDED, 2026-11-05: brief « FAUNOSTEO — V1-2.6 UX — Ratification des décisions
|
|
techniques » (BDR-100), then brief « V1-2.6 UX — Autorisation U0 uniquement » (BDR-101; T4 checks, T5 defaults, T10
|
|
option B, T15, T16 count, « Remplacer par un polygone »). Companion of `V1-2-6_UX_PLAN.md`; this is the single
|
|
table of what blocks what; the contract records the same decisions in `V1-2_ANATOMICAL_SHEETS.md` §17.12. The 11 UX
|
|
choices and the 16 boards are approved for good and not reopened. Nothing here authorises code: U0 (documents only)
|
|
was authorised on 2026-11-05; every later sub-step starts only on a new explicit authorisation.
|
|
|
|
## Owner decisions
|
|
|
|
The annotations and findings complement (sub-step U2b) has its own table, F1 to F22, in
|
|
`V1-2-6_UX_FINDINGS_NAV.md` section 7 (BDR-103, BDR-104, BDR-105: all decided on 2026-11-06).
|
|
|
|
| Id | Question | Owner answer (2026-11-05) | State | Blocks |
|
|
|---|---|---|---|---|
|
|
| T1 | Fallback if the wasm budget is exceeded | not asked; conditions kept (brief U0); measuring rule recorded (LRN-118) | open, used only if a measure exceeds 600 000 B | U5, U6 if a measure exceeds |
|
|
| T2 | Optional category keys; widening of the snapshot reader | agreement in principle, conditional on the proofs | ratified with conditions (§ T2 and T3) | writing the keys (U6 write lock) |
|
|
| T3 | Opacity semantics | integer percent from 10 to 100 | ratified with T2's conditions | U6 |
|
|
| T4 | Fixed-category checks | no residual gap; checks in the core and at the server boundaries of save and publication; nothing written before they are live; brief U0: both declared SQL checks approved (save, approval and publication), O22 amended strictly for these invariants | ratified; design below; O22 amended at U0 (contract §12.2) | none left to decide; U6 builds them |
|
|
| T5 | Equine history; categories of a new sheet | historical preservation mandatory; roles on a working copy only; conversion tested without mutating the originals; brief U0: ids `cat-bone`, `cat-joint`, `cat-vertebra`, French names kept, EN names and colours from the existing data | ratified | none left to decide; V1-2.8 (T6) |
|
|
| T6 | Equine working copy conversion | not asked; conditions and deadline kept (brief U0) | open, decided at V1-2.8 under T4 and T5 | V1-2.8 |
|
|
| T9 | Replacing a crop view's drawing | explicit choice: keep positions, reposition, cancel; no approximate automatic transformation | ratified; design below | U5 |
|
|
| T10 | Automatic access to a detail view | system navigation type distinct from the visible taxonomy; schema checked first; never Os, Articulations or Vertèbres; brief U0: option B (`cat-access`, role `navigation`, not visible as an anatomical category, automatic access at U6) | ratified | automatic access waits for U6 |
|
|
| T11 | Fate of the level-1 owner trial | approved: old-UX trials stopped; anomalies and untested items tracked; level 1 not declared validated | ratified | none |
|
|
| T12 | Common text | principle of one versioned copy kept; legal text, source and validation to be supplied; brief U0: U7 stays blocked until they are validated | principle ratified; text missing | U7 |
|
|
| T14 | Multi-tab notice | not asked | open, follow-up | none |
|
|
| T15 | « Annuler » wording | brief U0: « Annuler la dernière modification » for the history; « Abandonner » or « Abandonner les modifications » for a form | ratified | none left to decide; U1 applies it |
|
|
| T16 | Curve handle editing | deferral only if the audit confirms it; exact geometry; no destructive conversion; identified future lot; brief U0: deferral kept, existing geometries checked before any activation of the new model, no DEV access during U0; « Remplacer par un polygone » explicit, validated, old path kept until success, undoable | ratified: deferred to the curves lot | none in V1-2.6; the path count before the new model is activated on an environment and before U6 or U8 reaches any environment beyond the throwaway sandbox |
|
|
| T17 | Vertebral regions entry without a vertebra role | brief U1 (2026-11-06, BDR-102): fallback « Régions vertébrales » entry in Annotations when no category carries the role `vertebra`; once a Vertèbres category exists, the regions are configured from it, never in two places | ratified | none left to decide; U6 builds it |
|
|
|
|
## Implementer decisions (recorded at U0 in contract §17.12, no owner question)
|
|
|
|
| Id | Decision | Reason |
|
|
|---|---|---|
|
|
| T7 | Strip `role` and `fill_opacity` from every envelope snapshot, at `lean_document` and at the export gate | the PDF needs neither; the only alternative breaks N-1 reading of new PDFs |
|
|
| T8 | Path ops (curves lot) compute on the written decimal digits; output precision = max(input precision, 2 decimals for a user move) | keeps « no other point moves » and exact round trips |
|
|
| T13 | No sub-branches: commit in place on `feature/v1-2-anatomical-sheets`, rollback by reverting a sub-step's commits | the gitflow lib branches only from develop and `finish` merges into develop |
|
|
| T18 | Handle cap per shape (constant fixed at U2 from the equine maxima with margin); above it, outline and a message | bounded DOM for oversized shapes saved directly |
|
|
| T19 | Sliders and arrow moves commit on release, Enter or blur | BDR-050; the 8 MiB history holds about 20 equine documents |
|
|
|
|
## T1 · Wasm budget fallback (open)
|
|
|
|
- Facts: the gate is `packages/core-wasm/tests/size.test.ts:12-25`: Node `gzipSync(bytes, { level: 9 })` on the
|
|
shipped build `packages/core-wasm/pkg/faunosteo_wasm_bg.wasm`, at most `COMPRESSED_BUDGET_BYTES = 600_000`.
|
|
Re-measured 2026-11-05 with that exact call: 1 569 864 B raw, 592 143 B, margin 7 857 B (build of 2026-11-04,
|
|
after the last core change `bbab0e6`). GNU `gzip -9` gives a different figure and is never used (LRN-118).
|
|
Without curves the new core code is estimated at 4.5 to 13.5 KB. The plan builds `annotations_in_rect` first and
|
|
measures, then `remap_view`, then the U6 changes.
|
|
- Options if a measure exceeds the budget:
|
|
- (a) `wasm-opt -Oz`: gain unknown; `wasm-opt` is not installed (`RUST.md:4054`), so it becomes a pinned tool in
|
|
`scripts/wasm-build.sh`, the builder image and the release workflow.
|
|
- (b) raise the budget (D-R13) by the measured excess plus a margin.
|
|
- (c) lighter URL check (about 23 KB): must keep `new URL()` equivalence.
|
|
- (d) PDF code in a lazily loaded second module (about 55-60 KB): touches R4, the import worker, the CSP proof,
|
|
trap recovery and the readers of user data; its own track with its own owner checkpoint, never a prerequisite.
|
|
- Rule: the budget is never raised silently. (b) is an owner decision taken on the measured figure; a sub-step whose
|
|
measure exceeds stops for T1.
|
|
- Recommendation: (a), then (b) if still short. (d) only as a separate decision.
|
|
|
|
## T2 and T3 · Optional category keys and opacity (ratified with conditions)
|
|
|
|
- Owner answer: agreement in principle, conditional on proofs. Two optional keys in the v2 schema, omitted when
|
|
absent, never serialised as `null` by default; fill opacity an integer percent from 10 to 100; a controlled
|
|
widening of the snapshot reader. The effects on fingerprints, Rust, SQL, PDF, worker, the N-1 reader, R3/R4 and
|
|
BDR-068 are demonstrated; the impossibility of returning to the old application after the keys are written is
|
|
documented; this is never called full backward compatibility.
|
|
- Conditions, all met before any document carrying a key is written outside a test (the U6 write lock, T4):
|
|
1. every proof of `V1-2-6_UX_COMPATIBILITY.md` §8 green and reviewed;
|
|
2. the one-way compatibility written down (below, and COMPATIBILITY §0 and §7);
|
|
3. the snapshot reader widened only as bounded below.
|
|
- Serialisation: `#[serde(default, deserialize_with = "js::present", skip_serializing_if = "Option::is_none")]` and
|
|
`ts(optional)`, the `LocalizedOptionalText` pattern (`schema.rs:162-180`). An absent key is omitted on output; an
|
|
explicit `null` is refused on input. The serde readers also accept a struct written as a positional array and an
|
|
enum value written as a one-key map (`RUST.md:3326-3346`): the U6 proofs cover these shapes for both keys. No `SHEET_DOCUMENT_SCHEMA_VERSION` bump.
|
|
- One-way compatibility, not full backward compatibility. Old to new holds: the new core reads, writes and
|
|
fingerprints every existing document as today. New to old does not: once a document carries a key, the
|
|
application, the worker and the core of any earlier commit refuse it (`invalid_document`,
|
|
`verification.integrity.document`). Returning to the old application after the first write is impossible:
|
|
published versions are immutable and migrations forward-only (COMPATIBILITY §7).
|
|
- Controlled widening of the snapshot reader (`assert_snapshot`, used by `archive/read.rs`). It follows from the
|
|
shared `AnnotationCategory` type and is bounded: it accepts exactly `role` and `fill_opacity` with the document
|
|
reader's types and range; any other unknown key, an explicit `null`, an unknown role or an out-of-range opacity
|
|
still gives `SnapshotRejection::Schema` with the report kept (the positional-array and one-key-map shapes above
|
|
included in the proofs); no version is dropped (envelope v1, Report v2 and v3,
|
|
sheet document v2); the frozen N-1 copies are never edited. Writers still strip both keys (T7), so no envelope the
|
|
product writes carries them.
|
|
- BDR-068. The `sha256-rfc8785-validated-v1` construction and the validation rules stay frozen: no new
|
|
`validate.rs` error (T4 rules live in `edit.rs` and `sheet_report`), and an absent key is never filled with a
|
|
default in the validated document the fingerprint hashes (the layer applies its constants at render time). Every
|
|
existing identity stays equal, pinned by tests; a document carrying a key gets a new fingerprint under the same
|
|
convention, like any content change. Aliases still come only from frozen historical documents.
|
|
- Opacity (T3): when present it drives the fill of point twins and of zones; when absent the current constants stay
|
|
(0.65 main and 0.5 detail for twins, 0.3 for zones), so existing renders are identical. Below 10 a marker becomes
|
|
invisible while the 4 px rules assume it visible. Detail triggers keep 0.06; the selected state keeps its accent
|
|
at 0.85 (`apps/app/src/styles/index.css:14`). Written first in `docs/ANNOTATION-RENDERING.md`. The layer writes it
|
|
as `fill-opacity`, which the PDF highlight overwrites: no PDF effect.
|
|
- Doctrine: `.claude/rules/sheet-model.md` and `schemas.md` amended at U0 (an optional key omitted when absent is
|
|
not a version change, with this proof list). Route B (schema v3, excluded by contract §12.3, BLK-008 paragraph)
|
|
and route C (reserved ids without opacity, contradicts choice 5) stay excluded.
|
|
|
|
## T4 · Fixed-category checks (ratified: no residual gap)
|
|
|
|
- Owner answer: no residual gap allowed. The fixed-category checks are defined in the core and at the appropriate
|
|
server boundaries for save and publication; the new model is not written before the necessary checks are live;
|
|
a progressive rollout or a functional lock is used if needed. The earlier recommendation (issues relative to the
|
|
base, residual first-version gap accepted) is withdrawn.
|
|
- Owner answer, brief U0 (BDR-101): both declared SQL checks approved. At save: protect the uniqueness of the fixed
|
|
categories, their roles and their presence without blocking the old drafts that carry none of these keys. At
|
|
approval and publication: guarantee the model's invariants whatever the worker does. O22 is amended strictly for
|
|
these invariants (contract §12.2, §17.12); the rest of the core's validation is not duplicated in SQL. Both checks
|
|
are planned at U6 and not built.
|
|
- Property guaranteed: no review round opens and no version is published on a draft whose categories break the
|
|
fixed model, whoever wrote the draft (the editor, a direct `save_sheet_draft`, « Garder ma version », a tab
|
|
running an older bundle). Fixed model: each role `bone`, `joint`, `vertebra` carried by exactly one category,
|
|
and that category carries its fixed FR and EN names (T5); the role `navigation` (T10) carried by at most one
|
|
category, with its fixed names.
|
|
|
|
| Tier | Check | Where | New code |
|
|
|---|---|---|---|
|
|
| Core, verdict | absolute rule on the draft, no base needed: missing role, duplicate role, wrong name on a role-bearing category; error issues of their own code family `category.fixed.*`, mapped to the existing `verification.validation.rules` | `sheet_report` on the draft (`verdict.rs:188`), mapping `verdict.rs:277-296` | Rust; no verdict code, no `validate.rs` error |
|
|
| Core, editor | giving a role writes the fixed FR and EN names in the same update; renaming a role-bearing category is allowed only to its fixed names; removing it, changing or clearing its role and a duplicate role are refused; `navigation` (T10 B) is never given to, changed on or cleared from a category by an edit: the only way it enters a document is the insertion of the canonical `cat-access` (its id, fixed names, role, no colour) inside the core-built automatic-access batch, accepted only while no navigation category exists; repair commands insert a missing fixed category, restore the fixed names and clear a duplicate role, so every state a direct save can write is repairable | `edit.rs` | Rust |
|
|
| Server, save | declared check (approved, brief U0): refused when a role is carried by two categories, when a category carrying a role does not carry that role's fixed names, or when a role of the stored draft is lost; a document without roles saves when the stored draft has none (pre-U6 drafts, equine working copy); every state a save can reach stays repairable | U6 migration, `save_sheet_draft`, a second declared SQL check under O22 (contract §12.2) | SQL, pgTAP |
|
|
| Server, verification | the worker computes the verdict with the core above; a round opens only on a passed verdict | `complete_sheet_verification` (`20261101100000_sheet_verification_jobs.sql:300-345`) | none |
|
|
| Server, core gate | a passed verdict computed by a core older than the U6 core is refused at completion, so an old worker (rollback, stale image, second instance) never opens a round | U6 migration, keyed on `verified_with` | SQL, pgTAP |
|
|
| Server, publication | a declared SQL check `private.sheet_fixed_categories_ok(content)` (name provisional: each of `bone`, `joint`, `vertebra` once, `navigation` at most once, fixed names) at approval and at publication, beside the existing status checks, so a worker defect cannot publish a draft outside the fixed model (the reason O22 keeps declared SQL checks, contract §12.2, `20261028110000:146-149`); the existing preconditions stay (`verdict.missing`, `verdict.stale`, `:984-990`; approved round on the current revision, `:1028-1072`) | U6 migration, `decide_sheet_review`, `publish_sheet_version` | SQL, pgTAP; O22 amended at U0 |
|
|
| Server, rounds in flight | rounds in `verifying`, `open`, `approved` of draft versions withdrawn with the reason; the approved round linked to each published version stays approved | U6 migration (contract §6.4, worded at U0) | SQL, pgTAP |
|
|
|
|
- Save boundary: the earlier text left save fully permissive and cited BDR-043; the governing rule is O22 (contract
|
|
§12.2), which allows a declared SQL check. A check requiring the three fixed categories at save would lock the
|
|
equine working copy and every pre-U6 draft; the approved check requires nothing of a document without roles and
|
|
stops stripping, duplicating or renaming by a direct save, « Garder ma version » or an older tab at the source.
|
|
The owner approved both declared SQL checks (brief U0); O22 is amended in contract §12.2 (two table rows and the
|
|
bullet that replaces « No other rule is mirrored »), and the contract §6.2 and §6.7 cite them.
|
|
- Core gate detail: every core so far reports `faunosteo-core 0.1.0` (`verdict.rs:164-166`, workspace version
|
|
`Cargo.toml:10`), so the gate needs a marker that tells the U6 core apart: a core version bump (owner's call) or a
|
|
rules epoch added to `verified_with` (free text of at most 100 characters for SQL today). Chosen at U6, pinned by
|
|
pgTAP.
|
|
- Functional write lock: the U6 migration exposes the rules epoch (a read-only RPC); the application reads it and
|
|
writes no key and creates no sheet with the new model until the epoch is present: an application deployed too
|
|
early creates sheets through the plain v2 path (no categories, as today) and the repair adds the fixed ones later. Order SQL, worker, application (COMPATIBILITY §7), with SQL first
|
|
mandatory: only the orders that start with SQL fail closed. Worker before SQL leaves rounds already `approved` on
|
|
old verdicts publishable until the U6 migration lands; that is why SQL goes first. U6 stays
|
|
on the sandbox until the owner decides otherwise.
|
|
- Scope: the rule judges drafts submitted after U6, never a published version. The historical equine version has no
|
|
roles and stays as it is (T5); the release replay (contract §15) filters the `category.fixed.*` family, so it
|
|
checks published versions on reading, fingerprint, validation and drawings only. Consequences: the equine working
|
|
copy cannot pass verification until V1-2.8 converts it (T6), which is that lot's scope; the existing tests that
|
|
expect a passed verdict or an `open` round on a role-less document flip and move to converted in-memory copies
|
|
(`V1-2-6_UX_TESTS.md` U6), the seed itself unchanged.
|
|
|
|
## T5 · Equine history and the categories of a new sheet
|
|
|
|
- Owner answer: historical preservation mandatory. The historical equine versions keep their ids, names, colours,
|
|
particular annotations and fingerprints; any role adaptation applies to a working copy only, and the conversion is
|
|
tested without mutating the originals.
|
|
- Untouched: the five equine categories (`articulations`, `os`, `charnieres-vertebrales`, `zone-colonne`,
|
|
`cadrans-du-crane`) with their ids, names and colours; the three own colours (atm and ssb `#ff8800`, hyoid
|
|
`#d507c4`); every annotation; the fingerprint `12d78872…` and the alias `27c7383c…`; every file under
|
|
`supabase/seed/anatomical-sheets/equine/` (`pnpm r5:import-equine --check` clean); the published historical
|
|
version (immutable, `sheet.historical_read_only`).
|
|
- Test: a conversion of an in-memory copy of the seed draft document (roles on the T6 categories) asserts before and
|
|
after that the seed bytes, the fingerprint, the alias and every review digest are unchanged, and that the copy
|
|
differs only in the converted categories (`V1-2-6_UX_TESTS.md` U6).
|
|
- New-sheet defaults, ratified (brief U0, BDR-101): ids `cat-bone`, `cat-joint`, `cat-vertebra`, chosen by the core
|
|
(suffixes of 4 to 8 characters, so never a page id `cat-<10 chars a-z2-7>`, `apps/app/src/editor/ids.ts:1-21`);
|
|
French names « Os », « Articulations », « Vertèbres » (validated on board 07, `docs/design/v1-2-6/ARBITRAGES.md:60`).
|
|
English names and reference colours, documented from the existing data:
|
|
|
|
| Id | FR | EN | Colour | Source |
|
|
|---|---|---|---|---|
|
|
| `cat-bone` | Os | Bones | `#a41e65` | equine category `os`: « Os » / « Bones », `#a41e65` (`supabase/seed/anatomical-sheets/equine/draft/document.json:425-430`) |
|
|
| `cat-joint` | Articulations | Joints | `#ff9500` | equine category `articulations`: « Articulations » / « Joints », `#ff9500` (`document.json:417-422`) |
|
|
| `cat-vertebra` | Vertèbres | Vertebrae | `#e100ff` | colour of the equine category `zone-colonne` (« Segments vertébraux » / « Vertebral segments », `document.json:441-446`), the one T6 proposes for the vertebra role; no existing category is named « Vertèbres », and EN « Vertebrae » is the existing dictionary pair of the editor tab (`apps/app/src/i18n/fr.ts:1230` « Vertèbres », `en.ts:1199` « Vertebrae ») |
|
|
|
|
The colours come from the curated draft, which is the historical sheet's document; the legacy import holds none
|
|
(`legacy-import/document.json`, every category colour `null`). Copying a value mutates nothing. The colours are shown as
|
|
« Couleur d'origine » (board 07 A). Names stay stored, so old readers show them.
|
|
|
|
## T6 · Equine working copy conversion (V1-2.8)
|
|
|
|
- Facts: five categories (`articulations` 12 annotations, `os` 2, `charnieres-vertebrales` 4, `zone-colonne` 5,
|
|
`cadrans-du-crane` 5). `os` and `articulations` already carry the fixed names; `zone-colonne` is « Segments
|
|
vertébraux / Vertebral segments ». Three own colours: atm and ssb `#ff8800`, hyoid `#d507c4`.
|
|
- Bound by T5 (working copy only, originals never mutated) and T4 (the copy passes verification only with the three
|
|
roles on categories carrying the fixed names).
|
|
- Proposal: roles on `os`, `articulations`, `zone-colonne`; `zone-colonne` renamed « Vertèbres / Vertebrae » in the
|
|
working copy only (id unchanged); the two other categories stay free; own colours kept (choice 11) unless the
|
|
business review decides otherwise. Decided at V1-2.8.
|
|
|
|
## T9 · Replacing a crop view's drawing (ratified)
|
|
|
|
- Owner answer: an explicit choice when an SVG is replaced, with three actions: keep the positions, only if the
|
|
framing is compatible and the checks pass; reposition the annotations when the operation is safely supported;
|
|
cancel without any change. No approximate automatic transformation. The earlier recommendation (no question when
|
|
the `viewBox` equals the crop) is withdrawn.
|
|
- R (the view's crop rectangle) is written in the coordinates of the drawing the view shows today; V (the
|
|
candidate's `viewBox`) in the candidate's own. The core cannot check that the candidate was cut from the same
|
|
master or shows exactly region R: both actions rest on a premise the dialog states, and both fail closed.
|
|
- Two core calls (the cleaning output has no `viewBox`, `clean.rs:50-68`; the asset id exists only after
|
|
registration, `drawingUpload.ts:124-169`):
|
|
1. Offer, before any upload: input = the document, the view id and the cleaned candidate text; the core reads V
|
|
from the candidate root and runs the frame checks on it; output = the actions offered, each with its reason.
|
|
2. Batch, after the drawing is registered and held: input = the view id and the asset id; output = the
|
|
`sheet.edit` commands of the chosen action, committed as one undo entry under the geometry accept
|
|
(`issues.ts:123-175`). A refusal there leaves the document unchanged and a registered drawing that nothing
|
|
references, as today's refused attach (`drawingUpload.ts:195-196`).
|
|
- The dialog opens on every replacement of a crop view's drawing, before the upload, no action preselected:
|
|
- « Conserver les positions »: offered only when V equals R (the seed head drawing case); the dialog states the
|
|
premise « ce dessin utilise le repère de la vue parente ». Applied as today's attach (`attachToView`,
|
|
`drawingUpload.ts:184-192`); the view's annotations turn `to_confirm` (redrawn-view rule, `edit.rs:792-857`).
|
|
- « Repositionner les annotations »: offered only when V differs from R with the same aspect ratio (compared on
|
|
the values rounded to the editor's 0.01 grid; any other case refused, `remap.aspect`, never centred), no path in
|
|
the view (`remap.path`), no descendant crop (`remap.descendant_crop`), numbers in range. Premise stated:
|
|
« ce dessin montre exactement la zone de la vue ». One scale and one translation; numbers on the 0.01 grid; a
|
|
point pushed out of the frame by the rounding refuses the whole remap; every moved annotation turns `to_confirm`.
|
|
- « Annuler »: always offered; nothing is uploaded, the document and the history are untouched.
|
|
- An action that is not available stays visible, disabled, with its reason. A candidate without a `viewBox` gets
|
|
neither keep nor reposition, only « Annuler »: stricter than today's attach, which accepts it (stated in U5).
|
|
- Labels: the owner's French words above; EN « Keep positions », « Reposition annotations », « Cancel » proposed.
|
|
|
|
## T10 · Automatic access to a detail view (ratified: option B)
|
|
|
|
- Owner answer: prefer a system navigation type distinct from the visible anatomical taxonomy; check the existing
|
|
schema constraints before choosing an internal id or category; never categorise this access arbitrarily as Os,
|
|
Articulations or Vertèbres. The earlier recommendation (the Joints category) is withdrawn.
|
|
- Constraints checked (2026-11-05):
|
|
- The navigation type exists: `detail_trigger` (`crates/core/src/domain/sheet/schema.rs:439-462`, « Navigation
|
|
only: a trigger opens a detail view and never carries findings »).
|
|
- It requires `category_id` (`schema.rs:449`), which must name an existing category:
|
|
`annotation.category.missing` is an error (`validate.rs:287-292`), and an error blocks the fingerprint, the
|
|
snapshot and publication.
|
|
- Snapshots copy annotations and categories whole (`lean_document`, `snapshot_rules.rs:141-165`): every trigger
|
|
reaches the PDF envelope and the frozen N-1 reader, whose schema requires `category_id`.
|
|
- Page ids are `<prefix>-<10 chars a-z2-7>` (`ids.ts:1-21`); a stable id has 1 to 64 characters (`js.rs:158`).
|
|
- The catalogue shows a selected annotation's category name (`ZonePanel.tsx:45-48`); the layer colours a trigger
|
|
from its own colour or its category (`layer.rs:142-150`).
|
|
- Options:
|
|
- (A) `category_id` optional on `detail_trigger`. A required key becomes optional: the ts-rs type is no longer
|
|
assignable to the N-1 type (`contracts.types.test.ts:53-61` fails by construction), and a trigger without a
|
|
category in a snapshot makes N-1 drop the snapshot unless triggers are stripped from snapshots, which touches
|
|
the readers of user data again.
|
|
- (B) one internal navigation category, created by the core, outside the visible taxonomy: id `cat-access` (a
|
|
6-character suffix, never a page id), role `navigation` (a fourth value of the T2 key), fixed names FR « Accès
|
|
aux vues détaillées », EN « Detail view access », colour `null`. Old readers and N-1 read it as an ordinary
|
|
category (the role is stripped from snapshots, T7). The editor lists it in no category panel and no picker;
|
|
only detail triggers use it (an edit refusal and a verdict issue for an observable annotation in it, and for a
|
|
second category with that role).
|
|
- Owner answer, brief U0 (BDR-101): option B validated: internal category `cat-access`, role `navigation`, not
|
|
visible as an anatomical category, automatic access conditional on U6. Its names and colour are those written in
|
|
option B above. Creation path (implementer, to keep the editor rule of T4 whole): `navigation` is never given to,
|
|
changed on or cleared from a category by an edit; the canonical `cat-access` enters a document only inside the
|
|
core-built automatic-access batch, accepted while no navigation category exists. Limit kept in view: old readers
|
|
and N-1 show it as an ordinary category (its names are visible there).
|
|
- Open point for U6 (not decided at U0, owner question if it is visible): the category of an access placed by hand
|
|
from the view's menu after U6, when the overlap list is not empty. Until U6 the editor chooses it explicitly.
|
|
- Effect on the plan: automatic access moves from U5 to U6 (it needs the role). U5 keeps the name proposal and the
|
|
overlap list. Until U6, « Ajouter un accès » (U4) asks the editor for the category as level 1 does: an explicit
|
|
choice by the editor, never an automatic one. Existing triggers keep their category (the equine « Tête » access
|
|
stays in `articulations`, T5); moving the working copy's access is a V1-2.8 question.
|
|
- Automatic creation (U6): only when the overlap list is empty; the view, its access and, if missing, the navigation
|
|
category inserted in one batch; otherwise the box is unchecked with the reason and the access is placed from the
|
|
view's menu.
|
|
|
|
## T11 · Level-1 owner trial (ratified)
|
|
|
|
- Owner answer: approved. Complementary trials of the old UX stop and the redesign preparation continues; the
|
|
anomalies and the untested items stay tracked; the old V1-2.6 is not declared fully validated.
|
|
- Level 1 (lots A to O, criteria C1 to C48): built and gated (`.claude/tasks/plans/2026-11-04-v1-2-6-checkpoint.md`),
|
|
never tried by the owner, NOT functionally validated. Its infrastructure (store, save, recovery, conflicts,
|
|
upload, modes) is the base of the redesign. The criteria the redesign does not touch (C13, C14, C16, C34, C41)
|
|
stay in force and are re-tested at U1 and U8.
|
|
- Tracked in TODO.md (level-1 line), from the checkpoint report, the execution ledger and the trial guide:
|
|
- owner manual trial: not run, stopped by this decision;
|
|
- a real second device on the LAN: not tested;
|
|
- editing specs at 375 px skipped (C16 waiver), and 8 admin journeys at 375 px skipped;
|
|
- worker-gated sandbox suite skipped (no worker by contract);
|
|
- the keyboard spec focuses programmatically (no Tab walk);
|
|
- free-path attach repair covered by automated tests only (no trial step);
|
|
- Safari iOS `beforeunload` unreliable (only « Enregistrer » protects work);
|
|
- LOW security items kept by the fresh auditor (checkpoint report, « Audits and reviews »: cleartext LAN trial
|
|
traffic including the TOTP enrolment key, allow list including tests and node_modules, first `hostname -I`
|
|
address as default trial host, template SQL in e2e helpers, trial gateway without a Host check, an unproven
|
|
sign-out copy-rewrite window);
|
|
- review minors m4, m6, m7, m8, m10 (execution ledger);
|
|
- path point correction (`.claude/tasks/plans/2026-11-04-v1-2-6-path-repair-core-proposal.md`, not built), now in
|
|
the curves lot (T16).
|
|
|
|
## T12 · Common text (principle ratified, text missing)
|
|
|
|
- Owner answer: the principle of one versioned copy is kept; the final legal text, its source and its validation are
|
|
still to be supplied; U7 delivers no invented or unapproved normative text.
|
|
- Design: a versioned module in the application (id, version, FR, EN), changed only by a reviewed commit; inserted
|
|
once into empty fields; the editor shows « texte commun, version n » and never presents it as veterinary or legal
|
|
advice approved by the platform.
|
|
- U7 is blocked until the owner supplies the FR and EN text, its source, and who validated it and when. The commit
|
|
that adds the text cites that record. Until then no such wording is written in the application, the dictionaries
|
|
or the docs; U7's tests use a fixture text marked as a test value, kept under `tests/`, never shipped.
|
|
- Contract §7.4 amended at U0 to state this, without any normative wording (brief U0: U7 stays blocked until the
|
|
source and the legal content are validated).
|
|
|
|
## T14 · Multi-tab notice (open)
|
|
|
|
- Facts: no multi-tab detection exists; the server revision check and the conflict dialog prevent silent loss; the
|
|
boards show no such notice.
|
|
- Recommendation: out of V1-2.6, tracked as a follow-up. If kept later: heartbeat-based (a crashed tab never says
|
|
goodbye), wording consistent with « Garder ma version ».
|
|
|
|
## T15 · « Annuler » wording (ratified)
|
|
|
|
- Owner answer, brief U0 (BDR-101): distinguish the commands. « Annuler la dernière modification » for the history;
|
|
« Abandonner » or « Abandonner les modifications » for a form.
|
|
- Applied at U1 and later:
|
|
- history command: the header button keeps the drawn icon and short label of the approved boards; its accessible
|
|
name and tooltip are « Annuler la dernière modification » (EN « Undo the last change », proposed); the toast
|
|
after a gesture undoes the same entry under the same name;
|
|
- leaving a staged form without applying it (board 02 pending point, board 07 states, board 08 rectangle, board 09
|
|
regions): « Abandonner »;
|
|
- returning the draft to its last saved revision (level-1 C11, today `editor.draft.discard` « Annuler les
|
|
modifications », `apps/app/src/i18n/fr.ts:1238`): « Abandonner les modifications »; its confirmation already
|
|
uses those words (`fr.ts:1240`);
|
|
- the trace strip of board 04 already reads « Abandonner ».
|
|
- Not covered by the answer and unchanged: « Annuler » on dialogs that close without any effect (confirmations,
|
|
the cleaning dialog, the T9 dialog's third action, which the owner named « Annuler »). Any change there is an owner
|
|
question, not an implementer choice.
|
|
|
|
## T16 · Curve handle editing (ratified: deferred to the curves lot)
|
|
|
|
- Owner answer: defer the curve handle editing only if the audit confirms that no existing curved annotation and no
|
|
journey available today needs it; keep geometries exactly; prevent any destructive conversion; record full curve
|
|
editing in an identified future lot.
|
|
- Audit (2026-11-05, at `e10f167`):
|
|
- Tracked documents: the seed draft holds 22 circles, 6 polygons, 0 paths; the legacy import 21 circles, 6
|
|
polygons, 0 paths (`supabase/seed/anatomical-sheets/equine/{draft,legacy-import}/document.json`). The historical
|
|
sheet and its working copy derive from them.
|
|
- Journeys that write geometry: creation makes points and polygons only (`apps/app/src/editor/annotations/creation.ts:90-97`);
|
|
the editable geometries are circle and polygon (`geometryEdit.ts:9`, `34`); package import, zones from the
|
|
drawing's shapes and curve drawing are level 2 (contract §8.3).
|
|
- Journeys that meet a path: display by the core layer; the attach repair returns a path unchanged and keeps the
|
|
attach refused, document unchanged byte for byte (`repair.ts:55-69`, blocked ids `95-100`, C45, `editor-geometry.spec.ts:317`);
|
|
« Remplacer par un polygone » (`PropertiesPanel.tsx:138`, contract §8.3).
|
|
- Not inspected: the database contents of DEV and of the sandbox (docs-only brief, no query run). A path there can
|
|
only come from a direct RPC save or a test fixture. Before the new model is activated on an environment (its U6
|
|
write lock lifted there), and before U6 or U8 reaches any environment beyond the throwaway sandbox, a read-only
|
|
count of path geometries in its drafts and published versions is recorded; on the throwaway sandbox U6 runs it
|
|
itself, on DEV and any shared environment the owner runs it or authorises it explicitly, never during U0 (brief
|
|
U0); a non-zero count reopens T16.
|
|
- Re-checked at U0 (2026-11-05, `a505b24`): same counts (seed draft 22 circles, 6 polygons, 0 paths; legacy import
|
|
21, 6, 0); `pnpm r5:import-equine --check` clean (0 differences).
|
|
- Conclusion: the condition holds for every tracked document and every product journey; the deferral is adopted.
|
|
- Guarantee until the curves lot:
|
|
- a stored path keeps its `d` text byte for byte; no TypeScript parses it (C45); no operation moves, scales,
|
|
remaps, simplifies, samples or converts it;
|
|
- every operation that would have to change a path is refused with the document unchanged: attach repair (C45),
|
|
remap (`remap.path`), the U2 handle layer and zone move (a path gets no handle and no move);
|
|
- « Remplacer par un polygone » is the one way a path leaves a document: the editor draws a new polygon by hand,
|
|
one undo entry, published versions untouched. It replaces the curve by the editor's choice; nothing converts
|
|
it. Owner, brief U0 (BDR-101): kept only as an explicit replacement, validated, the old path kept until success,
|
|
undo and redo supported, no automatic destructive conversion (contract §8.3 as amended). Level 1 already holds
|
|
it: the trace closes into one `update` committed under the geometry accept, a refusal drops the trace and leaves
|
|
the annotation unchanged (`apps/app/src/editor/annotations/usePlacement.ts:39-63`, `annotationCommit.ts:55-72`,
|
|
`93-104`); tests cover the replacement and the refusal (`apps/app/tests/unit/editor-annotations-tab.test.tsx:692-714`,
|
|
`845-866`). Not yet tested: undo and redo restoring the exact `d`, and Escape during the trace; added at U2
|
|
(`V1-2-6_UX_TESTS.md` U2, « Paths » row).
|
|
- Future lot « Courbes » (ex-U9): specification in `V1-2-6_UX_PLAN.md` §2 D, tests in `V1-2-6_UX_TESTS.md`
|
|
(« Curves lot »), with the path point-correction proposal. Recorded in TODO.md with its dependency rule: no
|
|
feature that lets a path enter a document (package import, zones from the drawing's shapes, a curve drawing tool)
|
|
ships before or without it. It needs a size lever (T1) and a round-withdrawal migration.
|
|
|
|
## Points from the boards for U1 and later (found at U0, not decided)
|
|
|
|
The validated boards show these; level 1 or its contract says otherwise. Each involves a visible choice or another
|
|
step's scope, so it is an open owner question, asked when the sub-step that builds it is planned; until then the
|
|
level-1 text stays as written (precedence rule of the level-1 contract header). None blocks U0.
|
|
|
|
| Point | Boards | Level 1 or contract | Sub-step |
|
|
|---|---|---|---|
|
|
| « Prévisualiser » in the editor header | 01 to 05, 07 to 11, 13 | deferred to V1-2.7 (level-1 CLARIFICATIONS; contract §16.8) | U1 planning: owner question (V1-2.7 is not open) |
|
|
| Withdrawing a submission from the Vérification tab | 12 C notice | withdrawal deferred to V1-2.7 (same) | U1 planning: owner question |
|
|
| Recovery buttons « Restaurer » / « Ignorer » | 12 D | C27: « Restaurer la copie » / « Ignorer la copie » | U1 label review |
|
|
| Properties at creation of points and zones: names and laterality asked before the element exists, no preselected laterality | 02, 04 (laterality and other properties set after creation) | level-1 plan choice 2 (C25), `apps/app/src/editor/annotations/creation.ts:48-56`, `109`; the core requires a laterality (`crates/core/src/domain/sheet/schema.rs:424`, `450`), so the boards' flow implies a default | U2 planning: owner question (detail-view names are not open: choice 6, proposed name, U5) |
|
|
| Region code read-only after creation | 09 (not legible) | C5: read-only after creation | U6 planning |
|
|
| Category of an access placed by hand after U6 when annotations overlap | 08 | T10 section above | U6 planning |
|
|
|
|
## T17 · Vertebral regions entry without a vertebra role (ratified)
|
|
|
|
- Facts: board 09 opens the regions from the Vertèbres category; the equine working copy has no role before V1-2.8.
|
|
- Owner answer, brief « Autorisation de U1 uniquement » (2026-11-06, BDR-102): when no category carries the role
|
|
`vertebra`, Annotations offers a fallback entry « Régions vertébrales »; when a Vertèbres category exists, the
|
|
regions are configured from that category, with no duplicate entry. The new category model is not built before U6.
|
|
- Effect: U1 places the existing regions editor in Annotations as that entry (no role exists before U6, so it is the
|
|
fallback case); U6 adds the vertebra-role path of board 09 and removes the entry when the role is present.
|