90 lines
8.1 KiB
Markdown
90 lines
8.1 KiB
Markdown
# V1-2.6 checkpoint report: ready for the owner trial (2026-11-04)
|
|
|
|
Contract `.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md` (criteria 1-48), plan
|
|
`.claude/tasks/plans/2026-11-03-v1-2-6-editor.md`, resume ledger `.claude/tasks/plans/2026-11-03-v1-2-6-execution.md`.
|
|
The owner has not tried the editor: V1-2.6 is NOT declared functionally validated.
|
|
|
|
## HEAD and commits
|
|
- Branch `feature/v1-2-anatomical-sheets`, pushed, no merge, working tree clean. HEAD: the commit that adds this file
|
|
(`git log -1 -- .claude/tasks/plans/2026-11-04-v1-2-6-checkpoint.md`); last application code `2057b0e`, last trial
|
|
tooling: `git log -1 -- apps/app/vite/trial.config.ts` (the host filter itself is `5207f87`).
|
|
- Step range `2571978..HEAD`: lots A-M (`2f824a9..7a4ce9e`), lot N owner checkpoint decisions (`be4f468..5e0aa62`),
|
|
lot O last owner decisions (`a69eba5`, `d74c54e`, `2057b0e`, `fb95255`, `5207f87`, `8531dd3`, `72b742f`, then a
|
|
comment-and-wording commit on the trial config, the trial script and the guide, the one before this report's last
|
|
update); docs and `.claude` commits in between.
|
|
- No file changed under `crates/`, `supabase/seed/`, `apps/app/tests/fixtures/`, `packages/core-wasm/{tests,types}/`
|
|
in the range; the only migration is M8 `20261103100000_sheet_draft_last_save.sql` (a read). Supabase DEV, its
|
|
worker and its migrations untouched; no deploy; V1-2.7 not started.
|
|
|
|
## Tests (one fresh sandbox, contract order, on `2057b0e`; raw logs kept in the session scratchpad `final-o/`)
|
|
- `pnpm db:sandbox up fresh` → `pnpm db:sandbox test-db`: Files=21, Tests=1992, PASS.
|
|
- `pnpm db:sandbox e2e-shell`: 151 passed, 49 skipped, 0 failed (skips: the 375 px project of editing specs, waived
|
|
for C16, and 8 pre-existing admin journeys at 375 px), including the free-path refusal (`editor-geometry.spec.ts:317`),
|
|
the attach repair (`:226`), sign-out (`editor-signout.spec.ts`), the full non-equine journey (`editor-journey.spec.ts`).
|
|
- `pnpm db:sandbox test`: 105 passed, 10 skipped (worker-gated suite, no worker by contract) → `pnpm db:sandbox down`.
|
|
- `pnpm check:all`: « all checks passed » (unit core-wasm 66, supabase 159, app 1085; e2e:ui passed).
|
|
- `pnpm r5:import-equine --check`: legacy-import 6 files and draft 12 files, 0 differences (historical documents intact).
|
|
- LAN trial on `fb95255` (orchestrator): `pnpm db:sandbox trial` → `== trial: http://192.168.1.100:5193`; sockets
|
|
192.168.1.100:5193 and 127.0.0.1:57801 only; 127.0.0.1:5193 refused; `/@fs` of `.claude`,
|
|
`.superpowers`, `supabase/seed.sql`, `crates`, the sandbox secrets → 403, `packages` → 200; no `PGPASSWORD` in the
|
|
Vite environment; the LAN Playwright journey (`apps/app/e2e/playwright.lan.config.ts`: sign-in, TOTP, catalogue,
|
|
new non-equine sheet, SVG import through cleaning, save, reload, no request leaving the LAN origin) passed; then
|
|
stopped, `down`, 0 containers, 0 listeners, throwaway password deleted. Not tested: a real second device.
|
|
- `fb95255` changes only the trial Vite config, the trial command and docs (not used by the automated suites).
|
|
- Host filter (after the third fresh verifier found that Vite 7's `allowedHosts` lets every IP literal and
|
|
localhost through): the trial config adds a middleware answering 403 to any Host other than the trial host.
|
|
Probed on the running trial: `Host: 192.168.1.100:5193` → 200; `10.0.0.1:5193`, `127.0.0.1:5193`,
|
|
`localhost:5193`, `a.localhost`, `evil.example` → 403, also on the proxied `/auth/v1/health`; the LAN Playwright
|
|
journey passed again; then stopped, `down`, 0 containers, 0 listeners, password deleted.
|
|
- Then (fourth fresh verifier and auditor: OPTIONS pre-flights answered by Vite's CORS before any host check, and
|
|
the hot-reload WebSocket upgrade bypassing the middlewares): the trial sets `cors: false` and `ws: false` and
|
|
closes `/__open-in-editor`. Probed: OPTIONS with Host localhost or 10.0.0.1 → 403 (trial host → 404, no CORS);
|
|
WebSocket upgrade → never answered 101 (then closed at once, see below); `/__open-in-editor` and `/__OPEN-IN-EDITOR` → 404; no
|
|
`Access-Control-Allow-Origin`; /login 200; the LAN journey passed again; stopped, `down`, 0 containers,
|
|
0 listeners, password deleted. Security of the host-filter commit (`fb95255..671a1bd`): PASS.
|
|
- Security of `671a1bd..b2941eb` (cors/ws/open-in-editor): PASS, two LOW: an upgrade request was held open by the
|
|
proxy's upgrade listener (not refused), and the guide's CORS sentence was exact for Vite only (the proxied
|
|
Supabase routes keep the stack's CORS headers). Both fixed after: every upgrade socket is destroyed at once,
|
|
`/__open-in-editor` also matched by connect's own route, the guide reworded. Probed on the running trial: an
|
|
upgrade request (trial host, localhost, /auth/v1/health) gets an empty reply in 0.01 s; `/__open-in-editor` → 404
|
|
with the trial Host and with an IP-literal Host (a host name gets Vite's own 403 first); OPTIONS with Host
|
|
10.0.0.1 → 403; evil.example → 403; /login 200; LAN journey passed; stopped, `down`, 0 containers, 0 listeners,
|
|
password deleted. Security of `b2941eb..fe724b2` (`72b742f`): PASS, both earlier LOWs closed, one LOW on wording
|
|
(« 403 » for every wrong Host was not exact for `/__open-in-editor` and upgrades), fixed in the comment-and-wording
|
|
commit, which changes comments and docs only.
|
|
|
|
## Audits and reviews
|
|
- Security (fresh auditor): full range `2571978..25bdac4` PASS (0 blocking); scoped `25bdac4..fb95255` PASS: worktree
|
|
serving on the LAN closed, PGPASSWORD closed, cleartext LAN traffic re-rated LOW (documented in the guide: trusted
|
|
network only, the TOTP enrolment key also travels in clear). `/__open-in-editor` closed (8531dd3). Kept LOW: the
|
|
allow list includes tests and node_modules, the
|
|
default trial host is the first `hostname -I` address (the guide says how to force 192.168.1.100), template SQL in
|
|
e2e helpers, trial gateway without a Host check (loopback only), an unproven sign-out copy-rewrite window, AAL2
|
|
claim after a factor removal (§13, production prerequisite).
|
|
- Fresh verifiers: criteria 1-36 and 38-44 MET in code at `6471b25`; 37 and 43 MET at `6f0fa41`; 20, 21, 22, 30
|
|
CONFORME from the raw logs of the `5e0aa62` run. Lots N and O reviewed per lot (spec ✅, quality Approved after the
|
|
fix rounds recorded in the ledger). Criteria 23, 34, 45-48: judged on this report by the next fresh verifier.
|
|
|
|
## Owner decisions applied
|
|
- C35-C44 (lot N): Prettier files restored after a kept diff and a per-file proof; plurals; trimmed names only;
|
|
mode precedence unchanged; parent illustration confirmed and undoable; default tab; attach repair; findings
|
|
categories; sign-out confirmation and copy purges; labels stay proposals.
|
|
- C45 (lot O1): free paths are never reshaped; no TypeScript path parser; an attachment that would leave a free path
|
|
outside the new frame is refused, the document unchanged byte for byte, cancel loses nothing. Point correction for
|
|
free paths needs a core operation: proposal `.claude/tasks/plans/2026-11-04-v1-2-6-path-repair-core-proposal.md`,
|
|
NOT built (it reopens `crates/**`; owner approval required).
|
|
- C46 (lot O1): « Ajouter une catégorie » never depends on the selection; required zone choice.
|
|
- C47 (lot O2): trial served on http://192.168.1.100:5193, sandbox kept on loopback behind Vite.
|
|
|
|
## Owner trial
|
|
Guide `docs/development/V1-2-6_OWNER_TRIAL.md`, every command from `/home/bchanot/Documents/faunosteo-v1-2`:
|
|
`pnpm db:sandbox up fresh`; `pnpm db:sandbox trial-account vous@example.com` (hidden password, 12+ characters);
|
|
`pnpm db:sandbox trial-grant vous@example.com sheet_editor` and `... sheet_publisher`; `pnpm db:sandbox trial`; open
|
|
`http://192.168.1.100:5193/login`; end with Ctrl+C then `pnpm db:sandbox down` and
|
|
`docker ps -a --format '{{.Names}}' | grep dbsandbox` (no line). If another device cannot reach the page, the owner
|
|
may add `sudo ufw allow from 192.168.1.0/24 to any port 5193 proto tcp` (never run by the agent).
|
|
|
|
## Open before the V1-2 merge (tracked in the ledger)
|
|
Path point correction (core proposal), the LOW security items above, m4/m6/m7/m8/m10 of the final review, the
|
|
LRN-095 / BLK-013 / RR-11-RR-12 id reconciliation, the keyboard spec's programmatic focus (no Tab walk).
|