Files
faunosteo/.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md
bchanot 8cb681e2fa chore(memory): U1 owner checkpoint decisions, RR-13, LRN-120 to 122
BDR-106 owner decisions at the U1 checkpoint; TODO U1 line closed up
to the open owner checkpoint, admin.spec:717 confirmation and kept
reservations; RR-13 rights list server paging track; contract
clarification; journal.
2026-11-09 12:47:42 +01:00

487 lines
40 KiB
Markdown

# CONTRACT — v1-2-6-ux-u1
- date: 2026-11-06 | flow: ship-feature | branch: feature/v1-2-anatomical-sheets
- status: active
- worktree: /home/bchanot/Documents/faunosteo-v1-2 (every command runs from this absolute path; never from
/home/bchanot/Documents/faunosteo; never against DEV: the `supabase_*_faunosteo` containers are DEV; the throwaway
sandbox is `faunosteo_dbsandbox_*`, reached only through `pnpm db:sandbox …`)
- base: 846994b (T17 recorded, BDR-102). Commit in place, push each commit; no merge, no `gitflow.sh finish`
(T13), no sub-branch.
- spec: `docs/development/V1-2-6_UX_PLAN.md` §3 U1 and §2 G (undo rules), `docs/development/V1-2-6_UX_TESTS.md` U1,
`docs/development/V1-2_ANATOMICAL_SHEETS.md` §8.2-§8.4 and §17.12 as amended, the level-1 contract
`.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md` with its U0 notes and header precedence rule,
`docs/development/V1-2-6_UX_DECISIONS.md` (T15, T17, « Points from the boards for U1 and later »), boards
`docs/design/v1-2-6` (`maquettes.html` is their source).
## REQUEST (verbatim — IMMUTABLE)
# FAUNOSTEO — V1-2.6 UX — Autorisation de U1 uniquement
Le propriétaire approuve définitivement le checkpoint U0.
U0 est terminé, vérifié CONFORME 12/12, commité et poussé au HEAD 452a346.
J'autorise maintenant l'implémentation de U1 uniquement, conformément à V1-2-6_UX_PLAN.md, aux contrats amendés et aux 16 maquettes V2 validées.
## 1. Périmètre U1
Implémenter la nouvelle structure générale de l'éditeur anatomique.
Navigation principale à quatre onglets :
- Général
- Annotations
- Constats
- Vérification
Les références doivent rester accessibles depuis un panneau secondaire, sans imposer un onglet principal supplémentaire.
Les vues détaillées et les régions vertébrales seront intégrées progressivement à Annotations dans les étapes prévues. U1 ne doit pas anticiper les opérations U2 à U6.
## 2. Annuler / Rétablir
Déplacer les commandes globales dans l'en-tête conformément aux maquettes corrigées.
Contraintes :
- Historique global de la fiche.
- Conservation du comportement existant et de la pile d'historique.
- États activé/désactivé correctement synchronisés.
- Raccourcis clavier appropriés.
- Noms accessibles explicites, notamment « Annuler la dernière modification ».
- Aucun bouton flottant redondant sur le dessin.
Ne pas confondre Annuler/Rétablir avec l'abandon d'un formulaire.
## 3. Navigation et compatibilité
Préserver toutes les fonctions métier de l'ancien éditeur pendant leur réorganisation.
En particulier :
- Aucune perte de brouillon lors d'un changement d'onglet.
- Aucun changement non prévu du mécanisme de sauvegarde explicite.
- Préservation de la récupération locale.
- Préservation des contrôles d'autorisation et du MFA.
- Aucune modification des règles de soumission et de publication.
- Aucun changement du format des documents anatomiques.
- Conservation des chemins et des états nécessaires aux étapes suivantes.
Ne pas implémenter prématurément des fonctions de V1-2.7 simplement parce qu'elles figurent dans certaines maquettes.
## 4. Responsive et accessibilité
Appliquer les règles UX validées :
- Barre latérale repliée sous 1 280 px dans l'éditeur.
- Navigation accessible au clavier.
- Focus visible et cohérent après changement d'onglet.
- Annonces et libellés accessibles.
- Préservation de la règle O14 A : téléphone en lecture seule sous 1 024 px.
- Ne pas supprimer les capacités tactiles déjà présentes sur les largeurs autorisées.
La manipulation avancée des points et des polygones relève de U2, pas de U1.
## 5. Décision T17
Le propriétaire valide la solution suivante pour U6 :
Lorsqu'aucune catégorie ne porte le rôle `vertebra`, proposer une entrée de secours « Régions vertébrales » depuis Annotations.
Lorsqu'une catégorie Vertèbres existe, sa configuration doit se faire depuis cette catégorie, sans doublon.
Enregistrer cette décision selon la convention du registre et actualiser ses dépendances. Ne pas implémenter maintenant le nouveau modèle de catégories.
## 6. Vérifications
Avant toute exécution de tests :
- Vérifier le répertoire et la branche.
- Examiner le statut Git.
- Préserver le fichier de revue non suivi.
- Inspecter les commandes pour confirmer qu'elles ne visent pas DEV.
Exécuter les vérifications applicables à U1 :
- TypeScript et lint.
- Tests unitaires de navigation et d'historique.
- Tests de non-régression.
- Tests clavier/accessibilité pertinents.
- Tests d'intégration et E2E en sandbox jetable strictement isolée, si nécessaires.
Ne jamais exécuter une commande susceptible de joindre ou modifier Supabase DEV.
Faire une revue indépendante de la conformité U1 et corriger les écarts justifiés.
## 7. Git et traçabilité
Travailler dans :
`/home/bchanot/Documents/faunosteo-v1-2`
Sur :
`feature/v1-2-anatomical-sheets`
Utiliser les conventions Git du projet, avec commits réguliers et push.
Ne pas ajouter les fichiers non suivis préexistants sans nécessité et autorisation.
Ne pas modifier le checkout V1-1.
## 8. Interdictions
Aucune modification Rust, SQL, worker ou schéma documentaire.
Aucune migration, aucune opération sur DEV et aucun déploiement.
Aucune fusion.
Ne pas commencer U2, U3, U4, U5, U6, U7, U8 ou V1-2.7.
## 9. Checkpoint U1
Fournir :
- Liste des modifications réalisées.
- Correspondance entre l'interface et les maquettes V2.
- Tests réellement exécutés et leurs résultats.
- Revue indépendante et verdict exact.
- Éventuelles limitations restantes.
- Démonstration testable dans la sandbox.
- Commits et état Git.
- Critères de sortie U1.
S'arrêter au checkpoint U1.
Ne pas commencer U2 sans nouvelle autorisation explicite.
## CLARIFICATIONS
Q: The plan's U1 tooling (worker image commit label in `crates/worker/Dockerfile`, `verify-e2e` image check against
HEAD, demo sheet provisioned by the trial command in `scripts/db-sandbox.sh`) — the brief forbids worker changes /
A: [gated 2026-11-06] defer all of it to U6 (owner). No change under `crates/` or `scripts/` in U1. The U1 demo runs
on the existing trial stack: the owner creates a non-equine sheet in the UI as in `docs/development/V1-2-6_OWNER_TRIAL.md`.
The PLAN U1 acceptance line « a stale worker image is refused » and the TESTS U1 « Tooling » row move to U6.
Q: Where does « Abandonner les modifications » (C11, return to the last saved revision) sit, since the boards show no
discard control / A: [gated 2026-11-06] in the header, a secondary button beside the save state and « Enregistrer »,
edit mode only, disabled when nothing is unsaved; same confirmation and behaviour as today (owner).
Q: Internal design (brief « U1 — Validation de la conception interne », 2026-11-06) / A: [gated 2026-11-06] approach
A: the Annotations panel keeps board 01's cards; « Gérer les vues », « Modifier les catégories » and « Régions
vertébrales » open the existing level-1 editors in full-width sections with « Retour au dessin », until U3, U4 and U6
replace them; four tabs, references in a side panel, history in the header, sidebar hidden below 1 280 px, keyboard
navigation, focus management, read-only below 1 024 px. Ten mandatory precisions: no silent loss of changes, history
or editing state on a section, tab or panel change; « Retour au dessin » restores a coherent context and an
accessible focus; history tests on typed text, shortcuts and section transitions; a save shown only after effective
confirmation, never the browser clock as proof of persistence; read-only below 1 024 px on every editing entry,
moved forms and shortcuts included; reference counters from the current document, no network, no costly recount per
render; no « Prévisualiser » nor withdrawal, no existing function removed; the regions entry respects T17 without
anticipating U6; « Abandonner les modifications » only for unsaved changes, confirmed when data can be lost, never
removing the local copy silently; no provisional code hard to remove, sections replaceable without rebuilding the
navigation. Plan: `.claude/tasks/plans/2026-11-06-v1-2-6-ux-u1.md`.
Q: Save time source / A: [gated 2026-11-06] server time: after a confirmed save, one read of the existing admin
endpoint; « Enregistré à hh:mm · révision n » only when `draft_last_save` names the same revision, else « Enregistré ·
révision n »; never the browser clock.
Q: References panel behaviour / A: [gated 2026-11-06] non-modal: scrim over the content below the tabs (board 11),
content inert, header, tabs and Annuler/Rétablir usable, Escape or scrim click closes, content kept across closes.
Q: Control opening the filtered panel from a finding / A: [gated 2026-11-06] a « n référence(s) » button in the
Citations block of the selected finding's detail; no control inside the ARIA tree.
Q: Annotation list layout / A: [gated 2026-11-06] board 01 card « Annotations de la vue » (grouped by category,
« Filtrer par nom »), shown when nothing is selected; the properties panel gains « Toutes les annotations » to return
to it.
Q: U1 authorisation (brief « V1-2.6 UX — Ratification finale U1 et autorisation conditionnelle d'implémentation »,
2026-11-06) / A: [gated 2026-11-06] the 18 visible choices of the plan (checkpoint page section 1), approach A, the
amendments of AC3, AC4, AC5, AC7, AC17 (applied above, each tagged) and the changes 2.6 to 2.9 approved, with the two
precautions below. The plan at 2e46c14 stays the reference and is not redesigned. Implementation of U1 only, lots A to
I; per lot: scope and criteria respected, applicable checks run, existing functions kept, regressions fixed, validated
changes committed and pushed, no next lot while its preconditions are unmet. Kept in particular: global history and
Annuler/Rétablir, unsaved changes, the local recovery copy, rights and MFA checks, read-only behaviours, focus,
keyboard navigation and accessibility, document compatibility. U2 to U6 graphic operations excluded. Code starts
only after the targeted counter-check of the confirmation pass's three fixes and of the two precautions (verdict
reported, blocking gaps fixed and re-checked).
Q: Design criteria (checkpoint 2.7) / A: [gated 2026-11-06] no loss on a tab, section or panel change (Lots B2, D
tests); « Retour au dessin » focus and context; history tests on typed text, shortcuts and section transitions; save
shown only after the server answer, time only from the server; read-only below 1 024 px on every moved form and
shortcut; counts from the current document without network; no « Prévisualiser », no withdrawal, no removed function;
T17 entry without role logic; discard confirmation naming the stored copy; sections replaceable through one registry.
Q: Sandbox data deletion (checkpoint 2.9, made stricter by the authorisation brief §4) / A: [gated 2026-11-06] the
plan approval authorises no deletion of data, sandbox included, and no earlier go carries over. Before each
`pnpm db:sandbox down`, `pnpm db:sandbox up fresh` or any equivalent that may reset the sandbox (Lot B1, Lot I or any
other): stop before the destruction; take a read-only inventory of the containers, the accounts outside the seed, the
sheets, drafts and other resources concerned; present exactly what will be deleted; run it only on the owner's
explicit go for that operation. DEV is never a substitute for an unavailable sandbox. This prevails over plan :38-40,
:59 and :397.
Q: Unmounted forms (checkpoint 2.8, owner precaution) / A: [gated 2026-11-06] owner: « La traversée du seuil de
1 024 px ou une décision de récupération ne doit pas provoquer une perte silencieuse de saisie. Vérifier le
comportement réel des composants existants. Préserver les valeurs lorsqu'une solution sûre existe dans le périmètre
U1. Sinon, prévoir une confirmation explicite ou documenter précisément la limitation et les garanties de
récupération. Si la prévention de la perte exige une évolution hors périmètre U1, signaler le blocage avant
implémentation concernée. Ajouter les tests adaptés. » Facts (read 2026-11-06, `apps/app/src`): `readOnly = mode !==
'edit' || recovery !== 'none'` (route :132); the store accepts commits in narrow mode (`canEdit` true for edit and
narrow, `mode.ts:90-92`, `editorBase.ts:44-50`). Resolution, executor's, under the owner's rule:
- Recovery decision: no loss possible. An offer is pending only at opening (before any form exists,
`editorLoad.ts:65-88`, route :125-131) or when `canEdit` turns true from rights, inactive, historical or frozen
(`recoveryFlow.ts:76-95`), all read-only, so every edit-only part is absent while it is pending; « Restaurer » and
« Ignorer » mount empty forms. Pinned by a test (no edit-only control while an offer is pending, empty forms after).
- Width change to read-only, kept as today: `TextField` commits its typed text on unmount (`TextField.tsx:61-73`),
accepted in narrow mode (an unsaved change, recovery copy written); a value the field refuses keeps its message,
shown again when editing resumes.
- Width change to read-only, preserved (new): the edit-only parts without a native modal of their own stay mounted and
are hidden with `hidden` while read-only, instead of unmounting, so their values come back on widening: the
creation forms of categories, references, regions and detail views, the findings creation form, the submission
note, the crop group editor, and the annotation edit body (`EditableAnnotations`: tool, selection, pending creation
with its typed name, tracing, numeric geometry drafts) beside the read-only body. Hidden parts use the B2
`KeptPlace` visibility, so their canvases detach (one live composition per view). Three guards a width change needs
and a tab change does not: when the editor turns read-only, the route runs `commitFocusedField()` and blurs any
focus left inside a hidden part; the annotation edit body drops an in-flight drag without commit (its `moveTarget`
null while hidden, `EditableAnnotations.tsx:256-265`, `useMoveGesture.ts:54-57`); dialogs that confirm an edit
(`DeleteDialog`s, the discard confirmation) close without effect when the editor turns read-only, so no editing
entry stays usable below 1 024 px (precision 5; today they stay open and still write, level-1 behaviour).
- Width change to read-only, drawing actions of the views section (`ViewDrawing.tsx:47`): superseded by the answer
« Targeted counter-check before code » below (kept hidden, dialogs closed while read-only, one documented limit:
geometries typed inside an open repair dialog). Written in `docs/development/V1-2-6_OWNER_TRIAL.md` (Lot I) and the
checkpoint report.
- Not changed: `ConflictDialog` (a save outcome). Lots: B2 (kept edit-only parts, guards, unit tests), H (Chromium:
type in each preserved part, cross 1 024 px, no edit control and no focus in a hidden part, widen, values back; a
drag across the crossing commits nothing; open delete and discard confirmations close). Plan §2 cites
`CategoriesSection.tsx:51` and `ReferencesTab.tsx:44`; the lines are 52 and 47.
Q: Save time rights (AC7, owner precaution) / A: [gated 2026-11-06] owner: « Vérifier les droits nécessaires pour
consulter l'heure de sauvegarde à partir de l'endpoint existant. Ne pas élargir les permissions. Si l'information
n'est pas accessible avec les droits normaux du praticien, afficher « Enregistré · révision n ». Ne jamais afficher
une sauvegarde réussie avant confirmation serveur, ni utiliser l'horloge du navigateur comme preuve de persistance. »
Facts (read 2026-11-06): the read (`packages/supabase/src/sheets.ts:475-483`, SQL
`supabase/migrations/20261103100000_sheet_draft_last_save.sql:14-94`) is `stable security definer`, needs
`require_catalog_actor` (active profile, confirmed e-mail, aal2) and `caller_can_see_official_sheet` (aal2 and an
active sheet_editor, reviewer or publisher grant on an official, non-deleted sheet); `save_sheet_draft` needs
`can_edit_sheet` (aal2 and an active editor grant), so every user who can save can read; no audit row, no write
budget, no sign-out or step-up in the wrapper; `saved_at` is the server's audit time, null when the revision was not
written by a save. Resolution: no permission change; `readSaveTime` calls the accessor directly with the store's
client and session, as `readConflict` does (`editorSave.ts:56-71`), never the route's query (a failed route refresh
unmounts the editor, `useAdminQuery.ts:45-48`); any refusal or failure leaves `savedAt` null, shown « Enregistré ·
révision n »; « Enregistré » appears only after the server's save answer (`applySaved`); the time is
`draft_last_save.saved_at` formatted, never `Date.now()` or `new Date()`. Tests in Lot E: refusal and network failure
→ « Enregistré · révision n », editor still mounted; no saved line while the request is in flight; no browser clock
read in `saveLine.ts` and `readSaveTime`.
Q: Targeted counter-check before code (2026-11-06, plan-challenger, REMAINING(4), 9 MINOR) / A: [gated 2026-11-06]
fixes, executor's, under the owner's rules (no plan redesign; this answer prevails over the plan lines it names):
- E2E per lot (MAJOR): lots B1, E and F, which change the draft header or `AppLayout`/`MobileDrawer` used by every
shell page, run the whole shell suite (`pnpm db:sandbox e2e-shell`, no filter); the other lots from B1 run every
`apps/app/e2e/shell/editor-*.spec.ts`. « The two sentinels » of plan :362 is struck: :55-59 and this line are the
rule. No sandbox go at B1 → every e2e step waits and the lot is not committed as validated; never on the trial stack
as found, never on DEV.
- Plan text on unmounted forms (MAJOR): CLARIFICATIONS « Unmounted forms » prevails over plan :76-78, :145-146,
:164-168 and :646-647. Lot B2 adds to its files: `general/CategoriesSection.tsx`, `references/ReferenceForm.tsx`
(via the panel), `annotations/sections/{RegionsSection,ViewsSection}.tsx`, `views/{DetailViewRow,CropEditor,
ViewDrawing}.tsx`, `tabs/{FindingsTab,VerificationTab,AnnotationsTab}.tsx`, `annotations/{EditableAnnotations,
PropertiesPanel}.tsx`, `DeleteDialog.tsx`, the discard confirmation, `editor/useViewport.ts`, the route; its unit
tests add, per preserved part: type, switch to read-only, no edit control in the accessibility tree, switch back,
value back. Lot H (plan :519-520) checks that the values come back, not only « unsaved kept ».
- Ids in read-only (MAJOR): an edit part kept hidden beside a read-only twin never shares an id with it: the read-only
twins (`CropValues`, the read-only body's `PropertiesPanel` and fields) take an id prefix of their own; the B2
unique-id test also runs in read-only after a crossing, every place visited, a crop group open.
- Drawing actions (MAJOR): no longer a documented limit. `DrawingActions` stays mounted and hidden while read-only;
its three dialogs receive their open state (candidate, offer, asking) only while not read-only, so no native modal
is ever open inside a hidden part (`Dialog` mounts the modal only while open, `ModalDialog.tsx:72`) and the upload
phase, a pending cleaning candidate, a repair offer and a parent choice come back on widening; an upload settling
while read-only lands in the live hook. Remaining limit, documented: geometries typed inside an open repair dialog
are lost when it closes on the crossing (the dialog unmounts); the offer itself comes back.
- MINOR fixes: the read-only guard blurs before the hide: the viewport hook runs `commitFocusedField()` in its resize
handler before it changes the tier across 1 024 px, Chromium case « type, no blur, cross 1 024 px → unsaved, copy
written »; a value a field refuses is lost with that refusal (its message kept), stated as such; values a blur does
not commit (region range drafts until « Appliquer », creation drafts, refused values) are kept by the hidden place,
never committed, outside the document, the leave guard and the copy, as in level 1; focus requests go to the
visible annotation body only; « Aller à » another annotation drops a refused « non appliqué » geometry group, the
level-1 rule, kept and stated under choice 12; B2 tests add a click with no focus change (Safari-like) and the
panel closed by its header toggle while a reference field is focused, and the real path: pending creation and a
« Remplacer par un polygone » tracing, then Vérification, then « Aller à » an annotation → kept and focused.
Q: Re-check of those fixes (2026-11-06, fresh plan-challenger, REMAINING(1), 7 MINOR) / A: [gated 2026-11-06]
fixes, executor's (prevail over the answers above where they differ):
- Dialogs in hidden places (MAJOR N1): a dialog of a kept part receives its open state only while editing AND its
place is visible (`!readOnly && usePlaceVisible()`), so an offer that settles while the views section is hidden
(left during an upload) or a widening on another tab never opens a native modal inside a hidden subtree; the dialog
opens when the section is shown again. `DeleteDialog` and the discard confirmation close through `onClose`, never
withheld. B2 test: an offer settling with the section hidden, and a widening on another tab, leave `dialog[open]` at
0 until « Gérer les vues ».
- N2: on a crossing, a withheld dialog stays modal for its exit animation (0.15-0.18 s, `Dialog.tsx:47-61`) and its
unmount returns focus inside the editor; stated; H waits for a dialog count of 0 (LRN-111) before checking focus.
- N3: the general rule: anything rendered in both annotation bodies (properties panel and fields, overview panel and
its « Filtrer par nom », selection tag, test ids) takes the body's prefix or a `useId` id; the e2e helper scopes to
the visible body; the unique-id test runs with nothing selected and with a selection, in edit and after a crossing.
- N4: the split, stated and tested: a field that switches in place to its read-only value (`TextField.tsx:31-40`)
loses a value its commit refuses (message kept); a field inside a kept part keeps it.
- N5: a kept part mounts at its first edit-mode render and is kept from then on; a page opened read-only (narrow,
recovery pending, rights, frozen, inactive, historical) mounts no edit part, so the recovery bullet holds; test: a
page opened narrow has no edit body.
- N6: level-1 behaviour stated in the limits: an upload in flight when the editor turns read-only still attaches its
drawing (`drawingUpload.ts:184-191`, a commit the store accepts in narrow mode, an unsaved change); B2 test.
- N7: B2's files add `annotations/AnnotationFields.tsx` and `references/ReferencesPanel.tsx`.
- N8: the repair-dialog limit is removed: `geometries` moves from `RepairForm` into `RepairDialog`, keyed on the
offer, so typed repair geometries survive the crossing like the other kept values (`views/RepairDialog.tsx`, B2).
Q: Third pass (2026-11-06, fresh plan-challenger, REMAINING(1), 3 MINOR) / A: [gated 2026-11-06] MINOR fixes,
executor's:
- Pending offer after an edit-mode render: the route also treats `useEditorStore(s => s.canEdit) !==
storeCanEdit(mode)` as read-only, so no render is in edit mode before the recovery detection of `setCanEdit` runs
(`AdminSheetDraftRoute.tsx:115,132`, `recoveryFlow.ts:85-94`); test: rights → edit inside one mount with a stored
copy mounts no edit part before the offer.
- Repair dialog: `RepairDialog({ offer, open })`, `offer` never gated, state reset only when a different non-null
offer arrives; not kept across a crossing, stated: the apply refusal `result` and an unparseable draft held in
`GeometryGroup`'s own state.
- Upload outcomes: `UploadNotices` and the `views.error` notice render outside the hidden wrapper, so a working,
failed or pending state shows in read-only; N6 restricted to narrow mode (frozen, rights or inactive refuse the
attach, its failure shown by those notices).
Q: A withheld decision dialog of the views section (cleaning, repair, parent drawing) reopening by itself when its
place is shown again, taking focus from a tab or an « Aller à » target (third pass MAJOR) / A: [gated 2026-11-06]
owner: « Reprendre » button. A dialog withheld while its place was hidden or the editor read-only never reopens by
itself: the view row's upload notice shows the decision as pending with a « Reprendre » button that reopens it (new
label, proposal C44); AC12 and AC13 unchanged. B2/H tests: a tab click and an arrow back onto Annotations keep focus on
the tab; « Aller à » a view focuses its row; `dialog[open]` stays 0 until « Reprendre »; « Reprendre » opens the
dialog with its state (candidate, offer with typed geometries, parent choice).
Q: Fourth pass (2026-11-06, fresh plan-challenger, REMAINING(1), 5 MINOR) / A: [gated 2026-11-06] fixes,
executor's:
- « Reprendre » in read-only (MAJOR): an `ActionButton readOnly={readOnly}`, absent in every read-only mode (AC11),
the pending text kept; clicking it is the only way a withheld dialog opens. B2 test: narrow with a withheld
decision shows the pending text and no « Reprendre »; after widening `dialog[open]` stays 0 until « Reprendre ».
- Withheld state: per decision object (candidate, offer, parent `asking`), held in `DrawingActions`, set in any render
where that decision exists while `readOnly`, its place hidden, or the references panel open; a new decision that
arrives in edit mode, place visible and panel closed, opens normally. Test: after a withheld decision ends, a new
one opens on its own.
- Pending decision and new actions: while a decision is pending (dialog withheld), the file picker and « Utiliser
l'illustration de la vue parente » are disabled with the pending notice as their description, so no pick silently
replaces a pending offer and its typed geometries.
- Parent choice: a withheld parent choice has its own pending line in the row's notices; the pending texts (cleaning,
repair, parent) and « Reprendre » are label proposals listed in the Lot G file (C44).
- References panel open: a place under the open panel counts as not visible for decision dialogs (withheld, then
« Reprendre »), so no modal opens over the panel and focus is never lost to `body`.
- Route resync after a submission: the route's `setCanEdit` effect depends on `[canEdit, sheet]`, so after
`submit()` sets the store's `canEdit` false and the refresh keeps the draft editable (`verification_failed`,
`changes_requested`, `withdrawn`), editing is re-enabled; test for each of those rounds.
Q: Fifth pass (2026-11-06, fresh plan-challenger, VERDICT: CONFORME, 4 MINOR) / A: [gated 2026-11-06] MINOR
answers, executor's:
- Recovery bullet amended: an offer can also become pending mid-session after the submission resync or an edit →
rights → edit change, with kept parts mounted and hidden; no data is lost (read-only, the user decides) and kept
drafts stay across « Restaurer » or « Ignorer »; B2 test pins it. Skipping the detection would need `editor/state`
(outside U1).
- Parent choice: `asking` becomes a per-click token, so a later parent choice is a new decision and opens normally;
cleared when the view's own drawing disappears; included in the « new decision opens on its own » test.
- The hidden file input gets `disabled` while a decision is pending, as the visible picker.
- Limits written in `V1-2-6_OWNER_TRIAL.md` (Lot I) with one B2 test: a withheld decision is lost when its view is
removed (undo, discard, reload, deletion), redo does not bring it back; a decision pending at a submission stays as
a pending line without action in frozen mode.
Q: Files outside FILE SCOPE added during execution (fresh verifier, 2026-11-08) / A: executor's rulings, recorded in
the SDD ledger at the lot that made them, not owner-gated: `components/catalogue/CatalogueCanvas.tsx` (B2a, the
catalogue canvas detaches its tree while hidden like the editor canvases), `lib/placeVisibility.ts` (B2a, the
visibility context in a neutral lib so the catalogue does not import the editor), `editor/editingContext.ts` (B2b,
`EditOnly` and `useEverEditable`, precaution 2.8), `editor/references/filter.ts` (D, the panel filter split from
`citations.ts`), `components/shell/ShellChrome.tsx` (F, `Sidebar` and `TopBar` split from `AppLayout.tsx` for the
function limits). Each is reviewed in its lot. The three limits of N4, N6 and the third pass (repair `result`) are
written in `V1-2-6_OWNER_TRIAL.md` « Limites connues de U1 » with the Fifth pass ones.
Q: Owner decisions at the U1 checkpoint (2026-11-09) / A: brief « V1-2.6 UX — Décisions au checkpoint U1 » (BDR-106) [gated 2026-11-09]: the five files of « Files outside FILE SCOPE added during execution » and the three one-for-one assertion rewrites (editor-journey.spec.ts:14, editor-recovery.spec.ts:7, editor-route-recovery.test.tsx:93; mapping 99b669b) are accepted, their justification and mapping kept in `docs/development/V1-2-6_UX_U1_CHECKPOINT.md` §7.2; no general scope widening for later steps. U1 implemented, checkpoint open; shell suite at da95b84 188 passed / 90 skipped / 4 failed (admin.spec.ts:717), never reported green on the last commit; no sandbox reset to get green.
## ACCEPTANCE CRITERIA
1. Four tabs from 1 024 px: Général, Annotations, Constats, Vérification, as an ARIA tablist (arrows, Home/End not
required beyond today's pattern); no « Vues et illustrations », « Références » or « Vertèbres » tab remains; the
initial-tab rule of C40 as amended holds (Général for a sheet without a measurable view, else Annotations).
2. Annotations holds, with their level-1 operations unchanged: the views and their drawings (main view, detail views,
upload, cleaning, attach, the numeric crop editor kept until U4), the annotation categories (level-1 editor kept
until U3) and the « Régions vertébrales » fallback entry with the level-1 regions editor (T17, BDR-102; no role
exists before U6), laid out after board 01's overview panel; no U2-U6 operation is added (no handle, slider,
rectangle, remap, role, opacity).
3. [amended 2026-11-06, owner, checkpoint 2.1] References open in a non-modal side panel after board 11, anchored
below the tab row so that it never covers the draft header or the tab row, from a « Références » button in the
header and from the selected finding's detail (a « n référence(s) » button in its Citations block), filtered to
that finding's citations with « Tout afficher (N) », with search on citation, DOI and URL, the citation count per
reference, and the level-1 add / edit / delete; a scrim covers the tab panels, which are `inert` while the panel is
open; the header, the tab row, « Annuler », « Rétablir » and Ctrl+Z stay usable; Escape, ✕ or a click on the scrim
closes it, and focus returns to the opener, else to the header « Références » button; read-only (no edit control)
in every read-only mode; the panel is not a `ModalDialog`, and every dialog opened from it stays one (D13,
BDR-076).
4. [amended 2026-11-06, owner, checkpoint 2.2] Undo and redo sit at the right of the tab row on every tab (board
`hist()`): icon and visible « Annuler » /
« Rétablir »; « Annuler » has the accessible name and tooltip « Annuler la dernière modification » (T15); redo's
long name is a label proposal; enabled exactly when the store can undo or redo AND the editor is in edit mode with
no recovery pending; disabled in every read-only mode (narrow, frozen, rights, inactive, historical, recovery
pending); enabled while a save is in flight, as Ctrl+Z (a step taken during a save stays unsaved); the same `undo()`/`redo()` store actions as today, history and its 8 MiB bound unchanged;
Ctrl+Z and Ctrl+Shift+Z unchanged; the undo and redo buttons of the tool column are removed (no pair on the
drawing).
5. [amended 2026-11-06, owner, checkpoint 2.3] Undo from any tab reverts the last accepted commit, whichever tab made
it; a field holding typed text is committed before the header undo (blur forced at pointerdown; keyboard users
reach the button with Tab, which blurs the field), and that commit is what the undo reverts, also when the history
was empty before it; when the field refuses the value (its error shown), no undo happens and focus returns to the
field (behaviours pinned by tests).
6. « Abandonner les modifications » replaces « Annuler les modifications » in the header beside « Enregistrer »
(clarification), with the same confirmation and `discardChanges` behaviour; C28's list names it.
7. [amended 2026-11-06, owner, checkpoint 2.4; precaution in CLARIFICATIONS « Save time rights »] The header save
line follows the boards, first matching form: a recovery copy issue (cap or quota), today's text;
« Enregistrement… » while saving; while unsaved, « n modification(s) non enregistrée(s) » (plural mechanism) when
n, the number of accepted changes between the shown and the saved document along the history, is a positive
number, else « Modifications non enregistrées »; after a save confirmed by the server in this page session,
« Enregistré à hh:mm · révision n » when one read of the existing admin endpoint returns that revision's save time,
else « Enregistré · révision n » (also after `draft.unchanged`), never the browser clock; « Révision n » when
nothing was saved in the session; state changes announced, not each count change; the save mechanism itself
unchanged.
8. The Vérification tab shows the boards' text badge « n erreur(s) » (plural mechanism) when the in-page check has
errors.
9. In the editor, the application sidebar is hidden below 1 280 px and shown from 1 280 px; below 1 280 px the top bar
shows the menu button, which opens the existing drawer (D11, BDR-079) one tap away; the drawer does not close by
itself while the sidebar stays hidden; every menu link stays under the leave guard (BDR-078); other pages keep
today's 1 024 px rule.
10. From 1 024 to 1 279 px the editor follows board 13: properties beside the canvas (C25 as amended), header actions
in reach; no horizontal scroll at 1 024, 1 180, 1 279 and 1 280 px on any tab and with the references panel open.
11. Below 1 024 px (O14 A, C16 as amended): read-only as today, notice title alone, badges, tabs, whole drawing, zoom
and pan, properties summary, no editing action and no enabled undo or redo; unsaved work survives a width change;
no horizontal scroll at 320, 375 and 768 px; touch abilities already present from 1 024 px kept.
12. Focus and announcements: clicking or arrowing a tab keeps focus on that tab; a tab change started from inside a
panel (a hint link, « Aller à ») moves focus to its target element, or to the new tab when there is none, never to
`body`; a polite live region (distinct from the save status) announces a tab or section reached that way; focus
is visible on every new control.
13. « Aller à » reaches every issue kind in its new place: views, categories and regions in Annotations (the section
shown and its row focused), references in the side panel (opened, the reference focused), annotations, findings
and general fields as today.
14. Unchanged: the explicit save, the local recovery (C13, C27, C28), conflicts, rights and MFA checks, the mode
precedence (C38), submission and publication rules, the document format, Rust, SQL, the worker, the core and its
wasm build; level-1 criteria C13, C14, C16, C34 and C41 re-run green.
15. No V1-2.7 control: no « Prévisualiser », no withdrawal (DECISIONS « Points from the boards »).
16. i18n: every string through `useT`, FR/EN parity; prose that names an old tab is reworded to the new place; the new
labels are listed as proposals in `.claude/audits/2026-11-06-v1-2-6-u1-label-proposals.md` for the owner's label
review (C19, C44).
17. Tests: unit tests for the tab model and tiers, header undo/redo states (edit and every read-only mode), cross-tab
undo, the typed-field flush, the references panel (open from header and finding, filter, close, focus return),
« Aller à » targets, the sidebar rule, the save line; e2e helpers (`e2e/support/editor.ts`, `warm-up.ts`) and
specs rewritten for the new shell; every removed or rewritten assertion mapped to its replacement in the commit
message (R-24); axe with no serious or critical violation on the four tabs, the open references panel and the
narrow read-only mode; a keyboard test of the order header → tab list → « Annuler » / « Rétablir » → references
panel when open → tab panel content in visual order (tools, canvas, side column) [last item amended 2026-11-06,
owner, checkpoint 2.5].
18. Gates, in this order, all green: `pnpm typecheck`, `pnpm lint`, `pnpm test:run`, `pnpm build`, `pnpm e2e:ui`,
a fresh sandbox `pnpm db:sandbox up fresh` then `test-db → e2e-shell → test` (LRN-113), `pnpm check:all`,
`pnpm r5:import-equine --check`; a fresh verifier and a fresh security review.
19. Scope: no change under `crates/`, `supabase/`, `scripts/`, `packages/core-wasm/src/`, `packages/supabase/src/`,
`docs/design/v1-2-6/`; nothing staged from the untracked review file.
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && git diff --quiet 846994b..HEAD -- crates supabase scripts packages/core-wasm/src packages/supabase/src docs/design/v1-2-6 && git diff --quiet -- crates supabase scripts packages/core-wasm/src packages/supabase/src docs/design/v1-2-6 && ! git ls-files --error-unmatch faunosteo-v1-2-6-revue-ux-chatgpt.md >/dev/null 2>&1 && echo U1_SCOPE_OK
EXPECT: U1_SCOPE_OK
EVIDENCE: MET exit=0 marker-found :: U1_SCOPE_OK
20. FR/EN dictionaries hold the same keys.
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && node -e "const fs=require('fs');const k=f=>new Set([...fs.readFileSync(f,'utf8').matchAll(/^\s*'([a-z0-9_.]+)':/gm)].map(m=>m[1]));const a=k('apps/app/src/i18n/fr.ts'),b=k('apps/app/src/i18n/en.ts');const d=[...a].filter(x=>!b.has(x)).concat([...b].filter(x=>!a.has(x)));if(d.length||a.size<100){console.error(d);process.exit(1)}console.log('I18N_PARITY_OK',a.size)"
EXPECT: I18N_PARITY_OK
EVIDENCE: MET exit=0 marker-found :: I18N_PARITY_OK 1458
21. [added 2026-11-06, owner precaution 2.8] No silent loss of typed input on a 1 024 px crossing or a recovery
decision, as resolved in CLARIFICATIONS « Unmounted forms »: the listed edit-only parts kept and hidden while
read-only with their values back on widening (drawing actions included, their dialogs closed while read-only),
the guards, distinct ids for read-only twins, dialogs open only in edit mode in a visible place, kept parts mounted
from the first edit-mode render; unit tests (B2) and Chromium journeys (H), as completed by CLARIFICATIONS
« Targeted counter-check before code » and « Re-check of those fixes ».
22. [added 2026-11-06, owner precaution AC7] Save time read with the existing rights only, as resolved in
CLARIFICATIONS « Save time rights »: no permission change, refusal or failure → « Enregistré · révision n » with
the editor still mounted, nothing shown as saved before the server's answer, no browser clock; tests in Lot E.
## FILE SCOPE
- apps/app/src: editor tabs model (`editor/tabs.ts`, `editor/useViewport.ts`, `editor/verification.ts`,
`editor/focusRequest.ts`, `editor/annotations/focusTarget.ts`), editor state selectors needed for the header
(`editor/state/*`, read-only additions only: save count, save time), `components/editor/**` (EditorTabs,
EditorTabBody, DraftHeader, tab bodies, annotations panels, references panel, verification), `components/shell/
{AppLayout,MobileDrawer,SidebarNav}.tsx`, `app/routes/app/admin/AdminSheetDraftRoute.tsx`, `i18n/{fr,en}.ts`
- [added 2026-11-06, owner, checkpoint 2.6] `apps/app/src/editor/{navigation,saveLine,useEditorNavigation,
sheetDocument}.ts`, `apps/app/src/editor/references/citations.ts`, `apps/app/src/editor/annotations/{overview,
useCanvasBuild}.ts` (overview new; the build hook detaches while hidden; the canvas reset uses the existing `view`
action of `uiState.ts`, unchanged), `apps/app/src/catalogue/useCatalogue.ts` (export `folded` only),
`apps/app/e2e/lan/trial-lan.spec.ts`; `editor/state/*` edits limited to `lastSave` and `readSaveTime`
- apps/app/tests/unit/**, apps/app/tests/helpers/**, apps/app/e2e/** (support helpers, shell and ui specs)
- docs: `docs/development/V1-2-6_OWNER_TRIAL.md` (U1 demo steps), `docs/development/BROWSER_TESTS.md` if a suite
changes, `docs/development/V1-2-6_UX_{PLAN,TESTS}.md` (tooling moved to U6), `.claude/audits/2026-11-06-v1-2-6-u1-
label-proposals.md`
- .claude/tasks (this contract, plan, TODO), .claude/memory (through memory.sh)
- NOT in scope: crates/**, supabase/**, scripts/**, packages/core-wasm/src/**, packages/supabase/src/**,
docs/design/v1-2-6/**, the V1-1 checkout