60 lines
4.1 KiB
Markdown
60 lines
4.1 KiB
Markdown
# Contract: V1-2.2 owner decisions of 2026-11-01
|
||
|
||
Owner brief « V1-2.2 : décisions et poursuite des corrections », 2026-11-01, on `f1bb19b`
|
||
(branch `feature/v1-2-anatomical-sheets`). Owner answers during the run (2026-11-01): threshold
|
||
4 CSS px on the editor at 320 × 568; « the visible wins » on the editor canvas only, the PDF view
|
||
keeping the document order.
|
||
|
||
Diff under review: `f1bb19b..HEAD` (commits `4f52f5e` lot B, `e677150` R4.1 manifest, `9c606aa`
|
||
junctions, `96b9978` visible size and frame range).
|
||
|
||
## Criteria
|
||
|
||
- D1 Lot B committed as the approved patch `.claude/audits/2026-10-30-v1-2-2-lot-b-isolation.patch`
|
||
(no other change in `4f52f5e` but the allowlist census: `sanitize::ALLOWED_ATTRIBUTES` made public,
|
||
`svg_marker_isolation::nothing_the_reader_keeps_changes_the_layer_or_the_halo`). Isolation holds for
|
||
every attribute the reader keeps and for descendant `style` values, including CSS that acts outside
|
||
its subtree in HTML; browser probe documented (RUST.md §12.12).
|
||
- D2 References: R3 highlight oracle and R3 canvas goldens compared under declared transforms, frozen
|
||
files unedited; the only edited reference is the R4.1 manifest call-1 `svgSha256`
|
||
(`a9a3155c…` → `45fd4aaf…`); R4 PDF digests, step6 goldens, N-1 copies, seed review drawings,
|
||
equine drawing and fingerprint unchanged. Each transform documented exactly (RUST.md §12.12 table).
|
||
RUST.md §12.10 correction recorded. No general regeneration.
|
||
- D3 Junctions: the canvas (`compose_canvas`, `render_canvas_layer`) paints every point hitbox, then
|
||
every zone and trigger, then every visible twin capturing on `visiblePainted`, document order inside
|
||
each pass; the PDF view (`render_composed_layer`) and the R3 layer (`render_layer`) unchanged.
|
||
ANNOTATION-RENDERING updated. Click spec: `c7-t1`, `l6-s1`, `t18-l1`, fore fetlock, close fetlocks,
|
||
disc coverage (main and head), zone coverage, touch projects (Chromium 320 and 375, WebKit 375); no
|
||
`fixme`; red on `e677150` for the junction and disc tests. Drawings and documents not edited.
|
||
- D4 Visible size: every annotation in frame shows at least `MIN_VISIBLE_PX` 4 CSS px on the preview
|
||
boxes measured at 320 × 568 (main 286 × 310, detail 254 × 191, `xMidYMid meet`); a point measured on
|
||
its visible disc (`layer::twin_radius`, the formula the layer draws with), never its hitbox; shapes
|
||
on their smaller side with curves and arcs on their shape. Issue `annotation.geometry.too_small`,
|
||
verdict `verification.validation.marker_too_small`; verdict and preview agree; the document never
|
||
rewritten. The bypass (horse `viewBox` × 100 with content scaled back) refused with its 19
|
||
main-view markers; × 1 000 refused as no usable frame.
|
||
- D5 Frame range: one definition (`Frame::from_numbers`) for the composers, the verdict and the
|
||
preview: finite, edges within 2²⁰, spans from 1 unit, aspect at most 100, farthest edge at most 256
|
||
smaller spans; each bound tested at its limit and past it; justification measured in the three
|
||
engines (RUST.md §12.13 tables); the equine accepted.
|
||
- D6 Gates: cargo on every feature set, clippy `-D warnings`, mutations (2026-10-30 and 2026-11-01
|
||
scripts) with every survivor justified, wasm module under 600 000 B gzip, `check:all` on the final
|
||
HEAD (Docker stages included), e2e:ui (canvas clicks on the six projects), e2e:shell when the
|
||
isolated stack runs.
|
||
- D7 Docs describe only what is implemented: RUST.md §12.12 and §12.13, V1-2 contract §6.7 table,
|
||
ANNOTATION-RENDERING, BROWSER_TESTS.
|
||
|
||
## Out of scope
|
||
|
||
No SQL, no Supabase DEV, no worker change, no merge, no V1-2.3, no deploy.
|
||
|
||
## Clarifications
|
||
|
||
- Declared limit: a thin shape on a diagonal is measured on its bounds (scale floor, not a shape
|
||
review).
|
||
- `crates/core/tests/svg_marker_isolation.rs` `layer_and_defs` uses `Iterator::skip(1)` (skips the drawing's
|
||
group before serialising the layer and the halo): not a skipped test.
|
||
- Mutant F5 (zero width accepted) is equivalent: the aspect rule refuses a zero or negative span.
|
||
- New closed codes chosen by the implementer, to confirm with the owner: `marker_too_small`,
|
||
`annotation.geometry.too_small`.
|