50 lines
3.2 KiB
Markdown
50 lines
3.2 KiB
Markdown
# Contract: V1-2.2 root visibility and final A6 perimeter
|
|
|
|
Owner brief « V1-2.2 : arbitrage définitif A6 et correction visibility », 2026-10-30, on `81f7639`
|
|
(branch `feature/v1-2-anatomical-sheets`). Diff under review: the working tree against `81f7639`.
|
|
|
|
## Problem
|
|
|
|
Both composers (`crates/core/src/anatomy/compose.rs`) append the engine's marker layer as the drawing
|
|
root's last child (PDF view: the drawing's own root; canvas: a root copying its attributes). A root
|
|
`visibility="hidden"` was accepted with no removal; the layer inherited it while the drawing's
|
|
children set `visible` back, so the markers vanished from the PDF and the canvas.
|
|
|
|
## Criteria
|
|
|
|
- R1 The shared reader (`read_svg`) refuses a root `visibility` other than `visible` with a closed,
|
|
stable reason `root_visibility`, before a drawing can be verified or published; the cleaning
|
|
(`clean_svg`), the verdict, the preview and its canvas, the loaded sheet, the upload tool and the PDF
|
|
snapshot gate answer through the same check (no divergent rule).
|
|
- R2 No bypass through the forms the reader accepts: letter case, CSS whitespace, character
|
|
references, CSS-wide keywords, unreadable values; equivalent styles (root `style`, root `class`,
|
|
`<style>`) never reach the root; a descendant's `visibility` cannot reach the layer.
|
|
- R3 Targeted: legitimate attributes are not refused without a demonstrated danger; other root
|
|
properties (`opacity`, `display`, `filter`, `mask`, `clip-path`, paint) are either already removed or
|
|
argued to act on drawing and markers alike, with evidence.
|
|
- R4 Both composers refuse such a root (fail-closed); the `osteo-halo` protections of `08efd9a` stay
|
|
effective.
|
|
- R5 Historical drawings, the equine fingerprint (sha256 `0ea5202f…`), frozen R3/R4 oracles, step6
|
|
goldens and N-1 copies unchanged.
|
|
- R6 Tests: reproduce the defect first, then the fix; normal drawing, hidden root, descendant
|
|
`visible`, styles, other root attributes, cleaning and canonical form, verdict, PreviewSheet, composed
|
|
canvas, real PDF export session, equine non-regression, adversarial inputs, targeted mutations,
|
|
shipped wasm module.
|
|
- R7 A6 final perimeter: Figma, Inkscape, cairo, ImageMagick (real exports, tested). Adobe Illustrator
|
|
and Affinity are OPTIONAL: their absence is NOT a gap and must not be reported as one; they must not
|
|
be declared compatible or validated anywhere without a real export; fixtures and the `owner/`
|
|
procedure stay. Contract core (D1/B6/C1 superseded by E1), V1-2 contract §17.6, RUST.md, READMEs,
|
|
TODO and the decisions registry (BDR-090, BDR-088 amended) say so consistently.
|
|
- R8 BDR (reserved `osteo-halo`, not `osteo-*`) and LRN (heredoc expansion) recorded factually.
|
|
- R9 Docs: RUST.md §12.10, V1-2 contract §9.2 and closed codes, ANNOTATION-RENDERING.
|
|
|
|
## Out of scope
|
|
|
|
No SQL, no Supabase DEV, no worker DEV, no historical resource change, no merge, no V1-2.3.
|
|
|
|
## Clarifications
|
|
|
|
- The reader-refusal assertions of `svg_reserved_ids.rs` moved, reason-parameterised and unchanged, into
|
|
`tests/common/sheet_readers.rs::assert_refused_everywhere` (shared with `svg_root_visibility.rs`); the test count is
|
|
unchanged (floor guard: assertion lines 18 → 10 in that file, by design).
|