2.9 KiB
2.9 KiB
V1-2 test reductions found by the floor guard (develop..HEAD), 2026-11-01
Owner brief « Validation V1-2.3 (M6) et derniers ajustements » §5: keep the four historical test
reductions identifiable, with scope and justification; report any one hiding a missing security
coverage before V1-2.4. Found by floor-guard.sh develop -- . during the V1-2.3 reserves
verification; none has a commit in V1-2.3.
| # | Finding | Commit | Scope | Justification | Security coverage |
|---|---|---|---|---|---|
| 1 | crates/core/tests/sheet_conformance.rs assertion lines 5 → 0 (counted at line 1) |
77e5fa4 (V1-2.1 M4/M5) |
the two SQL-mirror tests the_sql_expectations_are_the_mirrored_error_codes and the_pgtap_file_is_generated_from_the_fixtures, and the generated supabase/tests/011_sheet_conformance.sql |
owner decision O22 (V1-2 contract §12.2): the SQL business mirror private.sheet_document_* removed, the Rust core the only authority on business rules; the Rust-side test the_rust_rules_report_what_the_typescript_rules_reported stays with its three assertions over every fixture (the guard's count is a line-1 artefact) |
none lost: publication requires an approved round whose passed verdict is current, computed by the core in the worker (M6) and checked by SQL; pgTAP 016, 017, 021 and sandbox verify-e2e case d |
| 2 | crates/core/tests/curation/LEDGER.tsv:123 assertion lines 27 → 26 |
77e5fa4, a21866e, 08efd9a |
ledger rows: the 26 conformance rows retargeted to the remaining Rust test (same O22); the halo row retargeted to the_halo_filter_is_written_once_and_a_composed_root_is_refused |
the ledger follows the tests it names; the halo test is stronger (one filter and a composed root refused, V1-2.2 reserved halo id, owner brief) | none lost; the TS « has no stale fixture file » check is now implicit: every file in tests/conformance is read and asserted |
| 3 | crates/core/tests/svg_marker_isolation.rs:248 .skip(1) |
4f52f5e, 9c606aa (V1-2.2) |
an iterator .skip(1) in layer_and_defs (the composed root's first child, the drawing group, left out of the comparison) |
not a test skip: false positive of the guard's pattern | n/a |
| 4 | packages/supabase/tests/anatomical-sheets.test.ts deleted |
77e5fa4 (V1-2.1) |
the client-side publish gate test (publishSheetVersion calling the RPC only for a publishable document) |
the client gate was deleted with it: publication is the server's publish_sheet_version(review_id) on the stored verdict (V1-2 contract §6.8); a client check is not a security control |
server gate covered: pgTAP 017 (19 calls, publish.review.missing while not approved), 016, 018 matrix, sandbox verify-e2e case d and case j (publication after a current passed verdict) |
Conclusion: no reduction hides a missing security coverage. Only #1 and #4 remove tests, both with the owner decision O22 and the server-side replacement already tested.