Commit Graph
67 Commits
Author SHA1 Message Date
Bastien ChanotandClaude ff7ac5969e fix(editor): scope zone highlight to active obs + repaint detail SVG + harmonize header
Three related editor polish bugs from PDF-import dogfooding.

(1) boneStates previously walked every observation, marking zones
in collapsed observations as 'linked' (faint) or 'multi' (bold) —
so deselected zones kept lingering color states. Now we read only
the active observation; everything else renders neutral.

(2) AnatomyCanvas applied highlight attributes once on mount; when
the SVG (esp. inside DetailModal) loaded after the boneStates
effect had already run, the freshly-mounted nodes had no
data-state. Track loadedSrc and re-run the highlight effect after
each SVG swap so detail-popup zones get colored on open.

(3) NewReportRoute had "← Accueil" on the right while EditorRoute
keeps it on the left — disorienting. Both headers now share the
same left-aligned back-button + clickable Brand pattern.

Deviation: hotfix rule caps at 2 files, this touches 3. Each fix
is mechanical and obvious; bundling is cheaper than three separate
patches.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 06:55:16 +02:00
Bastien ChanotandClaude 2cfc49df04 fix(pdf): pack observation SVGs into 2-column grid, reserve text space
Multi-SVG observations previously stacked vertically and pushed
the zones/pathologies/severity/comment sections off the page.
Now SVGs are laid out 2 per row with cell width = (page - 2*margin
- col-gap)/2. Each cell scales to its own aspect, capped by a
per-row height budget that subtracts the reserved bottom (text
sections + bottom margin) from the available image area. Single-
SVG observations keep a full-width row.

Safety: the text-area reservation guarantees the sections always
fit; the cell-height cap prevents runaway when many details are
selected. A floor (IMAGE_MIN_CELL_H) avoids zero-height cells in
pathological cases.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 06:42:47 +02:00
Bastien ChanotandClaude 908790123d feat(editor): home navigation and edit-infos dialog
Header now exposes a back button and clickable brand title both
linking to /. New "Modifier les infos" button opens a dialog that
edits practitioner, animal, and owner via the existing forms with
cancel/save and required-name validation. Save also refreshes the
practitioner localStorage cache.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 06:27:38 +02:00
Bastien ChanotandClaude 1280f9feb8 feat(store): add practitioner/animal/owner setters
Enables in-place edit of report identity blocks from the editor.
Mirrors existing setConclusion/setRecommendations pattern; no-op
when no report is loaded.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 06:27:32 +02:00
Bastien ChanotandClaude d7ea99e040 fix(pdf): stack eyebrow + title without overlap, color-code severity pill
Eyebrow OBSERVATION / SYNTHÈSE now baseline-anchored at y=height-95;
title baseline at y=height-122. 27pt separation between baselines so
the Times-22 ascender no longer reaches into the eyebrow line.

Severity next to the observation number is rendered as a filled pill
with white uppercase label. Background color encodes severity at a
glance:
- légère  → sage green
- modérée → amber
- sévère  → red

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 06:14:14 +02:00
Bastien ChanotandClaude ee5b7f0277 fix(pdf): push titles below header rule + style headings and section labels
Layout:
- Title baseline dropped from height-90 to height-115 so the size-22
  ascender clears the header rule at y=760 with a real cushion.
- Image area starts further down to match.

Visual style:
- Eyebrow label (small bold accent) above each title: OBSERVATION /
  SYNTHÈSE. Title uses Times 22; observation page shows the index
  as a zero-padded number (01, 02, …) with severity as a muted
  inline note next to it.
- 2pt accent rule (48pt wide) under each title.
- Section labels (ZONES, PATHOLOGIES, SÉVÉRITÉ, COMMENTAIRE,
  CONCLUSION, RECOMMANDATIONS, PROCHAIN RENDEZ-VOUS) rendered as
  small bold uppercase accent labels with the value on the next
  line in regular body.
- Image area gets a "VUE GÉNÉRALE" / "VUE DÉTAIL — <id>" eyebrow.

Colors are inlined as rgb tokens (ink, muted, accent terracotta).
No new assets, only the three Standard fonts already embedded.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 06:08:12 +02:00
Bastien ChanotandClaude bc9a51784a fix(pdf): clear header, wrap zone line, hide non-selected zones, skip main SVG when only details
Four coupled PDF rendering bugs:
1. Title "Observation #N" and "Conclusion" overlapped the header rule
   (y = height - 80; rule at y = 760; size-16 ascender ate the line).
   Lowered both titles to y = height - 90.
2. Long zones lines visually wrapped via maxWidth but the cursor only
   advanced one slot per array entry, so pathologies/sévérité/commentaire
   collided with the wrapped tail. Added wrapLines + per-line advance.
3. The rasterized anatomy still showed unselected zones (purple spine
   fills, orange head trigger) because colorizedSvgString only mutated
   selected elements. Non-selected annotated elements are now hidden via
   display="none" and every data-anno-* attribute is stripped from the
   serialized output (data-anno are runtime-only hints).
4. Main SVG was drawn even when every zone lived in a detail popup.
   Render it only when at least one zone has no detailSourceId.

Layout constants extracted at the top of observationPage.ts.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 05:31:54 +02:00
Bastien ChanotandClaude 6e3a839595 fix(editor): keep detail-popup bones available to ObservationCard after popup closes
Detail bones were cleared on popup close, so zone labels reverted to
raw ids (point-mpbynls5✕) once the head modal was dismissed. Now the
detailBones map accumulates across opens, and a merged allBones map
(main ∪ detail) is passed to ObservationList so describeZone resolves
the FR label every time.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 05:18:24 +02:00
Bastien ChanotandClaude b3bd75d2e2 feat(editor): VertebraPicker preselects region tab inferred from zone label
When opened from a spine zone, the picker now lands on the matching
region tab instead of defaulting to Cervicales every time. Inference is
substring-based on the FR label first, EN as fallback (cervic→C,
thorac/dors→T, lombair/lumbar→L, sacral/sacre→S, caudal/coccyg→Cd),
case- and accent-insensitive. An existing selection still wins over
the inferred region so re-opening lands where the user left off.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 05:09:57 +02:00
Bastien ChanotandClaude b9da4fa04a fix(anatomy,editor): detail-popup clicks + spine zones open VertebraPicker via data-anno-special
Three coupled bugs in zone interaction:
1. Clicks inside the head detail popup were ignored — EditorRoute
   looked up the clicked id in the main-SVG bones map only, so
   detail-only ids (point-mpbykomv et al.) returned undefined.
2. Spine zones did not open VertebraPicker on click; the picker was
   only reachable via the per-zone "Vertèbres…" button.
3. The new SVG hint data-anno-special="vertebral-precision" was
   present in Horse.svg but unread by the parser/UI.

Parser now reads data-anno-special into Bone.special. EditorRoute
parses the detail SVG on open and falls back to detailBones for id
lookups. When bone.special === 'vertebral-precision', clicking adds
the zone (if absent) and opens VertebraPicker for that zone index;
toggle-off via main click is disabled for these zones (use ✕). The
"Vertèbres…" button in ObservationCard is now shown only on zones
that support it. Convention doc updated.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-05-19 04:58:04 +02:00
Bastien ChanotandClaude Opus 4.7 21b678c3d5 refactor(anatomy): category becomes free-form string, no enum / no auto-trigger
User asked that the app interact with anything carrying data-anno-*
attributes without hardcoding any specific category, id, or name. Future
SVGs may introduce new categories, and the existing SVGs may be updated.

Changes:
- `BoneCategory` is now `type BoneCategory = string`. The closed union
  is gone; the parser accepts any non-empty value. New categories don't
  require code changes.
- `VALID_CATEGORIES` and `isValidCategory()` removed from
  svgConvention.ts. `validateBoneElement()` now only enforces presence
  of `data-anno-id` and `data-anno-category`.
- EditorRoute no longer auto-triggers the vertebra picker when the
  clicked annotation is `zone-colonne`. Any zone is added the same way
  to the active observation regardless of category.
- ObservationCard shows a "Vertèbres…" link on every zone badge (was
  conditional on `category === 'zone-colonne'`). The praticien picks
  vertebrae only when relevant — the UI no longer knows or cares which
  zones are spinal.
- Tests rewritten: removed the `isValidCategory` enum assertions and
  the "rejects unknown category" branch. New test demonstrates that
  parseSvgBones accepts a completely novel category string.

90/90 tests pass, lint clean, build clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-19 04:10:54 +02:00
Bastien ChanotandClaude Opus 4.7 cad94a49db refactor(anatomy): adapt parser to new SVG convention (categories + single-element)
User dropped new Horse.svg / Horse_head.svg that follow a simpler
convention:

- Categories renamed to longer human strings:
    articulation       → articulations
    charniere          → charni-res-vert-brales
    spine-zone         → zone-colonne
    cadran-crane       → cadrans-du-cr-ne
    head, os-overlay   → dropped (head zone is now category="os" + data-anno-opens-detail)
    os                 → unchanged
- No more hitbox / visible class split; multiple elements may still share
  the same data-anno-id but they all carry the same role.
- Trigger-only zones (`data-anno-opens-detail="head"`) may omit
  `data-anno-name-fr/en`.

Changes:
- `Bone` now exposes a single `els: Element[]` instead of `hitboxEls +
  visibleEls`.
- `parseSvgBones` accepts annotations without fr/en labels (defaults to
  empty string) but still rejects unknown or missing categories.
- The "interactive vs decorative" filter is gone — every parsed
  annotation is interactive, since the new SVGs only annotate the
  clickable zones.
- Vertebra-picker trigger: `bone.category === 'zone-colonne'`
  (EditorRoute + ObservationCard).
- PDF colorisation in `observationPage.colorizedSvgString` writes the
  accent fill to every `els[]` entry (no more hitbox dual-pass).
- Dead `src/components/observation/ObservationEditor.tsx` removed (its
  body lives inside ObservationCard since the accordion refactor).
- Tests rewritten for the new vocabulary; synthetic fixture uses the new
  categories, real-SVG test asserts 18 + 9 unique zones.

92/92 tests pass, lint clean, build clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-19 04:06:26 +02:00
Bastien ChanotandClaude Opus 4.7 1109e33383 refactor(anatomy): rename SVG data attrs (bone → anno) per new convention
User updated the clickable-zone convention in the source SVGs:

  data-bone-id        → data-anno-id
  data-bone-fr        → data-anno-name-fr
  data-bone-en        → data-anno-name-en
  data-category       → data-anno-category
  data-opens-detail   → data-anno-opens-detail

Bulk-renamed across:
- public/species/equine/Horse.svg + Horse_head.svg (86 anno-attrs each)
- src/anatomy/svgConvention.ts (parser + getBoneIdFromEvent)
- src/anatomy/types.ts (doc strings)
- src/components/canvas/AnatomyCanvas.tsx (querySelector + delegated click)
- src/styles/index.css (`[data-bone-id]` selectors → `[data-anno-id]`)
- src/domain/species/types.ts + schema/observation.ts (doc strings)
- docs/{ANATOMY-SVG-CONVENTION,ADDING-A-SPECIES,superpowers/specs,plans}.md
- CLAUDE.md + .claude/{memory/learnings,tasks/TODO}.md
- tests/unit/{anatomy.svgConvention,anatomy.svgLoader,components.AnatomyCanvas}.test.tsx

Internal TS type names and field names (Bone, boneId, parseSvgBones,
getBoneIdFromEvent) are kept intentionally — they're the application's
logical shape and the persisted JSON contract. ObservationZone.boneId is
the identifier seen in already-exported PDFs; renaming it would break
re-import of those PDFs. Only the SVG-side attribute names change.

90/90 tests pass, lint clean, build clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-19 03:10:06 +02:00
Bastien ChanotandClaude Opus 4.7 e8c29c1fdf fix(editor,pdf): accordion observation cards + seed 1 obs + native SVG rasterization
Three issues from manual QA:

1. UX restructure — observations are now an accordion list. Each card has
   a header that's always visible (title + chips + chevron + action
   buttons) and a body that expands inline showing zones / pathologies /
   severity / comment. Click the header (or the chevron) to toggle.
   ObservationEditor has been merged into ObservationCard so each card
   owns its own details. Only one observation is expanded at a time; the
   chevron on the active card collapses everything. EditorRoute uses
   activeObservationIndex === -1 to represent "all collapsed".

2. App used to start with 2 observations instead of 1. Root cause:
   EditorRoute had a "seed first observation" useEffect that fired twice
   under React 19 StrictMode in dev, both invocations seeing length=0 and
   queueing addObservation(). Fixed by moving the seed into the store's
   initReport (synchronous, one-shot) and removing the useEffect entirely.
   Store tests updated to assert the seed behaviour (90/90 pass).

3. PDF export still failed with "The input is not a PNG file!" — canvg
   was returning bytes that pdf-lib rejected at embedPng(). Switched
   rasterizeSvg to the browser-native pipeline: serialize the SVG into a
   Blob URL, load it with an Image element, drawImage onto a 2D canvas,
   then toBlob → PNG bytes (with a toDataURL fallback). Validates the
   PNG signature before returning. Tree-shaking dropped canvg from the
   bundle (979 kB → 874 kB JS).

Tests updated for the new initReport behaviour and the new svgToPng
pipeline (Image mock + dataURL fallback case). lint + typecheck + build
all clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 23:32:01 +02:00
Bastien ChanotandClaude Opus 4.7 bdf5e6475b fix(bugs): obs card click + next-RDV radio + PDF toBlob fallback + head svg interactivity
Five fixes from manual QA:

1. ObservationCard — clicking anywhere on the card now selects it.
   The wrapping button only covered the text rows; empty space was dead.
   The whole card is now role="button" with keyboard (Enter/Space) support;
   inner action buttons (↑ ↓ 🗑) stop propagation so they don't double-fire.
   This was also the root cause of "details look stuck" — the active
   observation simply wasn't being switched.

2. NextAppointmentPicker — when value === undefined the "Date" radio was
   still showing as checked because `kind` defaulted to 'date'. The three
   radios now read from the raw `value?.kind` (which can be undefined),
   so "Aucun" is the only checked option when no next RDV is set.

3. svgToPng.rasterizeSvg — `canvas.toBlob` can return null in some
   browsers when the canvas state is unusual; the call now falls back to
   `canvas.toDataURL('image/png')` and decodes the base64 payload. Also
   paints a white background before canvg renders (so the PDF embed is
   opaque) and clamps width/height to >= 1px to avoid zero-area canvases.
   canvg errors are caught + logged instead of propagating, so the export
   still produces a (possibly blank) page rather than throwing.

4. svgConvention.parseSvgBones — clickable bones are now distinguished
   from decorative ones. Interactive = has a hitbox element OR category
   is spine-zone OR head. Decorative bones (teeth, malar, mandible,
   nasal-bone, facial-crest, individual vertebrae paths…) get
   `pointer-events: none` applied to their elements and are excluded from
   the returned map. Result: in Horse_head.svg, frontal/temporal/parietal/
   sphenoid/occipital/atm/ssb/c0-c1/hyoid become clickable as intended,
   while teeth / malar / mandible no longer intercept the clicks.

5. (covered by #1) — the per-observation details panel always read the
   active observation; the bug was the click handler scope. Confirmed by
   switching observations: the editor section now updates immediately.

88 tests still pass, lint clean, build clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 22:48:13 +02:00
Bastien ChanotandClaude Opus 4.7 188e79e76d fix(review): address code-review yellows — onExport catch, vertebra picker fresh-read, draft validation
Three impactful fixes from the post-impl code review:

1. EditorRoute.onExport now catches PDF generation failures, logs to
   console, and alerts the praticien in French — previously errors were
   swallowed by try/finally with only `setExporting(false)`.
2. VertebraPicker onConfirm reads the active observation from the store
   at confirm time instead of closing over the render-scope `activeObs`.
   Prevents mutating a stale observation if the praticien switches active
   observation while the picker is open.
3. readPersistedDraft validates the parsed JSON with ReportSchema instead
   of a raw `as Report` cast. Corrupted drafts now return null cleanly
   rather than poisoning the store.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 22:16:12 +02:00
Bastien ChanotandClaude Opus 4.7 dabab59656 chore: drop dead svgToPngDataUrl stub (replaced by pdf/render/svgToPng.rasterizeSvg)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 22:06:26 +02:00
Bastien ChanotandClaude Opus 4.7 a33693580f fix(lint): escape JSX entities and narrow useEffect dep
Escape French apostrophes/quotes in JSX text per react/no-unescaped-entities
and replace the report?.observations.length dependency with a derived
observationsCount value so react-hooks/exhaustive-deps is satisfied without
re-firing on every report change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 22:00:15 +02:00
Bastien Chanot 97ab4f67d1 feat(pdf): importReportFromPdf with ImportError on non-osteo PDFs 2026-05-18 21:55:03 +02:00
Bastien Chanot cf57297d2d feat(pdf): exportReportToPdf orchestrator with finalized page numbering 2026-05-18 21:53:55 +02:00
Bastien Chanot fb9a8fc3bd feat(pdf): attach + extract report JSON via pdf-lib (with fallback traversal) 2026-05-18 21:53:26 +02:00
Bastien Chanot 1c0b507458 feat(pdf): addConclusionPage with wrapped conclusion + recommendations + next RDV 2026-05-18 21:46:23 +02:00
Bastien Chanot 384d2918d4 feat(pdf): addObservationPage with rasterized colorized SVG + summary 2026-05-18 21:45:58 +02:00
Bastien Chanot 6cbc6ce328 feat(pdf): drawFooter with brand from runtime config 2026-05-18 21:45:26 +02:00
Bastien Chanot 099ebf326b feat(pdf): drawHeader with practitioner + animal/owner/date 2026-05-18 21:45:05 +02:00
Bastien Chanot ba30e0dbaf feat(pdf): embed Helvetica + Times-Roman standard fonts (MVP) 2026-05-18 21:44:25 +02:00
Bastien Chanot 55d9c32076 feat(pdf): rasterize SVG via canvg → PNG bytes 2026-05-18 21:43:58 +02:00
Bastien Chanot a3a4d4e1f6 feat(app): NotFoundRoute 2026-05-18 21:38:55 +02:00
Bastien Chanot 337f8c3aea feat(editor): wire canvas + observation panel + conclusion + export 2026-05-18 21:38:38 +02:00
Bastien Chanot 2b2a7db63c feat(new): NewReportRoute wires forms + practitioner cache 2026-05-18 21:37:24 +02:00
Bastien Chanot 9271a79067 feat(home): HomeRoute with new + import PDF flows 2026-05-18 21:37:00 +02:00
Bastien Chanot c1483ff265 feat(report): ReportHeader with brand + animal/owner/date 2026-05-18 21:30:59 +02:00
Bastien Chanot 6b115a558e feat(report): ConclusionPanel + NextAppointmentPicker (date | period | none) 2026-05-18 21:30:43 +02:00
Bastien Chanot 71ecebfa72 feat(report): AnimalForm + owner name with species select 2026-05-18 21:30:08 +02:00
Bastien Chanot 2970e7fcf5 feat(report): PractitionerForm with required name + optional fields 2026-05-18 21:29:43 +02:00
Bastien Chanot 3ef1c60682 feat(observation): ObservationEditor wires zones + pathologies + severity + comment 2026-05-18 21:29:22 +02:00
Bastien Chanot 10fa676f1e feat(observation): ObservationList with add + per-card actions 2026-05-18 21:28:53 +02:00
Bastien Chanot 1e4e56d2e2 feat(observation): ObservationCard with reorder + delete affordances 2026-05-18 21:28:33 +02:00
Bastien Chanot c78fe004dd feat(observation): SeveritySelector radio chips 2026-05-18 21:28:06 +02:00
Bastien Chanot 241bb42c7d feat(observation): FreeTextPathologyInput with chip removal 2026-05-18 21:27:45 +02:00
Bastien Chanot 4c67c900b9 feat(observation): PathologyPicker filtered by species + zones 2026-05-18 21:27:11 +02:00
Bastien Chanot b3e1a87690 feat(observation): VertebraPicker dialog with region tabs + chip grid 2026-05-18 21:23:55 +02:00
Bastien Chanot 19baf0281f feat(canvas): DetailModal renders detail SVG in Dialog 2026-05-18 21:23:00 +02:00
Bastien Chanot bea3712851 feat(canvas): inline SVG load + delegated click + state classes 2026-05-18 21:22:39 +02:00
Bastien Chanot 90d398656c feat(brand): render brandName from runtime config 2026-05-18 21:19:20 +02:00
Bastien Chanot cc5f4d077a feat(styles): design tokens + svg-canvas state rules 2026-05-18 21:18:47 +02:00
Bastien Chanot afd58b386b feat(ui): Dialog with backdrop + escape + motion fade 2026-05-18 21:18:18 +02:00
Bastien Chanot a1453ec32e feat(ui): Chip toggle 2026-05-18 21:17:32 +02:00
Bastien Chanot 03332246d3 feat(ui): Badge with tones 2026-05-18 21:17:12 +02:00
Bastien Chanot b806bedc4f feat(ui): Select 2026-05-18 21:16:56 +02:00