fix(review): address code-review yellows — onExport catch, vertebra picker fresh-read, draft validation

Three impactful fixes from the post-impl code review:

1. EditorRoute.onExport now catches PDF generation failures, logs to
   console, and alerts the praticien in French — previously errors were
   swallowed by try/finally with only `setExporting(false)`.
2. VertebraPicker onConfirm reads the active observation from the store
   at confirm time instead of closing over the render-scope `activeObs`.
   Prevents mutating a stale observation if the praticien switches active
   observation while the picker is open.
3. readPersistedDraft validates the parsed JSON with ReportSchema instead
   of a raw `as Report` cast. Corrupted drafts now return null cleanly
   rather than poisoning the store.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bastien ChanotandClaude Opus 4.7 committed 2026-05-18 22:16:12 +02:00
1 parent dabab59656
commit 188e79e76d
2 files changed
+15 -4

No files matched your search

+12 -2
View File
@@ -122,6 +122,11 @@ export default function EditorRoute() {
a.download = `bilan-${report.animal.name}-${report.date}.pdf`
a.click()
URL.revokeObjectURL(url)
} catch (err) {
console.error('PDF export failed', err)
window.alert(
"Échec de la génération du PDF. Réessayez ou contactez le support.",
)
} finally {
setExporting(false)
}
@@ -195,9 +200,14 @@ export default function EditorRoute() {
open
onClose={() => setVertebraTarget(null)}
onConfirm={(vertebrae) => {
const next = [...activeObs.zones]
const fresh = useReportStore.getState().report?.observations[activeIndex]
if (!fresh?.zones[vertebraTarget]) {
setVertebraTarget(null)
return
}
const next = [...fresh.zones]
next[vertebraTarget] = { ...next[vertebraTarget], vertebrae }
updateObservation(activeIndex, { ...activeObs, zones: next })
updateObservation(activeIndex, { ...fresh, zones: next })
setVertebraTarget(null)
}}
initial={activeObs.zones[vertebraTarget].vertebrae ?? []}
+3 -2
View File
@@ -1,5 +1,5 @@
import { create } from 'zustand'
import type { Report } from '@/domain/schema/report'
import { ReportSchema, type Report } from '@/domain/schema/report'
import type { Observation } from '@/domain/schema/observation'
import { generateId } from '@/lib/id'
import { nowIso } from '@/lib/dates'
@@ -133,7 +133,8 @@ export function readPersistedDraft(): Report | null {
const raw = sessionStorage.getItem(DRAFT_KEY)
if (!raw) return null
try {
return JSON.parse(raw) as Report
const parsed = ReportSchema.safeParse(JSON.parse(raw))
return parsed.success ? parsed.data : null
} catch {
return null
}