docs(docs): R4 closed by owner validation 2026-11-17, BDR-121
This commit is contained in:
1 parent
b6408f177f
commit
c42c65509b
8 files changed
+98
-5
No files matched your search
@@ -732,20 +732,20 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- [ ] e2e fixture accumulation (owner 2026-11-12 §3): sheets created by the suites persist on the sandbox (admin.spec A1 `fiche-e2e-<tag>` never archived, seedDraft / seedOfficialSheet sheets, editor copies); track them (count per run, owner per fixture) and propose run-scoped cleanup limited to ids each run created
|
||||
- [x] (was) Anomaly B (owner 2026-11-12, decision C): `admin.spec.ts` « admin screens: axe and no sideways scroll » (4 failures: 2 locales × 2 viewports) depends on the historical sheet's free working-copy slot, taken on the sandbox by `sheets-admin.sandbox.ts:181-195` (copy `8c315a12-…`, never archived). Fix in its own commit with proof the 4 failures are gone; isolated reproducible fixture, no existing data deleted; stop and present options if impossible without a destructive op or a scope change
|
||||
- [x] R3 sheet list: search + name sort first; date, date sort and « most recent » home card only after the dedicated SQL checkpoint `docs/development/V1-2-6_R3_SQL_CHECKPOINT.md` (A7 ratified 2026-11-09; never a creation date shown as modification date). Two-step split superseded 2026-11-16 by owner D2: one lot after M9, tracked in the R3 block above
|
||||
- [ ] R4 catalogue card integrity warning (independent fix, = anomaly C): `useCardDetails.ts` drops a failed `loadVersion` silently; UI only, check never bypassed
|
||||
- [x] R4 catalogue card integrity warning (independent fix, = anomaly C): CLOSED 2026-11-17, owner validation after the manual trial on `pnpm db:sandbox trial` (§4.16, account `praticien@trial.local`, `catalog_reader` only); D4 archive kept, business rules on sheets with a published version unchanged; `Card.tsx` and `e2e/support/records.ts` accepted; BDR-121. `useCardDetails.ts` dropped a failed `loadVersion` silently; UI only, check never bypassed
|
||||
- [x] R4 plan rev 2 (owner brief 2026-11-16 « R3 est terminé … passer à R4 »): `.claude/tasks/plans/2026-11-16-r4-card-integrity-2337.md`, audit F1-F12, three challenges on rev 1 (correctness FATAL(4), robustness FATAL(4), simplicity FATAL(3)) folded in. STOP: owner decisions D1 caps class, D2 thumbnail failure, D3 trial place (sandbox recommended, trial stack has no published version), D4 e2e cleanup of published fixtures (archive own rows by SQL recommended). No implementation before them; DEV unchanged, no merge
|
||||
- [x] R4 plan rev 3 VALIDATED 2026-11-17 (owner « Je valide le plan R4 … »: D1 alternative, own caps line without retry; D2, D3, D4 as recommended; R-2 to R-7 accepted; P1 trial tells sandbox anomalies apart, P2 spec cleans only its own rows). Contract `.claude/tasks/contracts/2026-11-17-r4-card-integrity-0004.md` (7575c67). Branch feature/v1-2-anatomical-sheets, no merge, DEV unchanged, no write on db:trial
|
||||
- [x] Task 1 card failure line (board 30): f061111 Notice warning tone, `icon`, `live` + `wifi-off`; 6ad8d83 `cardFailure`, `useCardDetails` `{ state, retry }`, `CardFailure`, A10 key; `Card` `aria-busy` (outside file list, accepted). App 1771 tests in 138 files; typecheck, lint, build exit 0. Review approved (0 C, 0 I)
|
||||
- [x] Task 2 browser proof dadd8e5: `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky (twice: once with temporary screenshot lines, once as committed); `catalogue.spec.ts` alone 8 passed. Guard: 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants); 8 R4 sheets archived, 4 grants revoked by id, read back. Review approved (0 C, 0 I)
|
||||
- [x] Task 3 documents as built: U1_CORRECTIONS §R4 « As built 2026-11-17 » and §5 row C closed, OWNER_TRIAL §4.16 (db:sandbox trial), review Part II class C row (R-8), CHANGELOG, BROWSER_TESTS, design README deviation. Read-only sandbox census: 164 catalogue entries, 160 ok and main view composed, 4 `fingerprint_mismatch` = the four « Cheval sandbox » (anomaly A, stored `'a'.repeat(64)`), no other kind. No `shortcut:` in the R4 diff (`git diff b895ecf..HEAD`)
|
||||
- [x] Closing gates (controller): design review vs board 30 (CONFORME but one écart, fixed in the wave), final code review (0 C, 1 I, fixed), security PASS (1 LOW fixed), re-review of the wave (16/16 addressed), verifier ECARTS(5) → two tests added `83f2d8b`, contract oracle 9 and scope rulings `2c9d837`, gates.sh MET; `pnpm check:all` at `2c9d837` exit 0 (core-wasm 66, supabase 182, app 1780, e2e:ui 253; e2e:shell not run by check:all). Second fresh verifier at `8224eda`: ECARTS(2), criteria 1-16 all MET; the two écarts are the out-of-scope files `Card.tsx` (optional `aria-busy`) and `e2e/support/records.ts` (`capturedId`), judged justified and additive, owner micro-gate
|
||||
- [ ] STOP owner trial R4 on `pnpm db:sandbox trial` (OWNER_TRIAL §4.16) and owner ruling on the two out-of-scope files; no merge
|
||||
- [x] STOP owner trial R4 on `pnpm db:sandbox trial` (OWNER_TRIAL §4.16) and owner ruling on the two out-of-scope files; no merge. Done 2026-11-17: trial passed, R4 validated, archive (D4) and both files accepted. Final results kept: app 1780 tests in 138 files; check:all at `2c9d837` exit 0 (core-wasm 66, supabase 182, app 1780, e2e:ui 253; e2e:shell not in check:all); `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky ×4; `catalogue.spec.ts` alone 8 passed; guard 0 removed 0 changed 81 added
|
||||
- [x] Final fix wave (FX1-FX16, `.superpowers/sdd/2026-11-16-r4-card-integrity-2337/final-fix-list.md`): b378cf0 retry ending with no retry left keeps the polite region and moves focus to « Consulter », busy look on « Réessayer », engine stopped for good in the error tone, one attempt for two calls in one tick, rendered tests (engine stopped, two cards on the core, no blob URL after unmount); 2930f49 lines over 100 columns wrapped; 1e50585 board 30 deviation fixed (failure row `*:px-3`, both buttons on one row at 1280 and 375, e2e checks it); 3bea19f spec reads each own sheet's name by id before archiving, `seedGrant` account id through `capturedId`. App 1775 tests in 138 files; typecheck, lint, build exit 0. `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky (twice: once with temporary screenshot lines, once as committed); `catalogue.spec.ts` alone 8 passed. Guard: 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants), the runs' own; 8 R4 sheets archived, 4 grants revoked, read back. `pnpm check:all` then run at `2c9d837` (line above)
|
||||
- [ ] Follow-up: seed owner row in `private.catalog_write_budgets` is R4's own (none before R4; its first run created it, later runs update that same row, 4 archives per run; 8 of 300 per hour after the final wave, outside the data guard); `catalogue.spec.ts` still leaves its published sheets listed, warm-up its sheet and `sheet_editor` grant per invocation (BLK-015, RR-13)
|
||||
- [ ] owner arbitrations A1-A15 (`V1-2-6_U1_CORRECTIONS.md` §6, `TRIAL_STACK.md` §6)
|
||||
- [ ] Test anomaly A (owner 2026-11-09, separate from U1/U2): fictitious fingerprints `'a'.repeat(64)` from worker stand-ins (`packages/supabase/tests/sandbox/sheet-fixtures.ts:115` openRound, `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`); 7 published/deprecated sandbox versions fail `check_published`. Fix: real fingerprint through the core (as e2e `fingerprintOf`, `apps/app/e2e/support/catalogue.ts:88`); never weaken the publish gate or the reader check. Needs its own go. Census 2026-11-17 (R4 Task 3, read-only): 4 of 164 catalogue entries fail, the four current « Cheval sandbox » versions (2 at v1, 2 at v2), all `fingerprint_mismatch`; R4 cards show them with the integrity line.
|
||||
- [ ] Test anomaly B (owner 2026-11-09, separate from U1/U2): `packages/supabase/tests/sandbox/sheets-admin.sandbox.ts:181-195` creates the historical working copy and never archives it; slot taken → `admin.spec.ts:717` fails x4. Fix test independence and cleanup; the existing copy `8c315a12-20d4-4432-9db3-7cb88b27a5b4` stays untouched until the owner authorises. Linked: RR-13, the admin.spec confirmation line above.
|
||||
- [ ] Test anomaly C (owner 2026-11-09, separate from U1/U2): integrity failure invisible in catalogue cards; implemented as lot R4; failure shown, never hidden or bypassed. Built 2026-11-17 (R4 Task 1-3 and final fix wave, `V1-2-6_U1_CORRECTIONS.md` §5 row C: built by R4, closes on the owner's validation); checked off with R4's owner validation.
|
||||
- [x] Test anomaly C (owner 2026-11-09, separate from U1/U2): CLOSED 2026-11-17 with R4's owner validation. Integrity failure invisible in catalogue cards; implemented as lot R4; failure shown, never hidden or bypassed. Built 2026-11-17 (R4 Task 1-3 and final fix wave, `V1-2-6_U1_CORRECTIONS.md` §5 row C: built by R4, closes on the owner's validation); checked off with R4's owner validation.
|
||||
- [ ] Dedicated persistent manual trial stack (owner 2026-11-09, D8; brief « Après R0 — Implémentation technique », contract .claude/tasks/contracts/2026-11-09-db-trial-stack-1809.md): [x] lot A suites' guard · [x] lot A2 trial dev server target (R13) · [x] lot B1 foundation · [x] lot B2 backups, restore, migrate, rotation · [x] lot B3 accounts, grants, drawings, app · [x] lot C docs · [x] reviews (verifier ECARTS owner-gated only, security PASS, code review + 2 re-reviews fixed: d3bdbbe, f2cbf68) · [x] first create 2026-11-11 at 255dd67 (owner go) · [x] post-create checks: interrupted at check 3 (TR_PW in the db container log), owner decided 2026-11-11 (rotation + fix, sub-item below) · [x] accounts 2026-11-11 (owner brief « Checkpoint sécurité et autorisation des comptes »): owner@trial.local owner+admin, praticien@trial.local admin+sheet_editor, 1 verified TOTP each (BDR-112), roles/rights/audit/aal2 refusals/secrets/persistence checked · [x] equine drawing 2026-11-11 (owner brief « Autorisation de l'import équin »): `pnpm db:trial assets`, 1/1 uploaded and confirmed, object re-downloaded through the gateway byte-identical, second read-only pass nothing to do, draft = document.json, seed = HEAD · [x] owner U1 manual test 2026-11-12 (brief « Retour du test manuel U1 »): equine working copy, four tabs, annotation select and edit, saves kept after reload, undo/redo, historical sheet unchanged; one defect → R1 D6b · [ ] owner Droits screen at aal2 not reported
|
||||
- app exposure (owner 2026-11-11, BDR-111): `pnpm db:trial app` listens on 192.168.1.100:5194 only (not 0.0.0.0; Host allowlist answers 403 to other names; 127.0.0.1:5194 closed). The accounts brief authorised 127.0.0.1:5194; the owner moved it to the LAN address the same day. No wider LAN exposure (other port, 0.0.0.0, firewall change) without a distinct decision.
|
||||
- shortcut: `pnpm db:trial app` takes no lock (scripts/db-trial.sh, comment above cmd_app): stop, backup, migrate, destroy, restore or rotate-* started in another terminal in the second before Vite listens on 5194 goes ahead. Upgrade: a dedicated app lock, shared by app and exclusive for those commands.
|
||||
|
||||
Reference in new issue
Block a user