From c42c65509bad87f397a44d1ed336262b42c1e262 Mon Sep 17 00:00:00 2001 From: bchanot Date: Tue, 17 Nov 2026 12:29:09 +0100 Subject: [PATCH] docs(docs): R4 closed by owner validation 2026-11-17, BDR-121 --- .claude/memory/decisions.md | 7 +++ .claude/memory/journal.md | 1 + .claude/memory/learnings.md | 12 ++++ .claude/tasks/TODO.md | 6 +- .../2026-11-17-r4-card-integrity-0004.md | 62 +++++++++++++++++++ CHANGELOG.md | 2 +- docs/development/V1-2-6_OWNER_TRIAL.md | 4 ++ docs/development/V1-2-6_U1_CORRECTIONS.md | 9 ++- 8 files changed, 98 insertions(+), 5 deletions(-) diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index 1cc853b4..5fd9918c 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -989,3 +989,10 @@ Alternatives: write-now + delete on abandon (two undo steps, rejected); fold exi **Rationale:** owner trial passed; desktop layout unchanged; no JS viewport detection; closed panel height 0 asserted at 375 px. **Alternatives:** reset button outside panel (rejected by owner); `inert` on panel (would disable desktop grid); motion lib (CSS enough). **Open, separate:** BLK-015, RR-13 (admin lists paging, server search), pgTAP 014/021 on accumulated sandbox, D5 keep list state on back. No merge, no deploy, DEV unchanged. + +## BDR-121 — R4 catalogue card integrity closed by owner, test sheets archived (2026-11-17) (2026-11-17) +- **Status**: accepted +**Decision:** R4 closed 2026-11-17 by owner after manual trial on `pnpm db:sandbox trial` (§4.16, account praticien@trial.local, catalog_reader only). Catalogue card says its own failure: integrity class (fingerprint, drawing hash, drawing missing, invalid document) → A10 line error tone, no retry; caps → own existing text, no retry (D1 alternative); other kinds → existing text warning tone + per-card « Réessayer »; view not drawable → neutral line (D2). « Consulter » always kept, check never bypassed, sheet page unchanged. Owner rulings at closure: e2e test sheets archived (not deleted) via `private.set_sheet_status` by captured id + name read-back; rules on sheets with published version unchanged (`delete_anatomical_sheet` still refuses); out-of-scope `Card.tsx` (`aria-busy`) and `e2e/support/records.ts` (`capturedId`) accepted. +**Rationale:** owner trial pass; soft delete of a published-history sheet = state no screen reaches, archive reachable + inside owner's authorisation. +**Alternatives:** soft delete (rejected, breaks §6.9); one engine retry for all cards (R-7, per-card kept); live region per card (burst at load, rejected). +**Open, separate:** BLK-015, RR-13, anomaly A (4 « Cheval sandbox » fingerprint_mismatch). No merge, no deploy, DEV unchanged. diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index e56ca7c9..fbe708dd 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -575,3 +575,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp ## 2026-11-17 - R4 built 2026-11-17 (f061111..8224eda): card integrity line A10, caps own line (D1), view line (D2), retry/focus R-3; spec on sandbox 6p, cleanup archive own ids; check:all exit 0 at 2c9d837 (app 1780); verifier 16/16 MET, 2 out-of-scope files to owner. STOP owner trial §4.16 on db:sandbox trial. +- R4 CLOSED 2026-11-17: owner manual trial db:sandbox §4.16 pass, archive (D4) + Card.tsx/records.ts accepted, BDR-121. check:all 2c9d837 exit 0, spec 6/0/0/0 x4. BLK-015, RR-13, anomaly A open. Next U2 design (boards 02-06, 13), no code. diff --git a/.claude/memory/learnings.md b/.claude/memory/learnings.md index 7c981b6d..12493cc1 100644 --- a/.claude/memory/learnings.md +++ b/.claude/memory/learnings.md @@ -977,3 +977,15 @@ Apply: a guard asks only layers the move actually removes; before showing a ques ## LRN-142 — Transactional dialog owns side-effect creations and explicit commit (2026-11-15) Context: R2 closure, owner db:trial trials 2026-11-14/15 drove Rev 4-6. Pattern: in dialog that edits draft, side-effect creations (new reference) belong to draft, written with save as one batch (one undo); abandon = no write. Select browses only, explicit action button commits choice; save refuses pending uncommitted choice with message + focus. Reason: arrow keys on native select fire change, silent draft edits. Apply: any future transactional dialog (U2 annotation properties dialog). + +## LRN-143 — E2E cleanup on persistent stack: archive own rows by captured id + name read-back (2026-11-17) +Context: R4 e2e on persistent sandbox seeded published sheets; app never deletes sheet with published history (`delete_anatomical_sheet` refuses + needs aal2). Pattern: clean only own rows: capture ids at seed, UUID-guard every id before SQL text (`capturedId`), read name back by id and compare exact seeded name (mismatch → archive nothing, fail run), archive via app's status RPC, revoke own grant by id, read back; data guard before/after (0 removed, 0 changed). Never match by pattern. +Apply: e2e fixtures on shared persistent stack → reachable end state (archive) over delete; identity check by id + name before any write; guard diff proves no pre-existing row touched. + +## LRN-144 — Per-card retry in lists: no live line, polite region on retry, focus rule (2026-11-17) +Pattern: list of N cards each with own failure + retry. No live region on card lines (burst of N announcements at load). Retry: line + button stay mounted, button aria-disabled (not disabled, keeps focus), card aria-busy, clicks ignored by ref guard (two calls same tick = one attempt). Polite sr-only region empty at load, cleared at each attempt, says new line on repeat failure; stays mounted once a retry ran. When attempt settles without « Réessayer », move focus to card's « Consulter » only if focus was on removed button or body. +Apply: any per-item retry in lists/grids; test focus on body vs elsewhere, repeat failure, failure with no retry left. + +## LRN-145 — Single-request failure e2e via route.fallback + remount; 0fr grid row keeps child padding (2026-11-17) +Pattern: (1) Playwright: fail one request (one version) with route.abort for its URL and route.fallback() for the rest; remount the component (search filter out/in) instead of page reload so failure state is reached without reload side effects; DevTools offline + search is the manual equivalent. (2) CSS collapse grid-rows 0fr→1fr: padding/border on the 0fr row's direct child stays visible (R3 phone panel kept 12 px); put padding on an inner wrapper inside the min-h-0 overflow-hidden child, assert closed height 0. +Apply: single-request failure e2e; any CSS-only collapsible panel. diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index d2dc1f41..4e051153 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -732,20 +732,20 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [ ] e2e fixture accumulation (owner 2026-11-12 §3): sheets created by the suites persist on the sandbox (admin.spec A1 `fiche-e2e-` never archived, seedDraft / seedOfficialSheet sheets, editor copies); track them (count per run, owner per fixture) and propose run-scoped cleanup limited to ids each run created - [x] (was) Anomaly B (owner 2026-11-12, decision C): `admin.spec.ts` « admin screens: axe and no sideways scroll » (4 failures: 2 locales × 2 viewports) depends on the historical sheet's free working-copy slot, taken on the sandbox by `sheets-admin.sandbox.ts:181-195` (copy `8c315a12-…`, never archived). Fix in its own commit with proof the 4 failures are gone; isolated reproducible fixture, no existing data deleted; stop and present options if impossible without a destructive op or a scope change - [x] R3 sheet list: search + name sort first; date, date sort and « most recent » home card only after the dedicated SQL checkpoint `docs/development/V1-2-6_R3_SQL_CHECKPOINT.md` (A7 ratified 2026-11-09; never a creation date shown as modification date). Two-step split superseded 2026-11-16 by owner D2: one lot after M9, tracked in the R3 block above - - [ ] R4 catalogue card integrity warning (independent fix, = anomaly C): `useCardDetails.ts` drops a failed `loadVersion` silently; UI only, check never bypassed + - [x] R4 catalogue card integrity warning (independent fix, = anomaly C): CLOSED 2026-11-17, owner validation after the manual trial on `pnpm db:sandbox trial` (§4.16, account `praticien@trial.local`, `catalog_reader` only); D4 archive kept, business rules on sheets with a published version unchanged; `Card.tsx` and `e2e/support/records.ts` accepted; BDR-121. `useCardDetails.ts` dropped a failed `loadVersion` silently; UI only, check never bypassed - [x] R4 plan rev 2 (owner brief 2026-11-16 « R3 est terminé … passer à R4 »): `.claude/tasks/plans/2026-11-16-r4-card-integrity-2337.md`, audit F1-F12, three challenges on rev 1 (correctness FATAL(4), robustness FATAL(4), simplicity FATAL(3)) folded in. STOP: owner decisions D1 caps class, D2 thumbnail failure, D3 trial place (sandbox recommended, trial stack has no published version), D4 e2e cleanup of published fixtures (archive own rows by SQL recommended). No implementation before them; DEV unchanged, no merge - [x] R4 plan rev 3 VALIDATED 2026-11-17 (owner « Je valide le plan R4 … »: D1 alternative, own caps line without retry; D2, D3, D4 as recommended; R-2 to R-7 accepted; P1 trial tells sandbox anomalies apart, P2 spec cleans only its own rows). Contract `.claude/tasks/contracts/2026-11-17-r4-card-integrity-0004.md` (7575c67). Branch feature/v1-2-anatomical-sheets, no merge, DEV unchanged, no write on db:trial - [x] Task 1 card failure line (board 30): f061111 Notice warning tone, `icon`, `live` + `wifi-off`; 6ad8d83 `cardFailure`, `useCardDetails` `{ state, retry }`, `CardFailure`, A10 key; `Card` `aria-busy` (outside file list, accepted). App 1771 tests in 138 files; typecheck, lint, build exit 0. Review approved (0 C, 0 I) - [x] Task 2 browser proof dadd8e5: `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky (twice: once with temporary screenshot lines, once as committed); `catalogue.spec.ts` alone 8 passed. Guard: 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants); 8 R4 sheets archived, 4 grants revoked by id, read back. Review approved (0 C, 0 I) - [x] Task 3 documents as built: U1_CORRECTIONS §R4 « As built 2026-11-17 » and §5 row C closed, OWNER_TRIAL §4.16 (db:sandbox trial), review Part II class C row (R-8), CHANGELOG, BROWSER_TESTS, design README deviation. Read-only sandbox census: 164 catalogue entries, 160 ok and main view composed, 4 `fingerprint_mismatch` = the four « Cheval sandbox » (anomaly A, stored `'a'.repeat(64)`), no other kind. No `shortcut:` in the R4 diff (`git diff b895ecf..HEAD`) - [x] Closing gates (controller): design review vs board 30 (CONFORME but one écart, fixed in the wave), final code review (0 C, 1 I, fixed), security PASS (1 LOW fixed), re-review of the wave (16/16 addressed), verifier ECARTS(5) → two tests added `83f2d8b`, contract oracle 9 and scope rulings `2c9d837`, gates.sh MET; `pnpm check:all` at `2c9d837` exit 0 (core-wasm 66, supabase 182, app 1780, e2e:ui 253; e2e:shell not run by check:all). Second fresh verifier at `8224eda`: ECARTS(2), criteria 1-16 all MET; the two écarts are the out-of-scope files `Card.tsx` (optional `aria-busy`) and `e2e/support/records.ts` (`capturedId`), judged justified and additive, owner micro-gate - - [ ] STOP owner trial R4 on `pnpm db:sandbox trial` (OWNER_TRIAL §4.16) and owner ruling on the two out-of-scope files; no merge + - [x] STOP owner trial R4 on `pnpm db:sandbox trial` (OWNER_TRIAL §4.16) and owner ruling on the two out-of-scope files; no merge. Done 2026-11-17: trial passed, R4 validated, archive (D4) and both files accepted. Final results kept: app 1780 tests in 138 files; check:all at `2c9d837` exit 0 (core-wasm 66, supabase 182, app 1780, e2e:ui 253; e2e:shell not in check:all); `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky ×4; `catalogue.spec.ts` alone 8 passed; guard 0 removed 0 changed 81 added - [x] Final fix wave (FX1-FX16, `.superpowers/sdd/2026-11-16-r4-card-integrity-2337/final-fix-list.md`): b378cf0 retry ending with no retry left keeps the polite region and moves focus to « Consulter », busy look on « Réessayer », engine stopped for good in the error tone, one attempt for two calls in one tick, rendered tests (engine stopped, two cards on the core, no blob URL after unmount); 2930f49 lines over 100 columns wrapped; 1e50585 board 30 deviation fixed (failure row `*:px-3`, both buttons on one row at 1280 and 375, e2e checks it); 3bea19f spec reads each own sheet's name by id before archiving, `seedGrant` account id through `capturedId`. App 1775 tests in 138 files; typecheck, lint, build exit 0. `catalogue-integrity.spec.ts` alone 6 passed 0 failed 0 skipped 0 flaky (twice: once with temporary screenshot lines, once as committed); `catalogue.spec.ts` alone 8 passed. Guard: 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants), the runs' own; 8 R4 sheets archived, 4 grants revoked, read back. `pnpm check:all` then run at `2c9d837` (line above) - [ ] Follow-up: seed owner row in `private.catalog_write_budgets` is R4's own (none before R4; its first run created it, later runs update that same row, 4 archives per run; 8 of 300 per hour after the final wave, outside the data guard); `catalogue.spec.ts` still leaves its published sheets listed, warm-up its sheet and `sheet_editor` grant per invocation (BLK-015, RR-13) - [ ] owner arbitrations A1-A15 (`V1-2-6_U1_CORRECTIONS.md` §6, `TRIAL_STACK.md` §6) - [ ] Test anomaly A (owner 2026-11-09, separate from U1/U2): fictitious fingerprints `'a'.repeat(64)` from worker stand-ins (`packages/supabase/tests/sandbox/sheet-fixtures.ts:115` openRound, `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`); 7 published/deprecated sandbox versions fail `check_published`. Fix: real fingerprint through the core (as e2e `fingerprintOf`, `apps/app/e2e/support/catalogue.ts:88`); never weaken the publish gate or the reader check. Needs its own go. Census 2026-11-17 (R4 Task 3, read-only): 4 of 164 catalogue entries fail, the four current « Cheval sandbox » versions (2 at v1, 2 at v2), all `fingerprint_mismatch`; R4 cards show them with the integrity line. - [ ] Test anomaly B (owner 2026-11-09, separate from U1/U2): `packages/supabase/tests/sandbox/sheets-admin.sandbox.ts:181-195` creates the historical working copy and never archives it; slot taken → `admin.spec.ts:717` fails x4. Fix test independence and cleanup; the existing copy `8c315a12-20d4-4432-9db3-7cb88b27a5b4` stays untouched until the owner authorises. Linked: RR-13, the admin.spec confirmation line above. - - [ ] Test anomaly C (owner 2026-11-09, separate from U1/U2): integrity failure invisible in catalogue cards; implemented as lot R4; failure shown, never hidden or bypassed. Built 2026-11-17 (R4 Task 1-3 and final fix wave, `V1-2-6_U1_CORRECTIONS.md` §5 row C: built by R4, closes on the owner's validation); checked off with R4's owner validation. + - [x] Test anomaly C (owner 2026-11-09, separate from U1/U2): CLOSED 2026-11-17 with R4's owner validation. Integrity failure invisible in catalogue cards; implemented as lot R4; failure shown, never hidden or bypassed. Built 2026-11-17 (R4 Task 1-3 and final fix wave, `V1-2-6_U1_CORRECTIONS.md` §5 row C: built by R4, closes on the owner's validation); checked off with R4's owner validation. - [ ] Dedicated persistent manual trial stack (owner 2026-11-09, D8; brief « Après R0 — Implémentation technique », contract .claude/tasks/contracts/2026-11-09-db-trial-stack-1809.md): [x] lot A suites' guard · [x] lot A2 trial dev server target (R13) · [x] lot B1 foundation · [x] lot B2 backups, restore, migrate, rotation · [x] lot B3 accounts, grants, drawings, app · [x] lot C docs · [x] reviews (verifier ECARTS owner-gated only, security PASS, code review + 2 re-reviews fixed: d3bdbbe, f2cbf68) · [x] first create 2026-11-11 at 255dd67 (owner go) · [x] post-create checks: interrupted at check 3 (TR_PW in the db container log), owner decided 2026-11-11 (rotation + fix, sub-item below) · [x] accounts 2026-11-11 (owner brief « Checkpoint sécurité et autorisation des comptes »): owner@trial.local owner+admin, praticien@trial.local admin+sheet_editor, 1 verified TOTP each (BDR-112), roles/rights/audit/aal2 refusals/secrets/persistence checked · [x] equine drawing 2026-11-11 (owner brief « Autorisation de l'import équin »): `pnpm db:trial assets`, 1/1 uploaded and confirmed, object re-downloaded through the gateway byte-identical, second read-only pass nothing to do, draft = document.json, seed = HEAD · [x] owner U1 manual test 2026-11-12 (brief « Retour du test manuel U1 »): equine working copy, four tabs, annotation select and edit, saves kept after reload, undo/redo, historical sheet unchanged; one defect → R1 D6b · [ ] owner Droits screen at aal2 not reported - app exposure (owner 2026-11-11, BDR-111): `pnpm db:trial app` listens on 192.168.1.100:5194 only (not 0.0.0.0; Host allowlist answers 403 to other names; 127.0.0.1:5194 closed). The accounts brief authorised 127.0.0.1:5194; the owner moved it to the LAN address the same day. No wider LAN exposure (other port, 0.0.0.0, firewall change) without a distinct decision. - shortcut: `pnpm db:trial app` takes no lock (scripts/db-trial.sh, comment above cmd_app): stop, backup, migrate, destroy, restore or rotate-* started in another terminal in the second before Vite listens on 5194 goes ahead. Upgrade: a dedicated app lock, shared by app and exclusive for those commands. diff --git a/.claude/tasks/contracts/2026-11-17-r4-card-integrity-0004.md b/.claude/tasks/contracts/2026-11-17-r4-card-integrity-0004.md index 0c18f1e8..70b0c4d5 100644 --- a/.claude/tasks/contracts/2026-11-17-r4-card-integrity-0004.md +++ b/.claude/tasks/contracts/2026-11-17-r4-card-integrity-0004.md @@ -87,6 +87,62 @@ Conserve BLK-015, RR-13 et l'anomalie A dans leurs chantiers respectifs. Aucune fusion ni intervention sur DEV. +### Owner validation 2026-11-17 (R4 closed, U2 design start) + +Je confirme avoir terminé mes tests manuels de R4 sur la sandbox. + +Tous les tests fonctionnent correctement et le résultat me convient. + +Je valide officiellement R4. + +Je confirme également les deux décisions restantes : + +1. Nettoyage des fiches de test : +Je valide leur archivage plutôt que leur suppression. + +Les règles métier concernant les fiches ayant eu une version publiée doivent rester inchangées. + +2. Fichiers supplémentaires : +J'accepte les modifications de Card.tsx et de l'utilitaire de validation des identifiants SQL. + +Tu peux maintenant procéder à la clôture documentaire de R4 : +- Enregistrer ma validation propriétaire. +- Mettre à jour les contrats, le TODO et le suivi. +- Enregistrer les décisions et apprentissages pertinents. +- Conserver les résultats exacts des tests. +- Committer et pousser les modifications documentaires. + +BLK-015, RR-13 et l'anomalie A restent des chantiers séparés. + +R4 est terminé. + +Nous pouvons maintenant préparer U2 : la refonte de la manipulation graphique des annotations. + +Je souhaite commencer par la conception graphique, conformément à notre méthode habituelle. + +Reprends les maquettes validées et les nouvelles décisions UX concernant les modales de propriétés des annotations. + +Les objectifs restent : +- Création d'un point directement sur le schéma. +- Création d'une zone en traçant son polygone. +- Déplacement des sommets avec la souris ou le doigt. +- Ajout d'un sommet avec « + » sur un segment. +- Suppression d'un sommet avec « − ». +- Déplacement et redessin d'une zone. +- Modification de la taille d'un point. +- Consultation et modification des propriétés dans une modale. +- Ouverture de la modale de création après le placement du point ou la fin du tracé. + +Les interactions graphiques doivent rester possibles sans que les modales gênent les gestes. + +Prépare les nouvelles maquettes U2, notamment les planches 02 à 06 et 13, ainsi que les éventuels écrans supplémentaires nécessaires. + +Je te laisse autonome pour auditer l'existant, proposer les meilleures interactions et organiser les relectures. + +Présente-moi les maquettes pour validation visuelle avant toute implémentation de U2. + +Aucune fusion ni intervention sur DEV. + ## CLARIFICATIONS - Graphic reference: board 30 `docs/design/v1-2-6-r0/30-catalogue-carte-integrite.png` (approved as is, 2026-11-09). Wording: A10 (`docs/design/v1-2-6-r0/ARBITRAGES.md`), REVUE.md:85. - Criterion 9: the CHECK greps each dictionary's own quote convention (double quotes in fr.ts for a text holding an apostrophe, single quotes in en.ts); the text is what binds. @@ -126,3 +182,9 @@ apps/app/src/{catalogue/failure.ts,catalogue/useCardDetails.ts,components/catalo ## Verification 2026-11-17 (fresh verifiers) - Pass 1 at `04b723c`: ECARTS(5): criteria 3 and 5 lacked a test (glyph per kind; focus rule on `body` / elsewhere), criterion 15 pending (check:all not yet run), two files outside FILE SCOPE. Fixed: tests `83f2d8b`; criterion 9 oracle and scope rulings `2c9d837`; `pnpm check:all` at `2c9d837` exit 0. - Pass 2 at `8224eda`: ECARTS(2). Criteria 1 to 16 all MET. The two écarts are `apps/app/src/components/ui/Card.tsx` (optional `aria-busy`, +4 lines, default undefined at the 33 other call sites) and `apps/app/e2e/support/records.ts` (`capturedId`, +8 lines, beside `literal`), judged justified and additive by the verifier; they wait for the owner's ruling. + +## Owner validation 2026-11-17 (R4 closed) +- The owner ran the manual trial on `pnpm db:sandbox trial` (OWNER_TRIAL §4.16) with a sandbox account created for it (`trial-account`, `catalog_reader` only) and validated R4 officially: every step works, the result suits them. +- D4 ruled by the owner: the spec's own test sheets are archived, not deleted. The business rules on sheets that had a published version stay unchanged (`delete_anatomical_sheet` still refuses them; nothing in R4 touched them). +- The two files outside FILE SCOPE are accepted by the owner: `apps/app/src/components/ui/Card.tsx` (optional `aria-busy`) and `apps/app/e2e/support/records.ts` (`capturedId`). The verifier's ECARTS(2) is closed by that ruling; criteria 1 to 16 MET. +- Final state `b6408f1` plus this record. Exact results as kept in `V1-2-6_U1_CORRECTIONS.md` §R4: app unit suite 1780 tests in 138 files; `pnpm check:all` at `2c9d837` exit 0 (core-wasm 66, supabase 182, app 1780, e2e:ui 253; e2e:shell not run by check:all); `catalogue-integrity.spec.ts` alone 6 passed, 0 failed, 0 skipped, 0 flaky at each of its four runs; `catalogue.spec.ts` alone 8 passed; data guard 0 removed, 0 changed, 81 added (the runs' own rows). BLK-015, RR-13 and anomaly A stay open in their own tracking. No merge, no deploy, DEV unchanged, no write on the trial stack. diff --git a/CHANGELOG.md b/CHANGELOG.md index 7074bcc5..5a89a0c8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ not merged into `develop`. `release/0.2.0` (Steps on that branch and reaches this file only if the release is finished (TODO RR-9). -### Changed (2026-11-17, V1-2.6 R4 on `feature/v1-2-anatomical-sheets`: not merged into `develop`, sandbox only) +### Changed (2026-11-17, V1-2.6 R4 on `feature/v1-2-anatomical-sheets`: validated by the owner 2026-11-17, not merged into `develop`, sandbox only) - A catalogue card whose version fails no longer stays silent. A version the core's integrity check refuses (fingerprint, drawing hash, missing drawing, unreadable document) shows « Contrôle d'intégrité échoué : cette version ne peut pas être affichée. » in the card (EN « Integrity check failed: this version cannot be displayed. »), with no « Réessayer »; a version over the size limits shows « Cette version dépasse les limites de taille d'une fiche. », also without retry. A load that failed for another reason (network, session, access, rate, server, engine) shows its own line and « Réessayer » for that card only, with a « no network » glyph for the network. A version that passes but whose main view cannot be drawn keeps its counts and says so in a neutral line. The card keeps its name, « Publiée », its version and « Consulter » in every case. The check itself, the sheet page and its notice are unchanged. The lines are not live regions; a retry that fails again is said once by a polite region (also when it ends on a failure with no retry, which moves the focus to « Consulter »), and a successful one moves the focus to « Consulter ». During an attempt « Réessayer » is greyed with a wait cursor; once the engine stopped for good the card's engine line has no retry and the error tone. « Réessayer » and « Consulter » sit side by side as on the board, desktop included. Board 30, wording A10. - New browser spec `e2e/shell/catalogue-integrity.spec.ts` on the sandbox: at `dadd8e5`, 6 passed, 0 failed, 0 skipped, 0 flaky, twice (once with temporary screenshot lines, once as committed); after the final fix wave, the same twice again (once with temporary screenshot lines, once as committed at `3bea19f`), and `catalogue.spec.ts` alone 8 passed. It archives its own sheets, each only after its name read by id matches the name it seeded, and revokes its own grant by id at the end. App unit suite 1780 passed (138 files); `pnpm typecheck`, `pnpm lint`, `pnpm build` exit 0. `pnpm check:all` at `2c9d837`: exit 0 (e2e:ui 253 passed; e2e:shell not run by check:all). The four « Cheval sandbox » entries of the sandbox now show the integrity line: their stored fingerprint is the fictitious value of test anomaly A, still open. Details: `docs/development/V1-2-6_U1_CORRECTIONS.md` §R4. diff --git a/docs/development/V1-2-6_OWNER_TRIAL.md b/docs/development/V1-2-6_OWNER_TRIAL.md index 5effa1e4..5d21a29d 100644 --- a/docs/development/V1-2-6_OWNER_TRIAL.md +++ b/docs/development/V1-2-6_OWNER_TRIAL.md @@ -676,6 +676,10 @@ Limites connues de R4 : - Les fiches « R4 … » créées par le test automatique sont archivées à la fin de chaque passage : elles ne sont plus au catalogue, mais restent dans la liste d'administration sous « Archivée ». +Résultat du 17 novembre 2026 : essai fait par le propriétaire sur la sandbox (`pnpm db:sandbox trial`), avec un +compte créé pour l'occasion et le seul droit `catalog_reader`. Toutes les étapes fonctionnent. R4 est validé. +L'archivage des fiches de test est confirmé, et les règles sur les fiches ayant eu une version publiée ne changent pas. + ## 5. Limites à connaître - Risque résiduel RR-12 : les opérations du catalogue lisent la mention `aal2` du jeton, pas la session vivante. Un jeton émis à `aal2` reste accepté après la suppression du facteur, jusqu'à son expiration (une heure). diff --git a/docs/development/V1-2-6_U1_CORRECTIONS.md b/docs/development/V1-2-6_U1_CORRECTIONS.md index 785a26f7..b2310c2d 100644 --- a/docs/development/V1-2-6_U1_CORRECTIONS.md +++ b/docs/development/V1-2-6_U1_CORRECTIONS.md @@ -904,6 +904,13 @@ Limits (accepted, recorded): - The cleanup's name check (D4 identity) is proved by the archives that passed (each row's name matched); the refusal path (a different name archives nothing) is not exercised by a test. +Owner validation 2026-11-17: R4 validated officially after the owner's manual trial on `pnpm db:sandbox trial` +(OWNER_TRIAL §4.16); every step works and the result suits the owner. R4 is closed. The owner confirmed the two +points left open: the spec's test sheets are archived, not deleted (D4 ruling above), and the business rules on +sheets that had a published version stay unchanged; `Card.tsx` (optional `aria-busy`) and `e2e/support/records.ts` +(`capturedId`) are accepted outside the plan's file list. The results above are the final ones. BLK-015, RR-13 and +anomaly A stay open in their own tracking. + ## 4. Order and dependencies R0 first (validation). R1 is independent of R2 and can ship first. R2 depends on the validated boards 23 to 27. R3 @@ -918,7 +925,7 @@ depend on the working-copy slot. |---|---|---| | A. Fictitious fingerprints | Worker stand-ins publish with `'a'.repeat(64)`: `packages/supabase/tests/sandbox/sheet-fixtures.ts:115` (`openRound`), `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`. Seven published or deprecated versions on the sandbox fail `check_published`; the owner opened three of them on 2026-11-09. | Compute the real fingerprint through the core as the catalogue e2e does (`fingerprintOf`), never weaken the publish gate or the reader's check. | | B. Working copy never archived | (a) `packages/supabase/tests/sandbox/sheets-admin.sandbox.ts` created the historical sheet's working copy (`8c315a12-…`, 2026-11-08 21:00:30) and never archived it; the single slot then disables « Créer une copie de travail » (`WorkingCopyAction.tsx:88`). (b) Even on a fresh stack `editor-equine.spec.ts` flips the slot while `admin.spec.ts:717` runs in parallel. Only the historical sheet offers the action, so the test depended on shared state. | FIXED (owner, 2026-11-12, option 1): the dialog's axe, layout and keyboard checks run on the real component in `e2e/ui/working-copy.spec.ts`; `admin.spec.ts` keeps the historical page and checks the button state against its reason; the sandbox suite archives only the copies it created (`returning id` checked) and each cleanup step runs independently. Limit: the dialog is no longer checked in its real server context by this accessibility test. Open: the creation branch of the cleanup is not yet run on a fresh stack. `editor-equine.spec.ts` still archives and restores pre-existing copies on every run. | -| C. Silent card failure | Section 3, R4. | Show the failure, never hide or route around it. Built by R4 (2026-11-17, §R4 « As built »), closes on the owner's validation: the card says its failure inside itself, « Consulter » kept, the check unchanged. The four sandbox entries it shows failing are anomaly A, still open. | +| C. Silent card failure | Section 3, R4. | Show the failure, never hide or route around it. Built by R4 (2026-11-17, §R4 « As built »), CLOSED 2026-11-17 by the owner's validation: the card says its failure inside itself, « Consulter » kept, the check unchanged. The four sandbox entries it shows failing are anomaly A, still open. | ## 6. Arbitrations