docs(app): R3 gate results, fix wave run, deploy order, trial steps
- CHANGELOG: the six shell failures split into the four Target crashed of BLK-015 and the two A0 lookup timeouts (counted as BLK-015, not A/B proven); pgTAP 014 / 021 not proven by a run without M9; the intro names the R3 entry's branch - owner trial 4.15: steps strictly in order (step 5 shows what two sheets prove, the move back to the top is step 9's last action), how to open the working copy, the trimmed text, no Claude sentence, the re-save sentence removed - deploy order (database first, then the application) and its fail-closed consequence in the SQL checkpoint and SUPABASE.md - design review, code review and security gate results, the fix wave run, the owner decisions left open; verifier, check:all and the owner trial still pending - TODO: fix wave line, three follow-ups
This commit is contained in:
1 parent
ea5512af02
commit
bcdacbbb9a
8 files changed
+125
-34
No files matched your search
@@ -640,10 +640,12 @@ deploy, DEV unchanged.
|
||||
reset), then the trial stack through `pnpm db:trial migrate` on the owner's go (cold backup
|
||||
`20261116T144154Z-pre-migrate` first), then the application code. Figures: `V1-2-6_R3_SQL_CHECKPOINT.md` §6.
|
||||
- Client (`packages/supabase/src/sheets.ts`): the summary requires `last_modified_at` as an ISO 8601 timestamp with
|
||||
offset; an answer without it, or with a value that is no timestamp, is the closed `unavailable` failure, never a
|
||||
list with a missing or invented date (P3).
|
||||
offset that a `Date` can read; an answer without it, with a value that is no timestamp, or with one the shape
|
||||
accepts but a `Date` cannot read (`+99:99`, final fix wave), is the closed `unavailable` failure, never a list with
|
||||
a missing or invented date (P3).
|
||||
- List page `/app/admin/sheets` (`AdminSheetsRoute.tsx`, boards 28 and 29 A): search on the name in French or English
|
||||
(`matchesSheetName`, shared with the catalogue: accents and case ignored, surrounding spaces trimmed), instant, 100
|
||||
(`sheetNameMatcher`, the catalogue's rule folded once per search, beside its `matchesSheetName`: accents and case
|
||||
ignored, surrounding spaces trimmed), instant, 100
|
||||
characters at most, no magnifier; « Effacer la recherche » shown only while the field holds text; Escape empties a
|
||||
non-empty field and does nothing on an empty one; every way of clearing returns the focus to the field. « Trier
|
||||
par »: « Dernière modification » (default, newest first) or « Nom » (the collation of the interface language: French
|
||||
@@ -685,16 +687,59 @@ Results recorded task by task up to the last code commit `b4a5254` (exact; nothi
|
||||
| `pnpm build` | passed at `423125c` and `de2424f` (the two screen commits) |
|
||||
| `pnpm test:run` | core-wasm 66, supabase 181, app 1743 (at `de2424f` and `b4a5254`) |
|
||||
| `pnpm db:sandbox test sheets-admin` (the client against the migrated sandbox's answers) | 5 of 5 |
|
||||
| `pnpm db:sandbox test-db` (pgTAP on the real image, accumulated sandbox, after M9) | Files=21, Tests=1958, Result FAIL. `022_sheet_admin_reads` ok, `023` ok. `014_animals_relations`: 2 of 258 failed (tests 6 « exactly the nine species… » and 7 « every species row is active »). `021_sheet_verification_jobs`: 23 failed, « Bad plan. You planned 90 tests but ran 42 », an error `draft.frozen` at :205. Read as dependent on the accumulated sandbox state (the suites need a fresh stack); M9 touches neither file's functions. NOT proven: no run of these files without M9, and no fresh stack (`up fresh` needs an owner go) |
|
||||
| `pnpm db:sandbox test-db` (pgTAP on the real image, accumulated sandbox, after M9) | Files=21, Tests=1958, Result FAIL. `022_sheet_admin_reads` ok, `023` ok. `014_animals_relations`: 2 of 258 failed (tests 6 « exactly the nine species of the contract and other, equine unchanged » and 7 « every species row is active »). `021_sheet_verification_jobs`: 23 failed, « Bad plan. You planned 90 tests but ran 42 », an error `draft.frozen` at :205. Read as dependent on the accumulated sandbox state (the suites need a fresh stack); M9 touches neither file's functions. NOT proven: no run of these files without M9, and no fresh stack (`up fresh` needs an owner go) |
|
||||
| `pnpm db:sandbox types --check` | no drift |
|
||||
| `e2e/shell/admin-sheets-list.spec.ts` alone on the sandbox | 4 passed, 0 failed |
|
||||
| Shell sweep, 27 spec files without `editor-equine.spec.ts` | 446 tests: 277 passed, 6 failed, 163 skipped, 0 flaky. All six failures in `admin.spec.ts`, on the rights screen: « admin screens » (:714) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed`; A0 (:220) ×2, fr and en at desktop, the grant lookup stuck on « Recherche… » until the « E-mail confirmé » check timed out (:144), about 7 600 grant rows rendered. Counted as BLK-015, the A0 pair with another symptom than « Target crashed ». NOT proven: no A/B run against the commit before R3. Green as required: A1 and « access per right » (the rewritten locators, both languages), `editor-journey`, the new spec |
|
||||
| Shell sweep, 27 spec files without `editor-equine.spec.ts` | 446 tests: 277 passed, 6 failed, 163 skipped, 0 flaky. All six failures in `admin.spec.ts`: « admin screens » (:714) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed` during axe at `admin.spec.ts:747`, inside that test's loop over the admin pages (the page is not recorded in this run; BLK-015's own description in `BROWSER_TESTS.md` names the rights screen as the proven cause in earlier runs); A0 (:220) ×2, on the rights screen, fr and en at desktop, the grant lookup stuck on « Recherche… » until the « E-mail confirmé » check timed out (:144), about 7 600 grant rows rendered. Counted as BLK-015, the A0 pair with another symptom than « Target crashed ». NOT proven: no A/B run against the commit before R3. Green as required: A1 and « access per right » (the rewritten locators, both languages), `editor-journey`, the new spec |
|
||||
| Data guard (every pre-existing row of `anatomical_sheets` and `anatomical_sheet_versions`, per id) | 0 changed, 0 missing on every run; the 12 sheets the R3 spec created in its two runs read back `deleted` (D7) |
|
||||
|
||||
Closing gates (verifier on the contract, security review of the whole diff, fresh design review of the two screens
|
||||
at 1 280 and 375 px, fresh code review of the range) and `pnpm check:all`: pending at the time of writing
|
||||
(2026-11-16). Not checked by the build: a browser sign-in on the trial stack (the owner's accounts, the owner's
|
||||
trial, `V1-2-6_OWNER_TRIAL.md` §4.15).
|
||||
Closing gates on the range `98178de..73ed375` (2026-11-16):
|
||||
|
||||
- Design review (fresh, the two screens at 1 280 and 375 px on the sandbox, one Playwright run, 2 passed, data guard
|
||||
0 changed, 0 missing): board 28 CONFORME (the two recorded deviations only); board 29 A ÉCARTS (2 small); board 29 B
|
||||
ÉCARTS. Findings 1 to 4 are fixed in the final fix wave: 1, the home at 1 280 px stacked « Espèces » and « Accès et
|
||||
habilitations » in the right column at their own height (`8bb2486`); 2, the card's sheet name links 44 px tall at
|
||||
375 px (`8bb2486`); 3, « Effacer la recherche » of the no-result block 44 px tall at 375 px (`1758276`); 4, the
|
||||
card item on the list row's rhythm (`8bb2486`). Left to the owner: finding 5 (below), the breadcrumb and the info
|
||||
icon. Finding 6 (typography: an opening guillemet can end a line, « version / 1 » orphan in the detail line) is not
|
||||
in the wave. Not checked by the design review: the badges and the working copy action on the card, the owner's
|
||||
layout (deduced from the code), the English wording, the 0 or 1 sheet link, distinct dates, hover, screen reader
|
||||
output.
|
||||
- Final code review (fresh, opus): 0 Critical, 0 Important, 9 Minor, « Ready for the owner's trial: Yes ». Fixed in
|
||||
the wave: 1 (each keystroke recomputed the whole list: the term folded once, the dates read once before the sort,
|
||||
the rows memoised; no `useDeferredValue`), 2, 3 and 6 (`useListView` split, className constants, the
|
||||
`SheetSummary` alias and the `ResultsProps` order, `1758276`), 4, 5 and 7 (the spec's `timezoneId`, the ordering
|
||||
loop's count, the escaped pattern, Escape pressed in Chromium, `ea5512a`). Already done by the Task 8 documents: 9
|
||||
(the `shortcut:` harvest). Left: 8 (the card checked for the true date: a flake risk on a shared sandbox).
|
||||
- Security gate (fresh): PASS. semgrep `p/security-audit`, `p/secrets`, `p/owasp-top-ten`: 0 findings. Four
|
||||
non-blocking findings: [MEDIUM] SQL built by template interpolation in the new spec, fixed (`literal()` and a uuid
|
||||
shape check, `ea5512a`); [MEDIUM] guardrails API-PASSWORD-LITERAL at `scripts/db-sandbox.sh:485`, a pre-existing line
|
||||
and a false positive, left; [LOW] the date checked by its shape only (`+99:99` passed and a `Date` read NaN), fixed
|
||||
(`374e300`); [LOW] a RegExp built from unescaped dictionary text in the spec, fixed (`ea5512a`). Outside the diff:
|
||||
the guardrails scanner reports 2 FAIL at `scripts/db-trial-check.sh:1340`, a file R3 never touched, not analysed
|
||||
(TODO).
|
||||
- Final fix wave (2026-11-16, `374e300`, `1758276`, `8bb2486`, `ea5512a`): unit gates core-wasm 66, supabase 182,
|
||||
app 1743; `pnpm build` passed. One Playwright run of `admin-sheets-list.spec.ts`, `admin.spec.ts` and
|
||||
`editor-journey.spec.ts`: 15 passed, 6 failed, 9 skipped. The new spec 4 passed; A1 and « access per right » green
|
||||
in both languages; `editor-journey` green. The six failures, all `admin.spec.ts`, all on the accumulated sandbox:
|
||||
« admin screens » (:714) fr desktop, en desktop and fr 375 px, `frame.evaluate: Target crashed` during axe at
|
||||
`:747`; « admin screens » en 375 px, `page.evaluate: Test timeout of 180000ms exceeded` during axe at `:747`, the
|
||||
screenshot on the rights screen; A0 (:220) fr, the « E-mail confirmé » check at `:144` after the lookup; A0 en, the
|
||||
« Right granted. » check at `:158`, the button stuck on « Granting… ». Counted as BLK-015, not proven by an A/B run
|
||||
against the commit before R3: the wave changed no file of the rights screen. Data guard: 0 changed, 0 missing, 20
|
||||
new lines (10 sheets with their 10 versions); the 6 sheets the R3 spec created read back `deleted`.
|
||||
- Still pending at the time of writing (2026-11-16): the verifier on the contract and `pnpm check:all` (run by the
|
||||
controller after the fix wave), and the owner's trial on the trial stack (`V1-2-6_OWNER_TRIAL.md` §4.15). Not
|
||||
checked by the build: a browser sign-in on the trial stack (the owner's accounts).
|
||||
|
||||
Owner decisions left open (R3):
|
||||
|
||||
1. The info icon of the no-result block: board 28 draws one, the page shows none (no glyph in `Icon`).
|
||||
2. At 375 px « Nouvelle fiche » sits beside the title, where board 29 A draws it under (header older than R3).
|
||||
3. The top-bar breadcrumb « Administration › Fiches officielles » the boards draw (shell level, older than R3).
|
||||
4. With a filter and a search both active and no result, the page shows the filters sentence without « Effacer la
|
||||
recherche » (board 28's note, followed literally).
|
||||
5. In that same case, the double announcement: the count line and the `role="status"` sentence.
|
||||
|
||||
### R4 — Integrity warning in catalogue cards (D9 C, independent fix)
|
||||
|
||||
|
||||
Reference in new issue
Block a user