docs(app): R3 sheet list documents as built, M9 applied

V1-2-6_U1_CORRECTIONS §R3 as built (A7 split superseded by D2, exact
results, deviations), the SQL checkpoint applied with corrections F2 to
F4, the owner's answers and the date limits F7, M9 in §12.3, db:sandbox
migrate, the sheet list spec and its named failures, class C rows, the
design deviations, CLAUDE.md and CHANGELOG. Gates pending.
This commit is contained in:
bchanot committed 2026-11-16 17:47:49 +01:00
1 parent 73ed37546f
commit a86020d6e3
9 files changed
+235 -12

No files matched your search

+80 -2
View File
@@ -613,12 +613,89 @@ Status: R2 closed. Next lots: R3, then R4 (below); U2 waits for its own planning
regenerated types, and its application to a stack, which needs the owner's go for that operation. Ratified (A7):
the dedicated checkpoint is `V1-2-6_R3_SQL_CHECKPOINT.md`; R3 ships in two steps, search and name sort with no date
first, the date, the date sort and the « most recent » card only once the SQL change is authorised and applied.
Superseded 2026-11-16 by the owner's decision D2 (below): one delivery in the final state, the « before » state
never built.
- Search and sort run in the browser on the full list: `shortcut:` until RR-13 pages the list on the server, where
search and sort move with it.
- Tests: unit for search (accents, both languages, empty, clear), sort (date ties by name, collation), date format
FR/EN, the home card (at most five, sorted); e2e admin list search and sort at desktop and 375 px with axe; the four
filters unchanged.
#### As built 2026-11-16
Owner brief « R3 » (2026-11-16), plan `.claude/tasks/plans/2026-11-16-r3-sheet-list-0017.md` rev 2b validated the
same day: D1 to D4, D6 and D7 yes, D5 no, the « recorded unless the owner objects » choices accepted, precisions P1 to
P4 binding. Then the owner's go for `pnpm db:trial migrate`. Contract:
`.claude/tasks/contracts/2026-11-16-r3-sheet-list-1720.md`. Branch `feature/v1-2-anatomical-sheets`, no merge, no
deploy, DEV unchanged.
- Delivery (D2): one lot in the final state. The two-step split of A7 is superseded: no « before » state (search and
name sort without a date) was built or shown.
- SQL: M9 `supabase/migrations/20261116100000_sheet_admin_last_modified.sql` adds `last_modified_at` to
`private.official_sheet_admin_summary`, the newest of the sheet row's `updated_at` and of its versions'
`updated_at` (`V1-2-6_R3_SQL_CHECKPOINT.md`). Reviewed (task review, security review) before its first
application, frozen since (blob `a33b1770`). pgTAP `supabase/tests/022_sheet_admin_reads.sql`, plan 74: a saved
draft, a saved working copy, a sheet without a version, a sheet row newer than its versions (P1).
- Stacks (D3): the sandbox through the new `pnpm db:sandbox migrate` (additions only to `scripts/db-sandbox.sh`, no
reset), then the trial stack through `pnpm db:trial migrate` on the owner's go (cold backup
`20261116T144154Z-pre-migrate` first), then the application code. Figures: `V1-2-6_R3_SQL_CHECKPOINT.md` §6.
- Client (`packages/supabase/src/sheets.ts`): the summary requires `last_modified_at` as an ISO 8601 timestamp with
offset; an answer without it, or with a value that is no timestamp, is the closed `unavailable` failure, never a
list with a missing or invented date (P3).
- List page `/app/admin/sheets` (`AdminSheetsRoute.tsx`, boards 28 and 29 A): search on the name in French or English
(`matchesSheetName`, shared with the catalogue: accents and case ignored, surrounding spaces trimmed), instant, 100
characters at most, no magnifier; « Effacer la recherche » shown only while the field holds text; Escape empties a
non-empty field and does nothing on an empty one; every way of clearing returns the focus to the field. « Trier
par »: « Dernière modification » (default, newest first) or « Nom » (the collation of the interface language: French
names in the French interface, English names in the English one). Equal dates, then equal names, fall back to the
name, then the id, so the order never depends on the server's. The four filters unchanged, combined with the
search. A count line (`aria-live="polite"`): « {n} fiches », or « {n} fiches sur {total} » when something is
hidden. Each row is one link: name, the existing badges, the detail line (species, sheet status, published
version or none, draft version, latest round), and « Modifiée le 9 nov. 2026, 12:06 » in Paris time, inside a
`<time>` whose value is the same instant (`toISOString()`). No new badge: published and draft are told apart by
the detail line.
- Empty states (board 28 note, literally): no official sheet at all, « Aucune fiche officielle pour le moment. »;
nothing shown while a filter is active, the existing « Aucune fiche ne correspond à ces filtres. »; nothing shown
for a search without a filter, a plain block « Aucune fiche ne contient « {q} » dans son nom. » with the button
« Effacer la recherche ». The searched text is the trimmed text, inserted as typed (a `$&` stays `$&`), wrapping
anywhere.
- Administration home card (`AdminHomeRoute.tsx`, board 29 B): under « Brouillons, revues, versions. » the
sub-heading « Dernières modifications », then at most five sheets in the list's « Dernière modification » order,
each with its name link, badges, detail line and date. The historical sheet keeps its « Créer une copie de
travail » action on the card only when it is among the five, for an editor; otherwise the action is on its own
page (F9, A9). Footer link: « Voir les {n} fiches » from two sheets, « Toutes les fiches officielles » for zero or
one (D6). A failed species read leaves the species id in the detail line and never hides the card; a rights
refusal of the sheet list still hides it.
- Labels exactly as `docs/design/v1-2-6-r0/REVUE.md:82-84` in French and English; date format A8.
- Deviations from boards 28 and 29, stated in `docs/design/README.md`: no magnifier in the search field (F14, a
choice the owner validated with the plan); no info icon in the no-result block although board 28 draws one (a
ruling during the build, to be confirmed by the owner: `Icon` has no such glyph and the plan allows no new icon).
- Search, sort and the date format stay TypeScript, display only: rows in `RUST_ARCHITECTURE_REVIEW.md` Part II
(class C). The `shortcut:` of `apps/app/src/admin/sheetList.ts` (search and sort in the browser on the whole list,
until RR-13 pages it, D4) and the one of the search field in `AdminSheetsRoute.tsx` (same markup as the Références
tab's search, to fold into one component) are in `.claude/tasks/TODO.md`.
- Not in R3: the search, sort and filters kept when coming back from a sheet (D5, a later navigation improvement,
BDR-079 follow-up); R4 (board 30).
Results recorded task by task up to the last code commit `b4a5254` (exact; nothing below that failed is green):
| Check | Result |
|---|---|
| `pnpm typecheck`, `pnpm lint` | passed at each task's gate |
| `pnpm build` | passed at `423125c` and `de2424f` (the two screen commits) |
| `pnpm test:run` | core-wasm 66, supabase 181, app 1743 (at `de2424f` and `b4a5254`) |
| `pnpm db:sandbox test sheets-admin` (the client against the migrated sandbox's answers) | 5 of 5 |
| `pnpm db:sandbox test-db` (pgTAP on the real image, accumulated sandbox, after M9) | Files=21, Tests=1958, Result FAIL. `022_sheet_admin_reads` ok, `023` ok. `014_animals_relations`: 2 of 258 failed (tests 6 « exactly the nine species… » and 7 « every species row is active »). `021_sheet_verification_jobs`: 23 failed, « Bad plan. You planned 90 tests but ran 42 », an error `draft.frozen` at :205. Read as dependent on the accumulated sandbox state (the suites need a fresh stack); M9 touches neither file's functions. NOT proven: no run of these files without M9, and no fresh stack (`up fresh` needs an owner go) |
| `pnpm db:sandbox types --check` | no drift |
| `e2e/shell/admin-sheets-list.spec.ts` alone on the sandbox | 4 passed, 0 failed |
| Shell sweep, 27 spec files without `editor-equine.spec.ts` | 446 tests: 277 passed, 6 failed, 163 skipped, 0 flaky. All six failures in `admin.spec.ts`, on the rights screen: « admin screens » (:714) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed`; A0 (:220) ×2, fr and en at desktop, the grant lookup stuck on « Recherche… » until the « E-mail confirmé » check timed out (:144), about 7 600 grant rows rendered. Counted as BLK-015, the A0 pair with another symptom than « Target crashed ». NOT proven: no A/B run against the commit before R3. Green as required: A1 and « access per right » (the rewritten locators, both languages), `editor-journey`, the new spec |
| Data guard (every pre-existing row of `anatomical_sheets` and `anatomical_sheet_versions`, per id) | 0 changed, 0 missing on every run; the 12 sheets the R3 spec created in its two runs read back `deleted` (D7) |
Closing gates (verifier on the contract, security review of the whole diff, fresh design review of the two screens
at 1 280 and 375 px, fresh code review of the range) and `pnpm check:all`: pending at the time of writing
(2026-11-16). Not checked by the build: a browser sign-in on the trial stack (the owner's accounts, the owner's
trial, `V1-2-6_OWNER_TRIAL.md` §4.15).
### R4 — Integrity warning in catalogue cards (D9 C, independent fix)
- The card already runs the integrity check: `useCardDetails` calls `loadVersion` and drops a failed load in
@@ -633,7 +710,8 @@ Status: R2 closed. Next lots: R3, then R4 (below); U2 waits for its own planning
## 4. Order and dependencies
R0 first (validation). R1 is independent of R2 and can ship first. R2 depends on the validated boards 23 to 27. R3
ships search and name sort first; its date part waits for the SQL checkpoint (A7 ratified).
ships search and name sort first; its date part waits for the SQL checkpoint (A7 ratified). Superseded 2026-11-16
(D2): R3 shipped in one lot, after M9 was applied to the sandbox and the trial stack.
R4 is independent and may run any time after its board (30) is validated. Anomaly B (section 5) is fixed: the admin specs no longer
depend on the working-copy slot.
@@ -660,7 +738,7 @@ The owner-facing table with consequences, in French: `docs/design/v1-2-6-r0/ARBI
| A5 | Escape priority | Dialog, then open menu, then contextual panel, then tracing in progress, then selection. | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
| A5b | « Toutes les annotations » already clears the selection | Keep both (D6). | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
| A6 | Focus after « Désélectionner » | The annotation's row in the list. | RATIFIED with precision: the row if it still exists, else the drawing; focus never selects again; an accessible announcement |
| A7 | Source of the last-modification date | SQL read change `last_modified_at`, own checkpoint. | RATIFIED: dedicated SQL checkpoint `V1-2-6_R3_SQL_CHECKPOINT.md`; until then no creation date shown as a modification date and no misleading sort |
| A7 | Source of the last-modification date | SQL read change `last_modified_at`, own checkpoint. | RATIFIED: dedicated SQL checkpoint `V1-2-6_R3_SQL_CHECKPOINT.md`; until then no creation date shown as a modification date and no misleading sort. 2026-11-16: M9 applied (sandbox, trial stack), the two-step delivery superseded by D2 (§R3 « As built ») |
| A8 | Date format | Absolute, « 9 nov. 2026, 12:06 » (EN « 9 Nov 2026, 12:06 »). | RATIFIED 2026-11-09 (BDR-109), exact recommendation; shown only after the SQL checkpoint |
| A9 | Administration home card | The five most recently modified sheets with species, status and date, then « Voir les N fiches ». | RATIFIED 2026-11-09 (BDR-109), exact recommendation; final state after the SQL checkpoint |
| A10 | Catalogue warning wording | FR « Contrôle d'intégrité échoué : cette version ne peut pas être affichée. », a distinct line with « Réessayer » for a load that failed for another reason. | R4 ACCEPTED; wording RATIFIED 2026-11-09 (BDR-109), exact recommendation |