docs(app): R3 sheet list documents as built, M9 applied
V1-2-6_U1_CORRECTIONS §R3 as built (A7 split superseded by D2, exact results, deviations), the SQL checkpoint applied with corrections F2 to F4, the owner's answers and the date limits F7, M9 in §12.3, db:sandbox migrate, the sheet list spec and its named failures, class C rows, the design deviations, CLAUDE.md and CHANGELOG. Gates pending.
This commit is contained in:
1 parent
73ed37546f
commit
a86020d6e3
9 files changed
+235
-12
No files matched your search
@@ -13,6 +13,13 @@ Steps 0 to 8 and the Rust migration R0 to R5 included. `release/0.2.0` (Steps
|
||||
on that branch and reaches this file only if the release is finished (TODO
|
||||
RR-9).
|
||||
|
||||
### Added (2026-11-16, V1-2.6 R3 on `feature/v1-2-anatomical-sheets`: not merged into `develop`, sandbox and trial stack only)
|
||||
|
||||
- The official sheet list (`/app/admin/sheets`) gets a search on the sheet name in French or English (accents and case ignored, instant, with « Effacer la recherche » and Escape), a « Trier par » with « Dernière modification » (default) or « Nom », a count line « {n} fiches » / « {n} fiches sur {total} », and « Modifiée le 9 nov. 2026, 12:06 » on each row, in Paris time. The four filters are unchanged and combine with the search; a search without result names the searched text with a clear button. The Administration home card lists the five most recently modified sheets under « Dernières modifications », with « Voir les {n} fiches ».
|
||||
- Migration M9 `20261116100000_sheet_admin_last_modified.sql`: the admin sheet summary answers `last_modified_at`, the newest of the sheet's and its versions' `updated_at`, so a draft save dates its sheet. Read change only; the typed client refuses an answer without a valid `last_modified_at` (`unavailable`). Applied to the sandbox and the trial stack, not to DEV.
|
||||
- `pnpm db:sandbox migrate`: the branch's pending migrations on the running sandbox, forward only, no reset.
|
||||
- Known open results, not green: pgTAP on the accumulated sandbox (`014_animals_relations` 2 of 258 failed, `021_sheet_verification_jobs` 23 failed with « Bad plan. You planned 90 tests but ran 42 »), and the shell sweep (277 passed, 6 failed, 163 skipped; the six in `admin.spec.ts` on the rights screen, BLK-015). Details: `docs/development/V1-2-6_U1_CORRECTIONS.md` §R3.
|
||||
|
||||
### Fixed (2026-10-27, V1-1 DEV acceptance, RESP-01)
|
||||
|
||||
- The dashboard no longer scrolls sideways on a phone when the account e-mail is long: the card grid has one explicit column below the `md` breakpoint, so the cards keep the screen's width, and the e-mail wraps instead of being cut (a long one was truncated on desktop and pushed the cards past a 320 to 430 px screen from about 31 characters). `e2e/shell/responsive.spec.ts` checks nine shell pages, the archive confirmations and the drawer at 320 to 430 px and on desktop, in French and English.
|
||||
|
||||
@@ -214,7 +214,7 @@ faunosteo/
|
||||
│ │ └─ providers/{ConfigProvider,AuthProvider}.tsx ← AppConfig context; session + locale sync start
|
||||
│ ├─ auth/{validation,redirects,useAuthFailureMessage}.ts ← Zod schemas (i18n keys), safe next path, failure phrasing
|
||||
│ ├─ auth/{navigationHint,stepUp,useStepUp,useMfaFailureMessage}.ts ← V1-2.5: nav entries from own grants + roles (a hint, never a gate), verified factors for a step-up, in-action step-up on aal2_required, MFA failure phrasing
|
||||
│ ├─ admin/{filters,labels,permissions,useAdminQuery,validation}.ts ← V1-2.5 admin screens: sheet list filters, status labels, capability checks for display, page-local query, form schemas
|
||||
│ ├─ admin/{filters,labels,permissions,sheetList,useAdminQuery,validation}.ts ← V1-2.5 admin screens: sheet list filters, status labels, sheet list search and sort (R3), capability checks for display, page-local query, form schemas
|
||||
│ ├─ editor/references/{filter,citations,citationEdits,panel,sort,view,referenceTypes,safeLink}.ts ← V1-2.6 R2 Références tab: display-only search, citer lists, `citationEdits` (the references dialog's draft as adds and removes over the current list), panel entries, the four sorts, shown set, type order, safe links (TypeScript by owner exception BDR-114 (A), `RUST_ARCHITECTURE_REVIEW.md` II.3)
|
||||
│ ├─ editor/history/{entry,useEditorHistory}.ts + editor/{findingLayer,useReferenceMoves}.ts ← R2 finish: the editor view in the browser history (entries carry the sheet id and a random session tag, navigation only; pure planning of push / replace / back, write budget; the reconcile hook), the finding layer and the reference moves
|
||||
│ ├─ catalogue/{catalogue,failure,framing,preview,useCardDetails,useCatalogue,useEmptyTap,useFraming,useSheetVersion,versionText}.ts ← V1-2.5 catalogue: reads, closed failure kinds, canvas zoom and pan, PreviewSheet load path (hash, fingerprint, caps checked by the core); useEmptyTap (R1, D6b): a press on the drawing outside any annotation, told from drags and multi-pointer gestures
|
||||
@@ -254,7 +254,7 @@ faunosteo/
|
||||
│ │ ├─ clients/{ClientForm,ClientAnimals,ArchiveClientDialog,ClientNotFound}.tsx
|
||||
│ │ ├─ animals/{AnimalForm,ArchiveAnimalDialog,AnimalNotFound}.tsx
|
||||
│ │ ├─ relations/{AnimalRelations,RelationPanel,RelationActionDialog,RelationDialogs,RecordPicker,Pickers}.tsx ← in-page link panel, end / dates / void confirmations
|
||||
│ │ ├─ admin/{ActivateSpeciesDialog,GrantList,GrantPanel,RevokeGrantDialog,SheetBadges,SpeciesDialog,WorkingCopyAction}.tsx ← V1-2.5 rights, species and sheet pieces
|
||||
│ │ ├─ admin/{ActivateSpeciesDialog,GrantList,GrantPanel,ModifiedDate,RevokeGrantDialog,SheetBadges,SpeciesDialog,WorkingCopyAction}.tsx ← V1-2.5 rights, species and sheet pieces
|
||||
│ │ ├─ editor/references/{ReferenceTiles,ReferenceTile,ReferenceFacts,ReferenceToolbar,NoResult,CitersList,CitationsPanel,CitationsDialog,CitationsEditForm,CitationsDraftList,ReferenceDialog,ReferenceForm}.tsx + use{ReferenceView,ReferenceLibrary,TileState,CitationsPanel}.ts ← V1-2.6 R2 and finish: read-only tiles, toolbar with the finding filter chip, the references dialog stacked over a finding (view and edit modes), the reference dialog and its form, their view and tile state hooks
|
||||
│ │ ├─ editor/findings/{FindingDialog,FindingView,FindingEditForm,FindingCreateForm,FindingActions,FindingCitations,DiscardConfirm,ReadOnlyNotice,useDirtyGuard}.tsx ← R2 finish: the finding dialog (view and transactional edit modes, creation), discard confirmation, dirty guard; `findings/useItemMode.ts`: the dialogs' local view / edit mode, focus back to « Modifier » or on the draft's first control
|
||||
│ │ ├─ editor/useMoreMenu.ts ← R2 finish: « Plus » overlay state, dismiss (Escape, outside press) and the CloseWatcher back request
|
||||
@@ -273,7 +273,7 @@ faunosteo/
|
||||
├─ tests/
|
||||
│ ├─ setup.ts
|
||||
│ └─ unit/*.test.ts
|
||||
├─ e2e/ ← Playwright (V1-1.3): playwright.{ui,shell}.config.ts, support/{browser,sandbox,shell,records,admin,catalogue}.ts, ui/*.spec.ts, shell/*.spec.ts (V1-2.5: admin, catalogue; V1-2.6 R2: editor-references, editor-citations), harness/{dialog,working-copy}.{html,tsx} (dev server only, never built)
|
||||
├─ e2e/ ← Playwright (V1-1.3): playwright.{ui,shell}.config.ts, support/{browser,sandbox,shell,records,admin,catalogue}.ts, ui/*.spec.ts, shell/*.spec.ts (V1-2.5: admin, catalogue; V1-2.6 R2: editor-references, editor-citations; R3: admin-sheets-list), harness/{dialog,working-copy}.{html,tsx} (dev server only, never built)
|
||||
├─ docker/
|
||||
│ ├─ entrypoint.sh ← injects env.js at container start
|
||||
│ └─ nginx.conf ← SPA fallback + PORT envsubst
|
||||
@@ -296,7 +296,7 @@ faunosteo/
|
||||
│ └─ tests/{client,anatomical-sheets}.test.ts, tests/db/ ← PGlite harness, shim, pgTAP runner, schema↔types test
|
||||
├─ supabase/
|
||||
│ ├─ config.toml, seed.sql ← CLI config (public schema only), local dev accounts
|
||||
│ ├─ migrations/*.sql ← forward-only; foundation, profiles, platform_roles, anatomical_sheets, storage, sheet_document_schema_v2, profiles_professional, files_foundation (assets, buckets, avatar policies, purge queue, RPCs), workspaces (V1-1.1: personal workspace per account, access helpers), clients (V1-1.2: client RPCs and search, write budget per workspace), animals_relations (V1-1.4: species rows, animals, relations with history and voiding, their RPCs and reads), sheet_access_hardening + sheet_review_workflow (V1-2.1 M4, M5), sheet_verification_jobs (V1-2.3 M6: the worker's verdict RPCs, service role only), sheet_admin_reads (V1-2.5 M7: admin reads, deprecated fingerprint)
|
||||
│ ├─ migrations/*.sql ← forward-only; foundation, profiles, platform_roles, anatomical_sheets, storage, sheet_document_schema_v2, profiles_professional, files_foundation (assets, buckets, avatar policies, purge queue, RPCs), workspaces (V1-1.1: personal workspace per account, access helpers), clients (V1-1.2: client RPCs and search, write budget per workspace), animals_relations (V1-1.4: species rows, animals, relations with history and voiding, their RPCs and reads), sheet_access_hardening + sheet_review_workflow (V1-2.1 M4, M5), sheet_verification_jobs (V1-2.3 M6: the worker's verdict RPCs, service role only), sheet_admin_reads (V1-2.5 M7: admin reads, deprecated fingerprint), sheet_admin_last_modified (V1-2.6 R3 M9: `last_modified_at` in the admin sheet summary)
|
||||
│ ├─ seed/anatomical-sheets/equine/
|
||||
│ │ ├─ legacy-sources/ ← the historical Horse.svg, Horse_head.svg, pathologies.json, vertebrae.ts (importer input, never edited)
|
||||
│ │ ├─ legacy-import/ ← GENERATED baseline: document, id map, IMPORT-REPORT, SVG copies (no SQL)
|
||||
|
||||
@@ -184,3 +184,18 @@ Not changed: the clients and animals list searches are not kept in browser histo
|
||||
planning: the properties panel becomes a dialog opened over the drawing, and the trace strip gains the point-size
|
||||
slider, « Déplacer la zone » and « Redessiner ». The owner validates the redrawn boards before any U2 code. Boards 14
|
||||
and 16 (phone) are unchanged (O14 A). Until then the boards stay the reference for everything else they show.
|
||||
|
||||
2026-11-16: R3 built (owner brief « R3 » and validation of plan rev 2b, `docs/development/V1-2-6_U1_CORRECTIONS.md` §R3
|
||||
« As built 2026-11-16 »). Boards 28 (sheet list, desktop) and 29 (sheet list at 375 px, Administration home card) of
|
||||
`v1-2-6-r0/` are the reference, labels as `v1-2-6-r0/REVUE.md:82-84`. Built as drawn: the search field with its clear
|
||||
button, « Trier par », the count line, « Modifiée le … » on each row, the four filters unchanged, the no-result note of
|
||||
board 28 literally, the card's « Dernières modifications » with at most five sheets. Two deviations from the boards:
|
||||
1. No magnifier in the search field, although boards 28 and 29 draw one (F14): `Icon` has no such glyph, and the two
|
||||
search fields already shipped and validated (catalogue, Références tab) show none. Validated by the owner with the
|
||||
plan (2026-11-16, « Pas de nouvelle icône de recherche »).
|
||||
2. No info icon in the no-result block, although board 28 draws one: same reason (no glyph in `Icon`, the plan allows
|
||||
no new icon); the block follows the editor's validated no-result block. A ruling made during the build, to be
|
||||
confirmed by the owner.
|
||||
Below two sheets the card's link reads « Toutes les fiches officielles » instead of « Voir les {n} fiches » (owner
|
||||
decision D6, 2026-11-16). The design review of the two screens against boards 28 and 29 at 1 280 and 375 px is pending
|
||||
at the time of writing (2026-11-16).
|
||||
@@ -10,7 +10,7 @@ engines are installed. The suites live in `apps/app/e2e`.
|
||||
| Command | Backend | Dev server | Content |
|
||||
|---|---|---|---|
|
||||
| `pnpm e2e:ui` | none | Vite on `127.0.0.1:5191` | `e2e/ui/dialog.spec.ts`: the D13 contract of the shared Dialog on a test page (since 2026-11-15 the ✕ measured at least 44 × 44 px, inside the viewport, beside a wrapped long title at 320, 375 and 1 280 px, with axe); `e2e/ui/working-copy.spec.ts`: the real `WorkingCopyAction` and its dialog on a test page (axe, layout, keyboard, fr and en, desktop and 375 px); `e2e/ui/local-tool.spec.ts`: the disclaimer, edit and replace dialogs on the real local-tool routes |
|
||||
| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer; `e2e/shell/clients.spec.ts`: the client journeys (V1-1.5); `e2e/shell/animals.spec.ts`: the animal and relation journeys (V1-1.6, contract §11.8); `e2e/shell/responsive.spec.ts`: no sideways scroll on nine shell pages, the archive confirmations and the drawer at 320, 360, 375, 390 and 430 px (phone project) and 1280 px, long values, the dashboard e-mail shown whole (RESP-01); `e2e/shell/admin.spec.ts` (V1-2.5): A0 the owner's bootstrap (two TOTP factors from Sécurité, the step-up at `/app/admin` and inside a factor action, no second factor from `aal1`, refresh keeping `aal1` and `aal2`, rights granted and revoked with their reason), A1 a sheet created by an editor on a new inactive species, S1 a species created inactive then activated by the owner, the creation page when the own-grants read fails (« Impossible de vérifier vos autorisations » and « Réessayer », never the form; Retry brings the form back), access per right (a reviewer-only account refused on the creation page), axe and no sideways scroll on every admin page; `e2e/shell/catalogue.spec.ts` (V1-2.5): P1 a reader searches, opens a sheet, picks a zone, reads a retired version, drafts and archived sheets never listed, the same refusal for an existing and an unknown sheet without access, 320, 375 and 430 px with the whole drawing in the box at opening; at 320 and 375 px the zone panel's live region present before a pick and naming the picked zone, the « Références » card starting at or below the drawing's bottom; `e2e/shell/editor-*.spec.ts` (V1-2.6, the draft editor level 1, contract C16 to C34): `editor-drawings` (A2: a hostile file refused with no cleaning box, an Inkscape export cleaned after its preview, a valid file attached, a detail view by crop, the same bytes attached twice), `editor-annotations` (A3: points, zones and links by clicks and by keyboard only, move by drag, a click with jitter never moves, numeric edits, undo and redo, review and delete), `editor-geometry` (a click near a frame edge with the corrected position confirmed and cancelled, an inherited out-of-frame point repaired through the geometry group, a crop change refused when it would invalidate a point, an unmeasured view with its tools disabled, touch-action and a touch drag in real Chromium), `editor-structures` (A4: categories, references, regions, findings tree, reorder, mark reviewed, delete with dependents; since the finish findings and references go through their dialogs, the delete dialog stacked over the finding dialog), `editor-references` (R2 and finish: read-only tiles, the reference dialog from « Modifier » and « Ajouter » with axe, its draft and its read-only flip, a tile edited out of the search keeping its place), `editor-journey` (the steps of `V1-2-6_OWNER_TRIAL.md` §4 with two editor accounts, a finding created through its dialog and the dialog closed before the next add: creation, drawing, findings, annotations, save, reload with the beforeunload dialog and the recovery offer, conflict, submission, the round read back in SQL), `editor-recovery` (two sessions, an older local copy restored then saved over a newer revision, a pending offer blocking edits, an unreadable copy kept until « Ignorer », Escape on the conflict read, the editor grant revoked, the admin role removed and the grant expired under an open session), `editor-access` (the finding dialog and the references dialog scanned by axe at the widths; a reviewer-only account read-only, the not-found screen for an editor without the admin role and for an admin without a capability, 320, 375 and 800 px read-only, 1 024 px editing, axe on every tab edit and read-only), `editor-deselect` (R1, D5 and D6b: « Désélectionner » with its live region, the focus on the list row and the document unchanged; Escape over the canvas, a field, the delete dialog, the references dialog over the finding dialog (Escape closes the references dialog, a second one the finding dialog, a third deselects) and a tracing; mouse clicks on empty parts deselecting, on annotations selecting; zoom, pan, marker drag and Ctrl+wheel keeping the selection; a typed value applied by the deselecting click; at 1 280 px with `hasTouch` and CDP touch taps near annotations and the canvas bottom deselecting once, drags, two-finger taps and pinch keeping the selection, with the pointer events counted by a recorder; the read-only twin at 375 px and Escape closing « Plus » before deselecting; the drawing's top unchanged when a point, a zone and a link are selected then deselected, on desktop and on the read-only twin at 375 px, with the selection tag out of the visual flow), `editor-equine` (the sheet and the finding dialog closed between visits since the finish; the historical equine sheet opened as a working copy, a copy left active byLine truncated
|
||||
| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer; `e2e/shell/clients.spec.ts`: the client journeys (V1-1.5); `e2e/shell/animals.spec.ts`: the animal and relation journeys (V1-1.6, contract §11.8); `e2e/shell/responsive.spec.ts`: no sideways scroll on nine shell pages, the archive confirmations and the drawer at 320, 360, 375, 390 and 430 px (phone project) and 1280 px, long values, the dashboard e-mail shown whole (RESP-01); `e2e/shell/admin.spec.ts` (V1-2.5): A0 the owner's bootstrap (two TOTP factors from Sécurité, the step-up at `/app/admin` and inside a factor action, no second factor from `aal1`, refresh keeping `aal1` and `aal2`, rights granted and revoked with their reason), A1 a sheet created by an editor on a new inactive species, S1 a species created inactive then activated by the owner, the creation page when the own-grants read fails (« Impossible de vérifier vos autorisations » and « Réessayer », never the form; Retry brings the form back), access per right (a reviewer-only account refused on the creation page), axe and no sideways scroll on every admin page; `e2e/shell/catalogue.spec.ts` (V1-2.5): P1 a reader searches, opens a sheet, picks a zone, reads a retired version, drafts and archived sheets never listed, the same refusal for an existing and an unknown sheet without access, 320, 375 and 430 px with the whole drawing in the box at opening; at 320 and 375 px the zone panel's live region present before a pick and naming the picked zone, the « Références » card starting at or below the drawing's bottom; `e2e/shell/admin-sheets-list.spec.ts` (V1-2.6 R3): the official sheet list's search, sorts, count line and dates and the Administration home's latest changes (below, « The sheet list spec »); `e2e/shell/editor-*.spec.ts` (V1-2.6, the draft editor level 1, contract C16 to C34): `editor-drawings` (A2: a hostile file refused with no cleaning box, an Inkscape export cleaned after its preview, a valid file attached, a detail view by crop, the same bytes attached twice), `editor-annotations` (A3: points, zones and links by clicks and by keyboard only, move by drag, a click with jitter never moves, numeric edits, undo and redo, review and delete), `editor-geometry` (a click near a frame edge with the corrected position confirmed and cancelled, an inherited out-of-frame point repaired through the geometry group, a crop change refused when it would invalidate a point, an unmeasured view with its tools disabled, touch-action and a touch drag in real Chromium), `editor-structures` (A4: categories, references, regions, findings tree, reorder, mark reviewed, delete with dependents; since the finish findings and references go through their dialogs, the delete dialog stacked over the finding dialog), `editor-references` (R2 and finish: read-only tiles, the reference dialog from « Modifier » and « Ajouter » with axe, its draft and its read-only flip, a tile edited out of the search keeping its place), `editor-journey` (the steps of `V1-2-6_OWNER_TRIAL.md` §4 with two editor accounts, a finding created through its dialog and the dialog closed before the next add: creation, drawing, findings, annotations, save, reload with the beforeunload dialog and the recovery offer, conflict, submission, the round read back in SQL), `editor-recovery` (two sessions, an older local copy restored then saved over a newer revision, a pending offer blocking edits, an unreadable copy kept until « Ignorer », Escape on the conflict read, the editor grant revoked, the admin role removed and the grant expired under an open session), `editor-access` (the finding dialog and the references dialog scanned by axe at the widths; a reviewer-only account read-only, the not-found screen for an editor without the admin role and for an admin without a capability, 320, 375 and 800 px read-only, 1 024 px editing, axe on every tab edit and read-only), `editor-deselect` (R1, D5 and D6b: « Désélectionner » with its live region, the focus on the list row and the document unchanged; Escape over the canvas, a field, the delete dialog, the references dialog over the finding dialog (Escape closes the references dialog, a second one the finding dialog, a third deselects) and a tracing; mouse clicks on empty parts deselecting, on annotations selecting; zoom, pan, marker drag and Ctrl+wheel keeping the selection; a typed value applied by the deselecting click; at 1 280 px with `hasTouch` and CDP touch taps near annotations and the canvas bottom deselecting once, drags, two-finger taps and pinch keeping the selection, with the pointer events counted by a recorder; the read-only twin at 375 px and Escape closing « Plus » before deselecting; the drawing's top unchanged when a point, a zone and a link are selected then deselected, on desktop and on the read-only twin at 375 px, with the selection Line truncated
|
||||
|
||||
Each suite runs on two Chromium projects: `chromium-desktop` (1280 × 800) and
|
||||
`chromium-375` (375 × 667, mobile viewport, touch). A test tagged `@phone`
|
||||
@@ -96,6 +96,40 @@ citation, and one « Défaire » removes both. Read-only at 375 px: the dialog i
|
||||
Constats, no edit control, axe; the ✕ at 44 × 44 px beside a long name at 375 and 320 px; by touch, taps act on the references
|
||||
dialog only and the finding dialog under it stays.
|
||||
|
||||
### The sheet list spec (V1-2.6 R3)
|
||||
|
||||
`e2e/shell/admin-sheets-list.spec.ts` needs the sandbox migrated to M9 (`pnpm db:sandbox migrate`) and never opens
|
||||
the rights screen (`/app/admin/access`, BLK-015). Serial, one editor account at `aal2` per project, French and
|
||||
English, desktop and 375 px (4 tests). Fixtures: three official draft sheets named with a run token (« R3 {token}
|
||||
Alpha », « Émeu », « Zèbre », English names with the same token), seeded in that order, each id kept as soon as it
|
||||
exists; then one more save of Alpha's draft through `save_sheet_draft`, so Alpha's sheet row is the oldest of the
|
||||
three and only the true last modification puts it first. Checks: a search on the token gives three rows, and the
|
||||
count line's total equals the length of the `list_official_sheets_admin` answer captured in the same load; the order
|
||||
Alpha, Zèbre, Émeu by « Dernière modification », then Alpha, Émeu, Zèbre by « Nom »; each row's date in the ratified
|
||||
format; the token followed by 100 characters without a space, cut at the field's limit, shows the no-result sentence
|
||||
with no sideways scroll, and « Effacer la recherche » empties the field, gives it the focus and restores the count;
|
||||
axe and no sideways scroll on the searched list, the empty state and `/app/admin` (never on the unsearched list of the
|
||||
accumulated sandbox); the home's sub-heading, at most five items with non-increasing `time[datetime]`, and a footer
|
||||
link that carries a number and opens the list. Teardown (owner decision D7): each id this run created is
|
||||
soft-deleted through `delete_anatomical_sheet` with the same token, the returned id checked, each step independent of
|
||||
the others. A sweep adds two accounts and two catalogue grants to the sandbox (BLK-015 counts grants), and leaves no
|
||||
sheet listed. `allSheetsLink(scope, dict)` (`e2e/support/admin.ts`) finds the sheets card's link by
|
||||
`admin.home.all_sheets` or by `admin.home.see_all` with any number; the three earlier locators of that link (A1 and
|
||||
« access per right » in `admin.spec.ts`, `createSheetFromAdmin` in `editor-journey.spec.ts`) use it, their assertions
|
||||
unchanged. Known gaps, left for the final fix wave: the hour and minute are compared with a Paris clock, but the shell
|
||||
config sets no `timezoneId`, so a regression to local time would pass on a host already in Europe/Paris; the home's
|
||||
ordering loop would pass with no `<time>` at all (its count is not compared with the items'); the date pattern is
|
||||
built from dictionary text without escaping.
|
||||
|
||||
Results on 2026-11-16 (code at `b4a5254`): the spec alone, 4 passed, 0 failed. The sweep of 27 spec files without
|
||||
`editor-equine.spec.ts`, 446 tests: 277 passed, 6 failed, 163 skipped, 0 flaky. The six failures, named: « admin
|
||||
screens » (`admin.spec.ts:714`) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed` during axe on
|
||||
the rights screen; A0 « the rights screen with grants » (`admin.spec.ts:220`) ×2, fr and en at desktop, the grant
|
||||
lookup stuck on « Recherche… » until the « E-mail confirmé » check timed out at `:144`, about 7 600 grant rows
|
||||
rendered. All six are counted as BLK-015, the A0 pair with another symptom than « Target crashed »; NOT proven by an
|
||||
A/B run against the commit before R3. Green as required: A1 and « access per right » in both languages,
|
||||
`editor-journey`, the new spec. The data guard found 0 pre-existing sheet or version row changed or missing.
|
||||
|
||||
Layout additions in `e2e/shell/editor-shell-layout.spec.ts`: five tabs everywhere the four were checked (no
|
||||
sideways scroll from 1 024 to 1 280 px, axe from the top, read-only at 320, 375 and 768 px); the open panel at most
|
||||
34 rem and never wider than the viewport, the document size unchanged before, during and after; the canvas width
|
||||
@@ -234,6 +268,8 @@ suite needs Docker in the runner for the sandbox.
|
||||
grants » and « admin screens » (fr or en, desktop and 375). The cure, a paginated grant list, is RR-13; BLK-015
|
||||
stays open. Unchanged by the R2 finish (2026-11-13). Rerun the spec alone to separate a crash from a real failure:
|
||||
that isolated run is a diagnosis, never the gate.
|
||||
R3 sweep (2026-11-16): the same four « admin screens » crashes, and A0 failing twice by a lookup timeout at about
|
||||
7 600 grants (other symptom, counted as BLK-015, not A/B proven; « The sheet list spec » above).
|
||||
- The layout spec covers the landscape 667 × 375 sample in two parts, in one test of the phone project. The citations
|
||||
trigger sits at 811 to 855 px at scroll 0. (A) Touch only: CDP `Input.dispatchTouchEvent` swipes of 200 px
|
||||
(`Input.synthesizeScrollGesture` with `touch` scrolls nothing in this Chromium) until the trigger is wholly on
|
||||
|
||||
@@ -306,6 +306,8 @@ concrete constraint.
|
||||
| `apps/app/src/editor/references/{sort,view,referenceTypes}.ts` | the four display orders of the Références tab (sheet, citation A to Z, count, type), the shown set after the finding filter, the search and the sort (R2F-6: the ids a finding cites narrow the list; no pin under a filter) | TS, `Intl.Collator` of the current language | the collation needs the browser's ICU data (a Rust equivalent would ship its own); a pure function of positions that never writes the document, the stored order or the history | no | none | none | `editor-reference-sort.test.ts` (stable, equal keys keep the stored order, inputs untouched), view suites | **C**: display-only ordering, no business rule, no mutation; BDR-114 (A) | n/a |
|
||||
| `apps/app/src/editor/references/safeLink.ts` | `http` and `https` link target for a URL, `https://doi.org/` target for a well-formed DOI | TS (`URL`) | portable; it builds a display link, and its `http`/`https` test also backs the reference dialog's precheck of the stored URL field (UI form validation: the same refusal the core makes, shown on the field; the core's reference rules stay authoritative and refuse anything else) | no | none | none | `editor-safe-link.test.ts` | **C**: display-only link building over validated data; BDR-114 (A) | n/a |
|
||||
| `apps/app/src/components/editor/references/useReferenceView.ts` | search text and sort choice (React state), the finding filter read from the history view (navigation, not typed text), tile order handed to the tab | React hook | holds view state only and calls the pure functions above; it reaches no wasm call and no document write | no | none | none | `editor-references-view.test.tsx` | **C**: React state of a display view; BDR-114 (A) | n/a |
|
||||
| `apps/app/src/admin/sheetList.ts` (`searchSheets`, `sortSheets`, `SHEET_SORTS`) and `matchesSheetName` in `apps/app/src/catalogue/useCatalogue.ts` | the admin official sheet list (R3): search on the name in French or English (`folded`, the catalogue's rule, now shared), sort by `last_modified_at` (newest first) or by name, ties by name then id | TS, `Intl.Collator` of the current language | portable, but the collation needs the browser's ICU data (a Rust equivalent would ship its own); filters and orders the loaded list for display, never writes; the date itself is computed by the server (M9) and checked at the client boundary | no | none; called in the render of the list page and the home card | none | `admin.sheetList.test.ts`, the catalogue suites | **C**: display-only search and ordering over server data, no business rule, no mutation; owner validation of the R3 plan, 2026-11-16 (as BDR-114 (A)); `shortcut:` until RR-13 pages the list on the server, where search and sort move | n/a |
|
||||
| `formatShortParisDateTime` in `apps/app/src/admin/labels.ts` | the « 9 nov. 2026, 12:06 » / « 9 Nov 2026, 12:06 » date of the admin list and home card (A8), Paris time | TS, `Intl.DateTimeFormat` (`fr-FR`, `en-GB`, `Europe/Paris`), one formatter per language | screen date formatting needs the browser's ICU and time zone data | no | none | none | `admin.labels.test.ts` (ratified strings, the Paris summer offset) | **C**: screen date formatting (as `lib/dates.ts`); owner validation of the R3 plan, 2026-11-16 | n/a |
|
||||
| `i18n/*` (281 keys ×2, `useT`, `pickLocaleLabel`) | UI strings | TS | UI data and hook; the engine's 25 archived labels move with the engine | no | | | parity test | **C** | n/a |
|
||||
| `config/env.ts`, `lib/supabase.ts`, providers, guards, routes, components, styles | runtime config, React | TS | glue | no | | | | **C** | n/a |
|
||||
| `vite/sheet-bundle.ts`, ESLint, Vite, vitest configs | build tooling | Node | Vite plugin API is JavaScript | no | | | | **C** | n/a |
|
||||
@@ -336,6 +338,11 @@ concrete constraint.
|
||||
mutate it. The limit: any rule that would change the document, or that the
|
||||
PDF or the server must share (what may be deleted, what a citation
|
||||
requires, a count stored or archived), moves to `crates/core`.
|
||||
Same exception for the admin sheet list (R3, owner validation of the plan,
|
||||
2026-11-16): search, sort and the short Paris date of
|
||||
`apps/app/src/admin/{sheetList,labels}.ts` only filter, order and format the
|
||||
list the server answered; the last-modification date is the server's
|
||||
(M9). A rule the server must share moves to SQL or `crates/core`.
|
||||
|
||||
---
|
||||
|
||||
|
||||
@@ -806,7 +806,7 @@ Docker.
|
||||
| `pnpm db:sandbox verify-e2e` | V1-2.3: a gateway (`nginx:1.31-alpine`, sandbox network only, no host port) and the real verification worker `faunosteo_worker:dev run --jobs sheet-verify` against the sandbox, then `packages/supabase/tests/sandbox/sheet-verification.sandbox.ts`; both containers removed at the end, the service key passed through a 600 file deleted at start |
|
||||
| `pnpm db:sandbox avatar-e2e` | V1-2.3: the same gateway, published on `127.0.0.1:57800` only and routing `/auth/v1/` too, the real worker `faunosteo_worker:dev run` (default mode: avatars and sweep, 5 s sweep, no quarantine grace, 512 MiB as the compose `worker`) against the sandbox, then `packages/supabase/tests/e2e/avatar-flow.e2e.ts` through that port; the suite's psql calls go to the sandbox database container, which it requires by name; its two accounts are made per run with random passwords and deleted after; both containers removed at the end |
|
||||
| `pnpm db:sandbox trial` / `trial-account <email>` / `trial-grant <email> <kind>` | V1-2.6 owner trial (`docs/development/V1-2-6_OWNER_TRIAL.md`): the app on `http://$FAUNOSTEO_TRIAL_HOST:5193` (default the LAN address of this machine, `127.0.0.1` = host-only; loopback or private IPv4 of an interface only, Host header allowlisted) behind a trial gateway on `127.0.0.1:57801` (refuses to start when `faunosteo_dbsandbox_trial_gateway` exists), a confirmed account (hidden password prompt), a catalogue right (email and kind checked, passed as psql variables; editor and publisher also get the admin role) |
|
||||
| `pnpm db:sandbox migrate` | forward only on the running sandbox: `supabase migration up --db-url` applies the branch's pending migrations, nothing else (no reset, no seed, no container recreated, data kept); prints the last applied version before and after, a second run applies nothing |
|
||||
| `pnpm db:sandbox migrate` | forward only on the running sandbox: `supabase migration up --db-url` applies the branch's pending migrations, nothing else (no reset, no seed, no container recreated, data kept); prints the last applied version before and after, a second run applies nothing. Takes no argument and refuses when the sandbox is not up. The CLI refuses a pending file older than the last applied one; a migration edited after it was applied is neither detected nor applied again, so a migration is frozen from its first application to any stack and a change ships as a new file. Added in V1-2.6 R3 (owner decision D3, 2026-11-16) as additions only to `scripts/db-sandbox.sh` (`scripts/db-trial-check.sh` checks that), so it is documented here and in the script's comment, not in the help header the script prints; first run 2026-11-16, M9, `20261103100000` → `20261116100000` |
|
||||
| `pnpm db:sandbox sql` / `down` | psql as postgres on stdin / remove the stack |
|
||||
|
||||
Every CLI call passes `--db-url` with `sslmode=disable` (the sandbox has no
|
||||
|
||||
@@ -1,9 +1,12 @@
|
||||
# R3 SQL checkpoint: a true last-modification date for the sheet list
|
||||
|
||||
Status: DESIGN ACCEPTED by the owner, 2026-11-09 (verdict « R0 — Verdict de revue graphique propriétaire », BDR-109),
|
||||
after the brief « R0 — Décisions propriétaire et dernière validation graphique » (A7). No migration is created or
|
||||
applied for now; writing and applying it needs the owner's later go. R3 keeps its split before and after this
|
||||
checkpoint (section 5). Companion of `V1-2-6_U1_CORRECTIONS.md` (lot R3).
|
||||
Status: APPLIED 2026-11-16 as M9 `supabase/migrations/20261116100000_sheet_admin_last_modified.sql`, on the
|
||||
sandbox and on the trial stack (`pnpm db:trial`); DEV unchanged. History: design accepted by the owner, 2026-11-09
|
||||
(verdict « R0 — Verdict de revue graphique propriétaire », BDR-109), after the brief « R0 — Décisions propriétaire et
|
||||
dernière validation graphique » (A7); writing and applying it authorised by the owner on 2026-11-16 (section 6). The
|
||||
split before and after this checkpoint (section 5) is superseded by the owner's decision D2: R3 shipped in one lot.
|
||||
Sections 1 to 5 are the checkpoint as accepted on 2026-11-09, with the corrections of 2026-11-16 marked in place.
|
||||
Companion of `V1-2-6_U1_CORRECTIONS.md` (lot R3).
|
||||
|
||||
## 1. The problem
|
||||
|
||||
@@ -42,6 +45,11 @@ A new migration replaces `private.official_sheet_admin_summary` with the same bo
|
||||
sheet metadata change moves both; a sheet without a version answers its own date; the key is present for every
|
||||
listed sheet; the call rights unchanged (existing tests :186-190 re-run).
|
||||
- `pnpm --filter @faunosteo/supabase test:run` (PGlite) and `pnpm db:test` on a real stack.
|
||||
Correction 2026-11-16 (F3): `pnpm db:test` runs `supabase test db` on the DEV stack, and V1-2 is sandbox only. The
|
||||
real-PostgreSQL run is `pnpm db:sandbox test-db`, after the sandbox is migrated; DEV stays untouched.
|
||||
- Correction 2026-11-16 (F4): a pgTAP file runs in one transaction, where `now()` is frozen and `set_updated_at`
|
||||
stamps `now()`. « A draft save moves `last_modified_at` and not `updated_at` » cannot be seen on rows dated
|
||||
`now()`, so the new fixture rows are dated in the past at insert (the trigger stamps updates only).
|
||||
- `pnpm db:types`: the functions return `jsonb`, so the generated types do not change; the hand-written summary type
|
||||
in `packages/supabase/src/sheets.ts` gains `last_modified_at`.
|
||||
|
||||
@@ -60,9 +68,80 @@ without the owner:
|
||||
Recommendation: a (with b only if the shell suite must see the date before the trial stack exists). PGlite and
|
||||
`pnpm db:test` need no existing stack.
|
||||
|
||||
Correction 2026-11-16 (F2, F3): path a alone was not enough. The shell suite runs on the sandbox, and once the
|
||||
client requires the key every admin and editor spec fails at load on a stack without M9, and nothing would prove the
|
||||
date on a real PostgreSQL. Both paths were taken: b first (`pnpm db:sandbox migrate`, forward only, additions
|
||||
only to the script), then a, then the application code (owner decision D3). The last sentence above is
|
||||
wrong for `pnpm db:test`, which runs on DEV (section 3).
|
||||
|
||||
## 5. What R3 does before and after
|
||||
|
||||
- Before: search and clear, sort by name only, no date on the rows, the Administration card without a date or a
|
||||
« most recent » claim (the first five by name, with « Voir les N fiches »).
|
||||
- After: « Modifiée le … » from `last_modified_at`, « Dernière modification » as the default sort, the card listing the
|
||||
five most recently modified sheets. Boards 28 and 29 draw this final state.
|
||||
|
||||
Superseded 2026-11-16 (owner decision D2): the « before » state was never built. R3 shipped once, in the « after »
|
||||
state.
|
||||
|
||||
## 6. Owner's answers and application (2026-11-16)
|
||||
|
||||
Owner messages of 2026-11-16, verbatim in `.claude/tasks/contracts/2026-11-16-r3-sheet-list-1720.md`:
|
||||
|
||||
- Plan validation (rev 2): D1 yes (write M9 and its pgTAP), D2 yes (one delivery in the final state), D3 yes (the
|
||||
sandbox through the new `pnpm db:sandbox migrate` without a reset, then `db:trial` after an operational checkpoint,
|
||||
then the application), D4 yes (RR-13 widened to the paging of the admin lists, rights and official sheets, not
|
||||
implemented in R3), D5 no (the list state kept on return stays out of R3, tracked as a later navigation
|
||||
improvement), D6 yes, D7 yes. Precisions: (P1) the tests cover the real computation on PostgreSQL, drafts and
|
||||
working copies included; (P2) the migration reviewed and frozen before its first application; (P3) the application
|
||||
never shows an old or wrong date as a reliable last modification; (P4) exact test results kept, the known BLK-015
|
||||
failures included.
|
||||
- Go for the trial stack: the controller runs the operations (state check, the app on port 5194 identified then
|
||||
stopped, cold backup, `pnpm db:trial migrate`, the six containers checked, integrity checks, the app restarted); on
|
||||
a backup or migration failure, stop and report, no destructive restore without a new go; the pgTAP failures of 014
|
||||
and 021 kept in the tracking, the suite never presented as green.
|
||||
|
||||
As applied:
|
||||
|
||||
- M9 is the M7 summary body plus the key of section 2, the revoke restated; no table, policy, index or privilege
|
||||
change. Task review and security review before the first application (security PASS, one LOW finding that
|
||||
predates M9: file 022 checks the helper's revoke for `authenticated` only, not for `service_role`). Frozen since:
|
||||
blob `a33b1770`.
|
||||
- pgTAP `022_sheet_admin_reads.sql`, plan 74 (60 before): a draft newer than its sheet row, a sheet without a version,
|
||||
a draft save that moves `last_modified_at` and leaves the sheet row's `updated_at`, a sheet change that moves
|
||||
both, a dated working copy and its draft save, a sheet row newer than its versions, the key on every listed sheet.
|
||||
- Sandbox (`pnpm db:sandbox migrate`): `20261103100000` → `20261116100000`, a second run applies nothing. Data guard
|
||||
before and after (6 981 sheets, 7 130 versions, full rows per id): identical. Function digest
|
||||
`3a61a802…` → `1a4a1157…`. `pnpm db:sandbox types --check`: no drift. Recomputation of every official sheet not
|
||||
deleted against `greatest(s.updated_at, max(v.updated_at))`: 6 981 checked, 0 mismatch, 0 null, 11 working copies
|
||||
(0 mismatch), 1 historical sheet; 6 579 sheets whose date now differs from `updated_at`, 0 older than it. pgTAP on
|
||||
the real image: Files=21, Tests=1958, Result FAIL, with `022` and `023` ok, `014_animals_relations` 2 of 258 failed,
|
||||
`021_sheet_verification_jobs` 23 failed with « Bad plan. You planned 90 tests but ran 42 ». Read as dependent on the
|
||||
accumulated sandbox state, M9 touching neither file's functions; NOT proven by a run without M9 or on a fresh
|
||||
stack.
|
||||
- Trial stack (`pnpm db:trial migrate`, 21 s, 14:41:52Z to 14:42:13Z): backup `20261116T144154Z-pre-migrate` (63M),
|
||||
checked by the script before the migration, then by hand (`SHA256SUMS` 5 entries all match, `db.tar` 1 371 entries,
|
||||
`storage.tar` 6 entries); 18 migrations applied, six containers running. Digest of 58 tables, 155 functions
|
||||
(definition and privileges), 23 policies and 20 table grants before and after: exactly 3 lines differ (the
|
||||
migration registry 17 → 18 rows and its new row, the summary function's definition = the sandbox's digest
|
||||
`1a4a1157…`, its privileges unchanged). Accounts, roles, TOTP factors, the 2 sheets, 2 versions and 2 drawing rows
|
||||
identical. Recomputation: 2 checked, 0 mismatch, 0 null, 1 working copy, 1 historical. Reads as the trial's
|
||||
practitioner account (admin and `sheet_editor`, its own `aal2` session, read-only transaction rolled back): the
|
||||
admin list 2 rows, each with `last_modified_at`; one sheet's overview; each version with its document and
|
||||
drawings. The app restarted, its pages and the auth health check answering 200 through its proxy. NOT checked: a
|
||||
browser sign-in with TOTP and the admin and editor screens in a browser (the owner's accounts, the owner's
|
||||
trial); the restore of the backup was not exercised (destructive).
|
||||
|
||||
## 7. Known limits of the date (F7)
|
||||
|
||||
`last_modified_at` moves, or fails to move, in these cases the checkpoint did not list. Only (iii) is reachable from
|
||||
the application today.
|
||||
|
||||
| # | Case | Effect |
|
||||
|---|---|---|
|
||||
| i | `delete_sheet_version` removes a draft row (`20261028110000_sheet_review_workflow.sql:1304-1332`) | the date can go back to an older one. No screen calls it today; fixed in that write the day a « supprimer le brouillon » screen exists |
|
||||
| ii | deleting an account that created a draft sets the version's `created_by` to null (`20261008110000_anatomical_sheets.sql:111`) | that update stamps the version: the sheet reads as modified at the account's deletion |
|
||||
| iii | review rounds and audit rows | never move the date, by design (section 2) |
|
||||
| iv | a future data migration that rewrites drafts | re-dates every such sheet to the deploy time |
|
||||
| v | the autumn clock change in Paris | two saves an hour apart can read the same « 02:30 » and still sort in their true order, which looks inconsistent |
|
||||
|
||||
@@ -613,12 +613,89 @@ Status: R2 closed. Next lots: R3, then R4 (below); U2 waits for its own planning
|
||||
regenerated types, and its application to a stack, which needs the owner's go for that operation. Ratified (A7):
|
||||
the dedicated checkpoint is `V1-2-6_R3_SQL_CHECKPOINT.md`; R3 ships in two steps, search and name sort with no date
|
||||
first, the date, the date sort and the « most recent » card only once the SQL change is authorised and applied.
|
||||
Superseded 2026-11-16 by the owner's decision D2 (below): one delivery in the final state, the « before » state
|
||||
never built.
|
||||
- Search and sort run in the browser on the full list: `shortcut:` until RR-13 pages the list on the server, where
|
||||
search and sort move with it.
|
||||
- Tests: unit for search (accents, both languages, empty, clear), sort (date ties by name, collation), date format
|
||||
FR/EN, the home card (at most five, sorted); e2e admin list search and sort at desktop and 375 px with axe; the four
|
||||
filters unchanged.
|
||||
|
||||
#### As built 2026-11-16
|
||||
|
||||
Owner brief « R3 » (2026-11-16), plan `.claude/tasks/plans/2026-11-16-r3-sheet-list-0017.md` rev 2b validated the
|
||||
same day: D1 to D4, D6 and D7 yes, D5 no, the « recorded unless the owner objects » choices accepted, precisions P1 to
|
||||
P4 binding. Then the owner's go for `pnpm db:trial migrate`. Contract:
|
||||
`.claude/tasks/contracts/2026-11-16-r3-sheet-list-1720.md`. Branch `feature/v1-2-anatomical-sheets`, no merge, no
|
||||
deploy, DEV unchanged.
|
||||
|
||||
- Delivery (D2): one lot in the final state. The two-step split of A7 is superseded: no « before » state (search and
|
||||
name sort without a date) was built or shown.
|
||||
- SQL: M9 `supabase/migrations/20261116100000_sheet_admin_last_modified.sql` adds `last_modified_at` to
|
||||
`private.official_sheet_admin_summary`, the newest of the sheet row's `updated_at` and of its versions'
|
||||
`updated_at` (`V1-2-6_R3_SQL_CHECKPOINT.md`). Reviewed (task review, security review) before its first
|
||||
application, frozen since (blob `a33b1770`). pgTAP `supabase/tests/022_sheet_admin_reads.sql`, plan 74: a saved
|
||||
draft, a saved working copy, a sheet without a version, a sheet row newer than its versions (P1).
|
||||
- Stacks (D3): the sandbox through the new `pnpm db:sandbox migrate` (additions only to `scripts/db-sandbox.sh`, no
|
||||
reset), then the trial stack through `pnpm db:trial migrate` on the owner's go (cold backup
|
||||
`20261116T144154Z-pre-migrate` first), then the application code. Figures: `V1-2-6_R3_SQL_CHECKPOINT.md` §6.
|
||||
- Client (`packages/supabase/src/sheets.ts`): the summary requires `last_modified_at` as an ISO 8601 timestamp with
|
||||
offset; an answer without it, or with a value that is no timestamp, is the closed `unavailable` failure, never a
|
||||
list with a missing or invented date (P3).
|
||||
- List page `/app/admin/sheets` (`AdminSheetsRoute.tsx`, boards 28 and 29 A): search on the name in French or English
|
||||
(`matchesSheetName`, shared with the catalogue: accents and case ignored, surrounding spaces trimmed), instant, 100
|
||||
characters at most, no magnifier; « Effacer la recherche » shown only while the field holds text; Escape empties a
|
||||
non-empty field and does nothing on an empty one; every way of clearing returns the focus to the field. « Trier
|
||||
par »: « Dernière modification » (default, newest first) or « Nom » (the collation of the interface language: French
|
||||
names in the French interface, English names in the English one). Equal dates, then equal names, fall back to the
|
||||
name, then the id, so the order never depends on the server's. The four filters unchanged, combined with the
|
||||
search. A count line (`aria-live="polite"`): « {n} fiches », or « {n} fiches sur {total} » when something is
|
||||
hidden. Each row is one link: name, the existing badges, the detail line (species, sheet status, published
|
||||
version or none, draft version, latest round), and « Modifiée le 9 nov. 2026, 12:06 » in Paris time, inside a
|
||||
`<time>` whose value is the same instant (`toISOString()`). No new badge: published and draft are told apart by
|
||||
the detail line.
|
||||
- Empty states (board 28 note, literally): no official sheet at all, « Aucune fiche officielle pour le moment. »;
|
||||
nothing shown while a filter is active, the existing « Aucune fiche ne correspond à ces filtres. »; nothing shown
|
||||
for a search without a filter, a plain block « Aucune fiche ne contient « {q} » dans son nom. » with the button
|
||||
« Effacer la recherche ». The searched text is the trimmed text, inserted as typed (a `$&` stays `$&`), wrapping
|
||||
anywhere.
|
||||
- Administration home card (`AdminHomeRoute.tsx`, board 29 B): under « Brouillons, revues, versions. » the
|
||||
sub-heading « Dernières modifications », then at most five sheets in the list's « Dernière modification » order,
|
||||
each with its name link, badges, detail line and date. The historical sheet keeps its « Créer une copie de
|
||||
travail » action on the card only when it is among the five, for an editor; otherwise the action is on its own
|
||||
page (F9, A9). Footer link: « Voir les {n} fiches » from two sheets, « Toutes les fiches officielles » for zero or
|
||||
one (D6). A failed species read leaves the species id in the detail line and never hides the card; a rights
|
||||
refusal of the sheet list still hides it.
|
||||
- Labels exactly as `docs/design/v1-2-6-r0/REVUE.md:82-84` in French and English; date format A8.
|
||||
- Deviations from boards 28 and 29, stated in `docs/design/README.md`: no magnifier in the search field (F14, a
|
||||
choice the owner validated with the plan); no info icon in the no-result block although board 28 draws one (a
|
||||
ruling during the build, to be confirmed by the owner: `Icon` has no such glyph and the plan allows no new icon).
|
||||
- Search, sort and the date format stay TypeScript, display only: rows in `RUST_ARCHITECTURE_REVIEW.md` Part II
|
||||
(class C). The `shortcut:` of `apps/app/src/admin/sheetList.ts` (search and sort in the browser on the whole list,
|
||||
until RR-13 pages it, D4) and the one of the search field in `AdminSheetsRoute.tsx` (same markup as the Références
|
||||
tab's search, to fold into one component) are in `.claude/tasks/TODO.md`.
|
||||
- Not in R3: the search, sort and filters kept when coming back from a sheet (D5, a later navigation improvement,
|
||||
BDR-079 follow-up); R4 (board 30).
|
||||
|
||||
Results recorded task by task up to the last code commit `b4a5254` (exact; nothing below that failed is green):
|
||||
|
||||
| Check | Result |
|
||||
|---|---|
|
||||
| `pnpm typecheck`, `pnpm lint` | passed at each task's gate |
|
||||
| `pnpm build` | passed at `423125c` and `de2424f` (the two screen commits) |
|
||||
| `pnpm test:run` | core-wasm 66, supabase 181, app 1743 (at `de2424f` and `b4a5254`) |
|
||||
| `pnpm db:sandbox test sheets-admin` (the client against the migrated sandbox's answers) | 5 of 5 |
|
||||
| `pnpm db:sandbox test-db` (pgTAP on the real image, accumulated sandbox, after M9) | Files=21, Tests=1958, Result FAIL. `022_sheet_admin_reads` ok, `023` ok. `014_animals_relations`: 2 of 258 failed (tests 6 « exactly the nine species… » and 7 « every species row is active »). `021_sheet_verification_jobs`: 23 failed, « Bad plan. You planned 90 tests but ran 42 », an error `draft.frozen` at :205. Read as dependent on the accumulated sandbox state (the suites need a fresh stack); M9 touches neither file's functions. NOT proven: no run of these files without M9, and no fresh stack (`up fresh` needs an owner go) |
|
||||
| `pnpm db:sandbox types --check` | no drift |
|
||||
| `e2e/shell/admin-sheets-list.spec.ts` alone on the sandbox | 4 passed, 0 failed |
|
||||
| Shell sweep, 27 spec files without `editor-equine.spec.ts` | 446 tests: 277 passed, 6 failed, 163 skipped, 0 flaky. All six failures in `admin.spec.ts`, on the rights screen: « admin screens » (:714) ×4, fr and en at desktop and 375 px, `frame.evaluate: Target crashed`; A0 (:220) ×2, fr and en at desktop, the grant lookup stuck on « Recherche… » until the « E-mail confirmé » check timed out (:144), about 7 600 grant rows rendered. Counted as BLK-015, the A0 pair with another symptom than « Target crashed ». NOT proven: no A/B run against the commit before R3. Green as required: A1 and « access per right » (the rewritten locators, both languages), `editor-journey`, the new spec |
|
||||
| Data guard (every pre-existing row of `anatomical_sheets` and `anatomical_sheet_versions`, per id) | 0 changed, 0 missing on every run; the 12 sheets the R3 spec created in its two runs read back `deleted` (D7) |
|
||||
|
||||
Closing gates (verifier on the contract, security review of the whole diff, fresh design review of the two screens
|
||||
at 1 280 and 375 px, fresh code review of the range) and `pnpm check:all`: pending at the time of writing
|
||||
(2026-11-16). Not checked by the build: a browser sign-in on the trial stack (the owner's accounts, the owner's
|
||||
trial, `V1-2-6_OWNER_TRIAL.md` §4.15).
|
||||
|
||||
### R4 — Integrity warning in catalogue cards (D9 C, independent fix)
|
||||
|
||||
- The card already runs the integrity check: `useCardDetails` calls `loadVersion` and drops a failed load in
|
||||
@@ -633,7 +710,8 @@ Status: R2 closed. Next lots: R3, then R4 (below); U2 waits for its own planning
|
||||
## 4. Order and dependencies
|
||||
|
||||
R0 first (validation). R1 is independent of R2 and can ship first. R2 depends on the validated boards 23 to 27. R3
|
||||
ships search and name sort first; its date part waits for the SQL checkpoint (A7 ratified).
|
||||
ships search and name sort first; its date part waits for the SQL checkpoint (A7 ratified). Superseded 2026-11-16
|
||||
(D2): R3 shipped in one lot, after M9 was applied to the sandbox and the trial stack.
|
||||
R4 is independent and may run any time after its board (30) is validated. Anomaly B (section 5) is fixed: the admin specs no longer
|
||||
depend on the working-copy slot.
|
||||
|
||||
@@ -660,7 +738,7 @@ The owner-facing table with consequences, in French: `docs/design/v1-2-6-r0/ARBI
|
||||
| A5 | Escape priority | Dialog, then open menu, then contextual panel, then tracing in progress, then selection. | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
|
||||
| A5b | « Toutes les annotations » already clears the selection | Keep both (D6). | RATIFIED 2026-11-09 (BDR-109), exact recommendation |
|
||||
| A6 | Focus after « Désélectionner » | The annotation's row in the list. | RATIFIED with precision: the row if it still exists, else the drawing; focus never selects again; an accessible announcement |
|
||||
| A7 | Source of the last-modification date | SQL read change `last_modified_at`, own checkpoint. | RATIFIED: dedicated SQL checkpoint `V1-2-6_R3_SQL_CHECKPOINT.md`; until then no creation date shown as a modification date and no misleading sort |
|
||||
| A7 | Source of the last-modification date | SQL read change `last_modified_at`, own checkpoint. | RATIFIED: dedicated SQL checkpoint `V1-2-6_R3_SQL_CHECKPOINT.md`; until then no creation date shown as a modification date and no misleading sort. 2026-11-16: M9 applied (sandbox, trial stack), the two-step delivery superseded by D2 (§R3 « As built ») |
|
||||
| A8 | Date format | Absolute, « 9 nov. 2026, 12:06 » (EN « 9 Nov 2026, 12:06 »). | RATIFIED 2026-11-09 (BDR-109), exact recommendation; shown only after the SQL checkpoint |
|
||||
| A9 | Administration home card | The five most recently modified sheets with species, status and date, then « Voir les N fiches ». | RATIFIED 2026-11-09 (BDR-109), exact recommendation; final state after the SQL checkpoint |
|
||||
| A10 | Catalogue warning wording | FR « Contrôle d'intégrité échoué : cette version ne peut pas être affichée. », a distinct line with « Réessayer » for a load that failed for another reason. | R4 ACCEPTED; wording RATIFIED 2026-11-09 (BDR-109), exact recommendation |
|
||||
|
||||
@@ -1856,6 +1856,7 @@ of the document's JSON text in one form, the same for every layer:
|
||||
| M6 `sheet_verification_jobs` | V1-2.3 | worker RPCs (claim, input, complete with the verdict structure check, fail), service role only, with the retry delay (hidden `not_before` column on the round, `private.sheet_verification_retry_delay`: owner decision 2026-11-01, replaces « without backoff ») and the retry by cause (definitive codes close at the first occurrence, `private.sheet_worker_final_codes`); written as `20261101100000_sheet_verification_jobs.sql`, pgTAP `021`, rehearsed on the sandbox from the state before M4 (M4 to M6 in one `migration up`) and from the state before M6 | none |
|
||||
| M7 `sheet_admin_reads` | V1-2.5 | read RPCs of the admin space (owner decision 2026-11-02, BDR-097): the official sheet list with its badges (historical, working copy), statuses and round counts, and one sheet's overview (versions, rounds); `get_sheet_version` redefined to return the fingerprint of deprecated versions too (BDR-098); the admin reads for capability holders at `aal2` only (`caller_can_see_official_sheet`); no new write path (it redefines two existing write RPCs), no new grant, no policy change; the one rule change is the species sort order: `create_species` and `update_inactive_species` are redefined to refuse an order outside 0..9 999 with `invalid_input` (null keeps today's meaning, owner 2026-11-02), `security definer`, `search_path = ''` and their privileges restated; pgTAP allowed and denied cases | none |
|
||||
| M8 `sheet_draft_last_save` | V1-2.6 | read migration (owner decision 2026-11-03, sandbox only): `get_official_sheet_admin` redefined to answer `draft_last_save` = `{revision, saved_at, saved_by}` (the account that saved the draft's current revision, from the newest `anatomical_sheet_version.saved` audit row of that revision), null when no save wrote it; the list and the summary helper untouched; no write path, no new grant, no policy change, privileges restated as M7; pgTAP allowed and denied cases | none |
|
||||
| M9 `sheet_admin_last_modified` | V1-2.6 (R3) | read migration (owner decisions D1 and D3 of 2026-11-16, design `V1-2-6_R3_SQL_CHECKPOINT.md`, BDR-109): `private.official_sheet_admin_summary` redefined to answer `last_modified_at`, the newest of the sheet row's `updated_at` and of its versions' `updated_at` (review rounds and audit rows do not count), so `list_official_sheets_admin` and `get_official_sheet_admin` carry it; the M7 body otherwise unchanged, the revoke restated; no table, policy, index, grant or write path; generated types unchanged (`jsonb`); pgTAP 022 (plan 74: saved draft, saved working copy, sheet without a version, sheet row newer than its versions). Applied 2026-11-16 to the sandbox through `pnpm db:sandbox migrate` (forward only, on the accumulated sandbox, not an `up upgrade` run from the DEV state) and to the trial stack through `pnpm db:trial migrate` (cold backup first); frozen since its first application (blob `a33b1770`) | none |
|
||||
|
||||
Each migration ships its pgTAP file (allowed and denied cases), regenerated
|
||||
`database.types.ts`, a `db:sandbox up upgrade` run from the DEV state (with a
|
||||
|
||||
Reference in new issue
Block a user