docs(supabase): db:trial review record and contract file scope

This commit is contained in:
bchanot committed 2026-11-10 23:13:23 +01:00
1 parent f7bf0c85cb
commit a78da9f4e2
2 files changed
+35 -8

No files matched your search

@@ -210,7 +210,7 @@ merge or deploy; a script's interactive confirmation is never the owner's prior
independent R13 counter-check returned CONFORME (or every finding it raised is closed in the plan) before lot A2.
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && pnpm --filter @faunosteo/app exec vitest run tests/unit/vite.trialTargets.test.ts tests/unit/vite.trialConfig.test.ts && pnpm --filter @faunosteo/app exec tsc -p tsconfig.node.json --noEmit && pnpm --filter @faunosteo/supabase exec vitest run tests/sandbox-target.test.ts && echo GUARD-TESTS-OK
EXPECT: GUARD-TESTS-OK
EVIDENCE: pending
EVIDENCE: MET exit=0 marker-found :: RUN v3.2.7 /home/bchanot/Documents/faunosteo-v1-2/apps/app stderr | tests/unit/vite.trialConfig.test.ts > shared trial dev server config, as…
17. [gated 2026-11-10] The stub harness passes in full with simulated services only (docker, curl, ss, node and env
wrapped; no daemon reachable), including: typed confirmations of `destroy` (`faunosteo_trial`), `restore`
(`restore <name>`) and `grant` (`grant <role>`) through a terminal only, piped phrases refused; `grant` never adds
@@ -220,32 +220,32 @@ merge or deploy; a script's interactive confirmation is never the owner's prior
any logged argv. bash -n and shellcheck are never offered as proof of real behaviour.
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && bash scripts/db-trial-check.sh
EXPECT: db-trial-check: ALL PASS
EVIDENCE: pending
EVIDENCE: MET exit=0 marker-found :: -- static PASS shellcheck: db-trial.sh and this harness PASS shellcheck: db-sandbox.sh (pre-existing SC1090, SC1091, SC2016 excluded) PASS d…
18. [gated 2026-11-10] Static checks: shellcheck clean on `db-trial.sh`, the harness and `db-sandbox.sh`.
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && shellcheck -x scripts/db-trial.sh scripts/db-trial-check.sh && shellcheck -e SC1090,SC1091,SC2016 scripts/db-sandbox.sh && echo SHELLCHECK-OK
EXPECT: SHELLCHECK-OK
EVIDENCE: pending
EVIDENCE: MET exit=0 marker-found :: SHELLCHECK-OK
19. [gated 2026-11-10] Project suites green.
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && pnpm typecheck && pnpm lint && pnpm test:run && echo SUITES-GREEN
EXPECT: SUITES-GREEN
EVIDENCE: pending
EVIDENCE: MET exit=0 marker-found :: > faunosteo@0.1.0 typecheck /home/bchanot/Documents/faunosteo-v1-2 > pnpm -r typecheck Scope: 3 of 4 workspace projects packages/core-wasm t…
20. [gated 2026-11-10] `scripts/db-sandbox.sh` gains lines and loses none since b215b89 (its commands unchanged).
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && test "$(git diff --numstat b215b89 -- scripts/db-sandbox.sh | awk '{print ($1>0 && $2==0) ? "ok" : "bad"}')" = ok && echo SANDBOX-ADDITIONS-ONLY
EXPECT: SANDBOX-ADDITIONS-ONLY
EVIDENCE: pending
EVIDENCE: MET exit=0 marker-found :: SANDBOX-ADDITIONS-ONLY
21. [gated 2026-11-10] Untouched: migrations, seed and crates (committed and working tree).
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && git diff --quiet b215b89 -- supabase/migrations supabase/seed crates && test -z "$(git status --porcelain -- supabase/migrations supabase/seed crates)" && echo UNTOUCHED
EXPECT: UNTOUCHED
EVIDENCE: pending
EVIDENCE: MET exit=0 marker-found :: UNTOUCHED
22. [gated 2026-11-10] Nothing real created: no `faunosteo_trial*` container, volume or network, no state folder
(the pattern is first proven on a fixture line, the listings must succeed).
CHECK: printf 'faunosteo_trial_db\n' | grep -q '^faunosteo_trial' && c=$(docker ps -a --format '{{.Names}}') && v=$(docker volume ls --format '{{.Name}}') && n=$(docker network ls --format '{{.Name}}') && ! printf '%s\n%s\n%s\n' "$c" "$v" "$n" | grep -q '^faunosteo_trial' && test ! -e "$HOME/.cache/faunosteo-trial" && echo NOTHING-CREATED
EXPECT: NOTHING-CREATED
EVIDENCE: pending
EVIDENCE: MET exit=0 marker-found :: NOTHING-CREATED
23. [gated 2026-11-10] The untracked review files are kept.
CHECK: test -f /home/bchanot/Documents/faunosteo-v1-2/faunosteo-v1-2-6-revue-ux-chatgpt.md && test -f /home/bchanot/Documents/faunosteo/faunosteo-v1-2-4-revue-chatgpt.md && echo REVIEWS-KEPT
EXPECT: REVIEWS-KEPT
EVIDENCE: pending
EVIDENCE: MET exit=0 marker-found :: REVIEWS-KEPT
24. [gated 2026-11-10] Each lot (A, A2, B1, B2, B3, C) tested, reviewed, committed and pushed before the next; no
merge, no deploy, no real create/start/stop/migrate/restore/destroy/rotation, DEV and the sandbox untouched; the
closure report gives the exact R13 counter-check verdict, test results, security review, the 8 checkpoint items
@@ -260,3 +260,5 @@ merge or deploy; a script's interactive confirmation is never the owner's prior
2026-11-10]); new `apps/app/vite/trial-targets.ts`, `apps/app/tests/unit/vite.trialTargets.test.ts` and
`apps/app/tests/unit/vite.trialConfig.test.ts`
- docs: `docs/development/{SUPABASE,V1-2-6_OWNER_TRIAL,TRIAL_STACK}.md`, `CLAUDE.md`, `.claude/tasks/TODO.md`
- orchestrator artifacts (named after GATE 1, 2026-11-10; not a criterion change): this contract and the plan
`.claude/tasks/plans/2026-11-09-db-trial-stack.md` (review record of every lot and of the R13 counter-check)
@@ -3571,6 +3571,31 @@ bash scripts/db-trial-check.sh # environment-free checks of db:trial and the db
image, default logging, the async Vite config and its port guard at the first real `app` and the next
`db:sandbox trial`). STOP; no `create`.
## Review record (orchestrator)
Each reviewer was a fresh subagent; each fix round went to a fresh executor; the orchestrator re-ran the checks
before every commit.
- Plan challenge (STEP 2b, 2026-11-09): simplicity CONCERNS(3), correctness FATAL(7), robustness CONCERNS(6);
plan revised, correctness re-challenge CONCERNS(2), closed in the plan.
- R13 counter-check (owner condition, 2026-11-10, before lot A2): CONCERNS(5) (5 MAJOR, 4 MINOR) → plan revised →
CONCERNS(3) → plan revised → SOLID (MINOR findings only). Criterion 16's "CONFORME" is this SOLID verdict.
- Lot A (b682f78): spec COMPLIANT; quality CHANGES(6) (6 MINOR) → fixed → APPROVED on re-review.
- Lot A2 (9f60d84): spec COMPLIANT; quality CHANGES(4) (none CRITICAL) → fixed → APPROVED on re-review.
- Lot B1 (1a7b952): spec COMPLIANT; safety CHANGES (4 IMPORTANT, 9 MINOR) → 12 fixes → re-review CHANGES(1)
(`resource_exists`) → fixed; harness 87/0.
- Lot B2 (b85614a): spec COMPLIANT; safety CHANGES REQUIRED (14) → fixed, SIGTERM trap guard fixed → re-review: 14
closed, one IMPORTANT (destroy dead end) → 7 fixes; harness 210/0.
- Lot B3 (3b687a2): spec COMPLIANT (4 MINOR); safety CHANGES REQUIRED (3 IMPORTANT, 4 MINOR) → 11 fixes → re-review:
findings closed, the `app` no-lock comment incomplete → fixed with 5 harness tightenings; harness 323/0.
- Lot C (f7bf0c8): orchestrator read of the diff against the script; one sentence restored to A13's wording (the
practitioner's `admin` exists for O1).
- Closure GATE 0 (2026-11-10): `gates.sh run` MET (8 runnable of 24). GATE 1 verifier: ECARTS(20), 0 NOT-MET: 3
UNVERIFIABLE (15, 16, 24: records and the checkpoint report, written here and in the closure report), 2 files
outside FILE SCOPE (the plan and the contract, now named there), 15 in-file `# shellcheck disable` directives
(SC2016, SC2178 on namerefs, SC2046) that only the owner can authorise; the four in this plan are copies of the
script's.
## Self-review (writing-plans)
- Spec coverage: criteria 1 (lots B1-B3 + package.json), 2-5 (B1 create checks), 6 (B1 state + B2 rotation), 7