docs(app): R1 limits after review

This commit is contained in:
bchanot committed 2026-11-12 13:42:02 +01:00
1 parent 9807ed217a
commit a180b9e291
3 files changed
+12 -5

No files matched your search

+1 -1
View File
@@ -10,7 +10,7 @@ engines are installed. The suites live in `apps/app/e2e`.
| Command | Backend | Dev server | Content |
|---|---|---|---|
| `pnpm e2e:ui` | none | Vite on `127.0.0.1:5191` | `e2e/ui/dialog.spec.ts`: the D13 contract of the shared Dialog on a test page; `e2e/ui/local-tool.spec.ts`: the disclaimer, edit and replace dialogs on the real local-tool routes |
| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer; `e2e/shell/clients.spec.ts`: the client journeys (V1-1.5); `e2e/shell/animals.spec.ts`: the animal and relation journeys (V1-1.6, contract §11.8); `e2e/shell/responsive.spec.ts`: no sideways scroll on nine shell pages, the archive confirmations and the drawer at 320, 360, 375, 390 and 430 px (phone project) and 1280 px, long values, the dashboard e-mail shown whole (RESP-01); `e2e/shell/admin.spec.ts` (V1-2.5): A0 the owner's bootstrap (two TOTP factors from Sécurité, the step-up at `/app/admin` and inside a factor action, no second factor from `aal1`, refresh keeping `aal1` and `aal2`, rights granted and revoked with their reason), A1 a sheet created by an editor on a new inactive species, S1 a species created inactive then activated by the owner, the creation page when the own-grants read fails (« Impossible de vérifier vos autorisations » and « Réessayer », never the form; Retry brings the form back), access per right (a reviewer-only account refused on the creation page), axe and no sideways scroll on every admin page; `e2e/shell/catalogue.spec.ts` (V1-2.5): P1 a reader searches, opens a sheet, picks a zone, reads a retired version, drafts and archived sheets never listed, the same refusal for an existing and an unknown sheet without access, 320, 375 and 430 px with the whole drawing in the box at opening; at 320 and 375 px the zone panel's live region present before a pick and naming the picked zone, the « Références » card starting at or below the drawing's bottom; `e2e/shell/editor-*.spec.ts` (V1-2.6, the draft editor level 1, contract C16 to C34): `editor-drawings` (A2: a hostile file refused with no cleaning box, an Inkscape export cleaned after its preview, a valid file attached, a detail view by crop, the same bytes attached twice), `editor-annotations` (A3: points, zones and links by clicks and by keyboard only, move by drag, a click with jitter never moves, numeric edits, undo and redo, review and delete), `editor-geometry` (a click near a frame edge with the corrected position confirmed and cancelled, an inherited out-of-frame point repaired through the geometry group, a crop change refused when it would invalidate a point, an unmeasured view with its tools disabled, touch-action and a touch drag in real Chromium), `editor-structures` (A4: categories, references, regions, findings tree, reorder, mark reviewed, delete with dependents), `editor-journey` (the steps of `V1-2-6_OWNER_TRIAL.md` §4 with two editor accounts: creation, drawing, findings, annotations, save, reload with the beforeunload dialog and the recovery offer, conflict, submission, the round read back in SQL), `editor-recovery` (two sessions, an older local copy restored then saved over a newer revision, a pending offer blocking edits, an unreadable copy kept until « Ignorer », Escape on the conflict read, the editor grant revoked, the admin role removed and the grant expired under an open session), `editor-access` (a reviewer-only account read-only, the not-found screen for an editor without the admin role and for an admin without a capability, 320, 375 and 800 px read-only, 1 024 px editing, axe on every tab edit and read-only), `editor-deselect` (R1, D5 and D6b: « Désélectionner » with its live region, the focus on the list row and the document unchanged; Escape over the canvas, a field, the delete dialog, the references panel and a tracing; mouse clicks on empty parts deselecting, on annotations selecting; zoom, pan, marker drag and Ctrl+wheel keeping the selection; a typed value applied by the deselecting click; at 1 280 px with `hasTouch` and CDP touch taps near annotations and the canvas bottom deselecting once, drags, two-finger taps and pinch keeping the selection, with the pointer events counted by a recorder; the read-only twin at 375 px and Escape closing « Plus » before deselecting), `editor-equine` (the historical equine sheet opened as a working copy, a copy left active by an earlier run set aside and put back; commit latency on it and on a synthetic document near 2 MiB, printed as `LATENCY` lines and kept as test annotations, budget 500 ms per commit on the equine copy; one empty click on a bone of the horse drawing deselects, D6b). U1 shell (V1-2.6 U1, the four-tab shell): `editor-shell` (kept-mounted places, focus on a named element, the open panel leaving the header and the tab row clickable at 1 024 and 1 280 px, the sidebar from 1 280 px and the drawer, canvas widths), `editor-shell-journeys` (four tabs, cross-tab undo, typed text then the header undo, a refused field kept through a real Shift+Tab to « Annuler », Ctrl+Z outside and inside a field, « Aller à » for each issue kind, the save line from the count to « Enregistrement… » to the time and revision), `editor-shell-crossing` (every edit-onLine truncated
| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer; `e2e/shell/clients.spec.ts`: the client journeys (V1-1.5); `e2e/shell/animals.spec.ts`: the animal and relation journeys (V1-1.6, contract §11.8); `e2e/shell/responsive.spec.ts`: no sideways scroll on nine shell pages, the archive confirmations and the drawer at 320, 360, 375, 390 and 430 px (phone project) and 1280 px, long values, the dashboard e-mail shown whole (RESP-01); `e2e/shell/admin.spec.ts` (V1-2.5): A0 the owner's bootstrap (two TOTP factors from Sécurité, the step-up at `/app/admin` and inside a factor action, no second factor from `aal1`, refresh keeping `aal1` and `aal2`, rights granted and revoked with their reason), A1 a sheet created by an editor on a new inactive species, S1 a species created inactive then activated by the owner, the creation page when the own-grants read fails (« Impossible de vérifier vos autorisations » and « Réessayer », never the form; Retry brings the form back), access per right (a reviewer-only account refused on the creation page), axe and no sideways scroll on every admin page; `e2e/shell/catalogue.spec.ts` (V1-2.5): P1 a reader searches, opens a sheet, picks a zone, reads a retired version, drafts and archived sheets never listed, the same refusal for an existing and an unknown sheet without access, 320, 375 and 430 px with the whole drawing in the box at opening; at 320 and 375 px the zone panel's live region present before a pick and naming the picked zone, the « Références » card starting at or below the drawing's bottom; `e2e/shell/editor-*.spec.ts` (V1-2.6, the draft editor level 1, contract C16 to C34): `editor-drawings` (A2: a hostile file refused with no cleaning box, an Inkscape export cleaned after its preview, a valid file attached, a detail view by crop, the same bytes attached twice), `editor-annotations` (A3: points, zones and links by clicks and by keyboard only, move by drag, a click with jitter never moves, numeric edits, undo and redo, review and delete), `editor-geometry` (a click near a frame edge with the corrected position confirmed and cancelled, an inherited out-of-frame point repaired through the geometry group, a crop change refused when it would invalidate a point, an unmeasured view with its tools disabled, touch-action and a touch drag in real Chromium), `editor-structures` (A4: categories, references, regions, findings tree, reorder, mark reviewed, delete with dependents), `editor-journey` (the steps of `V1-2-6_OWNER_TRIAL.md` §4 with two editor accounts: creation, drawing, findings, annotations, save, reload with the beforeunload dialog and the recovery offer, conflict, submission, the round read back in SQL), `editor-recovery` (two sessions, an older local copy restored then saved over a newer revision, a pending offer blocking edits, an unreadable copy kept until « Ignorer », Escape on the conflict read, the editor grant revoked, the admin role removed and the grant expired under an open session), `editor-access` (a reviewer-only account read-only, the not-found screen for an editor without the admin role and for an admin without a capability, 320, 375 and 800 px read-only, 1 024 px editing, axe on every tab edit and read-only), `editor-deselect` (R1, D5 and D6b: « Désélectionner » with its live region, the focus on the list row and the document unchanged; Escape over the canvas, a field, the delete dialog, the references panel and a tracing; mouse clicks on empty parts deselecting, on annotations selecting; zoom, pan, marker drag and Ctrl+wheel keeping the selection; a typed value applied by the deselecting click; at 1 280 px with `hasTouch` and CDP touch taps near annotations and the canvas bottom deselecting once, drags, two-finger taps and pinch keeping the selection, with the pointer events counted by a recorder; the read-only twin at 375 px and Escape closing « Plus » before deselecting), `editor-equine` (the historical equine sheet opened as a working copy, a copy left active by an earlier run set aside and put back; commit latency on it and on a synthetic document near 2 MiB, printed as `LATENCY` lines and kept as test annotations, budget 500 ms per commit on the equine copy; one empty click on a bone of the horse drawing deselects, D6b). U1 shell (V1-2.6 U1, the four-tab shell): `editor-shell` (kept-mounted places, focus on a named element, the open panel leaving the header and the tab row clickable at 1 024 and 1 280 px, the sidebar from 1 280 px and the drawer, canvas widths), `editor-shell-journeys` (four tabs, cross-tab undo, typed text then the header undo, a refused field kept through a real Shift+Tab to « Défaire », Ctrl+Z outside and inside a field, « Aller à » for each issue kind, the save line from the count to « Enregistrement… » to the time and revision), `editor-shell-crossing` (every edit-oLine truncated
Each suite runs on two Chromium projects: `chromium-desktop` (1280 × 800) and
`chromium-375` (375 × 667, mobile viewport, touch). A test tagged `@phone`
+4 -4
View File
@@ -249,22 +249,22 @@ vous avez créée dans l'interface.
2. Dans « Général », modifiez un nom sans enregistrer. Passez sur « Annotations » et cliquez « Défaire » à droite
de la rangée d'onglets. Attendu : le nom d'origine revient dans « Général » ; « Refaire » le remet. Un champ en
cours de saisie est validé avant « Défaire », donc sa saisie est la dernière modification défaite.
6. Désélection : dans « Annotations », sélectionnez une annotation (le panneau de ses propriétés s'ouvre).
3. Désélection : dans « Annotations », sélectionnez une annotation (le panneau de ses propriétés s'ouvre).
« Désélectionner » (à côté de « Supprimer ») la désélectionne, de même qu'Échap, et le message « Aucune
annotation sélectionnée. » est annoncé. Sélectionnez-la de nouveau, puis cliquez sur un os du dessin, sur un
espace vide du dessin ou sur la marge de la boîte : la sélection est levée, rien n'est ajouté à l'historique.
Un clic sur une autre annotation la sélectionne ; un glisser, un panoramique ou un zoom ne désélectionne pas.
Sur un écran tactile, un appui bref fait de même, un glisser ou un pincement non. Échap depuis le menu latéral
ou l'en-tête de l'application ne fait rien. iOS Safari : à vérifier à la main, non couvert par les tests.
3. Références : le bouton « Références » de l'en-tête ouvre un panneau latéral (non modal) avec une recherche sur
4. Références : le bouton « Références » de l'en-tête ouvre un panneau latéral (non modal) avec une recherche sur
la citation, le DOI et l'URL (« Rechercher une référence »). Dans « Constats », sélectionnez un constat qui cite
une référence : le bouton « n référence(s) » ouvre le même panneau limité à « Citées par « … » (n) », avec « Tout afficher (n) » pour revenir à la liste entière.
« Fermer les références » ou Échap ferme le panneau et rend le focus au bouton qui l'a ouvert.
4. Dans « Annotations », la carte « Vues » propose « Gérer les vues », la carte « Catégories » « Modifier les
5. Dans « Annotations », la carte « Vues » propose « Gérer les vues », la carte « Catégories » « Modifier les
catégories », et une entrée « Régions vertébrales (n régions) » est toujours là. Chacun ouvre sa section pleine largeur avec
« Retour au dessin » en tête. Une saisie commencée dans une section reste là quand vous revenez au dessin puis
rouvrez la section.
5. Redimensionnez la fenêtre à 1 180 px de large. Attendu : le menu latéral de l'application disparaît dans
6. Redimensionnez la fenêtre à 1 180 px de large. Attendu : le menu latéral de l'application disparaît dans
l'éditeur (il revient dès 1 280 px) et s'ouvre en un geste par « Ouvrir le menu » ; le dessin gagne la place
libérée. Sous 1 024 px l'éditeur passe en lecture seule (voir les limites) ; en dessous de 640 px, deux
onglets restent visibles et « Plus » ouvre les deux autres.
@@ -129,6 +129,13 @@ the 188 / 90 / 4 baseline; every new R1 test passed. The criteria below are the
`[data-anno-id]` element and ends as a click deselects. A press that began on an annotation never deselects, even if
it ends elsewhere. A drag, a pan, a zoom, a pinch or a press that gained a second finger never deselects.
- Escape from outside the editor workspace (sidebar, application header) does nothing.
- Escape with the focus on the page (`body`) respects the layers above: an open modal dialog (delete, phone drawer)
keeps the selection, and while the references panel is open Escape closes the panel first and keeps the selection.
In « Plus », Escape typed in a text field or outside the workspace is left alone.
- A pen tap follows the touch rule: the decision is taken in the tap's own click, and only when that click's target is
not an annotation; only the mouse acts at the pointer-up. A hover move after a press is not part of it, and a new
press by the same pointer outside the box cancels a stale one.
- The read-only twin keeps its keyboard pan and zoom (arrows, +, -, 0) when it deselects.
- A value refused as « non appliqué » in the properties panel is lost when the panel closes, as with « Toutes les
annotations ».
- « Toutes les annotations » keeps its focus behaviour: when its row is filtered out, the focus falls to the page.