docs(docs): V1-1.3 dialogs, browser tests and the D11 comparison
Contract §11.6: D13 final behaviour of the native modal dialog, D14 as built against the isolated stack, the three mobile navigation sources and their consequences for Clients and Animaux. BROWSER_TESTS.md: suites, prerequisites, guarantees, failures, limits. TEST_STRATEGY, SUPABASE §5.1, FRONTEND snapshot note, CLAUDE.md.
This commit is contained in:
1 parent
9b2a4bc6fc
commit
9cd33f1217
6 files changed
+196
-16
No files matched your search
@@ -50,8 +50,9 @@ Product roadmap (owner, 2026-10-25): P0 docs, then V1-1 clients and animals, V1-
|
||||
V1-3 cloud bilans, V1-4 stored PDF and sharing, V1-5 mobile and accessibility pass
|
||||
(`docs/development/IMPLEMENTATION_PLAN.md` §0; V1-1 contract `docs/development/V1-1_OWNERS_ANIMALS.md`:
|
||||
business decisions ratified 2026-10-25, BDR-073; architecture and N1-N9 validated, BDR-074; on
|
||||
`feature/v1-1-clients-animals` V1-1.1 (validated) and V1-1.2 are built: migrations `20261025100000_workspaces.sql` and
|
||||
`20261025110000_clients.sql`, tested on PGlite and the isolated stack `pnpm db:sandbox`, not applied to Supabase DEV).
|
||||
`feature/v1-1-clients-animals` V1-1.1 and V1-1.2 (validated) and V1-1.3 are built: migrations `20261025100000_workspaces.sql` and
|
||||
`20261025110000_clients.sql`, tested on PGlite and the isolated stack `pnpm db:sandbox`, not applied to Supabase DEV; V1-1.3 the
|
||||
native modal dialog (D13) and the Playwright + axe suites (D14, `docs/development/BROWSER_TESTS.md`)).
|
||||
|
||||
---
|
||||
|
||||
@@ -71,6 +72,7 @@ business decisions ratified 2026-10-25, BDR-073; architecture and N1-N9 validate
|
||||
| SVG raster | native Image/canvas (no dependency) | — |
|
||||
| Animation | motion | 11 |
|
||||
| Tests | vitest + happy-dom + @testing-library/react | 3.x |
|
||||
| Browser tests | @playwright/test (Chromium 1248) + @axe-core/playwright, pinned dev deps of apps/app (`docs/development/BROWSER_TESTS.md`) | 1.64.1 / 4.14.0 |
|
||||
| Backend | Supabase (PostgreSQL 17, GoTrue, PostgREST) — CLI pinned as root devDependency | CLI 2.120 |
|
||||
| DB client | @supabase/supabase-js (packages/supabase) | 2.x |
|
||||
| SQL tests | pgTAP under supabase/tests, run by `supabase test db` and by PGlite (Dockerless) | PGlite 0.3 |
|
||||
@@ -123,7 +125,7 @@ pnpm db:reset # replay from zero
|
||||
pnpm db:test # pgTAP on the real stack
|
||||
pnpm db:types # regenerate packages/supabase/src/database.types.ts
|
||||
pnpm db:types:check # CI diff
|
||||
pnpm db:sandbox up fresh|up upgrade <version>|test-db|types [--check]|test|down # throwaway stack (SUPABASE.md §5.1): migrations tested without touching DEV
|
||||
pnpm db:sandbox up fresh|up upgrade <version>|test-db|types [--check]|test|e2e-shell|down # throwaway stack (SUPABASE.md §5.1): migrations tested without touching DEV
|
||||
|
||||
# Reference sheet in the app: the dev server bundles the curated draft; a build does not
|
||||
pnpm build:preview # SHEET_BUNDLE=draft build (manual validation, preview deployments)
|
||||
@@ -178,8 +180,15 @@ or call `corepack pnpm <cmd>`. Root scripts resolve `node_modules/.bin/pnpm`.
|
||||
```bash
|
||||
pnpm test:run # vitest run — all tests, single pass, CI-safe
|
||||
pnpm test # vitest watch — dev loop
|
||||
pnpm e2e:ui # Playwright Chromium, no backend: Dialog test page + local tool dialogs, desktop + 375 px, axe (in check:all when the pinned Chromium is installed)
|
||||
pnpm e2e:shell # Playwright Chromium against `pnpm db:sandbox` (must be up): sign-in, dashboard, photo confirmation, phone drawer; never DEV
|
||||
```
|
||||
|
||||
Browser suites (`apps/app/e2e`, `docs/development/BROWSER_TESTS.md`): Chromium only until V1-5,
|
||||
`pnpm --filter @faunosteo/app exec playwright install chromium` once (no sudo, never `--with-deps`);
|
||||
loopback dev servers of their own (5191, 5192, `--strictPort`, never reused); every request outside the
|
||||
suite's allowlist is aborted and fails the test; the shell suite keeps no trace (session tokens).
|
||||
|
||||
Test files live in `apps/app/tests/unit/*.test.ts(x)`; golden fixtures in
|
||||
`apps/app/tests/fixtures/`. The 612 legacy catalog leaves run through the v2 → v3 migration
|
||||
in the core (`crates/core/tests/curation_leaves.rs`, against the draft document) and the app (sheet index + PDF roundtrip). Setup: `apps/app/tests/setup.ts` imports
|
||||
@@ -235,7 +244,7 @@ faunosteo/
|
||||
│ │ └─ practitionerCache.ts ← localStorage prefill
|
||||
│ ├─ anatomy/drawing.ts ← the core's composed view (`view.canvas`) → DOMParser → importNode (R3; no sanitiser here)
|
||||
│ ├─ components/
|
||||
│ │ ├─ ui/{Button,ButtonLink,Card,Dialog,Input,Label,Select,Textarea,Badge,Chip,Icon,FormField,Notice}.tsx
|
||||
│ │ ├─ ui/{Button,ButtonLink,Card,Dialog,ModalDialog,Input,Label,Select,Textarea,Badge,Chip,Icon,FormField,Notice}.tsx ← ModalDialog: native <dialog> showModal (D13), Dialog and MobileDrawer on it
|
||||
│ │ ├─ canvas/{AnatomyCanvas,DetailModal}.tsx
|
||||
│ │ ├─ observation/{ObservationList,ObservationCard,ObservationPickers,FindingsTreePicker,
|
||||
│ │ │ VertebraPicker,SeveritySelector,LateralityPicker,
|
||||
@@ -256,6 +265,7 @@ faunosteo/
|
||||
├─ tests/
|
||||
│ ├─ setup.ts
|
||||
│ └─ unit/*.test.ts
|
||||
├─ e2e/ ← Playwright (V1-1.3): playwright.{ui,shell}.config.ts, support/{browser,sandbox}.ts, ui/*.spec.ts, shell/*.spec.ts, harness/dialog.{html,tsx} (dev server only, never built)
|
||||
├─ docker/
|
||||
│ ├─ entrypoint.sh ← injects env.js at container start
|
||||
│ └─ nginx.conf ← SPA fallback + PORT envsubst
|
||||
@@ -476,7 +486,8 @@ Database (Supabase)
|
||||
### Environments and LAN access (docs/development/ENVIRONMENTS.md)
|
||||
- The owner tests from other devices of the private network, never on the Ubuntu machine: every test surface
|
||||
(app, Supabase API, Mailpit, Studio) is addressed by the DEV origin (`scripts/dev-env.sh`, `FAUNOSTEO_DEV_HOST`),
|
||||
never by `127.0.0.1` / `localhost`, never hard-coded in a source. The Supabase CLI runs only through
|
||||
never by `127.0.0.1` / `localhost`, never hard-coded in a source (the automated browser suites are not a
|
||||
surface for other devices: their dev servers and the sandbox stay on 127.0.0.1). The Supabase CLI runs only through
|
||||
`scripts/supabase.sh` (`pnpm db:*`, `pnpm supabase`): config.toml reads the origin with `env()`.
|
||||
- Exposure (least privilege, `pnpm dev:net-check`): LAN gets Vite 5173, the Supabase API 54321 and Mailpit
|
||||
behind basic auth through the DEV gateway (`pnpm dev:gateway`, nginx, `faunosteo_dev_gateway`, 54325). The CLI
|
||||
|
||||
@@ -0,0 +1,113 @@
|
||||
# Browser tests (Playwright and axe)
|
||||
|
||||
Status: V1-1.3, 2026-10-25 (decision D14, `V1-1_OWNERS_ANIMALS.md` §12.5).
|
||||
Chromium only until V1-5. The suites live in `apps/app/e2e`.
|
||||
|
||||
## 1. Suites
|
||||
|
||||
| Command | Backend | Dev server | Content |
|
||||
|---|---|---|---|
|
||||
| `pnpm e2e:ui` | none | Vite on `127.0.0.1:5191` | `e2e/ui/dialog.spec.ts`: the D13 contract of the shared Dialog on a test page; `e2e/ui/local-tool.spec.ts`: the disclaimer, edit and replace dialogs on the real local-tool routes |
|
||||
| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer |
|
||||
|
||||
Each suite runs on two Chromium projects: `chromium-desktop` (1280 × 800) and
|
||||
`chromium-375` (375 × 667, mobile viewport, touch). A test tagged `@phone`
|
||||
runs on the phone project only (the drawer has no desktop counterpart). Both
|
||||
languages run: the local tool and the shell through the browser locale and
|
||||
the account's locale, the test page through `?lang=en`.
|
||||
|
||||
The test page `e2e/harness/dialog.html` is served by the dev server only
|
||||
(`/e2e/harness/dialog.html`); the build has one entry, `index.html`, so it
|
||||
never ships. It holds the D13 cases (basic, long content, refused close,
|
||||
vanishing opener) and no product journey.
|
||||
|
||||
The shell suite never reaches DEV. Its dev server is built with the Supabase
|
||||
URL `http://sandbox.faunosteo.invalid` (a name that resolves nowhere,
|
||||
RFC 6761); `e2e/support/sandbox.ts` replays `/auth/v1`, `/rest/v1` and
|
||||
`/storage/v1` on the sandbox's loopback ports, the way Kong maps them on the
|
||||
CLI stack. Each test creates its own confirmed account through the sandbox's
|
||||
GoTrue admin API (random address under `sandbox.local`, random password, a
|
||||
fictitious display name, the profile locale of the test), and seeds the clean
|
||||
avatar the worker would have produced (the `assets` row as postgres, the
|
||||
object with the service key). `pnpm db:sandbox down` removes all of it.
|
||||
|
||||
## 2. Prerequisites
|
||||
|
||||
- The repository's Node and pnpm, `pnpm install`.
|
||||
- The Chromium build of the pinned Playwright (1.64.1, Chromium 1248):
|
||||
`pnpm --filter @faunosteo/app exec playwright install chromium`. It
|
||||
downloads into `~/.cache/ms-playwright` and needs no `sudo`. Never pass
|
||||
`--with-deps`: it installs system packages with `sudo`, an owner action. On
|
||||
the Ubuntu development machine the headless shell runs with the libraries
|
||||
already present.
|
||||
- `pnpm wasm:build`: the local tool runs the core, and the UI suite stops on a
|
||||
missing or stale module (`packages/core-wasm/tests/global-setup.ts`).
|
||||
- For `pnpm e2e:shell`: Docker (rootless works) and the sandbox up,
|
||||
`pnpm db:sandbox up fresh` (or `up upgrade <version>`).
|
||||
- Ports 5191 and 5192 free: each server uses `--strictPort` and is never
|
||||
reused, so the owner's `pnpm dev` on 5173 is never picked up by mistake.
|
||||
|
||||
## 3. Guarantees
|
||||
|
||||
- Request guard (`e2e/support/browser.ts`, automatic in every test): an
|
||||
allowlist of origins per suite (the dev server, plus the fake Supabase
|
||||
origin for the shell). Any other request, DEV's API on the LAN address
|
||||
included, is aborted and fails the test with its URL.
|
||||
- No fixture value in a URL: the local tool's names and the shell account's
|
||||
email, password and display name are checked against every request URL;
|
||||
a match fails the test and the report masks the value.
|
||||
- axe (`@axe-core/playwright` 4.14.0, rules tagged WCAG 2.0 to 2.2 A and AA
|
||||
plus best practices): zero serious or critical violation on each scanned
|
||||
state, colours measured once animations have settled. Three pre-existing
|
||||
findings, outside the V1-1.3 code, are let through by exact node and listed
|
||||
with their reason in `KNOWN_VIOLATIONS` and in TODO RR-7: the language
|
||||
switcher's names (« FR » shown, « Passer en français » announced), the top
|
||||
bar account link (display name shown, « Mon compte » announced), the
|
||||
dashboard's `dl` holding a status row without `dt`/`dd`.
|
||||
- Reports: `apps/app/e2e/test-results/` and `apps/app/e2e/playwright-report/`,
|
||||
git-ignored. The UI suite keeps a trace and a screenshot of a failed test
|
||||
(no backend, no secret). The shell suite keeps a screenshot only: a trace
|
||||
would hold the session tokens and the typed password.
|
||||
|
||||
## 4. Reading a failure
|
||||
|
||||
The terminal shows each step and the failing assertion. The HTML report:
|
||||
`pnpm --filter @faunosteo/app exec playwright show-report e2e/playwright-report/ui`
|
||||
(or `.../shell`); a UI trace: `pnpm --filter @faunosteo/app exec playwright
|
||||
show-trace <path printed in the failure>`. Setup failures are named: a missing
|
||||
Chromium (Playwright prints the install command), a stale core module
|
||||
(`run pnpm wasm:build`), the shell suite outside its wrapper
|
||||
(`SANDBOX_ANON_KEY missing: run pnpm e2e:shell`), the sandbox down
|
||||
(`db-sandbox: not running`).
|
||||
|
||||
## 5. In `pnpm check:all` and a future CI
|
||||
|
||||
`pnpm check:all` runs `pnpm e2e:ui` when the pinned Chromium is installed;
|
||||
otherwise it prints `SKIPPED` with the reason and the install command, and
|
||||
goes on. `pnpm e2e:shell` needs the sandbox and stays a separate run, like
|
||||
`pnpm e2e:avatar`. A CI runner installs the same Chromium
|
||||
(`playwright install chromium` in its image) and runs `pnpm e2e:ui`; the shell
|
||||
suite needs Docker in the runner for the sandbox.
|
||||
|
||||
## 6. Limits
|
||||
|
||||
- Chromium only. Firefox, WebKit and the 412 × 915 viewport join at V1-5
|
||||
(contract §12.5). WebKit's system libraries may need `sudo` (owner action).
|
||||
Desktop WebKit is not iOS Safari: the owner's manual check on a real iPhone
|
||||
and on a computer over the LAN stays a validation criterion of every mobile
|
||||
step.
|
||||
- Tab past a modal dialog's last control reaches the browser's own interface
|
||||
for one step, then the first control (the platform's behaviour, D13); the
|
||||
page behind is never reached. The tests assert exactly that walk.
|
||||
- Safari does not focus a button on a pointer click, so a dialog opened by a
|
||||
click has no opener to return to there; a keyboard opening always has one.
|
||||
- The vitest suites (happy-dom) cover the React wiring of the dialogs only:
|
||||
happy-dom has no top layer, no inertness and no dialog focusing steps.
|
||||
|
||||
## 7. Adding a test
|
||||
|
||||
Import `test` and `expect` from `e2e/support/browser.ts` (the request guard
|
||||
comes with them), read every visible string from `@/i18n/{fr,en}`, use
|
||||
fictitious values only, and pass the values a test creates to
|
||||
`requests.forbid(...)`. A new backend origin goes into the suite's
|
||||
`allowedOrigins`, never into a wildcard.
|
||||
@@ -9,7 +9,10 @@ Edge Functions are retired (D-R9), the packages `domain`, `anatomy`, `pdf` and
|
||||
pdf-lib were replaced by `crates/core` and deleted (R4.8, R5.7), the legacy
|
||||
editors and `public/species` were deleted at Step 5, no TanStack Query
|
||||
(BDR-041), the public site framework is Astro (D-R8). `CLAUDE.md` (folder map,
|
||||
architecture) is the current description.
|
||||
architecture) is the current description. V1-1.3 (2026-10-25): every modal
|
||||
(`Dialog`, the mobile drawer) is built on `components/ui/ModalDialog.tsx`, the
|
||||
native `<dialog>` in modal mode (behaviour in `V1-1_OWNERS_ANIMALS.md` §11.6),
|
||||
and the real-browser suites live in `apps/app/e2e` (`BROWSER_TESTS.md`).
|
||||
|
||||
## 1. Starting point
|
||||
|
||||
|
||||
@@ -345,6 +345,7 @@ Docker.
|
||||
| `pnpm db:sandbox test-db` | `supabase test db --db-url`: the pgTAP files on the real image (rows unchanged afterwards) |
|
||||
| `pnpm db:sandbox types [--check]` | `supabase gen types --db-url ... --schema public` through Prettier, written or diffed with the committed file |
|
||||
| `pnpm db:sandbox test` | `packages/supabase/tests/sandbox/*.sandbox.ts`: real GoTrue and PostgREST sessions, concurrent SQL sessions |
|
||||
| `pnpm db:sandbox e2e-shell` (= `pnpm e2e:shell`) | the authenticated `/app` shell in Chromium (`apps/app/e2e/shell`, `docs/development/BROWSER_TESTS.md`): a loopback dev server whose Supabase calls are replayed on the sandbox, fictitious accounts per test |
|
||||
| `pnpm db:sandbox sql` / `down` | psql as postgres on stdin / remove the stack |
|
||||
|
||||
Every CLI call passes `--db-url` with `sslmode=disable` (the sandbox has no
|
||||
|
||||
@@ -21,6 +21,11 @@ pgTAP files (`013_clients.sql`, 130 checks; 661 in all); the isolated stack is
|
||||
a project tool (`pnpm db:sandbox`, SUPABASE.md §5.1) with its own suite under
|
||||
`packages/supabase/tests/sandbox` (28 real-stack checks: HTTP per role,
|
||||
concurrency, budget races, 20 000-client search timing).
|
||||
V1-1.3 (2026-10-25): the first real-browser suites (D14,
|
||||
`docs/development/BROWSER_TESTS.md`): Playwright 1.64.1 with axe 4.14.0 on
|
||||
Chromium, desktop and 375 × 667, under `apps/app/e2e`. `pnpm e2e:ui` (no
|
||||
backend) 26 cases, `pnpm e2e:shell` (isolated stack) 6 cases; vitest app 458
|
||||
(Dialog and avatar confirmation wiring added).
|
||||
|
||||
## 1. Layers
|
||||
|
||||
@@ -31,7 +36,7 @@ concurrency, budget races, 20 000-client search timing).
|
||||
| Integration (app ↔ local Supabase) | vitest with `supabase start`, test users created via the admin API in a fixture | `apps/app/tests/integration` | CI job with the Supabase stack |
|
||||
| Database (schema, functions, triggers) | pgTAP via `supabase test db` | `supabase/tests/db` | CI, before app tests |
|
||||
| RLS | pgTAP, per table, per role | `supabase/tests/rls` | CI, release gate |
|
||||
| End-to-end | Playwright against `pnpm preview` + local Supabase | `apps/app/e2e` | CI nightly + release gate |
|
||||
| End-to-end | Playwright and axe on Chromium (desktop, 375 px) against a loopback Vite dev server: no backend (`pnpm e2e:ui`) or the isolated stack (`pnpm e2e:shell`), never DEV; request allowlist, fixture values kept out of URLs | `apps/app/e2e` (`docs/development/BROWSER_TESTS.md`) | `e2e:ui` in `pnpm check:all` when the pinned Chromium is installed (SKIPPED line otherwise); `e2e:shell` by hand with `pnpm db:sandbox up`; CI nightly + release gate planned |
|
||||
| Migration | `supabase db reset` from zero + seed + regression fixtures | CI | every PR touching `supabase/` |
|
||||
| PDF regression | cargo: the R4 oracles (O1 draw logs, O2 PDFs, O4 to O10) and the R4 digests of the writer's own bytes; vitest: the Step 6 goldens read back from the app export's file (`tests/helpers/pdfFile.ts`, no pdf-lib), the attachment roundtrip through the module's reader, the N-1 readers | `crates/core/tests/pdf_*.rs`, `apps/app/tests/unit/pdf.*.test.ts`, `packages/core-wasm/tests/pdf-*.test.ts` | CI |
|
||||
| SQL/TS contract | generated types diff check | CI | every PR touching `supabase/` |
|
||||
|
||||
@@ -1117,12 +1117,58 @@ project's design workflow.
|
||||
|
||||
Every field labelled; errors announced; focus to the page heading on
|
||||
navigation and to the first error on submit; visible focus; nothing reachable
|
||||
only by pointer; confirmation dialogs with focus containment (the `inert`
|
||||
attribute on the rest of the page while open) and focus restored to the
|
||||
opener, no new dependency (D13);
|
||||
only by pointer; confirmation dialogs with focus containment and focus
|
||||
restored to the opener, no new dependency (D13, final behaviour in §11.6);
|
||||
status changes (saved, archived) announced through a live region; an axe check
|
||||
per screen in the browser tests.
|
||||
|
||||
### 11.6 V1-1.3 as built (2026-10-25)
|
||||
|
||||
D13, final behaviour. `components/ui/ModalDialog.tsx` is the one modal
|
||||
primitive, on the platform's `<dialog>` and `showModal()` (no dependency: none
|
||||
of the project's dependencies holds an accessibility primitive, and the
|
||||
browser's modal dialog is the proven one). `Dialog` and the mobile drawer are
|
||||
built on it.
|
||||
|
||||
| Need | Behaviour |
|
||||
|---|---|
|
||||
| Name and description | the `<dialog>` is named by its visible title (`aria-labelledby`); `Dialog`'s optional `description` is wired with `aria-describedby`; the four confirmations pass their message there (photo removal, replace session, held session, sheet disclaimer); long bodies (forms, drawings) carry no description; the drawer is named « Navigation principale » |
|
||||
| Opening | focus on the first control of the dialog (the close button for `Dialog`, the brand link for the drawer), set explicitly: Chromium would otherwise focus a scrollable panel when the content is long |
|
||||
| Containment | the rest of the page is inert (top layer): no focus, no click, no screen-reader access; the page does not scroll behind (`html:has(dialog:modal)`); Tab past the last control reaches the browser's own interface for one step, then the first control again, never the page (the platform's choice, kept: no hand-written trap) |
|
||||
| Escape and close requests | a request to the consumer through `onClose`, never a close by itself: the dialog leaves only when the consumer stops rendering it. The Escape keydown is cancelled, so Chromium's rule that closes a dialog on a second Escape after a cancelled one never applies; a close the platform forces anyway is reported to the consumer |
|
||||
| Closing controls | the close button (« Fermer » / « Close »), the backdrop and the consumer's own buttons, all through the same request |
|
||||
| Focus return | after the commit, to the opener when it can still take focus; otherwise to the first control of the opener's nearest container still on the page; nothing when the dialog opened without a focused opener (the disclaimer at editor load) |
|
||||
| Pending actions | a confirmation whose action is in flight refuses to close (Escape, Cancel, backdrop) and closes when the action settles: the photo removal now does so, so focus moves past the vanished button instead of falling on the page |
|
||||
|
||||
Closing a dialog is never a save or a confirmed cancel: the consumer decides
|
||||
what a request means. The V1-1 forms are full pages (§11.4), so the unsaved
|
||||
changes confirmation of §11.3 belongs to the page, not to a dialog.
|
||||
|
||||
D14, as built. `@playwright/test` 1.64.1 and `@axe-core/playwright` 4.14.0
|
||||
(axe-core 4.14.0), dev dependencies of `apps/app`, pinned; five packages in
|
||||
the lockfile (Apache-2.0 for Playwright, MPL-2.0 for axe, used unmodified).
|
||||
`pnpm e2e:ui` (no backend) and `pnpm e2e:shell` (the isolated stack), Chromium
|
||||
desktop and 375 × 667; details, guarantees and limits in
|
||||
`docs/development/BROWSER_TESTS.md`. Deviation from §12.5: the suites run
|
||||
against the isolated stack, not against DEV, which holds neither M1 nor M2 and
|
||||
stays untouched (owner choice, 2026-10-25).
|
||||
|
||||
D11, the mobile navigation conflict, documented for the decision before
|
||||
V1-1.6 (owner, 2026-10-25: no tab bar in V1-1.3, current navigation kept, the
|
||||
validated mockups unchanged).
|
||||
|
||||
| Source | Mobile navigation |
|
||||
|---|---|
|
||||
| Implemented | top bar (menu button, brand, language switcher, avatar link to Mon compte); the drawer (modal since V1-1.3) with the sidebar entries Tableau de bord, Mon compte, Outil de bilan, then the user badge and « Se déconnecter »; no bottom tab bar |
|
||||
| Validated mockups (`docs/design/README.md` items 5 to 7) | the same drawer, plus a bottom tab bar on the dashboard and the profile: Accueil, Bilans, Agenda, Profil; the README places the bar « with the first list screens » |
|
||||
| D11 recommendation (§13.3) | drawer only in V1-1; the mockup's tab bar arrives with Bilans (V1-3), when its entries lead somewhere |
|
||||
|
||||
| Option for the Clients and Animaux routes | Consequence |
|
||||
|---|---|
|
||||
| Drawer only (D11) | Clients and Animaux join the drawer and the sidebar; two taps from any page; no destination that leads nowhere; the README line moves to V1-3 once decided |
|
||||
| The mockup's bar now | Bilans and Agenda lead nowhere until V1-3 and later (hidden or disabled tabs); Clients and Animaux stay in the drawer anyway; a fixed bottom bar competes with the save action that §11.4 keeps reachable with the keyboard open |
|
||||
| A bar adapted to V1-1 (Accueil, Clients, Animaux, Profil) | one tap to the V1-1 screens; departs from the validated mockup, so it needs a new validated design file first; the bar changes again when Bilans and Agenda arrive |
|
||||
|
||||
---
|
||||
|
||||
## 12. Tests and Definition of Done
|
||||
@@ -1205,8 +1251,9 @@ key parity.
|
||||
|
||||
### 12.5 Real browsers (Playwright and axe, D14)
|
||||
|
||||
A suite under `apps/app/e2e`, run against `pnpm dev` and the local stack on the
|
||||
DEV origin. In V1-1: Chromium, desktop and a 375 × 667 phone viewport (Firefox,
|
||||
A suite under `apps/app/e2e`, run against the isolated stack of
|
||||
`pnpm db:sandbox` and a loopback dev server of its own (V1-1.3 deviation: DEV
|
||||
holds neither M1 nor M2 and stays untouched, §11.6). In V1-1: Chromium, desktop and a 375 × 667 phone viewport (Firefox,
|
||||
WebKit and 412 × 915 join at V1-5: WebKit's system libraries need `sudo`, a
|
||||
user action, and desktop WebKit is not iOS Safari, which the owner's real
|
||||
phone covers); journeys 1 to 7 of §11.2; the creation journey with the
|
||||
@@ -1276,10 +1323,10 @@ Not ratified; recommendation and impact given.
|
||||
| Id | Decision | Recommendation | Impact |
|
||||
|---|---|---|---|
|
||||
| D10 | Client information notice: text, and whether the app records that it was given | decide with the legal texts; nothing shown or recorded in V1-1 | none in V1-1; recording it later adds a column; required before public exposure |
|
||||
| D11 | Mobile navigation | drawer only in V1-1; the mockup's tab bar (Accueil, Bilans, Agenda, Profil) arrives with Bilans (V1-3), since two of its four entries would lead nowhere today. `docs/design/README.md` says the tab bar comes "with the first list screens": the README line is updated once D11 is decided | UI |
|
||||
| D11 | Mobile navigation (V1-1.3: current navigation kept, the three sources and their consequences in §11.6; decision before V1-1.6) | drawer only in V1-1; the mockup's tab bar (Accueil, Bilans, Agenda, Profil) arrives with Bilans (V1-3), since two of its four entries would lead nowhere today. `docs/design/README.md` says the tab bar comes "with the first list screens": the README line is updated once D11 is decided | UI |
|
||||
| D12 | Dashboard tiles | the two real tiles (clients, animals) now, from live counts; bilans and appointments when their tables exist | UI |
|
||||
| D13 | Shared `Dialog` focus containment and restore | fix it in V1-1 with `inert` and a restore to the opener, no dependency (it also improves the editor's dialogs; partial RR-7) | shared component |
|
||||
| D14 | Real-browser test tooling | `@playwright/test` and `@axe-core/playwright` as dev dependencies of `apps/app`; Chromium only in V1-1, Firefox and WebKit at V1-5 | manifest and lockfile change at step V1-1.3; a browser download |
|
||||
| D13 | Shared `Dialog` focus containment and restore | approved 2026-10-25, built in V1-1.3 on the native modal dialog (§11.6) | shared component |
|
||||
| D14 | Real-browser test tooling | approved 2026-10-25, built in V1-1.3: Playwright 1.64.1 and axe 4.14.0, Chromium desktop and 375 px, against the isolated stack (§11.6) | manifest and lockfile; Chromium build 1248, no `sudo` |
|
||||
| D17 | Bridge to the local tool (« start a bilan for this animal », prefill only) | no: V1-3 links bilans to animals properly; a prefill now would be a second path to delete later | none |
|
||||
| U1 | Long lists | « Afficher plus » (keyset pages of 25), no numbered pages | UI |
|
||||
| U2 | Archived records | one « archivés » toggle on each list, not a separate tab | UI |
|
||||
@@ -1306,7 +1353,7 @@ validates after V1-1.1 and after the first UI step; nothing merges into
|
||||
|---|---|
|
||||
| V1-1.1 | Workspaces: M1 (with the correlation header cap), helpers, trigger, backfill, RLS, pgTAP `012`. Written and tested on an isolated stack (§8.1), awaiting the owner's checkpoint; not applied to DEV |
|
||||
| V1-1.2 | Clients data: M2, RPCs, searches, D15 guards (budget per workspace, its lock), N9 audit policy, field limits and parity test, sandbox suite. Written and tested on the isolated stack (§8.2), awaiting the owner's checkpoint; not applied to DEV |
|
||||
| V1-1.3 | UI foundations: Playwright Chromium and axe (D14), `Dialog` containment and restore (D13) |
|
||||
| V1-1.3 | UI foundations: Playwright Chromium and axe (D14), `Dialog` containment and restore (D13). Built (§11.6), awaiting the owner's checkpoint |
|
||||
| V1-1.4 | Animals and relations data: M3 with the species rows, RPCs, history rules, D9a proof |
|
||||
| V1-1.5 | Clients UI: routes, forms, list and search, archive, navigation entry |
|
||||
| V1-1.6 | Animals and relations UI, navigation (D11), dashboard tiles (D12), documents, Definition of Done |
|
||||
|
||||
Reference in new issue
Block a user