chore(memory): R5.7 pre-merge, LRN-078, LRN-079, EVAL-033
This commit is contained in:
1 parent
97529f95b8
commit
9992f23b26
4 files changed
+26
-1
No files matched your search
@@ -235,3 +235,9 @@ Action: rerun gate after every patch extension, claim only measured state; patch
|
||||
Method: isolated worktree (patch + switched seed), rust:check + check:all green, fresh security + verifier (opus), verifier probe on core export API.
|
||||
Anomalies: RUST.md said M1 "needs fingerprint_verified" for every consumer; export path (input.rs) never sees LoadedSheet → v0 sheet snapshot gets alias at export (app unreachable, API reachable). Fix needs snapshot_rules.rs, outside owner's 8-file scope → stopped. Also `pnpm format` rewrote append-only audits in worktree (reverted).
|
||||
Action: claim a guard per call site, not per design; owner decision on snapshot_rules.rs; never run format over .claude/.
|
||||
|
||||
## EVAL-033 | 2026-10-25 | R5.7 closure: deletion gates + pre-merge rerun
|
||||
|
||||
Method: ledger 407 TS cases case by case before `git rm`; fresh verifier + security (opus) twice; check:all on R5.7 state, then rerun on 27bf59c after post-check edits; verifier ran 14 scratch reintroduction probes against census.
|
||||
Anomalies: round 1 verifier ECARTS(2): contract C6 "tsx gone" false vs pnpm optional peer (owner Clarification), digest typo `…dfe7` in docs. Two edits landed after first check:all → owner required full rerun. Census regex accepted `#[ignore]` targets (fixed) and still accepts ignore-before-test (LOW). Docs pointed to premerge record before it existed; `.bin/tsx` wording root-only; SUPABASE.md layout stale since R2. `pnpm audit` never run before this round (cargo advisories only): 57 pre-existing.
|
||||
Action: LRN-078, LRN-079; rerun gate after any post-check edit; run `pnpm audit` in every pre-merge round; checkpoint to owner, STOP before merge.
|
||||
@@ -376,3 +376,7 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
|
||||
- Owner validated R5.6, authorised R5.7. Census: anatomy 144 + domain 263 TS cases mapped; 15 anatomy contracts + 1 domain oracle only TS checked → ported to Rust first (+19 tests, curation_leaves.rs).
|
||||
- Deleted anatomy, domain, TS upload script, legacy scripts; LEDGER.tsv 407 (256/149/2), FILES.tsv 112; fixtures moved sha kept; xmldom out; tsx left as vite optional peer.
|
||||
- TS replay rehearsed at 59521dc + 756b7ef. check:all green 03:58:13; security PASS 2 LOW; verifier ECARTS(2): tsx residue (owner), digest typo fixed. STOP before merge.
|
||||
|
||||
## 2026-10-25 (R5.7 pre-merge)
|
||||
- Owner validated R5.7, accepted tsx as vite optional peer → C6 Clarification. Census now refuses `#[ignore]` ledger targets (cd69f0e). 149 replaced rows checked active, 2 deletions checked.
|
||||
- Rerun on 27bf59c: frozen install, dedupe, check:all green 13:41:41, --check 0 diff, report:compare ok; security PASS (pnpm audit 57 pre-existing, MEDIUM); verifier CONFORME 10/10. LRN-078, LRN-079, EVAL-033. STOP before merge.
|
||||
@@ -561,3 +561,15 @@ Apply: any tool touching a real service with a privileged key: stub tests in `ca
|
||||
Context: R5.6 M1. Alias granted at export from snapshot's claimed value; export never saw the loaded sheet. Load-time flag alone also insufficient (pub mutable document/reference).
|
||||
Pattern: put the decision where the evidence object lives (build_sheet_snapshot holds LoadedSheet), keep private verified state set only by the trusted constructor, and recompute the proof at decision time; every other site stays strict equality. Make the raw comparison crate-private so no caller can skip the proof.
|
||||
Apply: any equivalence/allowlist privilege (aliases, migrations, trust marks): one decision method on the verified object, recompute, strict elsewhere, negative tests on the direct API not just app paths.
|
||||
|
||||
## LRN-078 | 2026-10-25 | Before deleting old engine, census contracts only its test code checks
|
||||
|
||||
Context: R5.7. Oracles + Rust parity looked full; case-by-case map of 407 TS cases found 15 anatomy + 1 domain contracts no Rust test checked (612-leaf fates, 26 legacy ids, region inference, R5.1 ledger rows, overlay removal, halo, CHG-000, dollar tag, viewBox, cite of added ref, move via renamed path, folder file list, map vs oracle per entry). Oracle generators' own asserts carried them.
|
||||
Pattern: ledger row per old case (contract, disposition, live target, oracle); census test checks target is non-ignored `#[test]` fn and oracle file exists; port gaps before `git rm`.
|
||||
Apply: any engine deletion (R-phases): map every case first, "oracle covers it" is a claim to prove per case. Owner validated 2026-10-25.
|
||||
|
||||
## LRN-079 | 2026-10-25 | Optional peer in lockfile ≠ live use of deleted engine
|
||||
|
||||
Context: R5.7 C6. After removing anatomy, `tsx` stayed in pnpm-lock.yaml as vite's optional peer (`optional: true`, no importer, no bin); `pnpm install` keeps it, `dedupe --check` clean; only hand edit/override would drop name. Contract said "tsx gone" → false NOT-MET.
|
||||
Pattern: prove use by `pnpm why <pkg> -r` path + importer blocks + manifest/script/source census, not lockfile name grep. Never hand-edit lockfile or add override just to drop a name.
|
||||
Apply: dependency-removal clauses state objective (no declared dep, no script, no import), allow transitive/optional peers; census guards declared deps and `optional: true`. Owner validated 2026-10-25.
|
||||
@@ -356,7 +356,10 @@ feat/findings-tree-v2 merged (FindingsTreePicker tracked in HEAD); all work belo
|
||||
- [x] R5.7d census tests (r4 xmldom inverted + non-vacuity, R5 census, ESLint ban)
|
||||
- [x] R5.7e historical reproducibility documented and rehearsed (59521dc: git status clean, 144+262; 756b7ef: 2 files, 144+263) in a detached worktree
|
||||
- [x] R5.7f docs (CLAUDE.md, WORKSPACE, packages/README, README, RUST.md §11.23, CHANGELOG, sheet model, SUPABASE, TEST_STRATEGY, PDF-FORMAT)
|
||||
- [ ] R5.7g checks (frozen install, rust:check, check:all green 03:58:13, --check 0 diff, TS 943→546, Rust 364→383) + fresh security + fresh verifier → checkpoint, STOP
|
||||
- [x] R5.7g checks (frozen install, rust:check, check:all green 03:58:13, --check 0 diff, TS 943→546, Rust 364→383) + fresh security + fresh verifier → checkpoint, STOP
|
||||
- [x] R5.7h owner validated R5.7 2026-10-25 (« dernière vérification pré-fusion »); C6 Clarification (tsx = vite optional peer, accepted); census refuses `#[ignore]` targets (cd69f0e); pre-merge rerun on 27bf59c: frozen install + dedupe ok, check:all green 13:41:41, --check 0 diff, report:compare ok, security PASS, verifier CONFORME 10/10 (`.claude/audits/2026-10-25-rust-r5-7-premerge.md`) → STOP, merge `--no-ff` into develop only on the owner's signal
|
||||
- [ ] owner decision (LOW, security final): census regex still accepts `#[ignore]` before `#[test]` or `#[cfg_attr(…, ignore)]` (no instance); fix = inspect the whole attribute block
|
||||
- [ ] separate chore after merge (owner decision): `pnpm audit` 57 advisories, all pre-existing on develop (zod 3.25.76 runtime, patched only in zod 4 = major; tinypool/vitest, vite 7.3.6 dev server on LAN, happy-dom, pnpm 10.13.1 itself); none blocks develop, review before any release
|
||||
- [ ] owner action (non-blocking): `packages/{anatomy,domain}/node_modules` leftovers (git-ignored pnpm symlinks; recursive delete refused to Claude) → `rm -r packages/anatomy/node_modules packages/domain/node_modules && rmdir packages/anatomy packages/domain`
|
||||
- [ ] DEV hardening (owner 2026-10-24, risk accepted temporarily, not scheduled): Supabase on CLI demo keys + 54321 LAN-open (rootless, UFW allow incoming, no 54321 rule) → own JWT secret/signing keys via env() or narrower 54321 rule before any untrusted device or user (ENVIRONMENTS.md §3.6); never these keys in production; `confirm_sheet_asset_upload` object check before public exposure
|
||||
- [ ] separate chore (D-R7): form constraints module + PGlite `pg_constraint`/config.toml parity test
|
||||
|
||||
Reference in new issue
Block a user