chore(memory): R1 journal, contract evidence and rulings
This commit is contained in:
1 parent
6ef5223f0e
commit
9852e4e5bc
2 files changed
+11
-5
No files matched your search
@@ -551,3 +551,6 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
|
||||
- db:trial TR_PW leak 2026-11-11: owner-ordered one-off rotation (5 roles, auth/storage/rest recreated, old pw refused, services ok, DEV/sandbox unchanged); fix 5f63d22 -c log_statement=none on server cmdline (harness 373/0, control 372/1, verifier CONFORME, security PASS); LRN-127. Real proof pending: create on fresh volume.
|
||||
- db:trial MFA rule 2026-11-11 (owner): owner grant with 1 verified TOTP on trial only (45d7453, harness 375/0, verifier CONFORME, security PASS), BDR-112 narrows BDR-083; production rule unchanged. App on LAN 192.168.1.100:5194 (BDR-111). Accounts owner@trial.local, praticien@trial.local created by owner, 1 verified factor each, no role yet.
|
||||
- db:trial equine drawing imported 2026-11-11 (owner go): pre-checks (gateway faunosteo_trial, key iss/signature, historical sheet, sha256/size vs assets.json/draft/row, bucket empty), R5.5 --check plan, `pnpm db:trial assets` 1/1 confirmed, object re-downloaded byte-identical, 2nd --check nothing to do, draft=document.json, seed=HEAD, no secret in logs, DEV/sandbox unchanged. App exposure 192.168.1.100:5194 noted (BDR-111); host Valheim argv password noted separately in TODO.
|
||||
|
||||
## 2026-11-12
|
||||
- 2026-11-12 R1 + D6b delivered on feature/v1-2-anatomical-sheets (owner GO): Défaire/Refaire, Désélectionner, Escape priority, empty press on drawing deselects (useEmptyTap, press-based; mouse at pointerup, touch+pen at own click). Plan challenged x2 (capture retarget, blur-rebuild click drop, touch click-through). Gates: unit 1381/180/66, e2e:ui 227, e2e:shell 197/4/99 (4 = admin.spec.ts:717 baseline). Verifier 15/15, security PASS x2, code review fixes landed. Stopped at R1 checkpoint; R2 not started.
|
||||
@@ -124,32 +124,35 @@ Q: spec of R1? / A: docs/development/V1-2-6_U1_CORRECTIONS.md §1 D5, D6, D6b,
|
||||
Q: tooltip with the shortcut and Meta in aria-keyshortcuts? / A: yes, board 26 and REVUE.md:59, :108-110 (title = name + « (Ctrl+Z ou ⌘Z) » / « (Ctrl+Maj+Z ou ⇧⌘Z) », EN « (Ctrl+Z or ⌘Z) » / « (Ctrl+Shift+Z or ⇧⌘Z) »; aria-label = name only; aria-keyshortcuts adds Meta+Z / Meta+Shift+Z).
|
||||
Q: suites environment? / A: unit + e2e:ui local; e2e:shell only on `pnpm db:sandbox` (already up); never db:trial, never DEV; no sandbox reset/down; exact shell count reported against the known baseline (4 failures admin.spec.ts:717, anomaly B).
|
||||
|
||||
Q: pen pointer rule for D6b (criterion 14)? / A: [ruling 2026-11-12, controller, after the final code review] pen follows the TOUCH rule (verdict applied in the tap's own click, only when its target has no [data-anno-id]); the mouse alone acts at pointerup and swallows the next click. Reason: on stylus platforms the click is built after the lift on the layout without the selection and could land on « Ajouter … »; cost if wrong: a pen tap after a field blur-rebuild needs a second tap. Criterion 14's « mouse/pen » reads « mouse » for pointerup, « touch and pen » for the click.
|
||||
Q: path of the deselect helper? / A: [ruling 2026-11-12] apps/app/src/editor/annotations/deselect.ts as the plan specified (FILE SCOPE line was loose).
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
1. FR history labels read « Défaire » / « Refaire » with names « Défaire la dernière modification » / « Refaire la dernière modification défaite »; EN undo/redo strings unchanged; fr and en key sets identical.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2/apps/app && grep -q "'editor.history.undo': 'Défaire'" src/i18n/fr.ts && grep -q "'editor.history.redo': 'Refaire'" src/i18n/fr.ts && grep -q "'editor.history.undo_title': 'Défaire la dernière modification'" src/i18n/fr.ts && grep -q "'editor.history.redo_title': 'Refaire la dernière modification défaite'" src/i18n/fr.ts && grep -q "'editor.history.undo': 'Undo'" src/i18n/en.ts && grep -q "'editor.history.redo_title': 'Redo the last undone change'" src/i18n/en.ts && ! grep -qE "'editor\.history\.(undo|redo)(_title)?': '(Annuler|Rétablir)" src/i18n/fr.ts && echo LABELS_OK
|
||||
EXPECT: LABELS_OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: LABELS_OK
|
||||
2. History buttons: aria-label = the name, title = name + the shortcut text of board 26, aria-keyshortcuts lists Control and Meta forms; shortcuts themselves unchanged (useUndoShortcuts.ts untouched); dialog « Annuler » buttons untouched; the FR prose naming the history command (editor.views.drawing.use_parent_body, editor.views.repair.body_one/_other) says « Défaire ».
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && git diff --quiet 541706c -- apps/app/src/editor/useUndoShortcuts.ts && grep -q "Meta+Z" apps/app/src/components/editor/HistoryButtons.tsx && grep -q "Meta+Shift+Z" apps/app/src/components/editor/HistoryButtons.tsx && ! grep -q "un seul Annuler" apps/app/src/i18n/fr.ts && ! grep -q "ce changement (Annuler)" apps/app/src/i18n/fr.ts && echo HISTORY_OK
|
||||
EXPECT: HISTORY_OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: HISTORY_OK
|
||||
3. « Désélectionner » (secondary, deselect glyph) sits to the left of « Supprimer » in the properties panel, in edit and read-only modes (read-only: no « Supprimer »); after it: the annotation's list row if visible, else the drawing box; focus never reselects; polite announcement « Aucune annotation sélectionnée. » / « No annotation selected. ».
|
||||
4. Escape in the editor workspace, first applicable wins: open dialog (native, untouched) > « Plus » menu open (closes, focus on « Plus ») > references panel open (closes, focus on its opener) > tracing in progress (cancels, as today) > selection (deselects, focus per the [gated] rule, same announcement); Escape inside a text field / select never deselects; nothing applicable → nothing; acts on the shown body only (kept hidden edit body or hidden tab never changes).
|
||||
5. D6b, edit canvas: with the select tool, a click/tap whose target has no [data-anno-id] ancestor deselects when an annotation is selected (bone or any drawing shape, the composed root, the box margin); a click on a point, zone or link still selects it; nothing selected → no dispatch (pending keyboard creation, typed fields, « Filtrer par nom » kept); drawing tools and tracing unchanged; a press that moved > 4 px (pan, marker drag, pinch) or during which a second pointer came down never deselects; focus ends on the canvas box (role=group, tabIndex 0), never on an SVG shape; same announcement.
|
||||
6. D6b, read-only twin: CatalogueCanvas gets an optional onEmpty with the same rules, passed only by the editor's read-only twin; the catalogue reader (SheetRoute) passes none and behaves exactly as before; useFraming.ts unchanged.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && git diff --quiet 541706c -- apps/app/src/catalogue/useFraming.ts apps/app/src/app/routes/app/anatomy/SheetRoute.tsx && grep -q "onEmpty" apps/app/src/components/catalogue/CatalogueCanvas.tsx && grep -q "onEmpty" apps/app/src/components/editor/tabs/AnnotationsTab.tsx && echo READER_UNCHANGED_OK
|
||||
EXPECT: READER_UNCHANGED_OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: READER_UNCHANGED_OK
|
||||
7. Every deselect path (button, Escape, click/tap): document text, handle version, history length, unsaved count and save state unchanged by the deselect itself; no save request; a valid typed value not yet blurred is committed (its own edit, undoable), never dropped silently; a refused « non appliqué » value: panel closes, document unchanged (current behaviour, documented); undo after a deselect undoes the previous edit.
|
||||
8. Unit tests (vitest) cover items 1-7 including clicks on inner SVG elements (rect/circle/path), the root svg and the margin, pointer sequences (down/move/up then click) under and over 4 px, a second pointer, read-only twin, reader unchanged; `pnpm typecheck`, `pnpm lint`, `pnpm test:run`, `pnpm build` pass.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && pnpm -s typecheck >/dev/null 2>&1 && pnpm -s lint >/dev/null 2>&1 && pnpm -s test:run >/tmp/claude-1000/-home-bchanot-Documents-faunosteo/463d8810-0112-4b67-92e4-aa3c30af6089/scratchpad/r1-unit.txt 2>&1 && echo STATIC_UNIT_OK
|
||||
EXPECT: STATIC_UNIT_OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: STATIC_UNIT_OK
|
||||
9. Browser tests: `pnpm e2e:ui` passes; a new shell spec (Chromium, `pnpm db:sandbox` only) covers button, Escape matrix, D6b mouse clicks on inner shapes/root/margin/annotations, pan/zoom/marker drag, touch tap, touch drag, two-finger tap and pinch through CDP, read-only twin, persistence after reload and no save request; `editor-equine.spec.ts` clicks a bone path of the horse drawing on its own sandbox copy; the full shell suite run is reported with its exact counts against the baseline.
|
||||
10. D6b lands in its own commit; commits pushed on feature/v1-2-anatomical-sheets; no change under supabase/, crates/, scripts/db-trial*.sh, docker/; the untracked review file kept.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && [ -z "$(git diff --name-only 541706c -- supabase crates scripts/db-trial.sh scripts/db-trial-check.sh docker)" ] && [ -f faunosteo-v1-2-6-revue-ux-chatgpt.md ] && git log --format=%s 541706c..HEAD | grep -q "D6b" && [ "$(git rev-parse HEAD)" = "$(git rev-parse @{u})" ] && echo SCOPE_PUSH_OK
|
||||
EXPECT: SCOPE_PUSH_OK
|
||||
EVIDENCE: pending
|
||||
EVIDENCE: MET exit=0 marker-found :: SCOPE_PUSH_OK
|
||||
11. Docs: V1-2-6_U1_CORRECTIONS.md R1 status + the deselect limits (refused value, focus rules, iOS manual), BROWSER_TESTS.md (new spec, keyboard order « Défaire », « Refaire »), V1-2-6_OWNER_TRIAL.md labels, a D5 note on T15 in V1-2-6_UX_DECISIONS.md and V1-2_ANATOMICAL_SHEETS.md, ANNOTATION-RENDERING.md click paragraph (D6b); historical records (U1 checkpoint, v1-2-6 board records) untouched.
|
||||
|
||||
12. [gated 2026-11-12] Escape focus (G1, owner): focus inside the properties panel → A6 (row if visible, else the drawing box); focus anywhere else → stays where it is. Escape deselects from anywhere inside the editor workspace (header and tab row included) or with the focus on the page body, only on the shown annotation body; from outside the workspace nothing happens.
|
||||
|
||||
Reference in new issue
Block a user