chore(memory): V1-2.6 lot G closed, ruling R8 on the locals count

This commit is contained in:
bchanot committed 2026-11-04 13:37:01 +01:00
1 parent 7ea9619aa0
commit 66663dc0ca
2 files changed
+11 -18

No files matched your search

@@ -16,7 +16,7 @@ only. This file holds every ruling, finding and checkpoint needed to resume; the
| D store, undo, recovery, issues | 7f1d440, b14509f | clean after 1 fix round | done |
| E route, modes, offer, conflict | 6aba971 | clean | done |
| F Général, Références, Vertèbres | d163b2c | clean | done |
| G views + upload | 8343528 | 2 Important open (fix lost with the old worktree) | fix round to redo |
| G views + upload | 8343528, 1bbf97e, 7ea9619 | clean after the redone fix rounds (G1 closed codes, G3 hash at load, G2 split) | done |
| H Annotations | — | — | to redo from scratch (lost, uncommitted, never tested) |
| I Constats · J Vérification · K e2e · L owner trial · M gates | — | — | pending |
@@ -35,26 +35,19 @@ only. This file holds every ruling, finding and checkpoint needed to resume; the
- R7 a detail view's parent change goes through the geometry `accept` (it changes the inherited drawing, owner
rule 7); the button « Utiliser l'illustration de la vue parente » (drop an own drawing back to a crop) kept as a
label proposal and a visible choice for the checkpoint. Cost: a refused parent change; one button removed.
- R8 locals limit: one destructuring declaration (`const [x, setX] = useState()`, `const {a, b} = form`) counts as
one local, the reading every earlier lot was reviewed under; `useCropGroup` (5) and `useCropDraft` (4) pass.
Cost if wrong: a cosmetic split of two hooks.
- Promoted minors (same invariant as an Important finding): C non-trap `internal` taken as a trap (now detected by
runtime generation/status); D `discardChanges` busy guard and late `readConflict` write after dismiss.
## Open findings to carry
- Lot G fix (Important, from its review; V1-2 contract §9.3 item 6): `hash_mismatch` and `svg_not_canonical` must
show as closed codes with FR/EN messages. Design kept from the lost round: `drawingStatus.ts`
`rejectionReason(detail)` maps the core's rejection details (`not_canonical`, `processing_instruction`, reader
reasons, `removed …` → `removal`, else `other`; raw detail never shown); a `rejected` `not_canonical` drawing
reads « Illustration refusée : elle n'est pas sous la forme enregistrée… »; `updateView` refuses through
`accept` a new `svg_asset_id` the core holds as `rejected` (`drawing_rejected`), which `attachToView` reports as
`svg_not_canonical` (or `svg_rejected` with the reason); `object_conflict` unchanged; keys
`editor.upload.err.svg_not_canonical`, `editor.views.drawing.not_canonical`, `editor.views.drawing.hash_mismatch`,
`editor.upload.reason.processing_instruction`, `editor.upload.reason.removal` (proposals, section « Lot G »).
- Lot G fix (Important, code limits): `EditableCrop` (~8 locals, nested `apply`) and `ViewDrawing` over the limits.
Design kept: `useCropGroup(viewId, box)`; `CropEditor` → `EditableCrop`, `CropFields`, `CropRefusal`; `ViewDrawing`
→ `DrawingLines`, `DrawingActions`, `FilePicker`, `UploadNotices`.
- Store gap found during that round (owner 2026-11-04: must be checked): a hash mismatch at load shows
« Illustration introuvable » instead of the hash message; `state/editorLoad.ts` apparently does not record that
failure in `drawingFailures`. Not confirmed; the G fix round owns it (store files allowed for this point).
- Lot G fixes DONE (1bbf97e, 7ea9619): G3 root cause — the store already recorded `drawing_hash_mismatch` in
`drawingFailures`; `drawingStatusOf` read the core's `missing` entry first. `issues.ts` gained the refusal reason
`drawing_rejected` (+ optional `drawingDetail`) for attaching a drawing the core holds as rejected; `geometryAccept`
unchanged. `svg_not_canonical` is unreachable through the page's own upload (it uploads its cleaned form); covered by
attaching a held non-canonical drawing.
- Lot H design notes from the lost attempt (NOT implemented, NOT tested; to be rebuilt): proposal arithmetic in
`editor/annotations/frame.ts` (F from the `viewBox` text with `Number`, r0 floored to 0.01, candidates A/B/C, C by
an inward-rounded per-axis clamp with the exact clamp on an empty interval); every geometry commit through
@@ -82,7 +75,7 @@ only. This file holds every ruling, finding and checkpoint needed to resume; the
- F: digits-only count check overlaps the core's unsigned rule (shape check); `duplicate_key` retry and
DeleteDialog failure branch untested; RangeEditor `setState` during render; repeated row labels; long citation
titles.
- G: no session check between register/list/upload/confirm (idempotent); UI state set after an await without the
- G: `issues.ts` Prettier noise on Lot D lines; frame-refusal test lacks the `other` / `removal` fallbacks; no session check between register/list/upload/confirm (idempotent); UI state set after an await without the
session check; `parseBox` accepts `1e3` / `0x10` (the core decides).
## Questions for the owner at the checkpoint (not decided)