diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index e346d2f6..4cccbdc2 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -672,7 +672,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] L3 TOTP reuse measured (code accepted by several sessions in its step and the next, refused at N+2), lost-authenticator review (production prerequisite), decisions in docs; sandbox test 103 + 10 skipped x2 - [x] L4 gates: check:all green (dcb1a94; delta = sandbox test + docs), fresh stack test-db 1965, e2e:shell 110 + 8 skipped, sandbox test 103 + 10 skipped after e2e, upgrade from M6 1965 + types match; security PASS x2; verifier ECARTS(6) -> CONFORME; two state-dependent sandbox tests fixed (0499a39, f5456f3); suites need a fresh stack in order test-db, e2e:shell, test - [ ] V1-2.6 editor level 1: plan APPROVED by the owner 2026-11-03 (brief « GO propriétaire V1-2.6 »: 13 lots A-M, C1-C24, 8 visible choices, M8 sandbox only, no JSON export button, recovery messages exact), gated on a targeted independent re-check of the six FATAL fixes. Re-check 2026-11-03: REMAINING(2) — fixes 1-5 closed, I1-I5 hold; fix 6 (r = 12 + 3 %) opens `out_of_frame` on frames under ~25.5 units (hitbox r in frame bounds); I6 broken: the first commit overwrites a pending recovery copy before « Restaurer » / « Ignorer »; 2 MINOR (N source when the admin read fails, two-copy cap). Executor NOT launched; STOP for the owner. Owner arbitrations 2026-11-03 (« arbitrages propriétaire sur REMAINING(2) »): C25-C31 gated, plan revised; second targeted re-check: REMAINING(1), no BLOCKER, F1 MAJOR (accept trusted the core's silence on unmeasured views) + 7 MINOR, all integrated in the plan. Owner GO 2026-11-04 (« GO propriétaire après REMAINING(1) »): F1 fix approved, C26 refined by seven repair rules, minor effects approved; C32-C34 gated; execution of lots A-M authorised, no third plan review. 2026-11-04 13:08 the scratchpad worktree was removed by the harness cleanup (LRN-114): commits safe on origin (8343528), uncommitted lot H + lot G fix lost; worktree recreated at /home/bchanot/Documents/faunosteo-v1-2 (owner authorisation); resume ledger `.claude/tasks/plans/2026-11-03-v1-2-6-execution.md`. Contract `.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md`, plan `.claude/tasks/plans/2026-11-03-v1-2-6-editor.md`; sandbox only, no DEV, no worker on DEV, no merge, no V1-2.7; STOP at the V1-2.6 owner checkpoint (trial procedure) - - [x] A M8 draft_last_save (2f824a9) · [x] B sheet asset accessors (f7e7bf4) · [x] C preview mutators, edit ops, ids (173be59..cfd49c7) · [x] D editor store, undo, recovery (7f1d440..b14509f) · [x] E route, modes, tabs (6aba971) · [x] F Général, Références, Vertèbres (d163b2c) · [ ] G views + upload (8343528, review fix to redo) · [ ] H Annotations · [ ] I Constats · [ ] J Vérification + submit · [ ] K e2e · [ ] L owner trial tooling · [ ] M gates, reviews, checkpoint + - [x] A M8 draft_last_save (2f824a9) · [x] B sheet asset accessors (f7e7bf4) · [x] C preview mutators, edit ops, ids (173be59..cfd49c7) · [x] D editor store, undo, recovery (7f1d440..b14509f) · [x] E route, modes, tabs (6aba971) · [x] F Général, Références, Vertèbres (d163b2c) · [x] G views + upload (8343528, 1bbf97e, 7ea9619) · [ ] H Annotations · [ ] I Constats · [ ] J Vérification + submit · [ ] K e2e · [ ] L owner trial tooling · [ ] M gates, reviews, checkpoint - [ ] MANDATORY before merging V1-2 into develop (owner 2026-11-03): registry id reconciliation. LRN-095 collides: develop 09655b2 « Port a safe runner verbatim… » (2026-11-02) vs V1-2 « pgTAP across PGlite and the real Supabase image… » (2026-10-28, cited by BDR-084 and the V1-2.1 TODO lines). BLK-013 exists on develop only (« e2e:avatar on develop reached DEV »): `memory.sh` on V1-2 would hand out BLK-013 again, so a V1-2 blocker needs its id checked against develop first. Same for the TODO release-readiness ids: RR-11 is develop's (« sandbox-only e2e follow-ups »), V1-2 uses RR-12. No renumbering during V1-2.6 unless needed; renumber one side and patch its citers at the merge - [ ] V1-2.5 catalogue, admin space, rights, species, MFA · V1-2.6 editor level 1 · V1-2.7 preview, review, publication UI · V1-2.8 equine working copy and review preparation · V1-2.9 FR/EN acceptance and closure (owner checkpoints V1-2.3, V1-2.4, V1-2.6, V1-2.7, V1-2.8, V1-2.9 + each DEV operation of contract §16.11) diff --git a/.claude/tasks/plans/2026-11-03-v1-2-6-execution.md b/.claude/tasks/plans/2026-11-03-v1-2-6-execution.md index 5ba5a904..cdc983c1 100644 --- a/.claude/tasks/plans/2026-11-03-v1-2-6-execution.md +++ b/.claude/tasks/plans/2026-11-03-v1-2-6-execution.md @@ -16,7 +16,7 @@ only. This file holds every ruling, finding and checkpoint needed to resume; the | D store, undo, recovery, issues | 7f1d440, b14509f | clean after 1 fix round | done | | E route, modes, offer, conflict | 6aba971 | clean | done | | F Général, Références, Vertèbres | d163b2c | clean | done | -| G views + upload | 8343528 | 2 Important open (fix lost with the old worktree) | fix round to redo | +| G views + upload | 8343528, 1bbf97e, 7ea9619 | clean after the redone fix rounds (G1 closed codes, G3 hash at load, G2 split) | done | | H Annotations | — | — | to redo from scratch (lost, uncommitted, never tested) | | I Constats · J Vérification · K e2e · L owner trial · M gates | — | — | pending | @@ -35,26 +35,19 @@ only. This file holds every ruling, finding and checkpoint needed to resume; the - R7 a detail view's parent change goes through the geometry `accept` (it changes the inherited drawing, owner rule 7); the button « Utiliser l'illustration de la vue parente » (drop an own drawing back to a crop) kept as a label proposal and a visible choice for the checkpoint. Cost: a refused parent change; one button removed. +- R8 locals limit: one destructuring declaration (`const [x, setX] = useState()`, `const {a, b} = form`) counts as + one local, the reading every earlier lot was reviewed under; `useCropGroup` (5) and `useCropDraft` (4) pass. + Cost if wrong: a cosmetic split of two hooks. - Promoted minors (same invariant as an Important finding): C non-trap `internal` taken as a trap (now detected by runtime generation/status); D `discardChanges` busy guard and late `readConflict` write after dismiss. ## Open findings to carry -- Lot G fix (Important, from its review; V1-2 contract §9.3 item 6): `hash_mismatch` and `svg_not_canonical` must - show as closed codes with FR/EN messages. Design kept from the lost round: `drawingStatus.ts` - `rejectionReason(detail)` maps the core's rejection details (`not_canonical`, `processing_instruction`, reader - reasons, `removed …` → `removal`, else `other`; raw detail never shown); a `rejected` `not_canonical` drawing - reads « Illustration refusée : elle n'est pas sous la forme enregistrée… »; `updateView` refuses through - `accept` a new `svg_asset_id` the core holds as `rejected` (`drawing_rejected`), which `attachToView` reports as - `svg_not_canonical` (or `svg_rejected` with the reason); `object_conflict` unchanged; keys - `editor.upload.err.svg_not_canonical`, `editor.views.drawing.not_canonical`, `editor.views.drawing.hash_mismatch`, - `editor.upload.reason.processing_instruction`, `editor.upload.reason.removal` (proposals, section « Lot G »). -- Lot G fix (Important, code limits): `EditableCrop` (~8 locals, nested `apply`) and `ViewDrawing` over the limits. - Design kept: `useCropGroup(viewId, box)`; `CropEditor` → `EditableCrop`, `CropFields`, `CropRefusal`; `ViewDrawing` - → `DrawingLines`, `DrawingActions`, `FilePicker`, `UploadNotices`. -- Store gap found during that round (owner 2026-11-04: must be checked): a hash mismatch at load shows - « Illustration introuvable » instead of the hash message; `state/editorLoad.ts` apparently does not record that - failure in `drawingFailures`. Not confirmed; the G fix round owns it (store files allowed for this point). +- Lot G fixes DONE (1bbf97e, 7ea9619): G3 root cause — the store already recorded `drawing_hash_mismatch` in + `drawingFailures`; `drawingStatusOf` read the core's `missing` entry first. `issues.ts` gained the refusal reason + `drawing_rejected` (+ optional `drawingDetail`) for attaching a drawing the core holds as rejected; `geometryAccept` + unchanged. `svg_not_canonical` is unreachable through the page's own upload (it uploads its cleaned form); covered by + attaching a held non-canonical drawing. - Lot H design notes from the lost attempt (NOT implemented, NOT tested; to be rebuilt): proposal arithmetic in `editor/annotations/frame.ts` (F from the `viewBox` text with `Number`, r0 floored to 0.01, candidates A/B/C, C by an inward-rounded per-axis clamp with the exact clamp on an empty interval); every geometry commit through @@ -82,7 +75,7 @@ only. This file holds every ruling, finding and checkpoint needed to resume; the - F: digits-only count check overlaps the core's unsigned rule (shape check); `duplicate_key` retry and DeleteDialog failure branch untested; RangeEditor `setState` during render; repeated row labels; long citation titles. -- G: no session check between register/list/upload/confirm (idempotent); UI state set after an await without the +- G: `issues.ts` Prettier noise on Lot D lines; frame-refusal test lacks the `other` / `removal` fallbacks; no session check between register/list/upload/confirm (idempotent); UI state set after an await without the session check; `parseBox` accepts `1e3` / `0x10` (the core decides). ## Questions for the owner at the checkpoint (not decided)