docs(docs): C4 two-part proof and the final-review fix
This commit is contained in:
1 parent
346a8fd8f1
commit
58228ab522
2 files changed
+24
-10
No files matched your search
@@ -10,7 +10,7 @@ engines are installed. The suites live in `apps/app/e2e`.
|
||||
| Command | Backend | Dev server | Content |
|
||||
|---|---|---|---|
|
||||
| `pnpm e2e:ui` | none | Vite on `127.0.0.1:5191` | `e2e/ui/dialog.spec.ts`: the D13 contract of the shared Dialog on a test page; `e2e/ui/working-copy.spec.ts`: the real `WorkingCopyAction` and its dialog on a test page (axe, layout, keyboard, fr and en, desktop and 375 px); `e2e/ui/local-tool.spec.ts`: the disclaimer, edit and replace dialogs on the real local-tool routes |
|
||||
| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer; `e2e/shell/clients.spec.ts`: the client journeys (V1-1.5); `e2e/shell/animals.spec.ts`: the animal and relation journeys (V1-1.6, contract §11.8); `e2e/shell/responsive.spec.ts`: no sideways scroll on nine shell pages, the archive confirmations and the drawer at 320, 360, 375, 390 and 430 px (phone project) and 1280 px, long values, the dashboard e-mail shown whole (RESP-01); `e2e/shell/admin.spec.ts` (V1-2.5): A0 the owner's bootstrap (two TOTP factors from Sécurité, the step-up at `/app/admin` and inside a factor action, no second factor from `aal1`, refresh keeping `aal1` and `aal2`, rights granted and revoked with their reason), A1 a sheet created by an editor on a new inactive species, S1 a species created inactive then activated by the owner, the creation page when the own-grants read fails (« Impossible de vérifier vos autorisations » and « Réessayer », never the form; Retry brings the form back), access per right (a reviewer-only account refused on the creation page), axe and no sideways scroll on every admin page; `e2e/shell/catalogue.spec.ts` (V1-2.5): P1 a reader searches, opens a sheet, picks a zone, reads a retired version, drafts and archived sheets never listed, the same refusal for an existing and an unknown sheet without access, 320, 375 and 430 px with the whole drawing in the box at opening; at 320 and 375 px the zone panel's live region present before a pick and naming the picked zone, the « Références » card starting at or below the drawing's bottom; `e2e/shell/editor-*.spec.ts` (V1-2.6, the draft editor level 1, contract C16 to C34): `editor-drawings` (A2: a hostile file refused with no cleaning box, an Inkscape export cleaned after its preview, a valid file attached, a detail view by crop, the same bytes attached twice), `editor-annotations` (A3: points, zones and links by clicks and by keyboard only, move by drag, a click with jitter never moves, numeric edits, undo and redo, review and delete), `editor-geometry` (a click near a frame edge with the corrected position confirmed and cancelled, an inherited out-of-frame point repaired through the geometry group, a crop change refused when it would invalidate a point, an unmeasured view with its tools disabled, touch-action and a touch drag in real Chromium), `editor-structures` (A4: categories, references, regions, findings tree, reorder, mark reviewed, delete with dependents), `editor-references` (R2: cancel adding by button and by Escape, a tile edited out of the search), `editor-journey` (the steps of `V1-2-6_OWNER_TRIAL.md` §4 with two editor accounts: creation, drawing, findings, annotations, save, reload with the beforeunload dialog and the recovery offer, conflict, submission, the round read back in SQL), `editor-recovery` (two sessions, an older local copy restored then saved over a newer revision, a pending offer blocking edits, an unreadable copy kept until « Ignorer », Escape on the conflict read, the editor grant revoked, the admin role removed and the grant expired under an open session), `editor-access` (a reviewer-only account read-only, the not-found screen for an editor without the admin role and for an admin without a capability, 320, 375 and 800 px read-only, 1 024 px editing, axe on every tab edit and read-only), `editor-deselect` (R1, D5 and D6b: « Désélectionner » with its live region, the focus on the list row and the document unchanged; Escape over the canvas, a field, the delete dialog, the citations panel (opened from a finding) and a tracing; mouse clicks on empty parts deselecting, on annotations selecting; zoom, pan, marker drag and Ctrl+wheel keeping the selection; a typed value applied by the deselecting click; at 1 280 px with `hasTouch` and CDP touch taps near annotations and the canvas bottom deselecting once, drags, two-finger taps and pinch keeping the selection, with the pointer events counted by a recorder; the read-only twin at 375 px and Escape closing « Plus » before deselecting; the drawing's top unchanged when a point, a zone and a link are selected then deselected, on desktop and on the read-only twin at 375 px, with the selection tag out of the visual flow), `editor-equine` (the historical equine sheet opened as a working copy, a copy left active by an earlier run set aside and put back; commit latency on it and on a synthetic document near 2 MiB, printed as `LATENCY` lines and kept as test annotations, budget 500 ms per commit on the equine copy; one empty click on a bone of the horse drawing deselects, D6b). U1 shell (V1-2.6 U1, the tabbed shell): `editor-shell` (kept-mounted places, focus on a named element, the open panel leaving the header and the tab row clickable at 1 024 and 1 280 px, the sidebar from 1 280 px and the drawer, canvas widths), `editor-shell-journeys` (five tabs, cLine truncated
|
||||
| `pnpm e2e:shell` | the isolated stack of `pnpm db:sandbox` | Vite on `127.0.0.1:5192` | `e2e/shell/shell.spec.ts`: sign-in, dashboard, the account photo confirmation, the phone drawer; `e2e/shell/clients.spec.ts`: the client journeys (V1-1.5); `e2e/shell/animals.spec.ts`: the animal and relation journeys (V1-1.6, contract §11.8); `e2e/shell/responsive.spec.ts`: no sideways scroll on nine shell pages, the archive confirmations and the drawer at 320, 360, 375, 390 and 430 px (phone project) and 1280 px, long values, the dashboard e-mail shown whole (RESP-01); `e2e/shell/admin.spec.ts` (V1-2.5): A0 the owner's bootstrap (two TOTP factors from Sécurité, the step-up at `/app/admin` and inside a factor action, no second factor from `aal1`, refresh keeping `aal1` and `aal2`, rights granted and revoked with their reason), A1 a sheet created by an editor on a new inactive species, S1 a species created inactive then activated by the owner, the creation page when the own-grants read fails (« Impossible de vérifier vos autorisations » and « Réessayer », never the form; Retry brings the form back), access per right (a reviewer-only account refused on the creation page), axe and no sideways scroll on every admin page; `e2e/shell/catalogue.spec.ts` (V1-2.5): P1 a reader searches, opens a sheet, picks a zone, reads a retired version, drafts and archived sheets never listed, the same refusal for an existing and an unknown sheet without access, 320, 375 and 430 px with the whole drawing in the box at opening; at 320 and 375 px the zone panel's live region present before a pick and naming the picked zone, the « Références » card starting at or below the drawing's bottom; `e2e/shell/editor-*.spec.ts` (V1-2.6, the draft editor level 1, contract C16 to C34): `editor-drawings` (A2: a hostile file refused with no cleaning box, an Inkscape export cleaned after its preview, a valid file attached, a detail view by crop, the same bytes attached twice), `editor-annotations` (A3: points, zones and links by clicks and by keyboard only, move by drag, a click with jitter never moves, numeric edits, undo and redo, review and delete), `editor-geometry` (a click near a frame edge with the corrected position confirmed and cancelled, an inherited out-of-frame point repaired through the geometry group, a crop change refused when it would invalidate a point, an unmeasured view with its tools disabled, touch-action and a touch drag in real Chromium), `editor-structures` (A4: categories, references, regions, findings tree, reorder, mark reviewed, delete with dependents), `editor-references` (R2: cancel adding by button and by Escape, a tile edited out of the search), `editor-journey` (the steps of `V1-2-6_OWNER_TRIAL.md` §4 with two editor accounts: creation, drawing, findings, annotations, save, reload with the beforeunload dialog and the recovery offer, conflict, submission, the round read back in SQL), `editor-recovery` (two sessions, an older local copy restored then saved over a newer revision, a pending offer blocking edits, an unreadable copy kept until « Ignorer », Escape on the conflict read, the editor grant revoked, the admin role removed and the grant expired under an open session), `editor-access` (a reviewer-only account read-only, the not-found screen for an editor without the admin role and for an admin without a capability, 320, 375 and 800 px read-only, 1 024 px editing, axe on every tab edit and read-only), `editor-deselect` (R1, D5 and D6b: « Désélectionner » with its live region, the focus on the list row and the document unchanged; Escape over the canvas, a field, the delete dialog, the citations panel (opened from a finding) and a tracing; mouse clicks on empty parts deselecting, on annotations selecting; zoom, pan, marker drag and Ctrl+wheel keeping the selection; a typed value applied by the deselecting click; at 1 280 px with `hasTouch` and CDP touch taps near annotations and the canvas bottom deselecting once, drags, two-finger taps and pinch keeping the selection, with the pointer events counted by a recorder; the read-only twin at 375 px and Escape closing « Plus » before deselecting; the drawing's top unchanged when a point, a zone and a link are selected then deselected, on desktop and on the read-only twin at 375 px, with the selection tag out of the visual flow), `editor-equine` (the historical equine sheet opened as a working copy, a copy left active by an earlier run set aside and put back; commit latency on it and on a synthetic document near 2 MiB, printed as `LATENCY` lines and kept as test annotations, budget 500 ms per commit on the equine copy; one empty click on a bone of the horse drawing deselects, D6b). U1 shell (V1-2.6 U1, the tabbed shell): `editor-shell` (kept-mounted places, focus on a named element, the open panel leaving the header and the tab row clickable at 1 024 and 1 280 px, the sidebar from 1 280 px and the drawer, canvas widths), `editor-shell-journeys` (five tabs, cLine truncated
|
||||
|
||||
Each suite runs on two Chromium projects: `chromium-desktop` (1280 × 800) and
|
||||
`chromium-375` (375 × 667, mobile viewport, touch). A test tagged `@phone`
|
||||
@@ -220,10 +220,15 @@ suite needs Docker in the runner for the sandbox.
|
||||
grants » and « admin screens » (fr or en, desktop and 375). The cure, a paginated grant list, is RR-13; BLK-015
|
||||
stays open. Rerun the spec alone to separate a crash from a real failure: that isolated run is a diagnosis,
|
||||
never the gate.
|
||||
- The layout spec covers the landscape 667 × 375 sample by touch: the citations trigger sits at 811 to 855 px at
|
||||
scroll 0, CDP touch swipes (`Input.dispatchTouchEvent`; `Input.synthesizeScrollGesture` with `touch` scrolls
|
||||
nothing in this Chromium) bring its bottom 0 to 3 px above the viewport bottom (scrollY 480 to 483), a tap opens
|
||||
the panel with its heading and ✕ in the viewport and hit-testable, scrollY unchanged. Remaining exception: the
|
||||
- The layout spec covers the landscape 667 × 375 sample in two parts, in one test of the phone project. The citations
|
||||
trigger sits at 811 to 855 px at scroll 0. (A) Touch only: CDP `Input.dispatchTouchEvent` swipes of 200 px
|
||||
(`Input.synthesizeScrollGesture` with `touch` scrolls nothing in this Chromium) until the trigger is wholly on
|
||||
screen and hit-testable (2 swipes in every run, scrollY 491 to 512); a tap opens the panel, heading and ✕ in the
|
||||
viewport and hit-testable, scrollY unchanged. (B) Worst case: an instant programmatic scroll puts the trigger's
|
||||
bottom on the viewport bottom (gap 0, scrollY 480); a tap opens the panel, heading and ✕ in view and hit-testable,
|
||||
scrollY unchanged. B is programmatic because a touch swipe under about 60 px scrolls nothing (slop) and the gain
|
||||
varies under load, so a pixel-exact touch landing is not reproducible (an earlier calibrated version oscillated
|
||||
by 55 px in the full sweep). Remaining exception: the
|
||||
rotation to 667 × 375 with the panel open at scroll 0 keeps a cramped view (not built, an option for the owner).
|
||||
- A control placed below a field whose blur-commit is refused can lose its first click, because the error line
|
||||
moves the layout between mouse down and click. An editor-wide pattern found while writing the Références specs
|
||||
|
||||
@@ -222,11 +222,20 @@ top of `52aac41`:
|
||||
- C3 `b1fd896`: a pinned tile that no longer matches the search shows « Ne correspond pas à la recherche » under
|
||||
its header (`aria-describedby`). « Aucun résultat » shows only when no tile is shown (the add draft does not
|
||||
count).
|
||||
- C4 `969a5f3`, `817f74b`, `7766929`, `f7f0aa6` (test only): proof, no app code. At 667 × 375 with touch only, the
|
||||
citations trigger sits at 811 to 855 px at scroll 0. Touch swipes (CDP `Input.dispatchTouchEvent`;
|
||||
`Input.synthesizeScrollGesture` with `touch` scrolls nothing in this Chromium) bring its bottom 0 to 3 px above
|
||||
the viewport bottom across runs (scrollY 480 to 483). A tap opens the panel, its heading and ✕ are in the
|
||||
viewport and hit-testable, scrollY is unchanged (panel visible height about 319 px).
|
||||
- C4 `969a5f3`, `817f74b`, `7766929`, `f7f0aa6`, `78fb2d0` (test only): proof, no app code. One test of
|
||||
`editor-shell-layout` (phone project, 667 × 375), two parts. (A) Touch only: CDP `Input.dispatchTouchEvent` swipes
|
||||
of 200 px from scroll 0 (`Input.synthesizeScrollGesture` with `touch` scrolls nothing in this Chromium) until the
|
||||
trigger is wholly on screen and hit-testable (2 swipes in every run, scrollY 491 to 512); a tap opens the panel,
|
||||
heading and ✕ in the viewport and hit-testable, scrollY unchanged. (B) Worst case: an instant programmatic scroll
|
||||
puts the trigger's bottom on the viewport bottom (gap 0, scrollY 480); a tap opens the panel, heading and ✕ in
|
||||
view and hit-testable, scrollY unchanged. B is programmatic because a touch swipe under about 60 px scrolls
|
||||
nothing (slop) and the gain varies under load, so a pixel-exact touch landing is not reproducible (an earlier
|
||||
calibrated version oscillated by 55 px in the full sweep).
|
||||
- Final review `94f8a8b`, `346a8fd`: with two or more refused fields, a user leave (« Terminer », the panel's ✕,
|
||||
Escape or scrim, another tile's « Modifier », « Ajouter une référence ») now leaves the focus on the first refused
|
||||
field with its own error shown. Before, the last field tried owned the single error message (a regression of C1),
|
||||
and a mouse click on « Terminer » with Citation blank and a valid URL showed no error at all (present before R2's
|
||||
corrections). The forced close still names every refused field once.
|
||||
- New keys (provisional EN): `editor.references.add_cancel` fr « Annuler l'ajout », en « Cancel adding »;
|
||||
`editor.references.outside_search` fr « Ne correspond pas à la recherche », en « Does not match the search ».
|
||||
Rows in `V1-2-6_R2_LABELS.md`.
|
||||
|
||||
Reference in new issue
Block a user