chore(tasks): R1 owner gate outcomes G1, G2 and gated criteria
This commit is contained in:
1 parent
4923edefc0
commit
5803854860
2 files changed
+9
-4
No files matched your search
@@ -152,5 +152,10 @@ Q: suites environment? / A: unit + e2e:ui local; e2e:shell only on `pnpm db:sand
|
||||
EVIDENCE: pending
|
||||
11. Docs: V1-2-6_U1_CORRECTIONS.md R1 status + the deselect limits (refused value, focus rules, iOS manual), BROWSER_TESTS.md (new spec, keyboard order « Défaire », « Refaire »), V1-2-6_OWNER_TRIAL.md labels, a D5 note on T15 in V1-2-6_UX_DECISIONS.md and V1-2_ANATOMICAL_SHEETS.md, ANNOTATION-RENDERING.md click paragraph (D6b); historical records (U1 checkpoint, v1-2-6 board records) untouched.
|
||||
|
||||
12. [gated 2026-11-12] Escape focus (G1, owner): focus inside the properties panel → A6 (row if visible, else the drawing box); focus anywhere else → stays where it is. Escape deselects from anywhere inside the editor workspace (header and tab row included) or with the focus on the page body, only on the shown annotation body; from outside the workspace nothing happens.
|
||||
13. [gated 2026-11-12] « Supprimer » (G2, owner): unchanged style (filled danger button, no icon), to the right of « Désélectionner » in a row with a top border.
|
||||
14. [gated 2026-11-12] D6b decision (plan rev 3): the verdict comes from the press (pointerdown target without [data-anno-id], primary button, no second pointer anywhere in the page, no contextmenu, accumulated movement ≤ 4 px); mouse/pen apply it at pointerup and swallow the following click; touch applies it in the tap's own click and only when that click's target has no [data-anno-id]. A press that begins on the selected marker never deselects (even when its click is retargeted to the box by pointer capture).
|
||||
15. [gated 2026-11-12] « Désélectionner » is not rendered while a tracing runs; a press on it keeps a typed field focused until its handler commits it, so one press always closes the panel.
|
||||
|
||||
## FILE SCOPE
|
||||
apps/app/src/i18n/{fr,en}.ts; apps/app/src/components/editor/{HistoryButtons,EditorTabs,EditorWorkspace,EditorGlyph}.tsx; apps/app/src/components/editor/annotations/{PropertiesPanel,EditableAnnotations,AnnotationCanvas}.tsx; apps/app/src/components/editor/references/ReferencesPanel.tsx; apps/app/src/components/editor/tabs/AnnotationsTab.tsx; apps/app/src/components/catalogue/CatalogueCanvas.tsx; apps/app/src/editor/annotations/{useCanvasGestures,usePlacement}.ts; apps/app/src/editor/{focusRequest,useEditorNavigation}.ts; new apps/app/src/editor/{deselect,escape}.ts(x) helpers; apps/app/tests/unit/*.test.tsx (editor-history-buttons, editor-annotations-tab, editor-overview, editor-sections, editor-keep-alive, routes.catalogue, new editor-deselect / editor-escape); apps/app/e2e/shell/editor-*.spec.ts (titles/comments), new e2e/shell/editor-deselect.spec.ts, e2e/support/editor.ts, editor-equine.spec.ts; docs listed in criterion 11; .claude/tasks/*.
|
||||
apps/app/src/catalogue/useEmptyTap.ts (new); apps/app/src/i18n/{fr,en}.ts; apps/app/src/components/editor/{HistoryButtons,EditorTabs,EditorWorkspace,EditorGlyph}.tsx; apps/app/src/components/editor/annotations/{PropertiesPanel,EditableAnnotations,AnnotationCanvas}.tsx; apps/app/src/components/editor/references/ReferencesPanel.tsx; apps/app/src/components/editor/tabs/AnnotationsTab.tsx; apps/app/src/components/catalogue/CatalogueCanvas.tsx; apps/app/src/editor/annotations/{useCanvasGestures,usePlacement}.ts; apps/app/src/editor/{focusRequest,useEditorNavigation}.ts; new apps/app/src/editor/{deselect,escape}.ts(x) helpers; apps/app/tests/unit/*.test.tsx (editor-history-buttons, editor-annotations-tab, editor-overview, editor-sections, editor-keep-alive, routes.catalogue, new editor-deselect / editor-escape); apps/app/e2e/shell/editor-*.spec.ts (titles/comments), new e2e/shell/editor-deselect.spec.ts, e2e/support/editor.ts, editor-equine.spec.ts; docs listed in criterion 11; .claude/tasks/*.
|
||||
@@ -62,9 +62,9 @@ FR prose: `editor.views.drawing.use_parent_body` « … et vous pouvez défaire
|
||||
|
||||
## Gate outcomes (filled at the validation gate before dispatch)
|
||||
|
||||
- G1 Escape focus: [pending owner] recommended = focus inside the properties panel → A6 (row if visible, else the
|
||||
drawing box); focus elsewhere (canvas box, view chips, tool column, add buttons) → stays where it is.
|
||||
- G2 « Supprimer »: [pending owner] recommended = unchanged (filled danger button, no icon), per the board caption
|
||||
- G1 Escape focus [gated 2026-11-12, owner]: focus inside the properties panel → A6 (row if visible, else the
|
||||
drawing box); focus elsewhere (canvas box, view chips, tool column, add buttons, tab row) → stays where it is.
|
||||
- G2 « Supprimer » [gated 2026-11-12, owner]: unchanged (filled danger button, no icon), per the board caption
|
||||
« qui garde son style de danger »; only placed to the right of « Désélectionner » in the bordered row.
|
||||
|
||||
## Reviewer checklist (each has its test below)
|
||||
|
||||
Reference in new issue
Block a user