docs: supersede BDR-018 with BDR-019 (unified spine picker)
Record the pivot from additive distribution to an authoritative full-spine editor, the click-opens-own-tab precedence change, and the accepted orphan-findings wart on prune. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
38888cb3d1
commit
4c196bbd08
2 files changed
+19
No files matched your search
@@ -170,4 +170,18 @@ VertebraPicker anchored on clicked spine zone but lets user switch region tabs.
|
||||
**Why:** picking verts in a non-target tab must behave as if that zone was also clicked — highlight + findings picker both flow from observation.zones. Replace-everywhere would silently wipe a cervical zone selected earlier when reopening lumbar picker.
|
||||
Alt rejected: seed picker with full-spine union of all zones → forces handling deselection-to-zero per region (remove zone + orphan its findings); bigger scope, destructive. Additive-only matches user request.
|
||||
Alt rejected: keep dumping all verts on clicked zone (old bug) — other zones never highlight, no findings picker.
|
||||
Status: SUPERSEDED by BDR-019 (same session) — additive-union model dropped once picker shows full spine.
|
||||
|
||||
---
|
||||
|
||||
## BDR-019 | 2026-05-27 | Vertebra picker = unified full-spine editor, authoritative confirm
|
||||
|
||||
User asked picker to SHOW selections from all regions when switching tabs. Once it displays + edits every region, additive-union confirm (BDR-018) breaks: unchecking a side-tab vert can't stick (union re-adds from existing zone). So model flipped to unified + authoritative.
|
||||
Seed: `collectSpineVertebrae(zones, bones, clickedBoneId)` = union of all spine-zone verts, clicked zone first.
|
||||
Confirm: `syncSpineZones(zones, verts, bones)` — per region: REPLACE existing zone verts (deselect sticks); PRUNE spine zone whose region → 0; SPAWN zone for newly picked region. Non-spine zones + order preserved. `targetIndex` dropped — each vertebra carries its own region, no anchor needed.
|
||||
Tab: clicking zone ALWAYS opens its region — `initialRegion` now beats `initial[0].region` in VertebraPicker (was reverse). Updated the test that asserted old precedence.
|
||||
**Why:** picker as whole-spine editor is the only coherent model when all regions visible + editable; partial/additive semantics contradict what user sees.
|
||||
**Known wart (accepted):** pruning a region orphans its findings (findings keyed by tree zoneId, not boneId; sync works in boneId space). Parity with existing ✕ remove-zone button — neither cleans findings. Follow-up if needed.
|
||||
Confined to spine: picker only opens for `special==='vertebral-precision'`; sync/collect/find all gate on it; non-spine zones pass through. Tests cover.
|
||||
Alt rejected: keep additive (BDR-018) + only change seeding — deselection in non-clicked tab silently fails.
|
||||
Status: closed.
|
||||
@@ -141,3 +141,8 @@ feat(editor) 9544924 — cross-region vertebra picks spawn their spine zone.
|
||||
- EditorRoute onConfirm now distributes instead of dumping all verts on clicked zone. +7 tests (lib.spineZones).
|
||||
- BDR-018 (replace-target/union-others), LRN-028 (drive derived UI via source-of-truth row) captured.
|
||||
- 171/171 green, lint 0, typecheck clean.
|
||||
|
||||
- Iterated vertebra picker 3x same session. 9544924 additive distribute → 38888cb unified full-spine editor.
|
||||
- collectSpineVertebrae (union all spine zones, clicked first) seeds picker; syncSpineZones authoritative (replace region / prune zero / spawn new); initialRegion beats initial[0] so click opens own tab.
|
||||
- BDR-018 SUPERSEDED by BDR-019. LRN-028 still holds (drive derived UI — highlight+findings — via observation.zones lever).
|
||||
- Wart accepted: prune orphans zone findings (parity w/ ✕ button). All spine-gated (special==='vertebral-precision'). 174/174 green, lint 0, tc clean.
|
||||
Reference in new issue
Block a user