docs(docs): validated Step 7 mockups under docs/design (reference README with deltas and owning steps); chore(memory): BDR-042, journal, TODO 7.10 follow-ups — Step 7 validated

This commit is contained in:
bchanot committed 2026-10-12 00:54:03 +02:00
1 parent 9d2fb788c1
commit 3cf74fd255
7 files changed
+65 -2

No files matched your search

+5
View File
@@ -349,3 +349,8 @@ Status: closed.
Step 7 brief (UX validated by user with external mockups, not versioned). Choices: (1) no TanStack Query: one profile read/update per section, zustand `authStore` + `localeSync` enough; query layer deferred to the first list screens. (2) `practice_name`, `professional_title`, `siret` added to `profiles` as declared free text (CHECKs, column grants), verification stays the Professional Verification domain (Step 11). (3) MFA: foundations had TOTP disabled, no `has_mfa()`, no admin table → TOTP enabled server-side, enforcement + enrolment UI documented as gap (IDENTITY.md §4), Security section shows a note, no fake UI. (4) OAuth buttons listed by `APP_AUTH_PROVIDERS` / `VITE_AUTH_PROVIDERS`; config.toml providers read `env()` ids, `enabled = false` until ids exist; `platform_invitations` not written. (5) Local tool routes untouched + unauthenticated (`LocalToolShell`, catch-all), Home header entry only when Supabase configured; `/app` guard sends to `/login?next=` with same-origin check. (6) Account locale wins over device locale once per sign-in; switches while signed in persist to `profiles.locale`.
Alt rejected: TanStack now (YAGNI); MFA enrolment screen (unvalidated UI, nothing to protect); `/register` naming (`/signup` kept); nested `<a><button>` for card CTAs (ButtonLink instead).
Status: active, awaiting user validation of the step.
## BDR-042 | 2026-10-12 | Step 7 validated; validated mockups versioned as permanent design reference; Home without sidebar accepted
User validated every Step 7 screen and flow (login, signup, recovery, dashboard, account, sidebar + drawer, logout, FR/EN, responsive), no UI correction. Decisions: (1) the mockup file the user produced (`docs/design/faunosteo-etape7-maquettes-validees.png`, 7 views) is the permanent graphic reference for the SaaS shell; `docs/design/README.md` lists what it shows beyond Step 7 with the owning step (Bilans/Clients/Animaux/Agenda/Fiches entries, stat tiles, bell, avatar photo → Step 8, Mon compte tabs, mobile tab bar) so no screen invents them early; a redesign needs a new validated file there. (2) Local-tool Home (`/`) shows no sidebar when signed in, only "Mon espace": accepted until the tool is integrated into `/app` (Step 14). (3) Password rule in the mockup (8 chars) does NOT override the server policy (12 + classes). (4) Follow-ups kept in TODO 7.10: MFA before sensitive admin features, professional verification ≠ SIRET format, real OAuth tests once ids exist, tool integration into /app.
Status: closed; Step 7 finished into develop.
+4
View File
@@ -215,3 +215,7 @@ User round 2: logos OK, picker text crisp, flows OK → STEP 6 VALIDATED. Decisi
## 2026-10-11 (Step 7 implementation)
User: mockups validated (external, not in repo), implement Step 7 on a branch. feature/step-07-identity-app-shell off develop (release/0.2.0 still open, awaiting go). Foundation: packages/supabase auth/profile/roles services (closed AuthFailure kinds), migration 20261011100000 professional columns + pgTAP 009 (PGlite 22/22, real stack 280/280, types regenerated), config.toml TOTP on + google/apple via env(), `APP_AUTH_PROVIDERS`. App: authStore + localeSync + AuthProvider, routes /login /signup /forgot-password /reset-password /auth/callback, guards, AppLayout (sidebar / top bar / drawer), dashboard (profile completeness, local tool, account), Mon compte (4 sections, one save each), Home entry when configured. Tests 277 app + 24 supabase, lint 0, typecheck, build, docker OK; impeccable detect clean; headless e2e against the local stack 20/20 (guard, login, account save, SIRET error, language, mobile no overflow, drawer, logout, signup → Mailpit confirmation → /app, recovery → reset → login). Docs: IDENTITY.md, CLAUDE.md, SUPABASE.md, CHANGELOG, plan note. BDR-041, LRN-047. Gates (verifier, security) dispatched; awaiting user validation; `.env.example` edit denied (file rule) → user adds `APP_AUTH_PROVIDERS=`. Gates: verifier ECARTS(2) → `safeNextPath` parser-escape fix (+5 tests) + contract CHECK scoped → CONFORME 16/16; security PASS (MEDIUM = same redirect; LOWs: sign-out failure alert, `reauthentication_needed` kind, prod redirect allowlist doc). EVAL-015. Real-stack pgTAP 280, build, docker green. Stop: user validation.
## 2026-10-12 (Step 7 closure)
User validated Step 7 (all screens, flows, FR/EN, responsive; Home-without-sidebar accepted). Mockup file dropped at root → `docs/design/faunosteo-etape7-maquettes-validees.png` + README (deltas vs step, owning steps); CLAUDE.md design-reference rule; IDENTITY.md pointer. BDR-042; TODO 7.10 follow-ups (MFA gate, verification ≠ SIRET, OAuth real tests, tool integration). Final check green; gitflow finish into develop. Next: Step 8 files foundation, awaiting user go (Q2 hosting/edge-runtime decision shapes the SVG sanitizer).