docs(docs): validated Step 7 mockups under docs/design (reference README with deltas and owning steps); chore(memory): BDR-042, journal, TODO 7.10 follow-ups — Step 7 validated

This commit is contained in:
bchanot committed 2026-10-12 00:54:03 +02:00
1 parent 9d2fb788c1
commit 3cf74fd255
7 files changed
+65 -2

No files matched your search

+5
View File
@@ -349,3 +349,8 @@ Status: closed.
Step 7 brief (UX validated by user with external mockups, not versioned). Choices: (1) no TanStack Query: one profile read/update per section, zustand `authStore` + `localeSync` enough; query layer deferred to the first list screens. (2) `practice_name`, `professional_title`, `siret` added to `profiles` as declared free text (CHECKs, column grants), verification stays the Professional Verification domain (Step 11). (3) MFA: foundations had TOTP disabled, no `has_mfa()`, no admin table → TOTP enabled server-side, enforcement + enrolment UI documented as gap (IDENTITY.md §4), Security section shows a note, no fake UI. (4) OAuth buttons listed by `APP_AUTH_PROVIDERS` / `VITE_AUTH_PROVIDERS`; config.toml providers read `env()` ids, `enabled = false` until ids exist; `platform_invitations` not written. (5) Local tool routes untouched + unauthenticated (`LocalToolShell`, catch-all), Home header entry only when Supabase configured; `/app` guard sends to `/login?next=` with same-origin check. (6) Account locale wins over device locale once per sign-in; switches while signed in persist to `profiles.locale`.
Alt rejected: TanStack now (YAGNI); MFA enrolment screen (unvalidated UI, nothing to protect); `/register` naming (`/signup` kept); nested `<a><button>` for card CTAs (ButtonLink instead).
Status: active, awaiting user validation of the step.
## BDR-042 | 2026-10-12 | Step 7 validated; validated mockups versioned as permanent design reference; Home without sidebar accepted
User validated every Step 7 screen and flow (login, signup, recovery, dashboard, account, sidebar + drawer, logout, FR/EN, responsive), no UI correction. Decisions: (1) the mockup file the user produced (`docs/design/faunosteo-etape7-maquettes-validees.png`, 7 views) is the permanent graphic reference for the SaaS shell; `docs/design/README.md` lists what it shows beyond Step 7 with the owning step (Bilans/Clients/Animaux/Agenda/Fiches entries, stat tiles, bell, avatar photo → Step 8, Mon compte tabs, mobile tab bar) so no screen invents them early; a redesign needs a new validated file there. (2) Local-tool Home (`/`) shows no sidebar when signed in, only "Mon espace": accepted until the tool is integrated into `/app` (Step 14). (3) Password rule in the mockup (8 chars) does NOT override the server policy (12 + classes). (4) Follow-ups kept in TODO 7.10: MFA before sensitive admin features, professional verification ≠ SIRET format, real OAuth tests once ids exist, tool integration into /app.
Status: closed; Step 7 finished into develop.
+4
View File
@@ -215,3 +215,7 @@ User round 2: logos OK, picker text crisp, flows OK → STEP 6 VALIDATED. Decisi
## 2026-10-11 (Step 7 implementation)
User: mockups validated (external, not in repo), implement Step 7 on a branch. feature/step-07-identity-app-shell off develop (release/0.2.0 still open, awaiting go). Foundation: packages/supabase auth/profile/roles services (closed AuthFailure kinds), migration 20261011100000 professional columns + pgTAP 009 (PGlite 22/22, real stack 280/280, types regenerated), config.toml TOTP on + google/apple via env(), `APP_AUTH_PROVIDERS`. App: authStore + localeSync + AuthProvider, routes /login /signup /forgot-password /reset-password /auth/callback, guards, AppLayout (sidebar / top bar / drawer), dashboard (profile completeness, local tool, account), Mon compte (4 sections, one save each), Home entry when configured. Tests 277 app + 24 supabase, lint 0, typecheck, build, docker OK; impeccable detect clean; headless e2e against the local stack 20/20 (guard, login, account save, SIRET error, language, mobile no overflow, drawer, logout, signup → Mailpit confirmation → /app, recovery → reset → login). Docs: IDENTITY.md, CLAUDE.md, SUPABASE.md, CHANGELOG, plan note. BDR-041, LRN-047. Gates (verifier, security) dispatched; awaiting user validation; `.env.example` edit denied (file rule) → user adds `APP_AUTH_PROVIDERS=`. Gates: verifier ECARTS(2) → `safeNextPath` parser-escape fix (+5 tests) + contract CHECK scoped → CONFORME 16/16; security PASS (MEDIUM = same redirect; LOWs: sign-out failure alert, `reauthentication_needed` kind, prod redirect allowlist doc). EVAL-015. Real-stack pgTAP 280, build, docker green. Stop: user validation.
## 2026-10-12 (Step 7 closure)
User validated Step 7 (all screens, flows, FR/EN, responsive; Home-without-sidebar accepted). Mockup file dropped at root → `docs/design/faunosteo-etape7-maquettes-validees.png` + README (deltas vs step, owning steps); CLAUDE.md design-reference rule; IDENTITY.md pointer. BDR-042; TODO 7.10 follow-ups (MFA gate, verification ≠ SIRET, OAuth real tests, tool integration). Final check green; gitflow finish into develop. Next: Step 8 files foundation, awaiting user go (Q2 hosting/edge-runtime decision shapes the SVG sanitizer).
+3 -2
View File
@@ -114,7 +114,7 @@ feat/findings-tree-v2 merged (FindingsTreePicker tracked in HEAD); all work belo
- [ ] 6.7 follow-ups recorded for Step 13: catalog asset cap aligned with the archive cap (2 MiB), allowlist sanitiser at upload, app canvas sanitiser (EVAL-011)
- [ ] 5 follow-up: allowlist SVG sanitiser before Storage-served assets (Step 13); orphan findings UX (D5) at the report UX step; report:compare residuals (ZodError reason genericised, v3 lines computed once, long template lines); 16 MiB attachment cap without direct test
- [ ] Step 7 — identity: auth, profile, roles, /app shell (started 2026-10-11, branch feature/step-07-identity-app-shell; direction graphique validée par l'utilisateur: identité actuelle conservée, maquettes = référence externe non versionnée). Scope decisions: professional fields = additive migration on profiles (practice_name, professional_title, siret free text, verification = later domain); MFA = documented gap (TOTP disabled in config, no has_mfa helper, no admin table); no TanStack Query (zustand store suffices); legacy routes untouched and unauthenticated; /app visible from Home only when Supabase is configured
- [x] Step 7 — identity: auth, profile, roles, /app shell (started 2026-10-11, branch feature/step-07-identity-app-shell; USER VALIDATED 2026-10-12, all screens and flows OK, no UI correction; mockups now versioned at docs/design/faunosteo-etape7-maquettes-validees.png; finished into develop). Scope decisions: professional fields = additive migration on profiles (practice_name, professional_title, siret free text, verification = later domain); MFA = documented gap (TOTP disabled in config, no has_mfa helper, no admin table); no TanStack Query (zustand store suffices); legacy routes untouched and unauthenticated; /app visible from Home only when Supabase is configured
- [x] 7.0 plan + branch + ctx7 cache (supabase-js auth, config.toml providers)
- [x] 7.1 config: appConfig.authProviders (APP_AUTH_PROVIDERS / VITE_AUTH_PROVIDERS, google|apple), entrypoint + env.example + DEPLOY table; config.toml: TOTP enroll/verify on, [auth.external.google|apple] via env(), redirect URLs; packages/supabase: auth service wrappers (typed errors), profile read/update service
- [x] 7.2 migration 20261011100000_profiles_professional: practice_name, professional_title, siret (+ CHECKs, column grants); pgTAP 009; database.types regenerated (real stack) + schema-types map
@@ -124,7 +124,8 @@ feat/findings-tree-v2 merged (FindingsTreePicker tracked in HEAD); all work belo
- [x] 7.6 /app/account: personal (display, first, last, phone), professional (title, practice, siret), preferences (locale, timezone), security (change password, logout, MFA gap note), roles badge read-only
- [x] 7.7 Home coexistence: "Mon espace / Se connecter" entry on the header when configured; characterisation tests T12 unchanged with default config
- [x] 7.8 tests: config, authStore (fake client), locale sync, forms, guards, shell, dashboard, account; i18n parity; pgTAP 009 (PGlite + real stack 280/280); root check + docker build green; headless e2e vs local stack 20/20 (signup via Mailpit, recovery, logout, mobile)
- [x] 7.9 docs (IDENTITY.md, SUPABASE.md, CLAUDE.md, CHANGELOG, plan note); memory BDR-041, LRN-047, EVAL-015, journal; gates: verifier ECARTS(2) → open-redirect fix + contract CHECK → CONFORME 16/16; security PASS (MEDIUM fixed, 3 LOW closed, TOTP enforcement = documented gap). AWAITING USER VALIDATION (IDENTITY.md §5); user action: `.env.example` += `APP_AUTH_PROVIDERS=` (file edit denied here)
- [x] 7.9 docs (IDENTITY.md, SUPABASE.md, CLAUDE.md, CHANGELOG, plan note); memory BDR-041, LRN-047, EVAL-015, journal; gates: verifier ECARTS(2) → open-redirect fix + contract CHECK → CONFORME 16/16; security PASS (MEDIUM fixed, 3 LOW closed, TOTP enforcement = documented gap). User validated 2026-10-12; user action still open: `.env.example` += `APP_AUTH_PROVIDERS=` (file edit denied here)
- [ ] 7.10 follow-ups kept by the user (2026-10-12), each owned by a later step: MFA mandatory before any sensitive admin feature (has_mfa helper + enrolment UI, IDENTITY.md §4; first admin screen); professional verification distinct from the SIRET format check (Step 11); real tests of Google and Apple once the provider ids exist (config.toml env(), APP_AUTH_PROVIDERS); integration of the report tool into the signed-in /app space (Step 14 gating); mockup elements not built yet listed in docs/design/README.md (bell, avatar photo → Step 8, stat tiles, tabs, mobile tab bar)
---
## Phase A — DONE (kept for reference)
+4
View File
@@ -216,6 +216,7 @@ faunosteo/
├─ docs/
│ ├─ ANNOTATION-RENDERING.md ← annotation layer contract (attributes, styles, colours)
│ ├─ PDF-FORMAT.md
│ ├─ design/ ← VALIDATED graphic references (README.md + faunosteo-etape7-maquettes-validees.png); follow before proposing UI
│ ├─ faunosteo-audit/ ← audit of the current system (frozen at 83e40af)
│ ├─ development/ ← SaaS implementation plan, WORKSPACE.md
│ └─ history/superpowers/{specs,plans}/ ← 2026-05 design records (docs/superpowers is purged by gitflow finish)
@@ -336,6 +337,9 @@ Database (Supabase)
- Always read from ConfigProvider via useConfig()
- src/config/env.ts is the only place with defaults
### Design references
- `docs/design/` holds the owner-validated mockups (Step 7 file = target for the whole SaaS shell: sidebar entries, dashboard tiles, Mon compte tabs, mobile tab bar). Any new screen follows them; elements they show that no step has built yet are listed in `docs/design/README.md` with their owning step. A redesign needs a new validated file there first.
### Annotation rendering
- docs/ANNOTATION-RENDERING.md is the source of truth: the drawing carries no annotation element, the app draws
the markers from the document (`@faunosteo/anatomy/render`), with the attributes listed there
+45
View File
@@ -0,0 +1,45 @@
# Design references
Permanent graphic references for the application, validated by the owner.
A screen built later follows these before any new proposal; a change of
direction needs a new validated file here, never a silent drift.
## faunosteo-etape7-maquettes-validees.png
Validated 2026-10-12 with Step 7 (identity). One image, seven views:
1. Connexion (desktop): split layout, brand panel left with a photo and the
tagline, white card right, Google + Apple under the form.
2. Inscription (desktop): centred card, password rules shown as a checklist.
3. Tableau de bord (desktop): sidebar (Tableau de bord, Bilans, Clients,
Animaux, Agenda, Fiches anatomiques, Mon compte, Paramètres, Réduire),
top bar with a bell and the user menu, four stat tiles, "Accès rapides"
and "Derniers bilans".
4. Profil et paramètres (desktop): "Mon compte" with tabs (Profil, Cabinet et
activité, Sécurité, Préférences), avatar with "Modifier la photo",
professional block with activity name, SIRET, activity type, website.
5. Menu mobile: drawer with the same navigation and "Se déconnecter".
6. Tableau de bord (mobile): hamburger, bell, avatar, stat tiles, quick
actions, bottom tab bar (Accueil, Bilans, Agenda, Profil).
7. Profil (mobile): tabs Profil / Sécurité, bottom tab bar.
### What the mockup shows beyond Step 7
The mockup is the target for the whole SaaS shell. Items it shows that no
step has built yet, with the step that owns them:
| Element | Owner |
|---|---|
| Bilans, Clients, Animaux, Agenda, Fiches anatomiques entries and screens | Steps 9 to 16 (clients/animals, cloud reports, agenda) |
| Stat tiles (bilans créés, clients, animaux, rendez-vous) and "Derniers bilans" | once the reports and agenda tables exist; never invented numbers |
| Notification bell | notifications step |
| Avatar photo and "Modifier la photo" | Step 8 (files foundation, avatar bucket) |
| Bottom tab bar on mobile | with the first list screens (today only two destinations) |
| Tabs in Mon compte | optional restructuring when "Cabinet et activité" gains fields (activity type, website) |
| Password rule checklist | the mockup says 8 characters; the server policy is 12 with lower, upper and digit (config.toml); the hint text follows the server |
Step 7 as shipped (2026-10-11, validated 2026-10-12): login, signup,
password recovery, dashboard (profile completeness, local tool, account
facts), Mon compte as stacked sections, sidebar + drawer, FR/EN. The owner
accepted that the Home of the local tool (`/`) shows no sidebar while signed
in, only the "Mon espace" button, until the tool is integrated into `/app`.
Binary file not shown.

After

Width:  |  Height:  |  Size: 1.5 MiB

+4
View File
@@ -1,5 +1,9 @@
# Identity: auth, profile, /app shell (Step 7)
Validated by the owner on 2026-10-12. Graphic reference:
`docs/design/faunosteo-etape7-maquettes-validees.png` (see `docs/design/README.md`
for what the mockup shows beyond this step).
Source of truth for the signed-in space added in Step 7. The local tool
(`/`, `/new`, `/editor`) is untouched and needs no account; the two live side
by side until the plan's Step 14 decides what goes behind authentication.