chore(memory): journal + TODO 5.11/5.12 + contract — hotfix findings picker blur, Step 5 validated
This commit is contained in:
1 parent
1f0b710b6e
commit
271a8b6515
3 files changed
+31
-1
No files matched your search
@@ -0,0 +1,27 @@
|
||||
# CONTRACT — findings-picker-blur
|
||||
- date: 2026-10-10 | flow: hotfix | branch: feature/step-05-app-on-canonical-sheet
|
||||
- status: active
|
||||
|
||||
## REQUEST (verbatim — IMMUTABLE)
|
||||
Un seul défaut visuel constaté : le texte des constats apparaît flou dans le sélecteur de constats. En revanche, il est net dans le PDF. Merci d'analyser la cause réelle (rendu CSS, transformations, mise à l'échelle, opacité, police, etc.) et de corriger ce problème sans modifier inutilement le design ou les interactions. Vérifie le résultat à l'écran, notamment sur desktop et mobile, et conserve les tests de non-régression.
|
||||
|
||||
## CLARIFICATIONS
|
||||
none — request complete. Root cause located in the main loop (headless Chromium, Playwright): the `motion.ul` of `FindingsTreePicker` keeps a permanent inline `will-change: transform, opacity` after its 220 ms slide ends (computed transform `none`); the list sits at a fractional offset inside the height-animated card (left 561.1875 px desktop, top 735.765625 px mobile), so the composited text is resampled and blurs. The PDF never goes through that layer.
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
1. The findings list carries no inline `will-change` (motion promotes the element itself during the slide).
|
||||
CHECK: grep -n "willChange" apps/app/src/components/observation/FindingsTreePicker.tsx; echo "rc=$?"
|
||||
EXPECT: rc=1
|
||||
EVIDENCE: 2026-10-10 grep → no match, rc=1. MET.
|
||||
2. A regression test asserts the rendered findings list has no inline will-change; every existing test kept.
|
||||
CHECK: cd apps/app && corepack pnpm vitest run tests/unit/components.FindingsTreePicker.test.tsx 2>&1 | tail -3
|
||||
EXPECT: Tests .* passed
|
||||
EVIDENCE: 2026-10-10 appended to the existing picker test file (path corrected here, [gated 2026-10-10] main loop) → Test Files 1 passed, Tests 6 passed. App suite 182 passed (executor smoke). MET.
|
||||
3. Symptom gone on screen (desktop 1280×1, mobile 390×2): computed `willChange` of the list is `auto` and the edge-sharpness ratio rises versus the before capture (main loop measures with the Playwright script, no executor action).
|
||||
EVIDENCE: 2026-10-10 headless Chromium 1243: willChange "transform, opacity" → "auto" on both profiles. Sharpness ratio mobile 0.640 → 0.774 (visibly crisper), desktop 0.594 → 0.583 (flat: headless renders text without LCD antialiasing, so the desktop difference is not observable there; the compositing mechanism is removed, the user confirms in a real browser). PARTIALLY MET (mechanism + mobile proven; desktop by user).
|
||||
4. build/tests green: `corepack pnpm typecheck && corepack pnpm lint && corepack pnpm test:run`.
|
||||
EVIDENCE: typecheck + lint pass, app 182 tests pass (executor smoke); full workspace rerun before gitflow finish.
|
||||
|
||||
## FILE SCOPE
|
||||
apps/app/src/components/observation/FindingsTreePicker.tsx (delete the `style={{ willChange: 'transform, opacity' }}` prop on `motion.ul`)
|
||||
apps/app/tests/unit/FindingsTreePicker.test.tsx (new or existing picker test file: one regression test)
|
||||
Reference in new issue
Block a user