From 271a8b65155b82e9241d64f950a923e2d2f724d1 Mon Sep 17 00:00:00 2001 From: bchanot Date: Sat, 10 Oct 2026 22:16:18 +0200 Subject: [PATCH] =?UTF-8?q?chore(memory):=20journal=20+=20TODO=205.11/5.12?= =?UTF-8?q?=20+=20contract=20=E2=80=94=20hotfix=20findings=20picker=20blur?= =?UTF-8?q?,=20Step=205=20validated?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .claude/memory/journal.md | 1 + .claude/tasks/TODO.md | 4 ++- .../2026-10-10-findings-picker-blur-2212.md | 27 +++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 .claude/tasks/contracts/2026-10-10-findings-picker-blur-2212.md diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index c08b667d..e10c4477 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -194,3 +194,4 @@ Step 4 validated + finished into develop. User decisions on the 7 open points - Step 5 gates (2026-10-10): verifier 36→4→4 (real gaps closed by 2 executors + doc fixes; cap reached, last test lot unverified by a 4th pass), security PASS (2 LOW fixed: prototype keys, size caps). EVAL-011. Final check green. Awaiting user validation; no publication; default build carries no sheet. - Step 5 addendum (2026-10-10, user testing manually): per-leaf migration tests (612 leaves, anatomy + app + PDF roundtrip), `pnpm report:compare` archive check tool (privacy default, escaping), stale `scaffold:species` script removed, attachment read/parse split. Gates: verifier 2→1→CONFORME, security PASS ×2 (2 MEDIUM + 4 LOW fixed by executors). EVAL-012, LRN-044. Branch 14 commits ahead, not merged; awaiting user validation; no Step 6. +- Step 5 user validation (2026-10-10): all paths OK. One defect: findings picker text blurry on screen. Root cause (headless Chromium measure): permanent `will-change: transform, opacity` on the picker list + fractional offset inside height-animated card → composited text resampled; PDF unaffected. Hotfix 1f0b710: prop dropped, regression test (app 182). Security PASS, docs NONE. Full check green. User signal → finish Step 5; carpus + moved points noted, 28 annotations NOT a final catalog (enrichment with the osteopath + future editor later). Step 6 to present, not started. diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 99a4d45c..75eae18f 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -86,7 +86,7 @@ feat/findings-tree-v2 merged (FindingsTreePicker tracked in HEAD); all work belo - [x] 4c.5 reports: REVIEW-REPORT.md for the osteopath (10 sections, questions ranked), CHANGELOG table, before/after review SVGs (draft/review/, PNG renders by operator), quantitative before/after. - [ ] 4c follow-up (open, not blocking Step 5): 11 questions for the osteopath (draft/REVIEW-REPORT.md §10) → next changeset; legal scope text to re-read on consolidated Légifrance articles before publication; BLK-008 data migration v1→v2 before real data; user action `.env.example` COMPOSE_PROJECT_NAME=faunosteo (DEPLOY.md) - [x] 4c.6 verify (root check 68+21+100+278, PGlite + real stack 267/267, types, docker build, Storage e2e; verifier ×3 → fixes, security PASS; EVAL-010): pnpm check, PGlite + real stack pgTAP, types, docker build, golden tests; gates verifier + security; docs (spec §6/§7, SUPABASE.md, CLAUDE.md, plan Step 4c, CHANGELOG); memory (BDR/LRN/EVAL/journal). Stop for user validation. -- [ ] Step 5 — application on the canonical sheet (analysis validated 2026-10-10; implemented on feature/step-05-app-on-canonical-sheet, AWAITING user validation; D5 orphan findings documented as UX follow-up) +- [x] Step 5 — application on the canonical sheet (analysis validated 2026-10-10; implemented on feature/step-05-app-on-canonical-sheet; USER VALIDATED 2026-10-10, all paths OK; finished into develop 2026-10-10; D5 orphan findings documented as UX follow-up) - [x] 5.0 freeze: golden v2 PDFs + expected v3 docs; CHARACTERIZATION_REPORT refreshed - [x] 5.1 pipeline: report-migration-map.json (annotations, views, findingPaths 442/136/≤34), app-main.svg + app-head.svg review renders, category colours changeset (D1) - [x] 5.2 packages/domain: Report v3 (annotationId+viewId, free region codes, severity codes D8, sheet ref, unresolved findings, localAnnotations []), migrateReportV2ToV3, tests on fixtures + 612 leaves @@ -98,6 +98,8 @@ feat/findings-tree-v2 merged (FindingsTreePicker tracked in HEAD); all work belo - [x] 5.8 per-leaf migration (user ask 2026-10-10, during manual validation): every legacy leaf (612 = 442 identical, 141 moved, 29 removed) as a v2 finding → migrated → resolved to a draft leaf (anatomy, map file) and through sheetIndex.nodeAt + PDF roundtrip (app); the 27 legacy annotations as zones on their views - [x] 5.9 archive check tool `pnpm report:compare ...`: v2 attachment vs migrated v3 side by side, unresolved flagged (removed vs unknown), `--full` opt-in for names/free text, control chars escaped, --diff of two PDFs, --summary; attachment.ts split read/parse (additive, D3); docs PDF-FORMAT/CLAUDE/README - [x] 5.10 final controls on the last lot: stale root script scaffold:species removed; verifier ×3 (2→1→CONFORME) + security ×2 PASS on criteria 16-18; EVAL-012 + - [x] 5.11 user validation defect: findings picker text blurry on screen → permanent `will-change` on the list dropped (hotfix 1f0b710, regression test); PDF never affected + - [ ] 5.12 follow-up (not Step 5): equine sheet anatomical enrichment with the osteopath + future sheet editor (Step 17); the 28 draft annotations (carpus added, points moved) are NOT a final catalog - [ ] 5 follow-up: allowlist SVG sanitiser before Storage-served assets (Step 13); orphan findings UX (D5) at the report UX step; report:compare residuals (ZodError reason genericised, v3 lines computed once, long template lines); 16 MiB attachment cap without direct test --- diff --git a/.claude/tasks/contracts/2026-10-10-findings-picker-blur-2212.md b/.claude/tasks/contracts/2026-10-10-findings-picker-blur-2212.md new file mode 100644 index 00000000..fc43f6a0 --- /dev/null +++ b/.claude/tasks/contracts/2026-10-10-findings-picker-blur-2212.md @@ -0,0 +1,27 @@ +# CONTRACT — findings-picker-blur +- date: 2026-10-10 | flow: hotfix | branch: feature/step-05-app-on-canonical-sheet +- status: active + +## REQUEST (verbatim — IMMUTABLE) +Un seul défaut visuel constaté : le texte des constats apparaît flou dans le sélecteur de constats. En revanche, il est net dans le PDF. Merci d'analyser la cause réelle (rendu CSS, transformations, mise à l'échelle, opacité, police, etc.) et de corriger ce problème sans modifier inutilement le design ou les interactions. Vérifie le résultat à l'écran, notamment sur desktop et mobile, et conserve les tests de non-régression. + +## CLARIFICATIONS +none — request complete. Root cause located in the main loop (headless Chromium, Playwright): the `motion.ul` of `FindingsTreePicker` keeps a permanent inline `will-change: transform, opacity` after its 220 ms slide ends (computed transform `none`); the list sits at a fractional offset inside the height-animated card (left 561.1875 px desktop, top 735.765625 px mobile), so the composited text is resampled and blurs. The PDF never goes through that layer. + +## ACCEPTANCE CRITERIA +1. The findings list carries no inline `will-change` (motion promotes the element itself during the slide). + CHECK: grep -n "willChange" apps/app/src/components/observation/FindingsTreePicker.tsx; echo "rc=$?" + EXPECT: rc=1 + EVIDENCE: 2026-10-10 grep → no match, rc=1. MET. +2. A regression test asserts the rendered findings list has no inline will-change; every existing test kept. + CHECK: cd apps/app && corepack pnpm vitest run tests/unit/components.FindingsTreePicker.test.tsx 2>&1 | tail -3 + EXPECT: Tests .* passed + EVIDENCE: 2026-10-10 appended to the existing picker test file (path corrected here, [gated 2026-10-10] main loop) → Test Files 1 passed, Tests 6 passed. App suite 182 passed (executor smoke). MET. +3. Symptom gone on screen (desktop 1280×1, mobile 390×2): computed `willChange` of the list is `auto` and the edge-sharpness ratio rises versus the before capture (main loop measures with the Playwright script, no executor action). + EVIDENCE: 2026-10-10 headless Chromium 1243: willChange "transform, opacity" → "auto" on both profiles. Sharpness ratio mobile 0.640 → 0.774 (visibly crisper), desktop 0.594 → 0.583 (flat: headless renders text without LCD antialiasing, so the desktop difference is not observable there; the compositing mechanism is removed, the user confirms in a real browser). PARTIALLY MET (mechanism + mobile proven; desktop by user). +4. build/tests green: `corepack pnpm typecheck && corepack pnpm lint && corepack pnpm test:run`. + EVIDENCE: typecheck + lint pass, app 182 tests pass (executor smoke); full workspace rerun before gitflow finish. + +## FILE SCOPE +apps/app/src/components/observation/FindingsTreePicker.tsx (delete the `style={{ willChange: 'transform, opacity' }}` prop on `motion.ul`) +apps/app/tests/unit/FindingsTreePicker.test.tsx (new or existing picker test file: one regression test)