chore(memory): V1-2.5 checkpoint, LRN on inert drawer and GoTrue MFA, journal
This commit is contained in:
1 parent
5db85ff19f
commit
14ff890761
3 files changed
+13
-2
No files matched your search
@@ -767,3 +767,13 @@ Supersedes [[LRN-100]].
|
||||
|
||||
**Application**: quote every heredoc delimiter (`<<'EOF'`, `<<'PYEOF'`) unless expansion is wanted, pass values as arguments; prefer Write/Edit for prose. Run commands with an absolute, verified directory (`git -C <abs>`, `pnpm --dir <abs>`, `[ "$(pwd -P)" = <abs> ]` before acting); never `cd X && cmd &`. Validate the environment before any side effect (target URL, key issuer, container name) inside the script itself, so its safety never depends on cwd. Put these rules in every sub-agent brief that may run shell commands, with the explicit ban on running scripts from other worktrees.
|
||||
Supersedes [[LRN-102]].
|
||||
|
||||
## LRN-111 — Closing modal drawer leaves page inert: e2e typing lost until dialog gone (2026-11-02)
|
||||
**Context**: V1-2.5 e2e P1 at 375 px: search fill lost 2/4 full runs (8 cards, not 1). Test clicked drawer link, saw heading + first card, filled search at once.
|
||||
**Pattern**: native `<dialog>` showModal kept mounted through motion AnimatePresence exit → page behind inert ~200 ms; Playwright fill there goes nowhere, intermittently under load. Fix in test: after drawer link click, `expect(dialog).toHaveCount(0)` before typing. Proof: 1/16 red repro, 32/32 after.
|
||||
**Apply**: any e2e acting right after closing a modal drawer/dialog waits for it gone; flaky "input ignored" → suspect inert from closing modal first. Keep failure snapshot (check:all e2e:ui wipes test-results).
|
||||
|
||||
## LRN-112 — GoTrue v2.197 MFA: aal2 needed for password/email change; factor removal downgrades only its sessions (2026-11-02)
|
||||
**Context**: V1-2.5 sandbox proofs on GoTrue v2.197.0 (mfa-behaviour.sandbox.ts, IDENTITY.md §4.1).
|
||||
**Pattern**: once a TOTP factor verified: password change and recovery-link reset refused at aal1 (401 insufficient_aal) → reset/change UI must step up first; email change same. Removing verified factor downgrades only sessions last verified with that factor; their access token keeps aal2 claim until expiry (has_mfa true, has_aal2_session false). supabase-js `mfa.listFactors().totp` hides unverified factors → read `all`.
|
||||
**Apply**: never assume aal from claim alone for sensitive RPCs (session row check); any password/email flow on MFA accounts needs a step-up path; factor lists show unverified ones.
|
||||
Reference in new issue
Block a user